188461 2018-08-09 17:22:05 -0700 CrashTracer: com.apple.WebKit.Storage at WebCore::IDBServer::UniqueIDBDatabase::scheduleShutdownForClose 2018-08-10 12:05:54 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu alecflett beidson cdumez commit-queue ews-watchlist jsbell webkit-bug-importer oldest_to_newest 1449187 0 sihui_liu 2018-08-09 17:22:05 -0700 Thread 0 Crashed ↩: 0 WebCore 0x00000001f163e398 WebCore::IDBServer::UniqueIDBDatabase::scheduleShutdownForClose() + 268 (UniqueIDBDatabase.cpp:276) 1 WebCore 0x00000001f1ea6290 WebCore::ThreadTimers::sharedTimerFiredInternal() + 352 (ThreadTimers.cpp:117) 2 WebCore 0x00000001f1ea6290 WebCore::ThreadTimers::sharedTimerFiredInternal() + 352 (ThreadTimers.cpp:117) 3 WebCore 0x00000001f1eeb254 WebCore::timerFired(__CFRunLoopTimer*, void*) + 28 (MainThreadSharedTimerCF.cpp:74) 1449188 1 sihui_liu 2018-08-09 17:22:48 -0700 <rdar://problem/33555052> 1449196 2 346881 sihui_liu 2018-08-09 17:49:31 -0700 Created attachment 346881 Patch 1449272 3 346881 cdumez 2018-08-10 08:42:20 -0700 Comment on attachment 346881 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346881&action=review > Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:1553 > + if (!m_owningPointerForClose) Could we simply call m_operationAndTransactionTimer.stop(); in scheduleShutdownForClose(), similarly to what we already do in immediateCloseForUserDelete()? The ASSERT(!m_owningPointerForClose); in invokeOperationAndTransactionTimer() should make sure no one restarts the timer after that. 1449296 4 346881 sihui_liu 2018-08-10 10:04:05 -0700 Comment on attachment 346881 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346881&action=review >> Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:1553 >> + if (!m_owningPointerForClose) > > Could we simply call m_operationAndTransactionTimer.stop(); in scheduleShutdownForClose(), similarly to what we already do in immediateCloseForUserDelete()? > > The ASSERT(!m_owningPointerForClose); in invokeOperationAndTransactionTimer() should make sure no one restarts the timer after that. Yes, I think this will work too. 1449302 5 346909 sihui_liu 2018-08-10 10:16:16 -0700 Created attachment 346909 Patch 1449303 6 346910 sihui_liu 2018-08-10 10:17:14 -0700 Created attachment 346910 Patch 1449304 7 346910 cdumez 2018-08-10 10:18:27 -0700 Comment on attachment 346910 Patch r=me 1449340 8 346910 commit-queue 2018-08-10 12:05:52 -0700 Comment on attachment 346910 Patch Clearing flags on attachment: 346910 Committed r234766: <https://trac.webkit.org/changeset/234766> 1449341 9 commit-queue 2018-08-10 12:05:54 -0700 All reviewed patches have been landed. Closing bug. 346881 2018-08-09 17:49:31 -0700 2018-08-10 10:16:14 -0700 Patch bug-188461-20180809174930.patch text/plain 1852 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTk0YTA1NjBmYmVkODc2 ZGI5OWIzYzI0NjdjMmZlYWMyN2U4YmEyNC4uNDkyZmJjNTAxYTg3YzdhZjYxZjJmZmU0NjFmZjA1 OTUzM2QzNmU0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA4LTA5ICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoVHJhY2VyOiBjb20u YXBwbGUuV2ViS2l0LlN0b3JhZ2UgYXQgV2ViQ29yZTo6SURCU2VydmVyOjpVbmlxdWVJREJEYXRh YmFzZTo6c2NoZWR1bGVTaHV0ZG93bkZvckNsb3NlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODg0NjEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMz NTU1MDUyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEJlZm9yZSB3ZSB0cnkgdG8gc2NoZWR1bGUgc2h1dGRvd24gZm9yIGRhdGFiYXNlIGluIG9wZXJh dGlvbkFuZFRyYW5zYWN0aW9uVGltZXJGaXJlZCwgd2UgCisgICAgICAgIHNob3VsZCBjaGVjayBt X293bmluZ1BvaW50ZXJGb3JDbG9zZSB0byBzZWUgdGhlcmUgaXMgYWxyZWFkeSBhIHNodXRkb3du IHJ1bm5pbmcuCisgICAgICAgIFdoZW4gdGhlIHRpbWVyIGlzIGludm9rZWQgbXVsdGlwbGUgdGlt ZXMsIG9wZXJhdGlvbkFuZFRyYW5zYWN0aW9uVGltZXJGaXJlZCBtYXkgYmUgY2FsbGVkIAorICAg ICAgICBjb25zZWN1dGl2ZWx5IG9uIHRoZSBzYW1lIHRocmVhZC4KKworICAgICAgICAqIE1vZHVs ZXMvaW5kZXhlZGRiL3NlcnZlci9VbmlxdWVJREJEYXRhYmFzZS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpJREJTZXJ2ZXI6OlVuaXF1ZUlEQkRhdGFiYXNlOjpvcGVyYXRpb25BbmRUcmFuc2FjdGlv blRpbWVyRmlyZWQpOgorCiAyMDE4LTA4LTA5ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgogCiAgICAgICAgIG1lbW9yeUZvb3RwcmludCBzaG91bGQgcmV0dXJuIHNpemVfdCBub3Qg b3B0aW9uYWw8c2l6ZV90PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRl eGVkZGIvc2VydmVyL1VuaXF1ZUlEQkRhdGFiYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvaW5kZXhlZGRiL3NlcnZlci9VbmlxdWVJREJEYXRhYmFzZS5jcHAKaW5kZXggMjhkYTJhNTY2 MjUyYTExMThkMmY0Mjg2NGI4MjY3ZjljMjNmM2FmNS4uYjcyZThiMWEzOTlmOWVlYTc2ZDk0MDMy YzgxNTVmYTI3YWRhZDljYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRl eGVkZGIvc2VydmVyL1VuaXF1ZUlEQkRhdGFiYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvVW5pcXVlSURCRGF0YWJhc2UuY3BwCkBAIC0xNTUwLDcg KzE1NTAsOCBAQCB2b2lkIFVuaXF1ZUlEQkRhdGFiYXNlOjpvcGVyYXRpb25BbmRUcmFuc2FjdGlv blRpbWVyRmlyZWQoKQogICAgICAgICBBU1NFUlQobV9wZW5kaW5nVHJhbnNhY3Rpb25zLmlzRW1w dHkoKSk7CiAgICAgICAgIEFTU0VSVCghaGFzVW5maW5pc2hlZFRyYW5zYWN0aW9ucygpKTsKIAot ICAgICAgICBzY2hlZHVsZVNodXRkb3duRm9yQ2xvc2UoKTsKKyAgICAgICAgaWYgKCFtX293bmlu Z1BvaW50ZXJGb3JDbG9zZSkKKyAgICAgICAgICAgIHNjaGVkdWxlU2h1dGRvd25Gb3JDbG9zZSgp OwogICAgICAgICByZXR1cm47CiAgICAgfQogCg== 346909 2018-08-10 10:16:16 -0700 2018-08-10 10:17:12 -0700 Patch bug-188461-20180810101615.patch text/plain 1656 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NzMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTk0YTA1NjBmYmVkODc2 ZGI5OWIzYzI0NjdjMmZlYWMyN2U4YmEyNC4uMGU4OWU3MzY3NGZhMDhjOGIyNWJkNmM5MTgzYjhh ZDVkODUzYTg3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA4LTEwICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoVHJhY2VyOiBjb20u YXBwbGUuV2ViS2l0LlN0b3JhZ2UgYXQgV2ViQ29yZTo6SURCU2VydmVyOjpVbmlxdWVJREJEYXRh YmFzZTo6c2NoZWR1bGVTaHV0ZG93bkZvckNsb3NlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODg0NjEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMz NTU1MDUyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEJlZm9yZSB3ZSB0cnkgdG8gc2NoZWR1bGUgc2h1dGRvd24gZm9yIGRhdGFiYXNlIGluIG9wZXJh dGlvbkFuZFRyYW5zYWN0aW9uVGltZXJGaXJlZCwgd2UgCisgICAgICAgIHNob3VsZCBjYW5jZWwg dGhlIHRpbWVyIHNvIG5vIHNjaGVkdWxlU2h1dGRvd25Gb3JDbG9zZSB3aWxsIGJlIHJ1bm5pbmcg YWZ0ZXIgdGhpcy4KKworICAgICAgICAqIE1vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9VbmlxdWVJ REJEYXRhYmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJREJTZXJ2ZXI6OlVuaXF1ZUlEQkRh dGFiYXNlOjpzY2hlZHVsZVNodXRkb3duRm9yQ2xvc2UpOgorCiAyMDE4LTA4LTA5ICBTYWFtIEJh cmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIG1lbW9yeUZvb3RwcmludCBzaG91 bGQgcmV0dXJuIHNpemVfdCBub3Qgb3B0aW9uYWw8c2l6ZV90PgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL1VuaXF1ZUlEQkRhdGFiYXNlLmNwcCBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9VbmlxdWVJREJEYXRhYmFz ZS5jcHAKaW5kZXggMjhkYTJhNTY2MjUyYTExMThkMmY0Mjg2NGI4MjY3ZjljMjNmM2FmNS4uYTZm ZWRlNTA3NjE3OGU1MjEwOGJmMDlhOWQ5YTM4OTYxNzEzMjhiNCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL1VuaXF1ZUlEQkRhdGFiYXNlLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvVW5pcXVlSURCRGF0 YWJhc2UuY3BwCkBAIC0yNzMsNiArMjczLDggQEAgdm9pZCBVbmlxdWVJREJEYXRhYmFzZTo6c2No ZWR1bGVTaHV0ZG93bkZvckNsb3NlKCkKIHsKICAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOwog CisgICAgbV9vcGVyYXRpb25BbmRUcmFuc2FjdGlvblRpbWVyLnN0b3AoKTsKKwogICAgIFJFTEVB U0VfQVNTRVJUKCFtX293bmluZ1BvaW50ZXJGb3JDbG9zZSk7CiAgICAgbV9vd25pbmdQb2ludGVy Rm9yQ2xvc2UgPSBtX3NlcnZlci5jbG9zZUFuZFRha2VVbmlxdWVJREJEYXRhYmFzZSgqdGhpcyk7 CiAK 346910 2018-08-10 10:17:14 -0700 2018-08-10 12:05:52 -0700 Patch bug-188461-20180810101713.patch text/plain 1617 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NzMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTk0YTA1NjBmYmVkODc2 ZGI5OWIzYzI0NjdjMmZlYWMyN2U4YmEyNC4uOTBjMGViMzBlNDIzYThmOTdlYTMwNmEyNmYyNzk3 YzMzNWI5NzU4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA4LTEwICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoVHJhY2VyOiBjb20u YXBwbGUuV2ViS2l0LlN0b3JhZ2UgYXQgV2ViQ29yZTo6SURCU2VydmVyOjpVbmlxdWVJREJEYXRh YmFzZTo6c2NoZWR1bGVTaHV0ZG93bkZvckNsb3NlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODg0NjEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMz NTU1MDUyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFdoZW4gd2UgdHJ5IHRvIHNjaGVkdWxlIHNodXRkb3duIGZvciBkYXRhYmFzZSwgd2Ugc2hvdWxk IGNhbmNlbCB0aGUgdGltZXIgc28gbm8gCisgICAgICAgIHNjaGVkdWxlU2h1dGRvd25Gb3JDbG9z ZSB3aWxsIGJlIHJ1bm5pbmcgYWZ0ZXIgdGhpcy4KKworICAgICAgICAqIE1vZHVsZXMvaW5kZXhl ZGRiL3NlcnZlci9VbmlxdWVJREJEYXRhYmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJREJT ZXJ2ZXI6OlVuaXF1ZUlEQkRhdGFiYXNlOjpzY2hlZHVsZVNodXRkb3duRm9yQ2xvc2UpOgorCiAy MDE4LTA4LTA5ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIG1l bW9yeUZvb3RwcmludCBzaG91bGQgcmV0dXJuIHNpemVfdCBub3Qgb3B0aW9uYWw8c2l6ZV90Pgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL1VuaXF1 ZUlEQkRhdGFiYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZl ci9VbmlxdWVJREJEYXRhYmFzZS5jcHAKaW5kZXggMjhkYTJhNTY2MjUyYTExMThkMmY0Mjg2NGI4 MjY3ZjljMjNmM2FmNS4uYTZmZWRlNTA3NjE3OGU1MjEwOGJmMDlhOWQ5YTM4OTYxNzEzMjhiNCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL1VuaXF1 ZUlEQkRhdGFiYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9z ZXJ2ZXIvVW5pcXVlSURCRGF0YWJhc2UuY3BwCkBAIC0yNzMsNiArMjczLDggQEAgdm9pZCBVbmlx dWVJREJEYXRhYmFzZTo6c2NoZWR1bGVTaHV0ZG93bkZvckNsb3NlKCkKIHsKICAgICBBU1NFUlQo aXNNYWluVGhyZWFkKCkpOwogCisgICAgbV9vcGVyYXRpb25BbmRUcmFuc2FjdGlvblRpbWVyLnN0 b3AoKTsKKwogICAgIFJFTEVBU0VfQVNTRVJUKCFtX293bmluZ1BvaW50ZXJGb3JDbG9zZSk7CiAg ICAgbV9vd25pbmdQb2ludGVyRm9yQ2xvc2UgPSBtX3NlcnZlci5jbG9zZUFuZFRha2VVbmlxdWVJ REJEYXRhYmFzZSgqdGhpcyk7CiAK