188459 2018-08-09 17:08:08 -0700 Cleanup: Remove unnecessary code to resume animations from CachedFrameBase::restore() 2018-08-10 14:54:16 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates cdumez dino ews-watchlist graouts jonlee webkit-bug-importer oldest_to_newest 1449163 0 dbates 2018-08-09 17:08:08 -0700 CachedFrameBase::restore() starts off as: [[ void CachedFrameBase::restore() { ASSERT(m_document->view() == m_view); ... if (RuntimeEnabledFeatures::sharedFeatures().webAnimationsCSSIntegrationEnabled()) m_document->timeline().resumeAnimations(); else frame.animation().resumeAnimationsForDocument(m_document.get()); m_document->resume(ReasonForSuspension::PageCache); ... ]]] <https://trac.webkit.org/browser/trunk/Source/WebCore/history/CachedFrame.cpp?rev=234703#L88> And Document::resume() starts off as: [[ void Document::resume(ReasonForSuspension reason) { if (!m_isSuspended) return; ... if (RuntimeEnabledFeatures::sharedFeatures().webAnimationsCSSIntegrationEnabled()) timeline().resumeAnimations(); else m_frame->animation().resumeAnimationsForDocument(this); ... ]] <https://trac.webkit.org/browser/trunk/Source/WebCore/dom/Document.cpp?rev=234703#L4942> It is not necessary for CachedFrameBase::restore() to explicitly resume animations because Document will do this for us when Document::resume() is called. 1449179 1 346877 dbates 2018-08-09 17:13:01 -0700 Created attachment 346877 Patch 1449384 2 346877 dbates 2018-08-10 14:53:10 -0700 Comment on attachment 346877 Patch Clearing flags on attachment: 346877 Committed r234771: <https://trac.webkit.org/changeset/234771> 1449385 3 dbates 2018-08-10 14:53:12 -0700 All reviewed patches have been landed. Closing bug. 1449386 4 webkit-bug-importer 2018-08-10 14:54:16 -0700 <rdar://problem/43158193> 346877 2018-08-09 17:13:01 -0700 2018-08-10 14:53:10 -0700 Patch bug-188459-20180809171301.patch text/plain 1783 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NzAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWJhYmNjM2RlN2UwYzMw NjFmYmRhY2ZiNzdlZTJkYzNlYWJiZmI3NC4uMDk2NmZmZWE0YzFiMjczOGYzOTk1M2Q1NGNjOGZi Y2QwNmYwOTE0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA4LTA5ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBDbGVhbnVwOiBSZW1vdmUg dW5uZWNlc3NhcnkgY29kZSB0byByZXN1bWUgYW5pbWF0aW9ucyBmcm9tIENhY2hlZEZyYW1lQmFz ZTo6cmVzdG9yZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODg0NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJdCBpcyB1bm5lc3NhcnkgZm9yIENhY2hlZEZyYW1lQmFzZTo6cmVzdG9yZSgpIHRvIGV4 cGxpY2l0bHkgcmVzdW1lIGFuaW1hdGlvbnMgb24gdGhlCisgICAgICAgIGRvY3VtZW50IGFzIGl0 IGNhbGxzIERvY3VtZW50OjpyZXN1bWUoKSwgd2hpY2ggYWxyZWFkeSBkb2VzIHRoaXMuCisKKyAg ICAgICAgTm8gZnVuY3Rpb25hbGl0eSBjaGFuZ2VkLiBTbywgbm8gbmV3IHRlc3RzLgorCisgICAg ICAgICogaGlzdG9yeS9DYWNoZWRGcmFtZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDYWNoZWRG cmFtZUJhc2U6OnJlc3RvcmUpOgorCiAyMDE4LTA4LTA5ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVz QGFwcGxlLmNvbT4KIAogICAgICAgICBPbmNlIDxvYmplY3Q+IGlzIGhpZGRlbiwgaXRzIGNvbnRl bnQgd29uJ3QgYmUgZGlzcGxheWVkIGFnYWluIGlmIGl0cyBVUkwgaGFzIGZyYWdtZW50IGlkZW50 aWZpZXIgKCIjIikuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9oaXN0b3J5L0NhY2hlZEZy YW1lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2hpc3RvcnkvQ2FjaGVkRnJhbWUuY3BwCmluZGV4IGVk NTNmNTI4MDQ2ZDY5NjM0MDIxNDBlYTc0MjliZTQyMmVmZmY3YmEuLjNiMzQzODhlYjFkNjI3ODNk MjRiOTFjNTZjMjY3M2YxOTZkNTY3YzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2hpc3Rv cnkvQ2FjaGVkRnJhbWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2hpc3RvcnkvQ2FjaGVkRnJh bWUuY3BwCkBAIC05OCwxMSArOTgsNiBAQCB2b2lkIENhY2hlZEZyYW1lQmFzZTo6cmVzdG9yZSgp CiAgICAgaWYgKG1fZG9jdW1lbnQtPnN2Z0V4dGVuc2lvbnMoKSkKICAgICAgICAgbV9kb2N1bWVu dC0+YWNjZXNzU1ZHRXh0ZW5zaW9ucygpLnVucGF1c2VBbmltYXRpb25zKCk7CiAKLSAgICBpZiAo UnVudGltZUVuYWJsZWRGZWF0dXJlczo6c2hhcmVkRmVhdHVyZXMoKS53ZWJBbmltYXRpb25zQ1NT SW50ZWdyYXRpb25FbmFibGVkKCkpCi0gICAgICAgIG1fZG9jdW1lbnQtPnRpbWVsaW5lKCkucmVz dW1lQW5pbWF0aW9ucygpOwotICAgIGVsc2UKLSAgICAgICAgZnJhbWUuYW5pbWF0aW9uKCkucmVz dW1lQW5pbWF0aW9uc0ZvckRvY3VtZW50KG1fZG9jdW1lbnQuZ2V0KCkpOwotCiAgICAgbV9kb2N1 bWVudC0+cmVzdW1lKFJlYXNvbkZvclN1c3BlbnNpb246OlBhZ2VDYWNoZSk7CiAKICAgICAvLyBJ dCBpcyBuZWNlc3NhcnkgdG8gdXBkYXRlIGFueSBwbGF0Zm9ybSBzY3JpcHQgb2JqZWN0cyBhZnRl ciByZXN0b3JpbmcgdGhlCg==