188419 2018-08-08 14:30:07 -0700 Followup (r234683): Element::getAttribute() should return the first non-null attribute value 2018-08-13 09:40:29 -0700 1 1 1 Unclassified WebKit SVG WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=153854 InRadar P2 Normal --- 1 sabouhallawa sabouhallawa cdumez cmarcelo commit-queue darin dbates esprehn+autocc ews-watchlist kangil.han webkit-bug-importer zimmermann oldest_to_newest 1448846 0 sabouhallawa 2018-08-08 14:30:07 -0700 This is a follow up for Darin's comments in https://bugs.webkit.org/show_bug.cgi?id=153854. In r234683, a new template function Element::getAttribute() was added to return the first non-empty attribute value. The goal was to handle deprecated attributes in a clean way. Element::getAttribute() should return the first non-null attribute value since an empty string is a legitimate attribute value. 1448852 1 346799 sabouhallawa 2018-08-08 14:44:55 -0700 Created attachment 346799 Patch 1449647 2 346799 commit-queue 2018-08-13 09:39:22 -0700 Comment on attachment 346799 Patch Clearing flags on attachment: 346799 Committed r234803: <https://trac.webkit.org/changeset/234803> 1449648 3 commit-queue 2018-08-13 09:39:23 -0700 All reviewed patches have been landed. Closing bug. 1449649 4 webkit-bug-importer 2018-08-13 09:40:29 -0700 <rdar://problem/43236643> 346799 2018-08-08 14:44:55 -0700 2018-08-13 09:39:22 -0700 Patch bug-188419-20180808144454.patch text/plain 5346 sabouhallawa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNDcxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA4LTA4ICBTYWlkIEFi b3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgRm9sbG93dXAg KHIyMzQ2ODMpOiBFbGVtZW50OjpnZXRBdHRyaWJ1dGUoKSBzaG91bGQgcmV0dXJuIHRoZSBmaXJz dCBub24tbnVsbCBhdHRyaWJ1dGUgdmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4ODQxOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEVsZW1lbnQ6OmdldEF0dHJpYnV0ZSgpIHNob3VsZCByZXR1cm4g dGhlIGZpcnN0IG5vbi1udWxsIGF0dHJpYnV0ZSB2YWx1ZQorICAgICAgICBzaW5jZSBhbiBlbXB0 eSBzdHJpbmcgaXMgYSBsZWdpdGltYXRlIGF0dHJpYnV0ZSB2YWx1ZS4KKworICAgICAgICBUZXN0 OiBzdmcvY3VzdG9tL2hyZWYtc3ZnLW5hbWVzcGFjZS1lbXB0eS5odG1sCisKKyAgICAgICAgKiBk b20vRWxlbWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6Z2V0QXR0cmlidXRlIGNv bnN0KToKKwogMjAxOC0wOC0wOCAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29t PgogCiAgICAgICAgIFtOaWNvc2lhXSBBZGQgdGhlIE5pY29zaWEtc3BlY2lmaWMgUGxhdGZvcm1M YXllciB0eXBlIGFsaWFzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgJKHJldmlzaW9uIDIzNDY4MykK KysrIFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTgyMyw3 ICs4MjMsNyBAQCB0ZW1wbGF0ZTx0eXBlbmFtZS4uLiBRdWFsaWZpZWROYW1lcz4KIGlubGluZSBj b25zdCBBdG9taWNTdHJpbmcmIEVsZW1lbnQ6OmdldEF0dHJpYnV0ZShjb25zdCBRdWFsaWZpZWRO YW1lJiBuYW1lLCBjb25zdCBRdWFsaWZpZWROYW1lcyYuLi4gbmFtZXMpIGNvbnN0CiB7CiAgICAg Y29uc3QgQXRvbWljU3RyaW5nJiB2YWx1ZSA9IGdldEF0dHJpYnV0ZShuYW1lKTsKLSAgICBpZiAo IXZhbHVlLmlzRW1wdHkoKSkKKyAgICBpZiAoIXZhbHVlLmlzTnVsbCgpKQogICAgICAgICByZXR1 cm4gdmFsdWU7CiAgICAgcmV0dXJuIGdldEF0dHJpYnV0ZShuYW1lcy4uLik7CiB9CkluZGV4OiBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzQ2ODMpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w eSkKQEAgLTEsMyArMSwxMyBAQAorMjAxOC0wOC0wOCAgU2FpZCBBYm91LUhhbGxhd2EgIDxzYWJv dWhhbGxhd2FAYXBwbGUuY29tPgorCisgICAgICAgIEZvbGxvd3VwIChyMjM0NjgzKTogRWxlbWVu dDo6Z2V0QXR0cmlidXRlKCkgc2hvdWxkIHJldHVybiB0aGUgZmlyc3Qgbm9uLW51bGwgYXR0cmli dXRlIHZhbHVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xODg0MTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHN2Zy9jdXN0b20vaHJlZi1zdmctbmFtZXNwYWNlLWVtcHR5LWV4cGVjdGVkLnR4dDogQWRk ZWQuCisgICAgICAgICogc3ZnL2N1c3RvbS9ocmVmLXN2Zy1uYW1lc3BhY2UtZW1wdHkuaHRtbDog QWRkZWQuCisKIDIwMTgtMDgtMDcgIFNhaWQgQWJvdS1IYWxsYXdhICA8c2Fib3VoYWxsYXdhQGFw cGxlLmNvbT4KIAogICAgICAgICBBbGxvdyBocmVmIGF0dHJpYnV0ZSB3aXRob3V0IHhsaW5rIG9u IFNWRyBlbGVtZW50cwpJbmRleDogTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9ocmVmLXN2Zy1uYW1l c3BhY2UtZW1wdHktZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3N2Zy9j dXN0b20vaHJlZi1zdmctbmFtZXNwYWNlLWVtcHR5LWV4cGVjdGVkLnR4dAkobm9uZXhpc3RlbnQp CisrKyBMYXlvdXRUZXN0cy9zdmcvY3VzdG9tL2hyZWYtc3ZnLW5hbWVzcGFjZS1lbXB0eS1leHBl Y3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxOSBAQAorVGVzdCB0aGUgcG9zc2li bGUgY2FzZXMgb2YgdGhlIHN2ZyBocmVmIGF0dHJpYnV0ZSB2YWx1ZTogbnVsbCBzdHJpbmcsIGVt cHR5IHN0cmluZyBhbmQgbm9uLWVtcHR5IHN0cmluZy4KKworT24gc3VjY2VzcywgeW91IHdpbGwg c2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExF VEUiLgorCisKK1BBU1Mgd2luZG93LmVsZW1lbnQuZ2V0QXR0cmlidXRlTlMoJ2h0dHA6Ly93d3cu dzMub3JnLzE5OTkveGxpbmsnLCAnaHJlZicpIGlzIG51bGwKK1BBU1Mgd2luZG93LmVsZW1lbnQu Z2V0QXR0cmlidXRlKCdocmVmJykgaXMgbnVsbAorUEFTUyB3aW5kb3cuZWxlbWVudC5nZXRBdHRy aWJ1dGVOUygnaHR0cDovL3d3dy53My5vcmcvMTk5OS94bGluaycsICdocmVmJykgaXMgInd3dy53 ZWJraXQub3JnIgorUEFTUyB3aW5kb3cuZWxlbWVudC5nZXRBdHRyaWJ1dGUoJ2hyZWYnKSBpcyAi d3d3LndlYmtpdC5vcmciCitQQVNTIHdpbmRvdy5lbGVtZW50LmdldEF0dHJpYnV0ZU5TKCdodHRw Oi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rJywgJ2hyZWYnKSBpcyAiIgorUEFTUyB3aW5kb3cuZWxl bWVudC5nZXRBdHRyaWJ1dGUoJ2hyZWYnKSBpcyAiIgorUEFTUyB3aW5kb3cuZWxlbWVudC5nZXRB dHRyaWJ1dGVOUygnaHR0cDovL3d3dy53My5vcmcvMTk5OS94bGluaycsICdocmVmJykgaXMgInd3 dy5idWlsZC53ZWJraXQub3JnIgorUEFTUyB3aW5kb3cuZWxlbWVudC5nZXRBdHRyaWJ1dGUoJ2hy ZWYnKSBpcyAid3d3LmJ1aWxkLndlYmtpdC5vcmciCitQQVNTIHdpbmRvdy5lbGVtZW50LmdldEF0 dHJpYnV0ZU5TKCdodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rJywgJ2hyZWYnKSBpcyAiIgor UEFTUyB3aW5kb3cuZWxlbWVudC5nZXRBdHRyaWJ1dGUoJ2hyZWYnKSBpcyAiIgorUEFTUyBzdWNj ZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRl c3RzL3N2Zy9jdXN0b20vaHJlZi1zdmctbmFtZXNwYWNlLWVtcHR5Lmh0bWwKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9ocmVmLXN2Zy1uYW1lc3BhY2UtZW1wdHkuaHRtbAko bm9uZXhpc3RlbnQpCisrKyBMYXlvdXRUZXN0cy9zdmcvY3VzdG9tL2hyZWYtc3ZnLW5hbWVzcGFj ZS1lbXB0eS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMjkgQEAKKzxoZWFkPgorICAg IDxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0Pgor PC9oZWFkPgorPGJvZHk+CisgICAgPHNjcmlwdD4KKyAgICAgICAgZGVzY3JpcHRpb24oIlRlc3Qg dGhlIHBvc3NpYmxlIGNhc2VzIG9mIHRoZSBzdmcgaHJlZiBhdHRyaWJ1dGUgdmFsdWU6IG51bGwg c3RyaW5nLCBlbXB0eSBzdHJpbmcgYW5kIG5vbi1lbXB0eSBzdHJpbmcuIik7CisKKyAgICAgICAg d2luZG93LmVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50TlMoImh0dHA6Ly93d3cudzMu b3JnLzIwMDAvc3ZnIiwgImEiKTsKKyAgICAgICAgc2hvdWxkQmVOdWxsKCJ3aW5kb3cuZWxlbWVu dC5nZXRBdHRyaWJ1dGVOUygnaHR0cDovL3d3dy53My5vcmcvMTk5OS94bGluaycsICdocmVmJyki KTsKKyAgICAgICAgc2hvdWxkQmVOdWxsKCJ3aW5kb3cuZWxlbWVudC5nZXRBdHRyaWJ1dGUoJ2hy ZWYnKSIpOworCisgICAgICAgIHdpbmRvdy5lbGVtZW50LnNldEF0dHJpYnV0ZU5TKCJodHRwOi8v d3d3LnczLm9yZy8xOTk5L3hsaW5rIiwgImhyZWYiLCAid3d3LndlYmtpdC5vcmciKTsKKyAgICAg ICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJ3aW5kb3cuZWxlbWVudC5nZXRBdHRyaWJ1dGVOUygn aHR0cDovL3d3dy53My5vcmcvMTk5OS94bGluaycsICdocmVmJykiLCAid3d3LndlYmtpdC5vcmci KTsKKyAgICAgICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJ3aW5kb3cuZWxlbWVudC5nZXRBdHRy aWJ1dGUoJ2hyZWYnKSIsICAid3d3LndlYmtpdC5vcmciKTsKKworICAgICAgICB3aW5kb3cuZWxl bWVudC5zZXRBdHRyaWJ1dGVOUygiaHR0cDovL3d3dy53My5vcmcvMTk5OS94bGluayIsICJocmVm IiwgIiIpOworICAgICAgICBzaG91bGRCZUVtcHR5U3RyaW5nKCJ3aW5kb3cuZWxlbWVudC5nZXRB dHRyaWJ1dGVOUygnaHR0cDovL3d3dy53My5vcmcvMTk5OS94bGluaycsICdocmVmJykiKTsKKyAg ICAgICAgc2hvdWxkQmVFbXB0eVN0cmluZygid2luZG93LmVsZW1lbnQuZ2V0QXR0cmlidXRlKCdo cmVmJykiKTsKKworICAgICAgICB3aW5kb3cuZWxlbWVudC5zZXRBdHRyaWJ1dGUoImhyZWYiLCAi d3d3LmJ1aWxkLndlYmtpdC5vcmciKTsKKyAgICAgICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJ3 aW5kb3cuZWxlbWVudC5nZXRBdHRyaWJ1dGVOUygnaHR0cDovL3d3dy53My5vcmcvMTk5OS94bGlu aycsICdocmVmJykiLCAid3d3LmJ1aWxkLndlYmtpdC5vcmciKTsKKyAgICAgICAgc2hvdWxkQmVF cXVhbFRvU3RyaW5nKCJ3aW5kb3cuZWxlbWVudC5nZXRBdHRyaWJ1dGUoJ2hyZWYnKSIsICAid3d3 LmJ1aWxkLndlYmtpdC5vcmciKTsKKworICAgICAgICB3aW5kb3cuZWxlbWVudC5zZXRBdHRyaWJ1 dGUoImhyZWYiLCAiIik7CisgICAgICAgIHNob3VsZEJlRW1wdHlTdHJpbmcoIndpbmRvdy5lbGVt ZW50LmdldEF0dHJpYnV0ZU5TKCdodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rJywgJ2hyZWYn KSIpOworICAgICAgICBzaG91bGRCZUVtcHR5U3RyaW5nKCJ3aW5kb3cuZWxlbWVudC5nZXRBdHRy aWJ1dGUoJ2hyZWYnKSIpOworICAgIDwvc2NyaXB0PgorICAgIDxzY3JpcHQgc3JjPSIuLi8uLi9y ZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4K