188399 2018-08-07 19:31:11 -0700 Web Inspector: Consider raising the 4gb process memory limit for WebInspector process 2020-08-27 14:13:40 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All NEW InRadar P2 Normal --- 1 saam webkit-unassigned ap bburg inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1448662 0 saam 2018-08-07 19:31:11 -0700 I ran into this limit a few times when taking heap snapshots of large heaps. 1448865 1 joepeck 2018-08-08 15:14:06 -0700 In WebKit the Web Inspector frontend page is just a WebPageProxy: void WebInspectorProxy::createFrontendPage() { if (m_inspectorPage) return; m_inspectorPage = platformCreateFrontendPage(); ... trackInspectorPage(m_inspectorPage); ... } However these inspector frontend pages are put into special WebProcessPools meant for only Inspector Pages: WebProcessPool& inspectorProcessPool(unsigned inspectionLevel) { // Having our own process pool removes us from the main process pool and // guarantees no process sharing for our user interface. WebProcessPool*& pool = (inspectionLevel == 1) ? s_mainInspectorProcessPool : s_nestedInspectorProcessPool; if (!pool) { auto configuration = API::ProcessPoolConfiguration::createWithLegacyOptions(); pool = &WebProcessPool::create(configuration.get()).leakRef(); } return *pool; } This makes me think that if we can set a bit on the WebProcessProxy / WebProcess that says "You're a Debugger Process". Then when the first WebPage is created in the process pool it could propagate the property to the pressure handler: MemoryPressureHandler::singleton()->setDebuggerProcess(); This could then raise / affect the limit. 1448879 2 bburg 2018-08-08 16:22:01 -0700 Joe's investigation sounds like a good plan. Is there any reasonable way to test this without screwing up bots? Obviously we can try to take a huge heap snapshot, but considering how slow bots are already compared to dev boxes, I'm not sure a test like this would be stable or useful. 1448881 3 ap 2018-08-08 16:55:47 -0700 I'm also skeptical of testing that uses huge amounts of memory. 1683482 4 webkit-bug-importer 2020-08-27 14:13:40 -0700 <rdar://problem/67896698>