188395 2018-08-07 16:56:14 -0700 ResourceUsageOverlay should use physical footprint for its "Footprint" label 2018-08-07 21:42:20 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff rmorisset simon.fraser ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1448639 0 saam 2018-08-07 16:56:14 -0700 ... 1448643 1 saam 2018-08-07 17:06:35 -0700 It uses total dirty pages instead of physical footprint on darwin... 1448652 2 346748 saam 2018-08-07 18:10:31 -0700 Created attachment 346748 patch 1448658 3 346748 simon.fraser 2018-08-07 18:48:44 -0700 Comment on attachment 346748 patch View in context: https://bugs.webkit.org/attachment.cgi?id=346748&action=review > Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:461 > + if (auto footprint = memoryFootprint()) I don't like how memoryFootprint() returns an optional. This isn't normally how we do error handling. 1448680 4 346748 saam 2018-08-07 21:09:46 -0700 Comment on attachment 346748 patch View in context: https://bugs.webkit.org/attachment.cgi?id=346748&action=review >> Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:461 >> + if (auto footprint = memoryFootprint()) > > I don't like how memoryFootprint() returns an optional. This isn't normally how we do error handling. Also I don’t even think about this failing as really being standard error handling. A failure here is totally unexpected and not something that happens in practice. We should probably just make that function return zero in such a scenario 1448681 5 saam 2018-08-07 21:15:00 -0700 I’ll file a bug for this 1448682 6 346748 commit-queue 2018-08-07 21:41:35 -0700 Comment on attachment 346748 patch Clearing flags on attachment: 346748 Committed r234686: <https://trac.webkit.org/changeset/234686> 1448683 7 commit-queue 2018-08-07 21:41:37 -0700 All reviewed patches have been landed. Closing bug. 1448684 8 webkit-bug-importer 2018-08-07 21:42:20 -0700 <rdar://problem/43033735> 346748 2018-08-07 18:10:31 -0700 2018-08-07 21:41:35 -0700 patch c-backup.diff text/plain 2266 saam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNDY4MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA4LTA3ICBTYWFtIEJh cmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIFJlc291cmNlVXNhZ2VPdmVybGF5 IHNob3VsZCB1c2UgcGh5c2ljYWwgZm9vdHByaW50IGZvciBpdHMgIkZvb3RwcmludCIgbGFiZWwK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODM5NQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExldCdzIHVz ZSBwaHlzaWNhbCBmb290cHJpbnQgb24gQ29jb2EgZm9yIHRoZSBudW1iZXIgd2Ugc2F5IGlzICJm b290cHJpbnQiLgorICAgICAgICBCZWZvcmUsIHdlIHdlcmUganVzdCB1c2luZyB0aGUgbnVtYmVy IG9mIGRpcnR5IHBhZ2VzIG11bHRpcGxpZXMgYnkKKyAgICAgICAgcGFnZSBzaXplLiBUaGlzIG51 bWJlciB3YXMgYW4gdXBwZXIgYm91bmQgb24gZm9vdHByaW50IHNpbmNlIGl0CisgICAgICAgIGRv ZXNuJ3QgdGFrZSBpbnRvIGFjY291bnQgY29tcHJlc3NlZCBtZW1vcnkuCisKKyAgICAgICAgKiBw YWdlL2NvY29hL1Jlc291cmNlVXNhZ2VPdmVybGF5Q29jb2EubW06CisgICAgICAgIChXZWJDb3Jl OjpSZXNvdXJjZVVzYWdlT3ZlcmxheTo6cGxhdGZvcm1EcmF3KToKKwogMjAxOC0wOC0wNyAgUnlv c3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBkb2N1bWVudC5vcGVuIGFu ZCBkb2N1bWVudC53cml0ZSBtdXN0IHRocm93IHdoaWxlIHRoZSBIVE1MIHBhcnNlciBpcyBzeW5j aHJvbm91c2x5IGNvbnN0cnVjdGluZyBhIGN1c3RvbSBlbGVtZW50CkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9wYWdlL2NvY29hL1Jlc291cmNlVXNhZ2VPdmVybGF5Q29jb2EubW0KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcGFnZS9jb2NvYS9SZXNvdXJjZVVzYWdlT3ZlcmxheUNvY29hLm1t CShyZXZpc2lvbiAyMzQ2ODApCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL2NvY29hL1Jlc291cmNl VXNhZ2VPdmVybGF5Q29jb2EubW0JKHdvcmtpbmcgY29weSkKQEAgLTM5LDYgKzM5LDcgQEAKICNp bmNsdWRlIDxRdWFydHpDb3JlL0NBVHJhbnNhY3Rpb24uaD4KICNpbmNsdWRlIDx3dGYvTWFpblRo cmVhZC5oPgogI2luY2x1ZGUgPHd0Zi9NYXRoRXh0cmFzLmg+CisjaW5jbHVkZSA8d3RmL01lbW9y eUZvb3RwcmludC5oPgogI2luY2x1ZGUgPHd0Zi9OZXZlckRlc3Ryb3llZC5oPgogCiB1c2luZyBX ZWJDb3JlOjpSZXNvdXJjZVVzYWdlT3ZlcmxheTsKQEAgLTQ1Nyw3ICs0NTgsMTAgQEAgdm9pZCBS ZXNvdXJjZVVzYWdlT3ZlcmxheTo6cGxhdGZvcm1EcmF3KAogCiAgICAgc3RhdGljIENHQ29sb3JS ZWYgY29sb3JGb3JMYWJlbHMgPSBjcmVhdGVDb2xvcigwLjksIDAuOSwgMC45LCAxKTsKICAgICBz aG93VGV4dChjb250ZXh0LCAxMCwgMjAsIGNvbG9yRm9yTGFiZWxzLCBTdHJpbmc6OmZvcm1hdCgi ICAgICAgICBDUFU6ICVnIiwgZGF0YS5jcHUubGFzdCgpKSk7Ci0gICAgc2hvd1RleHQoY29udGV4 dCwgMTAsIDMwLCBjb2xvckZvckxhYmVscywgIiAgRm9vdHByaW50OiAiICsgZm9ybWF0Qnl0ZU51 bWJlcihkYXRhLnRvdGFsRGlydHlTaXplLmxhc3QoKSkpOworICAgIGlmIChhdXRvIGZvb3Rwcmlu dCA9IG1lbW9yeUZvb3RwcmludCgpKQorICAgICAgICBzaG93VGV4dChjb250ZXh0LCAxMCwgMzAs IGNvbG9yRm9yTGFiZWxzLCAiICBGb290cHJpbnQ6ICIgKyBmb3JtYXRCeXRlTnVtYmVyKCpmb290 cHJpbnQpKTsKKyAgICBlbHNlCisgICAgICAgIHNob3dUZXh0KGNvbnRleHQsIDEwLCAzMCwgY29s b3JGb3JMYWJlbHMsICIgIEZvb3RwcmludDogIiArIGZvcm1hdEJ5dGVOdW1iZXIoZGF0YS50b3Rh bERpcnR5U2l6ZS5sYXN0KCkpKTsKICAgICBzaG93VGV4dChjb250ZXh0LCAxMCwgNDAsIGNvbG9y Rm9yTGFiZWxzLCAiICAgRXh0ZXJuYWw6ICIgKyBmb3JtYXRCeXRlTnVtYmVyKGRhdGEudG90YWxF eHRlcm5hbFNpemUubGFzdCgpKSk7CiAKICAgICBmbG9hdCB5ID0gNTU7Cg==