18837 2008-05-01 15:57:25 -0700 Database panel fails to display tables if any value is NULL 2008-06-08 13:58:58 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 thos.davis aroben aroben timothy oldest_to_newest 79393 0 thos.davis 2008-05-01 15:57:25 -0700 An SQL NULL value in an SQLite database is correctly returned in the results as having the javascript null type, which (in file DatabasesPanel.js, function _tableForResult ) either causes the div.textContent or the text.length to throw an exception. The fix is to check for null and then reassign the text value, possible adding a new classname to the div as in: --- DatabasesPanel.js 2008/05/01 22:48:06 1.1 +++ DatabasesPanel.js 2008/05/01 22:51:23 1.2 @@ -204,6 +204,10 @@ var text = row[column]; var div = document.createElement("div"); + if ( text == null ) { + text = "NULL" + div.className = "sql_null"; + } div.textContent = text; div.title = text; td.appendChild(div); To make use of the className = "sql_null", append the following to inspector.js: .sql_null { text-align: center; color: #faa; } 79397 1 dev+webkit 2008-05-01 16:26:03 -0700 Please submit a patch using the instructions at <http://webkit.org/coding/contributing.html>. Our code style guidelines are available at <http://webkit.org/coding/coding-style.html>. 79410 2 20919 thos.davis 2008-05-01 22:03:39 -0700 Created attachment 20919 Proposed patch 79419 3 20919 mjs 2008-05-02 03:59:07 -0700 Comment on attachment 20919 Proposed patch r=me 82624 4 20919 darin 2008-06-08 11:47:41 -0700 Comment on attachment 20919 Proposed patch Sorry. This patch was great, but it wasn't landed. Now the Databases panel has changed too much to land it. It's now using a DataGrid class. I couldn't figure out exactly how to merge this or if the code has this issue any more. For now, setting review to review-. We can close this bug if it's already fixed, or rework the patch if not. 82645 5 21578 aroben 2008-06-08 13:19:37 -0700 Created attachment 21578 patch + changelog 82646 6 21578 darin 2008-06-08 13:21:09 -0700 Comment on attachment 21578 patch + changelog r=me The original patch had special formatting for null values. Did you decide that wasn't worthwhile? 82648 7 aroben 2008-06-08 13:25:01 -0700 (In reply to comment #6) > The original patch had special formatting for null values. Did you decide that > wasn't worthwhile? It probably is worthwhile, but I didn't want to add that while fixing this bug. I'll file a new bug about special formatting and add a FIXME. Thanks! 82651 8 aroben 2008-06-08 13:27:51 -0700 (In reply to comment #7) > I'll file a new bug about special formatting Bug 19439 82671 9 aroben 2008-06-08 13:58:58 -0700 Committed in r34456 20919 2008-05-01 22:03:39 -0700 2008-06-08 13:19:37 -0700 Proposed patch Handle_NULLs_in_DatabasesPanel.patch text/plain 1936 thos.davis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMjc4NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDgtMDUtMDEgIFRvbSBEYXZpcyAgPHRob3MuZGF2aXNAbWFjLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXQVJO SU5HOiBOTyBURVNUIENBU0VTIEFEREVEIE9SIENIQU5HRUQKKworICAgICAgICBIYW5kbGUgTlVM THMgaW4gcmV0dXJuZWQgZGF0YWJhc2UgcmVzdWx0cyAoRG9uJ3QgdGhyb3cgYW4gZXhjZXB0aW9u KQorCisgICAgICAgICogcGFnZS9pbnNwZWN0b3IvRGF0YWJhc2VzUGFuZWwuanM6CisgICAgICAg IEFkZCBhIHRlc3QgZm9yIG51bGwgKHRleHQgPT0gbnVsbCksIGFuZCBjaGFuZ2UgdGhlIHRleHQs IHBsdXMgYWRkIAorICAgICAgICBhIGNsYXNzIHRvIHRoZSBjb250YWluaW5nIGRpdiBzbyB0aGUg TlVMTCB3b24ndCBsb29rIGxpa2UgdGV4dCB3aGljaCAKKyAgICAgICAganVzdCBoYXBwZW5zIHRv IGJlIHRoZSBzdHJpbmcgJ05VTEwnLgorCisgICAgICAgICogcGFnZS9pbnNwZWN0b3IvaW5zcGVj dG9yLmNzczoKKyAgICAgICAgQWRkIHNvbWUgdmlzdWFsIGRpc3RpbmN0aW9uIHRvIGEgZGl2IHdp dGggY2xhc3Mgc3FsX251bGwuCisKIDIwMDgtMDUtMDEgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVy c2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW0uCkluZGV4OiBXZWJDb3Jl L3BhZ2UvaW5zcGVjdG9yL0RhdGFiYXNlc1BhbmVsLmpzCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv cGFnZS9pbnNwZWN0b3IvRGF0YWJhc2VzUGFuZWwuanMJKHJldmlzaW9uIDMyNzgzKQorKysgV2Vi Q29yZS9wYWdlL2luc3BlY3Rvci9EYXRhYmFzZXNQYW5lbC5qcwkod29ya2luZyBjb3B5KQpAQCAt MjA0LDYgKzIwNCwxMCBAQCBXZWJJbnNwZWN0b3IuRGF0YWJhc2VzUGFuZWwucHJvdG90eXBlID0g CiAKICAgICAgICAgICAgICAgICB2YXIgdGV4dCA9IHJvd1tjb2x1bW5dOwogICAgICAgICAgICAg ICAgIHZhciBkaXYgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKKyAgICAgICAgICAg ICAgICBpZiAodGV4dCA9PSBudWxsKSB7CisgICAgICAgICAgICAgICAgICAgIHRleHQgPSAiTlVM TCI7CisgICAgICAgICAgICAgICAgICAgIGRpdi5jbGFzc05hbWUgPSAic3FsX251bGwiOworICAg ICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICBkaXYudGV4dENvbnRlbnQgPSB0ZXh0Owog ICAgICAgICAgICAgICAgIGRpdi50aXRsZSA9IHRleHQ7CiAgICAgICAgICAgICAgICAgdGQuYXBw ZW5kQ2hpbGQoZGl2KTsKSW5kZXg6IFdlYkNvcmUvcGFnZS9pbnNwZWN0b3IvaW5zcGVjdG9yLmNz cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL2luc3BlY3Rvci5jc3MJKHJl dmlzaW9uIDMyNzgzKQorKysgV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9pbnNwZWN0b3IuY3NzCSh3 b3JraW5nIGNvcHkpCkBAIC0yMDU1LDMgKzIwNTUsOCBAQCBib2R5LmluYWN0aXZlIC5zaWRlYmFy LXRyZWUtaXRlbS5zZWxlY3RlCiAucmVzb3VyY2Utc2lkZWJhci10cmVlLWl0ZW0gLmJ1YmJsZS5l cnJvciB7CiAgICAgYmFja2dyb3VuZC1jb2xvcjogcmdiKDIxNiwgMzUsIDM1KTsKIH0KKworLnNx bF9udWxsIHsKKyAgICB0ZXh0LWFsaWduOiBjZW50ZXI7CisgICAgY29sb3I6ICNmYWE7Cit9Cg== 21578 2008-06-08 13:19:37 -0700 2008-06-08 13:21:09 -0700 patch + changelog 0002--Fix-Bug-18837-Database-panel-fails-to-displ.patch text/plain 3672 aroben RnJvbSBiNTg5MTZjNmI2ZDBjYzM3YTAwOTVhN2ZiNDE2NzI5YTE4N2QzZTZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGFtIFJvYmVuIDxhcm9iZW5AYXBwbGUuY29tPgpEYXRlOiBT dW4sIDggSnVuIDIwMDggMTM6MjE6MjUgLTA3MDAKU3ViamVjdDogW1BBVENIXSAgICAgICAgIEZp eCBCdWcgMTg4Mzc6IERhdGFiYXNlIHBhbmVsIGZhaWxzIHRvIGRpc3BsYXkgdGFibGVzIGlmIGFu eSB2YWx1ZSBpcyBOVUxMCgogICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTg4Mzc+CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAg ICAgICBUZXN0OiBtYW51YWwtdGVzdHMvaW5zcGVjdG9yL2Rpc3BsYXktc3FsLW51bGwuaHRtbAoK ICAgICAgICAqIG1hbnVhbC10ZXN0cy9pbnNwZWN0b3IvZGlzcGxheS1zcWwtbnVsbC5odG1sOiBB ZGRlZC4KICAgICAgICAqIHBhZ2UvaW5zcGVjdG9yL0RhdGFiYXNlc1BhbmVsLmpzOgogICAgICAg IChXZWJJbnNwZWN0b3IuRGF0YWJhc2VzUGFuZWwucHJvdG90eXBlLmRhdGFHcmlkRm9yUmVzdWx0 KTogQ29udmVydCBhbGwKICAgICAgICBvYmplY3RzIHRvIHN0cmluZ3MgYmVmb3JlIG9wZXJhdGlu ZyBvbiB0aGVtLgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHwgICAxNiArKysrKysrKysrKysrKysKIC4uLi9tYW51YWwtdGVzdHMvaW5zcGVj dG9yL2Rpc3BsYXktc3FsLW51bGwuaHRtbCAgIHwgICAyMSArKysrKysrKysrKysrKysrKysrKwog V2ViQ29yZS9wYWdlL2luc3BlY3Rvci9EYXRhYmFzZXNQYW5lbC5qcyAgICAgICAgICAgfCAgICAy ICstCiAzIGZpbGVzIGNoYW5nZWQsIDM4IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCiBj cmVhdGUgbW9kZSAxMDA2NDQgV2ViQ29yZS9tYW51YWwtdGVzdHMvaW5zcGVjdG9yL2Rpc3BsYXkt c3FsLW51bGwuaHRtbAoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9D aGFuZ2VMb2cKaW5kZXggOTQxOWY3Zi4uZWRhOTY4NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFu Z2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMSBAQAogMjAwOC0wNi0w OCAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKKyAgICAgICAgRml4IEJ1ZyAxODgz NzogRGF0YWJhc2UgcGFuZWwgZmFpbHMgdG8gZGlzcGxheSB0YWJsZXMgaWYgYW55IHZhbHVlIGlz CisgICAgICAgIE5VTEwKKworICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4ODM3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRlc3Q6IG1hbnVhbC10ZXN0cy9pbnNwZWN0b3IvZGlzcGxheS1zcWwtbnVsbC5o dG1sCisKKyAgICAgICAgKiBtYW51YWwtdGVzdHMvaW5zcGVjdG9yL2Rpc3BsYXktc3FsLW51bGwu aHRtbDogQWRkZWQuCisgICAgICAgICogcGFnZS9pbnNwZWN0b3IvRGF0YWJhc2VzUGFuZWwuanM6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuRGF0YWJhc2VzUGFuZWwucHJvdG90eXBlLmRhdGFHcmlk Rm9yUmVzdWx0KTogQ29udmVydCBhbGwKKyAgICAgICAgb2JqZWN0cyB0byBzdHJpbmdzIGJlZm9y ZSBvcGVyYXRpbmcgb24gdGhlbS4KKworMjAwOC0wNi0wOCAgQWRhbSBSb2JlbiAgPGFyb2JlbkBh cHBsZS5jb20+CisKICAgICAgICAgRml4IEJ1ZyAxOTQzODogVHJhbnNhY3Rpb24gZXJyb3JzIGFy ZSBuZXZlciBkaXNwbGF5ZWQgaW4gZGF0YWJhc2UKICAgICAgICAgcXVlcnkgdmlldwogCmRpZmYg LS1naXQgYS9XZWJDb3JlL21hbnVhbC10ZXN0cy9pbnNwZWN0b3IvZGlzcGxheS1zcWwtbnVsbC5o dG1sIGIvV2ViQ29yZS9tYW51YWwtdGVzdHMvaW5zcGVjdG9yL2Rpc3BsYXktc3FsLW51bGwuaHRt bApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4xZDE0MDNiCi0tLSAvZGV2L251 bGwKKysrIGIvV2ViQ29yZS9tYW51YWwtdGVzdHMvaW5zcGVjdG9yL2Rpc3BsYXktc3FsLW51bGwu aHRtbApAQCAtMCwwICsxLDIxIEBACis8c2NyaXB0PgorICAgIHRyeSB7CisgICAgICAgIHZhciBk YiA9IG9wZW5EYXRhYmFzZSgiSW5zcGVjdG9yVGVzdCIsICIwLjEiLCAiRGF0YWJhc2UgZm9yIElu c3BlY3RvciB0ZXN0cyIsIDIwMDAwMCk7CisgICAgICAgIGRiLnRyYW5zYWN0aW9uKGZ1bmN0aW9u KHR4KSB7CisgICAgICAgICAgICB0eC5leGVjdXRlU3FsKCJDUkVBVEUgVEFCTEUgRGlzcGxheVNR TE51bGwgKHRlc3QgVEVYVCkiLCBbXSwgZnVuY3Rpb24odHgpIHsKKyAgICAgICAgICAgICAgICB0 eC5leGVjdXRlU3FsKCJJTlNFUlQgSU5UTyBEaXNwbGF5U1FMTnVsbCAodGVzdCkgVkFMVUVTIChO VUxMKSIpOworICAgICAgICAgICAgfSkKKyAgICAgICAgfSk7CisgICAgfSBjYXRjaCAoZSkgewor ICAgIH0KKzwvc2NyaXB0PgorPHA+VGVzdCBmb3IgPGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODM3Ij5CdWcgMTg4Mzc6IERhdGFiYXNlIHBhbmVsIGZh aWxzIHRvIGRpc3BsYXkgdGFibGVzIGlmIGFueSB2YWx1ZSBpcyBOVUxMPC9hPi48L3A+Cis8cD5U byB0ZXN0OjwvcD4KKzxvbD4KKyAgICA8bGk+T3BlbiB0aGUgSW5zcGVjdG9yPC9saT4KKyAgICA8 bGk+R28gdG8gdGhlIERhdGFiYXNlcyBwYW5lbDwvbGk+CisgICAgPGxpPkNsaWNrIG9uIHRoZSA8 Y29kZT5EaXNwbGF5U1FMTnVsbDwvY29kZT4gdGFibGUgaW5zaWRlIHRoZSA8Y29kZT5JbnNwZWN0 b3JUZXN0PC9jb2RlPiBkYXRhYmFzZTwvbGk+Cis8L29sPgorPHA+SWYgdGhlIGNvbnRlbnRzIG9m IHRoZSB0YWJsZSBhcHBlYXIgKGEgc2luZ2xlIHJvdyB3aXRoIHRoZSB2YWx1ZQorIjxjb2RlPm51 bGw8L2NvZGU+IiBpbiB0aGUgPGNvZGU+dGVzdDwvY29kZT4gY29sdW1uKSwgeW91IGhhdmUgcGFz c2VkIHRoZQordGVzdC48L3A+CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL0Rh dGFiYXNlc1BhbmVsLmpzIGIvV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9EYXRhYmFzZXNQYW5lbC5q cwppbmRleCBmMjRhNTViLi5jYjRkM2Q3IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvaW5zcGVj dG9yL0RhdGFiYXNlc1BhbmVsLmpzCisrKyBiL1dlYkNvcmUvcGFnZS9pbnNwZWN0b3IvRGF0YWJh c2VzUGFuZWwuanMKQEAgLTE4NSw3ICsxODUsNyBAQCBXZWJJbnNwZWN0b3IuRGF0YWJhc2VzUGFu ZWwucHJvdG90eXBlID0gewogCiAgICAgICAgICAgICB2YXIgcm93ID0gcm93cy5pdGVtKGkpOwog ICAgICAgICAgICAgZm9yICh2YXIgY29sdW1uSWRlbnRpZmllciBpbiByb3cpIHsKLSAgICAgICAg ICAgICAgICB2YXIgdGV4dCA9IHJvd1tjb2x1bW5JZGVudGlmaWVyXTsKKyAgICAgICAgICAgICAg ICB2YXIgdGV4dCA9IFN0cmluZyhyb3dbY29sdW1uSWRlbnRpZmllcl0pOwogICAgICAgICAgICAg ICAgIGRhdGFbY29sdW1uSWRlbnRpZmllcl0gPSB0ZXh0OwogICAgICAgICAgICAgICAgIGlmICh0 ZXh0Lmxlbmd0aCA+IGNvbHVtbnNbY29sdW1uSWRlbnRpZmllcl0ud2lkdGgpCiAgICAgICAgICAg ICAgICAgICAgIGNvbHVtbnNbY29sdW1uSWRlbnRpZmllcl0ud2lkdGggPSB0ZXh0Lmxlbmd0aDsK LS0gCjEuNS42LnJjMC40Ni5nZDJiMwoK