18835 2008-05-01 14:08:03 -0700 spelling underlines disappear when they shouldn't 2009-01-28 16:51:02 -0800 1 1 1 Unclassified WebKit New Bugs 525.x (Safari 3.1) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric hbono justin.garcia oldest_to_newest 79388 0 eric 2008-05-01 14:08:03 -0700 This isn't 100% reproducible, but I can usually get it to happen with the following steps: 1. click into a textarea (add comment field on this page), or editable html region (gmail) 2. type the following: The quick brown foxxx jumped over 3. hit the back arrow four times to move the cursor to the beginning of 'over' 4. hit return The red squiggle under foxxx will disappear. I haven't tried on mac, just windows. 104852 1 26522 hbono 2009-01-08 00:04:12 -0800 Created attachment 26522 A Quick Fix I accidentally noticed a cause of this bug while investigating another issue. Somehow the InsertLineBreakCommand::doApply() function forgot copying markers while splitting a text node with a line-break key even though there is a CompositeEditCommand::splitTextNode() function, which splits a text node and copy markers. I'm not sure it is correct to call the CompositeEditCommand::splitTextNode() function here, though. 104854 2 26522 justin.garcia 2009-01-08 00:50:28 -0800 Comment on attachment 26522 A Quick Fix so, deleteTextFromNode removes spelling markers from text even if the deletion doesn't effect them? we should document that problem. do we need to make this change to InsertParagraphSeparatorCommand and BreakBlockquoteCommand? r=me 104855 3 justin.garcia 2009-01-08 00:55:48 -0800 > so, deleteTextFromNode removes spelling markers from text even if the deletion > doesn't effect them? we should document that problem. Oops my mistake, I misread the code, I thought it deleted what was after the caret, not what was before. Disregard that bit. 104986 4 hbono 2009-01-08 20:28:32 -0800 Thank you for your review and comments. > do we need to make this change to InsertParagraphSeparatorCommand and > BreakBlockquoteCommand? As far as I read the InsertParagraphSeparatorCommand::doApply() and BreakBlockquoteCommand::doApply() functions, they already use the splitTextNode() function to split a text node. (This is a reason why my quick fix uses the splitTextNode() function.) Regards, Hironori Bono 107357 5 fishd 2009-01-28 11:38:37 -0800 http://trac.webkit.org/changeset/40317 107437 6 fishd 2009-01-28 16:51:02 -0800 Added missing layout test results: http://trac.webkit.org/changeset/40341 26522 2009-01-08 00:04:12 -0800 2009-01-08 00:50:28 -0800 A Quick Fix issue18835-patch0.txt text/plain 3630 hbono SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTY5OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMDEtMDcgIEhpcm9ub3JpIEJvbm8gIDxoYm9ub0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QnVnIDE4ODM1OiBzcGVsbGluZyB1bmRlcmxpbmVzIGRpc2FwcGVhciB3aGVuIHRoZXkgc2hvdWxk bid0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODgz NQorCisgICAgICAgIFRoZSBXZWJDb3JlOjpJbnNlcnRMaW5lQnJlYWtDb21tYW5kOjpkb0FwcGx5 KCkgZnVuY3Rpb24gc3BsaXRzIGEgdGV4dCBub2RlCisgICAgICAgIHdpdGhvdXQgY29weWluZyBl eGlzdGluZyBtYXJrZXJzLiBUbyBmaXggdGhpcyBidWcsIGNoYW5nZSBjb2RlIHdoaWNoCisgICAg ICAgIG1hbnVhbGx5IHNwbGl0cyBhIHRleHQgbm9kZSBpbnRvIGEgQ29tcG9zaXRlRWRpdENvbW1h bmQ6OnNwbGl0VGV4dE5vZGUoKSBjYWxsLgorCisgICAgICAgIFRlc3Q6IGVkaXRpbmcvc3BlbGxp bmcvc3BlbGxpbmctbGluZWJyZWFrLmh0bWwKKworICAgICAgICAqIGVkaXRpbmcvSW5zZXJ0TGlu ZUJyZWFrQ29tbWFuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNlcnRMaW5lQnJlYWtDb21t YW5kOjpkb0FwcGx5KToKKwogMjAwOS0wMS0wNyAgQ2hyaXMgTWFycmluICA8Y21hcnJpbkBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBXZWJDb3Jl L2VkaXRpbmcvSW5zZXJ0TGluZUJyZWFrQ29tbWFuZC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9lZGl0aW5nL0luc2VydExpbmVCcmVha0NvbW1hbmQuY3BwCShyZXZpc2lvbiAzOTY5OCkKKysr IFdlYkNvcmUvZWRpdGluZy9JbnNlcnRMaW5lQnJlYWtDb21tYW5kLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMTMzLDExICsxMzMsOCBAQCB2b2lkIEluc2VydExpbmVCcmVha0NvbW1hbmQ6OmRvQXBw bHkoKQogICAgICAgICBBU1NFUlQocG9zLm5vZGUoKS0+aXNUZXh0Tm9kZSgpKTsKICAgICAgICAg CiAgICAgICAgIC8vIERvIHRoZSBzcGxpdAotICAgICAgICBFeGNlcHRpb25Db2RlIGVjID0gMDsK ICAgICAgICAgVGV4dCAqdGV4dE5vZGUgPSBzdGF0aWNfY2FzdDxUZXh0ICo+KHBvcy5ub2RlKCkp OwotICAgICAgICBSZWZQdHI8VGV4dD4gdGV4dEJlZm9yZU5vZGUgPSBkb2N1bWVudCgpLT5jcmVh dGVUZXh0Tm9kZSh0ZXh0Tm9kZS0+c3Vic3RyaW5nRGF0YSgwLCBzZWxlY3Rpb24uc3RhcnQoKS5v ZmZzZXQoKSwgZWMpKTsKLSAgICAgICAgZGVsZXRlVGV4dEZyb21Ob2RlKHRleHROb2RlLCAwLCBw b3Mub2Zmc2V0KCkpOwotICAgICAgICBpbnNlcnROb2RlQmVmb3JlKHRleHRCZWZvcmVOb2RlLmdl dCgpLCB0ZXh0Tm9kZSk7CisgICAgICAgIHNwbGl0VGV4dE5vZGUodGV4dE5vZGUsIHBvcy5vZmZz ZXQoKSk7CiAgICAgICAgIGluc2VydE5vZGVCZWZvcmUobm9kZVRvSW5zZXJ0LmdldCgpLCB0ZXh0 Tm9kZSk7CiAgICAgICAgIFBvc2l0aW9uIGVuZGluZ1Bvc2l0aW9uID0gUG9zaXRpb24odGV4dE5v ZGUsIDApOwogICAgICAgICAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDM5Njk4KQorKysgTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDEtMDcg IEhpcm9ub3JpIEJvbm8gIDxoYm9ub0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDE4ODM1OiBzcGVsbGluZyB1bmRlcmxp bmVzIGRpc2FwcGVhciB3aGVuIHRoZXkgc2hvdWxkbid0CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODgzNQorCisgICAgICAgIEFkZCBhIGxheW91dCB0 ZXh0IHRvIHZlcmlmeSBpZiBtaXNzcGVsbGVkIG1hcmtlcnMgYXJlIGNvcGllZCB3aGVuIGEKKyAg ICAgICAgbGluZS1icmVhayBjb21tYW5kIHNwbGl0cyBhIHRleHQgbm9kZS4KKworICAgICAgICAq IGVkaXRpbmcvc3BlbGxpbmcvc3BlbGxpbmctbGluZWJyZWFrLmh0bWw6IEFkZGVkLgorCiAyMDA5 LTAxLTA3ICBKdXN0aW4gR2FyY2lhICA8anVzdGluLmdhcmNpYUBhcHBsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0aW5nL3Nw ZWxsaW5nL3NwZWxsaW5nLWxpbmVicmVhay5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2VkaXRpbmcvc3BlbGxpbmcvc3BlbGxpbmctbGluZWJyZWFrLmh0bWwJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9lZGl0aW5nL3NwZWxsaW5nL3NwZWxsaW5nLWxpbmVicmVhay5odG1sCShy ZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQxIEBACis8aHRtbD4gCis8aGVhZD4KKworPHN0eWxlPgor LmVkaXRpbmcgeyAKKyAgICBib3JkZXI6IDJweCBzb2xpZCByZWQ7IAorICAgIHBhZGRpbmc6IDEy cHg7IAorICAgIGZvbnQtc2l6ZTogMjRweDsgCit9Cis8L3N0eWxlPgorPHNjcmlwdCBzcmM9Li4v ZWRpdGluZy5qcyBsYW5ndWFnZT0iSmF2YVNjcmlwdCIgdHlwZT0idGV4dC9KYXZhU2NyaXB0IiA+ PC9zY3JpcHQ+CisKKzxzY3JpcHQ+CisKK2Z1bmN0aW9uIGVkaXRpbmdUZXN0KCkgeworICAgIHR5 cGVDaGFyYWN0ZXJDb21tYW5kKCd6Jyk7CisgICAgdHlwZUNoYXJhY3RlckNvbW1hbmQoJ3onKTsK KyAgICB0eXBlQ2hhcmFjdGVyQ29tbWFuZCgnICcpOworICAgIHR5cGVDaGFyYWN0ZXJDb21tYW5k KCdhJyk7CisgICAgdHlwZUNoYXJhY3RlckNvbW1hbmQoJyAnKTsKKyAgICB0eXBlQ2hhcmFjdGVy Q29tbWFuZCgnYScpOworICAgIG1vdmVTZWxlY3Rpb25CYWNrd2FyZEJ5V29yZENvbW1hbmQoKTsK KyAgICBpbnNlcnRMaW5lQnJlYWtDb21tYW5kKCk7Cit9CisKKzwvc2NyaXB0PgorCis8dGl0bGU+ RWRpdGluZyBUZXN0PC90aXRsZT4gCis8L2hlYWQ+IAorPGJvZHk+Cis8ZGl2PllvdSBzaG91bGQg c2VlICd6eiBhJyBvbiB0aGUgZmlyc3QgbGluZSBiZWxvdywgYW5kICdhJyBvbiB0aGUgc2Vjb25k IGxpbmUuICd6eicgKGFuZCBvbmx5ICd6eicpIHNob3VsZCBiZSBtYXJrZWQgYXMgbWlzc3BlbGxl ZC48L2Rpdj4KKzxkaXYgY29udGVudGVkaXRhYmxlIGlkPSJyb290IiBjbGFzcz0iZWRpdGluZyI+ Cis8c3BhbiBpZD0idGVzdCI+PC9zcGFuPgorPC9kaXY+CisKKzxzY3JpcHQ+CitydW5FZGl0aW5n VGVzdCgpOworPC9zY3JpcHQ+CisKKzwvYm9keT4KKzwvaHRtbD4K