188334 2018-08-05 15:42:45 -0700 [iOS] Layout tests that send HID events cause WebKitTestRunner to crash on recent SDKs 2018-08-06 08:44:22 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh ap bdakin commit-queue jbedard lforschler ryanhaddad simon.fraser thorton webkit-bug-importer oldest_to_newest 1448004 0 wenson_hsieh 2018-08-05 15:42:45 -0700 <rdar://problem/40630074> 1448006 1 wenson_hsieh 2018-08-05 15:44:13 -0700 This is the exception being thrown: Application Specific Information: CRASHING TEST: fast/events/touch/ios/iphone7/force-press-event.html *** Terminating app due to uncaught exception 'WebKitTestRunnerTestProblem', reason: 'The test completed before all synthesized events had been handled. Perhaps you're calling notifyDone() too early?' terminating with uncaught exception of type NSException abort() called 1448014 2 346606 wenson_hsieh 2018-08-05 16:24:48 -0700 Created attachment 346606 Patch 1448111 3 346606 commit-queue 2018-08-06 06:59:11 -0700 Comment on attachment 346606 Patch Clearing flags on attachment: 346606 Committed r234599: <https://trac.webkit.org/changeset/234599> 1448112 4 commit-queue 2018-08-06 06:59:12 -0700 All reviewed patches have been landed. Closing bug. 346606 2018-08-05 16:24:48 -0700 2018-08-06 06:59:11 -0700 Patch bug-188334-20180805162448.patch text/plain 4753 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NTY5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWYxMjg4N2ZkMWMxYmZhYmJhZDFhMTEyYTRjMTY3NmM0 YzdlMTI5Zi4uODAzYmVmOTZjODExM2FjNGU3NDZjOGU0YjhlYTQwODhkOGU4ZjIwMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM3 IEBACisyMDE4LTA4LTA1ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgor CisgICAgICAgIFtpT1NdIExheW91dCB0ZXN0cyB0aGF0IHNlbmQgSElEIGV2ZW50cyBjYXVzZSBX ZWJLaXRUZXN0UnVubmVyIHRvIGNyYXNoIG9uIHJlY2VudCBTREtzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODgzMzQKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzQwNjMwMDc0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRvIG1hcmsgdGhlIGVuZCBvZiBwcmV2aW91c2x5IGRpc3BhdGNoZWQgSU9ISUQg ZXZlbnRzLCBISURFdmVudEdlbmVyYXRvciBjdXJyZW50bHkgc2VuZHMgYSB2ZW5kb3ItZGVmaW5l ZCBldmVudAorICAgICAgICBhbmQgc3RvcmVzIHRoZSBjb21wbGV0aW9uIGNhbGxiYWNrIElEIGZv ciB0aGUgcHJldmlvdXNseSBkaXNwYXRjaGVkIGV2ZW50cyBhcyB2ZW5kb3ItZGVmaW5lZCBkYXRh LiBXaGVuIHRoaXMKKyAgICAgICAgdmVuZG9yLWRlZmluZWQgbWFya2VyIGV2ZW50IGlzIGhhbmRs ZWQgYnkgdGhlIGFwcGxpY2F0aW9uLCB3ZSB0aGVuIHJlYWQgdGhlIGNhbGxiYWNrIElEIGJhY2sg ZnJvbSB0aGUgZXZlbnQsIG1hcAorICAgICAgICBpdCB0byBhIGNvbXBsZXRpb24gYmxvY2ssIGFu ZCBpbnZva2UgdGhlIGNvbXBsZXRpb24gYmxvY2sgdG8gc2lnbmFsIHRoYXQgdGhlIHByZXZpb3Vz IEhJRCBldmVudCBoYXMgYmVlbgorICAgICAgICBwcm9jZXNzZWQuCisKKyAgICAgICAgVGhpcyBj YWxsYmFjayBJRCBpcyBhbiB1bnNpZ25lZCwgc28gd2UgdGVsbCBJT0tpdCB0aGF0IHdlIG5lZWQg YHNpemVvZih1bnNpZ25lZClgICg0IGJ5dGVzKSB0byBzdG9yZSBpdC4gT24KKyAgICAgICAgc2hp cHBpbmcgc29mdHdhcmUsIElPS2l0IGNsYW1wcyB0aGlzIHRvIGEgbWluaW11bSBvZiA4IGJ5dGVz LCBpLmUuIGBzaXplb2YoQ0ZJbmRleClgLiBXaGVuIHdlIGxhdGVyIGNhbGwKKyAgICAgICAgSU9I SURFdmVudEdldEludGVnZXJWYWx1ZSB0byByZWFkIHRoZSB2YWx1ZSBvZiBvdXIgdmVuZG9yLWRl ZmluZWQgZGF0YSBhcyBhIENGSW5kZXgsIHdlIGdldCBvdXIgZXhwZWN0ZWQKKyAgICAgICAgY2Fs bGJhY2sgSUQgYmVjYXVzZSB0aGUgYnVmZmVyIHdhcyBjbGFtcGVkIHRvIDggYnl0ZXMuCisKKyAg ICAgICAgSG93ZXZlciwgb24gcmVjZW50IGlPUyBTREtzIHRoYXQgY29udGFpbiB0aGUgZml4IGZv ciA8cmRhcjovL3Byb2JsZW0vMjAwODIyODQ+LCBJT0tpdCBubyBsb25nZXIgY2xhbXBzIHRoZSBz aXplCisgICAgICAgIG9mIHRoZSB2ZW5kb3ItZGVmaW5lZCBkYXRhIGJ1ZmZlciB0byA4IGJ5dGVz LiBUaGlzIG1lYW5zIHRoYXQgd2hlbiB3ZSB0cnkgdG8gdXNlIElPSElERXZlbnRHZXRJbnRlZ2Vy VmFsdWUgdG8KKyAgICAgICAgcmVhZCBvdXIgY2FsbGJhY2sgSUQgYmFjaywgd2UgZW5kIHVwIGdl dHRpbmcgYSBDRkluZGV4IHdoZXJlIHRoZSBsb3dlciA0IGJ5dGVzIGFyZSB0aGUgY2FsbGJhY2sg SUQgd2Ugd3JvdGUsIGFuZAorICAgICAgICB0aGUgdXBwZXIgNCBieXRlcyBhcmUgZ2FyYmFnZS4g SW4gdGhlIGNhc2Ugd2hlcmUgYW55IG9mIHRoZXNlIHVwcGVyIDQgYnl0ZXMgYXJlIG5vbi16ZXJv LCB3ZSBmYWlsIHRvIG1hcCB0aGUKKyAgICAgICAgY2FsbGJhY2sgSUQgdG8gYSBjb21wbGV0aW9u IGhhbmRsZXIsIGFuZCBzbyB3ZSBuZXZlciBmaW5pc2ggZGlzcGF0Y2hpbmcgdGhlIEhJRCBldmVu dCwgY2F1c2luZyBhbiBleGNlcHRpb24gdG8KKyAgICAgICAgYmUgdGhyb3duLgorCisgICAgICAg IFRvIGZpeCB0aGlzLCB3ZSBhZGp1c3QgY2FsbGJhY2sgSUQgdG8gYmUgYSBDRkluZGV4LCB3aGlj aCBtYXRjaGVzIElPSElERXZlbnRHZXRJbnRlZ2VyVmFsdWUncyByZXR1cm4gdHlwZS4KKworICAg ICAgICAqIFdlYktpdFRlc3RSdW5uZXIvaW9zL0hJREV2ZW50R2VuZXJhdG9yLm1tOgorICAgICAg ICAoK1tISURFdmVudEdlbmVyYXRvciBuZXh0RXZlbnRDYWxsYmFja0lEXSk6CisgICAgICAgICgt W0hJREV2ZW50R2VuZXJhdG9yIF9zZW5kTWFya2VySElERXZlbnRXaXRoQ29tcGxldGlvbkJsb2Nr Ol0pOgorCisgICAgICAgIEFsc28gcmVmYWN0b3IgYSBiaXQgb2YgYC1fc2VuZE1hcmtlckhJREV2 ZW50V2l0aENvbXBsZXRpb25CbG9jazpgIGJ5IHVzaW5nIGF1dG8gYW5kIG1vdmUgc2VtYW50aWNz LgorCiAyMDE4LTA4LTAzICBCZW4gUmljaGFyZHMgIDxiZW50b25fcmljaGFyZHNAYXBwbGUuY29t PgogCiAgICAgICAgIFdlIHNob3VsZCBjYWNoZSB0aGUgY29tcGlsZWQgc2FuZGJveCBwcm9maWxl IGluIGEgZGF0YSB2YXVsdApkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9pb3Mv SElERXZlbnRHZW5lcmF0b3IubW0gYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9ISURFdmVu dEdlbmVyYXRvci5tbQppbmRleCAzZDUwZGVkZDhkNjllYWU5NzllOWU3NzQ5Y2I1OGMwZWU0YjA3 MjU1Li4yOTI2MmE0ZTk0YTQ0N2RkMDg2OGY0MTJiMDAzNjdjM2QxYWRkYWVmIDEwMDY0NAotLS0g YS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9ISURFdmVudEdlbmVyYXRvci5tbQorKysgYi9U b29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9ISURFdmVudEdlbmVyYXRvci5tbQpAQCAtMTcxLDkg KzE3MSw5IEBAICsgKEhJREV2ZW50R2VuZXJhdG9yICopc2hhcmVkSElERXZlbnRHZW5lcmF0b3IK ICAgICByZXR1cm4gZXZlbnRHZW5lcmF0b3I7CiB9CiAKLSsgKHVuc2lnbmVkKW5leHRFdmVudENh bGxiYWNrSUQKKysgKENGSW5kZXgpbmV4dEV2ZW50Q2FsbGJhY2tJRAogewotICAgIHN0YXRpYyB1 bnNpZ25lZCBjYWxsYmFja0lEID0gMDsKKyAgICBzdGF0aWMgQ0ZJbmRleCBjYWxsYmFja0lEID0g MDsKICAgICByZXR1cm4gKytjYWxsYmFja0lEOwogfQogCkBAIC00NzksMjQgKzQ3OSwyMSBAQCAt IChCT09MKV9zZW5kSElERXZlbnQ6KElPSElERXZlbnRSZWYpZXZlbnRSZWYKIAogLSAoQk9PTClf c2VuZE1hcmtlckhJREV2ZW50V2l0aENvbXBsZXRpb25CbG9jazoodm9pZCAoXikodm9pZCkpY29t cGxldGlvbkJsb2NrCiB7Ci0gICAgdW5zaWduZWQgY2FsbGJhY2tJRCA9IFtISURFdmVudEdlbmVy YXRvciBuZXh0RXZlbnRDYWxsYmFja0lEXTsKLSAgICB2b2lkICheY29tcGxldGlvbkJsb2NrQ29w eSkoKSA9IEJsb2NrX2NvcHkoY29tcGxldGlvbkJsb2NrKTsKLSAgICBbX2V2ZW50Q2FsbGJhY2tz IHNldE9iamVjdDpjb21wbGV0aW9uQmxvY2tDb3B5IGZvcktleTpAKGNhbGxiYWNrSUQpXTsKKyAg ICBhdXRvIGNhbGxiYWNrSUQgPSBbSElERXZlbnRHZW5lcmF0b3IgbmV4dEV2ZW50Q2FsbGJhY2tJ RF07CisgICAgW19ldmVudENhbGxiYWNrcyBzZXRPYmplY3Q6QmxvY2tfY29weShjb21wbGV0aW9u QmxvY2spIGZvcktleTpAKGNhbGxiYWNrSUQpXTsKIAotICAgIHVpbnQ2NF90IG1hY2hUaW1lID0g bWFjaF9hYnNvbHV0ZV90aW1lKCk7Ci0gICAgUmV0YWluUHRyPElPSElERXZlbnRSZWY+IG1hcmtl ckV2ZW50ID0gYWRvcHRDRihJT0hJREV2ZW50Q3JlYXRlVmVuZG9yRGVmaW5lZEV2ZW50KGtDRkFs bG9jYXRvckRlZmF1bHQsCi0gICAgICAgIG1hY2hUaW1lLAorICAgIGF1dG8gbWFya2VyRXZlbnQg PSBhZG9wdENGKElPSElERXZlbnRDcmVhdGVWZW5kb3JEZWZpbmVkRXZlbnQoa0NGQWxsb2NhdG9y RGVmYXVsdCwKKyAgICAgICAgbWFjaF9hYnNvbHV0ZV90aW1lKCksCiAgICAgICAgIGtISURQYWdl X1ZlbmRvckRlZmluZWRTdGFydCArIDEwMCwKICAgICAgICAgMCwKICAgICAgICAgMSwKICAgICAg ICAgKHVpbnQ4X3QqKSZjYWxsYmFja0lELAotICAgICAgICBzaXplb2YodW5zaWduZWQpLAorICAg ICAgICBzaXplb2YoQ0ZJbmRleCksCiAgICAgICAgIGtJT0hJREV2ZW50T3B0aW9uTm9uZSkpOwog ICAgIAogICAgIGlmIChtYXJrZXJFdmVudCkgewotICAgICAgICBtYXJrZXJFdmVudC5nZXQoKTsK LSAgICAgICAgZGlzcGF0Y2hfYXN5bmMoZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUoKSwgXnsKLSAg ICAgICAgICAgIHVpbnQzMl90IGNvbnRleHRJRCA9IFtVSUFwcGxpY2F0aW9uIHNoYXJlZEFwcGxp Y2F0aW9uXS5rZXlXaW5kb3cuX2NvbnRleHRJZDsKKyAgICAgICAgZGlzcGF0Y2hfYXN5bmMoZGlz cGF0Y2hfZ2V0X21haW5fcXVldWUoKSwgW21hcmtlckV2ZW50ID0gV1RGTW92ZShtYXJrZXJFdmVu dCldIHsKKyAgICAgICAgICAgIGF1dG8gY29udGV4dElEID0gW1VJQXBwbGljYXRpb24gc2hhcmVk QXBwbGljYXRpb25dLmtleVdpbmRvdy5fY29udGV4dElkOwogICAgICAgICAgICAgQVNTRVJUKGNv bnRleHRJRCk7CiAgICAgICAgICAgICBCS1NISURFdmVudFNldERpZ2l0aXplckluZm8obWFya2Vy RXZlbnQuZ2V0KCksIGNvbnRleHRJRCwgZmFsc2UsIGZhbHNlLCBOVUxMLCAwLCAwKTsKICAgICAg ICAgICAgIFtbVUlBcHBsaWNhdGlvbiBzaGFyZWRBcHBsaWNhdGlvbl0gX2VucXVldWVISURFdmVu dDptYXJrZXJFdmVudC5nZXQoKV07Cg==