188283 2018-08-02 16:14:21 -0700 Regression(r234486): assertion hit in ~CallbackAggregator() 2018-08-02 17:24:22 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=188084 InRadar P2 Normal --- 1 cdumez cdumez achristensen commit-queue ggaren sihui_liu simon.fraser webkit-bug-importer oldest_to_newest 1447426 0 cdumez 2018-08-02 16:14:21 -0700 Regression(r234486): assertion hit in ~CallbackAggregator(): Thread 5 Crashed:: Dispatch queue: com.apple.CFNetwork.CookieServerEndpoint-queue-0x7f9c2500d300 0 com.apple.JavaScriptCore 0x000000011d1872d0 WTFCrash + 16 (Assertions.cpp:267) 1 com.apple.WebKit 0x0000000109cfb08b WTFCrashWithInfo(int, char const*, char const*, int) + 27 (Assertions.h:545) 2 com.apple.WebKit 0x0000000109dd4fcf WTF::CallbackAggregator::~CallbackAggregator() + 127 (CallbackAggregator.h:40) 3 com.apple.WebKit 0x0000000109dd4f45 WTF::CallbackAggregator::~CallbackAggregator() + 21 (CallbackAggregator.h:43) 4 com.apple.WebKit 0x0000000109dd4f17 WTF::ThreadSafeRefCounted<WTF::CallbackAggregator, (WTF::DestructionThread)0>::deref() const + 71 (ThreadSafeRefCounted.h:76) 5 com.apple.WebKit 0x000000010a12fe81 void WTF::derefIfNotNull<WTF::CallbackAggregator>(WTF::CallbackAggregator*) + 49 (RefPtr.h:46) 6 com.apple.WebKit 0x000000010a12fe49 WTF::RefPtr<WTF::CallbackAggregator, WTF::DumbPtrTraits<WTF::CallbackAggregator> >::~RefPtr() + 41 (RefPtr.h:70) 7 com.apple.WebKit 0x000000010a12e5a5 WTF::RefPtr<WTF::CallbackAggregator, WTF::DumbPtrTraits<WTF::CallbackAggregator> >::~RefPtr() + 21 (RefPtr.h:70) 8 com.apple.WebKit 0x000000010a1306a5 auto WebKit::NetworkProcess::platformSyncAllCookies(WTF::CompletionHandler<void ()>&&)::$_2::operator()<WebCore::NetworkStorageSession const>(WebCore::NetworkStorageSession const&) const::'lambda'()::~() + 21 (NetworkProcessCocoa.mm:223) 9 com.apple.WebKit 0x000000010a130625 auto WebKit::NetworkProcess::platformSyncAllCookies(WTF::CompletionHandler<void ()>&&)::$_2::operator()<WebCore::NetworkStorageSession const>(WebCore::NetworkStorageSession const&) const::'lambda'()::~() + 21 (NetworkProcessCocoa.mm:223) 10 com.apple.WebKit 0x000000010a130609 __destroy_helper_block_ + 25 (NetworkProcessCocoa.mm:223) 11 libsystem_blocks.dylib 0x00007fff76e5c988 _Block_release + 109 12 libsystem_blocks.dylib 0x00007fff76e5c988 _Block_release + 109 13 libsystem_blocks.dylib 0x00007fff76e5c988 _Block_release + 109 14 libsystem_blocks.dylib 0x00007fff76e5c988 _Block_release + 109 15 libdispatch.dylib 0x00007fff76dc3de3 _dispatch_client_callout + 8 16 libdispatch.dylib 0x00007fff76dca148 _dispatch_lane_serial_drain + 618 17 libdispatch.dylib 0x00007fff76dcac00 _dispatch_lane_invoke + 388 18 libdispatch.dylib 0x00007fff76dd30b3 _dispatch_workloop_worker_thread + 603 19 libsystem_pthread.dylib 0x00007fff770025b4 _pthread_wqthread + 409 20 libsystem_pthread.dylib 0x00007fff770023ad start_wqthread + 13 On trunk, CallbackAggregators need to be destroyed on the thread they were created on (since r234288). Unfortunately, the CFNetwork _saveCookies SPI is calling us back on a background queue, even though we are calling it on the main thread. 1447430 1 cdumez 2018-08-02 16:27:04 -0700 <rdar://problem/42851342> 1447435 2 346429 cdumez 2018-08-02 16:37:16 -0700 Created attachment 346429 Patch 1447463 3 346429 commit-queue 2018-08-02 17:24:20 -0700 Comment on attachment 346429 Patch Clearing flags on attachment: 346429 Committed r234529: <https://trac.webkit.org/changeset/234529> 1447464 4 commit-queue 2018-08-02 17:24:22 -0700 All reviewed patches have been landed. Closing bug. 346429 2018-08-02 16:37:16 -0700 2018-08-02 17:24:20 -0700 Patch bug-188283-20180802163716.patch text/plain 2958 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NTIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk4ZWZiZTZiZjQ0MTk2OTc5 MDEwZDBiZGEwYWRmOTZmMDI3ZmUzYjUuLmJjMDQ4YWJiZmMxODZjYmVlYWIyZDlmNmY1YTI2NmI1 ODE3NmE3ZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTgtMDgtMDIgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIyMzQ0ODYpOiBh c3NlcnRpb24gaGl0IGluIH5DYWxsYmFja0FnZ3JlZ2F0b3IoKQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4MjgzCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS80Mjg1MTM0Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBbTlNIVFRQQ29va2llU3RvcmFnZSBfc2F2ZUNvb2tpZXM6XSBTUEkgbWF5IGNhbGwg aXRzIGNvbXBsZXRpb24gYmxvY2sgb24gdGhlIGJhY2tncm91bmQgcXVldWUKKyAgICAgICAgc28g d2UgbmVlZCB0byBtYWtlIHN1cmUgd2UgZGlzcGF0Y2ggYmFjayB0byB0aGUgbWFpbiB0aHJlYWQg YmVmb3JlIGNhbGxpbmcgb3VyIGNvbXBsZXRpb24KKyAgICAgICAgaGFuZGxlci4KKworICAgICAg ICAqIE5ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtQcm9jZXNzQ29jb2EubW06CisgICAgICAg IChXZWJLaXQ6OnNhdmVDb29raWVzKToKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya1Byb2Nlc3M6 OnBsYXRmb3JtU3luY0FsbENvb2tpZXMpOgorCiAyMDE4LTA4LTAyICBBbGV4IENocmlzdGVuc2Vu ICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IHNvbWUgYnVpbGRzIGFm dGVyIHIyMzQ1MTYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29j b2EvTmV0d29ya1Byb2Nlc3NDb2NvYS5tbSBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mv Y29jb2EvTmV0d29ya1Byb2Nlc3NDb2NvYS5tbQppbmRleCA3NmJhZTExNjY4NzMwMmJkNmExNjll YmMxZWFiNDZiYmY2NjUyMDE4Li5iNjkzYmEyZDczN2ZkYTEyMDc4NzlhMWExOTU3ZDBkYTQ4N2Qw ODZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdv cmtQcm9jZXNzQ29jb2EubW0KKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2Nv YS9OZXR3b3JrUHJvY2Vzc0NvY29hLm1tCkBAIC0yMTIsNiArMjEyLDE5IEBAIHZvaWQgTmV0d29y a1Byb2Nlc3M6OnN5bmNBbGxDb29raWVzKCkKICAgICB9KTsKIH0KIAorI2lmIChQTEFURk9STShN QUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxNDAwKSB8fCAoUExB VEZPUk0oSU9TKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMjAwMDAp CitzdGF0aWMgdm9pZCBzYXZlQ29va2llcyhOU0hUVFBDb29raWVTdG9yYWdlICpjb29raWVTdG9y YWdlLCBDb21wbGV0aW9uSGFuZGxlcjx2b2lkKCk+JiYgY29tcGxldGlvbkhhbmRsZXIpCit7Cisg ICAgQVNTRVJUKFJ1bkxvb3A6OmlzTWFpbigpKTsKKyAgICBbY29va2llU3RvcmFnZSBfc2F2ZUNv b2tpZXM6QmxvY2tQdHI8dm9pZCgpPjo6ZnJvbUNhbGxhYmxlKFtjb21wbGV0aW9uSGFuZGxlciA9 IFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpXSgpIG11dGFibGUgeworICAgICAgICAvLyBDRk5l dHdvcmsgbWF5IGNhbGwgdGhlIGNvbXBsZXRpb24gYmxvY2sgb24gYSBiYWNrZ3JvdW5kIHF1ZXVl LCBzbyB3ZSBuZWVkIHRvIHJlZGlzcGF0Y2ggdG8gdGhlIG1haW4gdGhyZWFkLgorICAgICAgICBS dW5Mb29wOjptYWluKCkuZGlzcGF0Y2goW2NvbXBsZXRpb25IYW5kbGVyID0gV1RGTW92ZShjb21w bGV0aW9uSGFuZGxlcildKCkgbXV0YWJsZSB7CisgICAgICAgICAgICBjb21wbGV0aW9uSGFuZGxl cigpOworICAgICAgICB9KTsKKyAgICB9KS5nZXQoKV07Cit9CisjZW5kaWYKKwogdm9pZCBOZXR3 b3JrUHJvY2Vzczo6cGxhdGZvcm1TeW5jQWxsQ29va2llcyhDb21wbGV0aW9uSGFuZGxlcjx2b2lk KCk+JiYgY29tcGxldGlvbkhhbmRlcikgewogICAgIEFTU0VSVChoYXNQcm9jZXNzUHJpdmlsZWdl KFByb2Nlc3NQcml2aWxlZ2U6OkNhbkFjY2Vzc1Jhd0Nvb2tpZXMpKTsKICNwcmFnbWEgY2xhbmcg ZGlhZ25vc3RpYyBwdXNoCkBAIC0yMjAsNyArMjMzLDcgQEAgdm9pZCBOZXR3b3JrUHJvY2Vzczo6 cGxhdGZvcm1TeW5jQWxsQ29va2llcyhDb21wbGV0aW9uSGFuZGxlcjx2b2lkKCk+JiYgY29tcGxl dGkKICNpZiAoUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVE ID49IDEwMTQwMCkgfHwgKFBMQVRGT1JNKElPUykgJiYgX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5f UkVRVUlSRUQgPj0gMTIwMDAwKQogICAgIFJlZlB0cjxDYWxsYmFja0FnZ3JlZ2F0b3I+IGNhbGxi YWNrQWdncmVnYXRvciA9IENhbGxiYWNrQWdncmVnYXRvcjo6Y3JlYXRlKFdURk1vdmUoY29tcGxl dGlvbkhhbmRlcikpOwogICAgIFdlYkNvcmU6Ok5ldHdvcmtTdG9yYWdlU2Vzc2lvbjo6Zm9yRWFj aChbJl0gKGF1dG8mIG5ldHdvcmtTdG9yYWdlU2Vzc2lvbikgewotICAgICAgICBbbmV0d29ya1N0 b3JhZ2VTZXNzaW9uLm5zQ29va2llU3RvcmFnZSgpIF9zYXZlQ29va2llczpbY2FsbGJhY2tBZ2dy ZWdhdG9yXSB7IH1dOworICAgICAgICBzYXZlQ29va2llcyhuZXR3b3JrU3RvcmFnZVNlc3Npb24u bnNDb29raWVTdG9yYWdlKCksIFtjYWxsYmFja0FnZ3JlZ2F0b3JdIHsgfSk7CiAgICAgfSk7CiAj ZWxzZQogICAgIF9DRkhUVFBDb29raWVTdG9yYWdlRmx1c2hDb29raWVTdG9yZXMoKTsK