188255 2018-08-02 03:54:36 -0700 [Win][DLLLauncher] Remove --highDPI switch 2018-08-06 16:33:17 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii achristensen basuke bfulgham commit-queue don.olmstead lforschler pvollan webkit-bug-importer ysuzuki oldest_to_newest 1447218 0 fujii 2018-08-02 03:54:36 -0700 [WinCairo] All dump render tree tests are failing in high DPI https://github.com/WebKit/webkit/blob/cb5005335fba0182dad582825751beea625d2cd0/Tools/win/DLLLauncher/DLLLauncherMain.cpp#L173 shouldUseHighDPI should return false for DumpRenderTree. 1447219 1 fujii 2018-08-02 04:00:09 -0700 I uploaded the result of fast/css/001.htm. https://gist.github.com/fujii/748bdb9e2754152b95ecc0515f265a4b RenderView sizes are different. 1448073 2 fujii 2018-08-06 01:24:14 -0700 This code has been added in Bug 149417. But, Bug 158733 has made MiniBrowser always DPI aware. It became useless since the change. Bug 149417 – [Win] Use command-line argument to launch in regular or High DPI mode Bug 158733 – [Win] MiniBrowser is not DPI aware. 1448087 3 346618 fujii 2018-08-06 02:04:02 -0700 Created attachment 346618 Patch 1448094 4 346618 ysuzuki 2018-08-06 03:00:34 -0700 Comment on attachment 346618 Patch r=me 1448153 5 346618 commit-queue 2018-08-06 10:43:50 -0700 Comment on attachment 346618 Patch Clearing flags on attachment: 346618 Committed r234607: <https://trac.webkit.org/changeset/234607> 1448154 6 commit-queue 2018-08-06 10:43:51 -0700 All reviewed patches have been landed. Closing bug. 1448155 7 webkit-bug-importer 2018-08-06 10:44:17 -0700 <rdar://problem/42973487> 346618 2018-08-06 02:04:02 -0700 2018-08-06 10:43:50 -0700 Patch bug-188255-20180806180401.patch text/plain 3033 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NTg2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWYxMjg4N2ZkMWMxYmZhYmJhZDFhMTEyYTRjMTY3NmM0 YzdlMTI5Zi4uMjZjODcyNzJiZjI4OTIwMzYxYWZkZWFjZWY2ZGE4ODMwNWNjMTliNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDE4LTA4LTA2ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIFtXaW5dW0RMTExhdW5jaGVyXSBSZW1vdmUgLS1oaWdoRFBJIHN3aXRjaAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4MjU1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDE0OTQx NyBoYXMgYWRkZWQgYC0taGlnaERQSWAgc3dpdGNoIHRvIG1ha2UgTWluaUJyb3dzZXIgRFBJCisg ICAgICAgIGF3YXJlLiBCdXQsIEJ1ZyAxNTg3MzMgaGFzIG1hZGUgTWluaUJyb3dzZXIgYWx3YXlz IERQSSBhd2FyZS4gSXQKKyAgICAgICAgYmVjYW1lIHVzZWxlc3Mgc2luY2UgdGhlIGNoYW5nZS4g UmVtb3ZlIHRoZSBzd2l0Y2guCisKKyAgICAgICAgVGhpcyBjaGFuZ2UgZml4ZXMgdGhlIGlzc3Vl IGFsbCBkdW1wIHJlbmRlciB0cmVlIHRlc3RzIGFyZSBmYWlsaW5nCisgICAgICAgIGluIFdpbkNh aXJvIHBvcnQgaWYgaGlnaCBEUEkgZGlzcGxheSBpcyBjb25uZWN0ZWQuCisKKyAgICAgICAgKiBN aW5pQnJvd3Nlci93aW4vQ29tbW9uLmNwcDoKKyAgICAgICAgKHBhcnNlQ29tbWFuZExpbmUpOiBS ZW1vdmVkIGAtLWhpZ2hEUElgIHN3aXRjaC4KKyAgICAgICAgKiB3aW4vRExMTGF1bmNoZXIvRExM TGF1bmNoZXJNYWluLmNwcDoKKyAgICAgICAgKHdXaW5NYWluKTogRG8gbm90IGNhbGwgU2V0UHJv Y2Vzc0RQSUF3YXJlLgorICAgICAgICAoc2hvdWxkVXNlSGlnaERQSSk6IERlbGV0ZWQuCisKIDIw MTgtMDgtMDMgIEJlbiBSaWNoYXJkcyAgPGJlbnRvbl9yaWNoYXJkc0BhcHBsZS5jb20+CiAKICAg ICAgICAgV2Ugc2hvdWxkIGNhY2hlIHRoZSBjb21waWxlZCBzYW5kYm94IHByb2ZpbGUgaW4gYSBk YXRhIHZhdWx0CmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci93aW4vQ29tbW9uLmNwcCBi L1Rvb2xzL01pbmlCcm93c2VyL3dpbi9Db21tb24uY3BwCmluZGV4IDM1ODhmYzQzYjNmZjY5YjA1 NTlhY2UxOWFmZmFhNGM0MDE2MGM5OWIuLmFjMzhmMDFiNGJkODQ3NzA5ODEwMmY1ZmMzOGQ2ZWQy OTFjMzBjYTQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL3dpbi9Db21tb24uY3BwCisr KyBiL1Rvb2xzL01pbmlCcm93c2VyL3dpbi9Db21tb24uY3BwCkBAIC0xNzgsOCArMTc4LDYgQEAg Q29tbWFuZExpbmVPcHRpb25zIHBhcnNlQ29tbWFuZExpbmUoKQogICAgICAgICAgICAgb3B0aW9u cy51c2VGdWxsRGVza3RvcCA9IHRydWU7CiAgICAgICAgIGVsc2UgaWYgKCF3Y3NpY21wKGFyZ3Zb aV0sIEwiLS1wZXJmb3JtYW5jZSIpKQogICAgICAgICAgICAgb3B0aW9ucy5wYWdlTG9hZFRlc3Rp bmcgPSB0cnVlOwotICAgICAgICBlbHNlIGlmICghd2NzaWNtcChhcmd2W2ldLCBMIi0taGlnaERQ SSIpKQotICAgICAgICAgICAgY29udGludWU7IC8vIGlnbm9yZQogICAgICAgICBlbHNlIGlmICgh d2NzaWNtcChhcmd2W2ldLCBMIi0td2sxIikgfHwgIXdjc2ljbXAoYXJndltpXSwgTCItLWxlZ2Fj eSIpKQogICAgICAgICAgICAgb3B0aW9ucy53aW5kb3dUeXBlID0gTWFpbldpbmRvdzo6QnJvd3Nl cldpbmRvd1R5cGU6OldlYktpdExlZ2FjeTsKICNpZiBFTkFCTEUoV0VCS0lUKQpkaWZmIC0tZ2l0 IGEvVG9vbHMvd2luL0RMTExhdW5jaGVyL0RMTExhdW5jaGVyTWFpbi5jcHAgYi9Ub29scy93aW4v RExMTGF1bmNoZXIvRExMTGF1bmNoZXJNYWluLmNwcAppbmRleCBmY2YxYTg3MTlmOTI3ZGE2NmQw OThjMzU0ZmVhYjM3MzQzZGVhMTM1Li4xZDIyZGFhNGRlMDQwNDNjZWNlMTNmMTQwMTY2ODI1MGFi ZmE3OTMyIDEwMDY0NAotLS0gYS9Ub29scy93aW4vRExMTGF1bmNoZXIvRExMTGF1bmNoZXJNYWlu LmNwcAorKysgYi9Ub29scy93aW4vRExMTGF1bmNoZXIvRExMTGF1bmNoZXJNYWluLmNwcApAQCAt MTY3LDMzICsxNjcsMTIgQEAgc3RhdGljIHdzdHJpbmcgZ2V0TGFzdEVycm9yU3RyaW5nKEhSRVNV TFQgaHIpCiAgICAgcmV0dXJuIGVycm9yTWVzc2FnZTsKIH0KIAotc3RhdGljIGJvb2wgc2hvdWxk VXNlSGlnaERQSSgpCi17Ci0jaWZkZWYgV0lOX0NBSVJPCi0gICAgcmV0dXJuIHRydWU7Ci0jZWxz ZQotICAgIGludCBhcmdjID0gMDsKLSAgICBXQ0hBUioqIGFyZ3YgPSBDb21tYW5kTGluZVRvQXJn dlcoR2V0Q29tbWFuZExpbmVXKCksICZhcmdjKTsKLSAgICBmb3IgKGludCBpID0gMTsgaSA8IGFy Z2M7ICsraSkgewotICAgICAgICBpZiAoIXdjc2ljbXAoYXJndltpXSwgTCItLWhpZ2hEUEkiKSkK LSAgICAgICAgICAgIHJldHVybiB0cnVlOwotICAgIH0KLQotICAgIHJldHVybiBmYWxzZTsKLSNl bmRpZgotfQotCiAjaWYgVVNFX0NPTlNPTEVfRU5UUllfUE9JTlQKIGludCBtYWluKGludCBhcmdj LCBjb25zdCBjaGFyKiBhcmd2W10pCiAjZWxzZQogaW50IFdJTkFQSSB3V2luTWFpbihfSW5fIEhJ TlNUQU5DRSBoSW5zdGFuY2UsIF9Jbl9vcHRfIEhJTlNUQU5DRSBoUHJldkluc3RhbmNlLCBfSW5f IExQV1NUUiBscHN0ckNtZExpbmUsIF9Jbl8gaW50IG5DbWRTaG93KQogI2VuZGlmCiB7Ci0gICAg aWYgKHNob3VsZFVzZUhpZ2hEUEkoKSkgewotICAgICAgICBCT09MIGRpZEl0ID0gU2V0UHJvY2Vz c0RQSUF3YXJlKCk7Ci0gICAgICAgIF9BU1NFUlQoZGlkSXQpOwotICAgIH0KLQogI2lmZGVmIF9D UlREQkdfTUFQX0FMTE9DCiAgICAgX0NydFNldFJlcG9ydEZpbGUoX0NSVF9XQVJOLCBfQ1JUREJH X0ZJTEVfU1RERVJSKTsKICAgICBfQ3J0U2V0UmVwb3J0TW9kZShfQ1JUX1dBUk4sIF9DUlREQkdf TU9ERV9GSUxFKTsK