188202 2018-07-31 11:48:10 -0700 [Cocoa] Addressing post-review comments on r234158 2018-08-01 20:26:38 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=187936 InRadar P2 Normal --- 1 mmaxfield mmaxfield commit-queue lforschler oldest_to_newest 1446621 0 mmaxfield 2018-07-31 11:48:10 -0700 [Cocoa] Addressing post-review comments on r234158 1446622 1 346183 mmaxfield 2018-07-31 11:48:40 -0700 Created attachment 346183 Patch 1446789 2 346183 commit-queue 2018-07-31 19:29:30 -0700 Comment on attachment 346183 Patch Clearing flags on attachment: 346183 Committed r234444: <https://trac.webkit.org/changeset/234444> 1446790 3 commit-queue 2018-07-31 19:29:31 -0700 All reviewed patches have been landed. Closing bug. 1447134 4 webkit-bug-importer 2018-08-01 20:26:38 -0700 <rdar://problem/42840304> 346183 2018-07-31 11:48:40 -0700 2018-07-31 19:29:30 -0700 Patch bug-188202-20180731114840.patch text/plain 1898 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NDMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYThmYjE5MTIxOThiZmFi MGY0Y2Y2ZGQwNzJlMDNlMTgxMDQ3Y2RmYi4uODQ4NmFmMjlmMTNlZTllMDgxYmJhNzliMjk1YjEx NzQ3ZjM1OTY1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE4LTA3LTMxICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBB ZGRyZXNzaW5nIHBvc3QtcmV2aWV3IGNvbW1lbnRzIG9uIHIyMzQxNTgKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODIwMgorCisgICAgICAgIFJldmll d2VkIGJ5IERhcmluIEFkbGVyLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2Ev Rm9udENhY2hlQ29yZVRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udENhY2hlOjpsYXN0 UmVzb3J0RmFsbGJhY2tGb250KToKKwogMjAxOC0wNy0zMSAgWXVzdWtlIFN1enVraSAgPHV0YXRh bmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBDbGVhbiB1cCBUcmFuc2Zvcm1hdGlvbk1hdHJp eCBpbXBsZW1lbnRhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY29jb2EvRm9udENhY2hlQ29yZVRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY29jb2EvRm9udENhY2hlQ29yZVRleHQuY3BwCmluZGV4IDYzMDE0ZTI1YTE1 MWVlY2I3NmQ2ZTM0Y2U1MmRhZmU3YTdhZjMyMDguLmM0ODEwMjAzNmNiNzhiYTZjNTlkMDE5MTAx Zjk2YzIzNDQ5ZTQ3ZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2NvY29hL0ZvbnRDYWNoZUNvcmVUZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jb2NvYS9Gb250Q2FjaGVDb3JlVGV4dC5jcHAKQEAgLTE0ODQsMTEgKzE0 ODQsNiBAQCBSZWY8Rm9udD4gRm9udENhY2hlOjpsYXN0UmVzb3J0RmFsbGJhY2tGb250KGNvbnN0 IEZvbnREZXNjcmlwdGlvbiYgZm9udERlc2NyaXB0aQogICAgIGlmIChhdXRvIHJlc3VsdCA9IGZv bnRGb3JGYW1pbHkoZm9udERlc2NyaXB0aW9uLCBBdG9taWNTdHJpbmcoIlRpbWVzIiwgQXRvbWlj U3RyaW5nOjpDb25zdHJ1Y3RGcm9tTGl0ZXJhbCkpKQogICAgICAgICByZXR1cm4gKnJlc3VsdDsK IAotICAgIC8vIFRoZSBUaW1lcyBmYWxsYmFjayB3aWxsIGFsbW9zdCBhbHdheXMgd29yaywgYnV0 IGluIHRoZSBoaWdobHkgdW51c3VhbCBjYXNlIHdoZXJlCi0gICAgLy8gdGhlIHVzZXIgZG9lc24n dCBoYXZlIGl0LCB3ZSBmYWxsIGJhY2sgb24gTHVjaWRhIEdyYW5kZS4KLSAgICBpZiAoYXV0byBy ZXN1bHQgPSBmb250Rm9yRmFtaWx5KGZvbnREZXNjcmlwdGlvbiwgQXRvbWljU3RyaW5nKCJMdWNp ZGEgR3JhbmRlIiwgQXRvbWljU3RyaW5nOjpDb25zdHJ1Y3RGcm9tTGl0ZXJhbCksIG51bGxwdHIs IG51bGxwdHIsIHsgfSwgZmFsc2UpKQotICAgICAgICByZXR1cm4gKnJlc3VsdDsKLQogICAgIC8v IExhc3RSZXNvcnQgaXMgZ3VhcmFudGVlZCB0byBiZSBub24tbnVsbC4KICNpZiAoUExBVEZPUk0o SU9TKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMTAwMDApIHx8IChQ TEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMzAw KQogICAgIGF1dG8gZm9udERlc2NyaXB0b3IgPSBhZG9wdENGKENURm9udERlc2NyaXB0b3JDcmVh dGVMYXN0UmVzb3J0KCkpOwo=