188115 2018-07-27 12:33:03 -0700 [GTK] API test /webkit/WebKitWebInspectorServer/test-page-list is flaky 2020-07-15 01:52:39 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Mac Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro webkit-unassigned aperez bugs-noreply cgarcia mcatanzaro oldest_to_newest 1445809 0 mcatanzaro 2018-07-27 12:33:03 -0700 API test /webkit/WebKitWebInspectorServer/test-page-list is flaky: TEST: ./Tools/glib/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestInspectorServer... /webkit/WebKitWebInspectorServer/test-page-list: FAIL ERROR:/home/slave/webkitgtk/gtk-linux-64-release/build/Tools/TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:150:void testInspectorServerPageList(InspectorServerTest*, gconstpointer): assertion failed (valueString.get() == "http://127.0.0.1:2999/"): ("about:blank" == "http://127.0.0.1:2999/") 1671345 1 cgarcia 2020-07-14 06:05:31 -0700 The test is still trying to connect to DBus, but we no longer use DBus. Let's fix the test and see if its still flaky. 1671346 2 404228 cgarcia 2020-07-14 06:08:24 -0700 Created attachment 404228 Patch 1671690 3 cgarcia 2020-07-15 01:52:39 -0700 Committed r264390: <https://trac.webkit.org/changeset/264390> 404228 2020-07-14 06:08:24 -0700 2020-07-14 09:24:55 -0700 Patch wkgtk-remote-inspector-test.diff text/plain 4817 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjMGIz MTgzODRlZjAuLmEzNTFmZDRiZTVkNiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA3LTE0ICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBBUEkgdGVz dCAvd2Via2l0L1dlYktpdFdlYkluc3BlY3RvclNlcnZlci90ZXN0LXBhZ2UtbGlzdCBpcyBmbGFr eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4MTE1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3RvcCB1 c2luZyBEQnVzIHRvIGNvbm5lY3QgdG8gdGhlIHJlbW90ZSBpbnNwZWN0b3IgYW5kIHJlbG9hZCB0 aGUgcGFnZSB1bnRpbCB3ZSBzZWUgdGhlIGluc3BlY3RhYmxlIHRhcmdldC4KKworICAgICAgICAq IFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R3RrL1Rlc3RJbnNwZWN0b3JTZXJ2ZXIuY3BwOgor ICAgICAgICAoY29ubmVjdFRvSW5zcGVjdG9yU2VydmVyKToKKyAgICAgICAgKiBUZXN0V2ViS2l0 QVBJL2dsaWIvVGVzdEV4cGVjdGF0aW9ucy5qc29uOgorCiAyMDIwLTA3LTEzICBBYWthc2ggSmFp biAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgRVdTIHF1ZXVlcyBmb3Ig dHZPUyBhbmQgd2F0Y2hPUyBidWlsZGVycyAoZm9sbG93LXVwIGZpeCkKZGlmZiAtLWdpdCBhL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R3RrL1Rlc3RJbnNwZWN0b3JTZXJ2ZXIuY3Bw IGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHdGsvVGVzdEluc3BlY3RvclNlcnZl ci5jcHAKaW5kZXggYmMyNjE0M2UxNTc0Li5mOWE1ZTI1OTAzZmYgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R3RrL1Rlc3RJbnNwZWN0b3JTZXJ2ZXIuY3BwCisr KyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R3RrL1Rlc3RJbnNwZWN0b3JTZXJ2 ZXIuY3BwCkBAIC01MSwyNSArNTEsMjUgQEAgc3RhdGljIHZvaWQgc2lnQWJvcnRIYW5kbGVyKGlu dCBzaWdOdW0pCiAKIHN0YXRpYyB2b2lkIGNvbm5lY3RUb0luc3BlY3RvclNlcnZlcihHTWFpbkxv b3AqIG1haW5Mb29wKQogewotICAgIGdfZGJ1c19jb25uZWN0aW9uX25ld19mb3JfYWRkcmVzcygi dGNwOmhvc3Q9MTI3LjAuMC4xLHBvcnQ9Mjk5OSIsIEdfREJVU19DT05ORUNUSU9OX0ZMQUdTX0FV VEhFTlRJQ0FUSU9OX0NMSUVOVCwgbnVsbHB0ciwgbnVsbHB0ciwKLSAgICAgICAgW10oR09iamVj dCogLCBHQXN5bmNSZXN1bHQqIHJlc3VsdCwgZ3BvaW50ZXIgdXNlckRhdGEpIHsKLSAgICAgICAg ICAgIGF1dG8qIG1haW5Mb29wID0gc3RhdGljX2Nhc3Q8R01haW5Mb29wKj4odXNlckRhdGEpOwot ICAgICAgICAgICAgR1VuaXF1ZU91dFB0cjxHRXJyb3I+IGVycm9yOwotICAgICAgICAgICAgR1Jl ZlB0cjxHREJ1c0Nvbm5lY3Rpb24+IGNvbm5lY3Rpb24gPSBhZG9wdEdSZWYoZ19kYnVzX2Nvbm5l Y3Rpb25fbmV3X2Zvcl9hZGRyZXNzX2ZpbmlzaChyZXN1bHQsICZlcnJvci5vdXRQdHIoKSkpOwot ICAgICAgICAgICAgaWYgKCFjb25uZWN0aW9uKSB7Ci0gICAgICAgICAgICAgICAgaWYgKGdfZXJy b3JfbWF0Y2hlcyhlcnJvci5nZXQoKSwgR19JT19FUlJPUiwgR19JT19FUlJPUl9DT05ORUNUSU9O X1JFRlVTRUQpKSB7Ci0gICAgICAgICAgICAgICAgICAgIGdfdGltZW91dF9hZGQoMTAwLCBbXShn cG9pbnRlciB1c2VyRGF0YSkgewotICAgICAgICAgICAgICAgICAgICAgICAgY29ubmVjdFRvSW5z cGVjdG9yU2VydmVyKHN0YXRpY19jYXN0PEdNYWluTG9vcCo+KHVzZXJEYXRhKSk7Ci0gICAgICAg ICAgICAgICAgICAgICAgICByZXR1cm4gR19TT1VSQ0VfUkVNT1ZFOwotICAgICAgICAgICAgICAg ICAgICB9LCB1c2VyRGF0YSk7Ci0gICAgICAgICAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAg ICAgICAgICB9Ci0KLSAgICAgICAgICAgICAgICBnX3ByaW50ZXJyKCJGYWlsZWQgdG8gY29ubmVj dCB0byBpbnNwZWN0b3Igc2VydmVyIik7Ci0gICAgICAgICAgICAgICAgZ19hc3NlcnRfbm90X3Jl YWNoZWQoKTsKKyAgICBHUmVmUHRyPEdTb2NrZXRDbGllbnQ+IHNvY2tldENsaWVudCA9IGFkb3B0 R1JlZihnX3NvY2tldF9jbGllbnRfbmV3KCkpOworICAgIGdfc29ja2V0X2NsaWVudF9jb25uZWN0 X3RvX2hvc3RfYXN5bmMoc29ja2V0Q2xpZW50LmdldCgpLCIxMjcuMC4wLjE6Mjk5OSIsIDAsIG51 bGxwdHIsIFtdKEdPYmplY3QqIGNsaWVudCwgR0FzeW5jUmVzdWx0KiByZXN1bHQsIGdwb2ludGVy IHVzZXJEYXRhKSB7CisgICAgICAgIGF1dG8qIG1haW5Mb29wID0gc3RhdGljX2Nhc3Q8R01haW5M b29wKj4odXNlckRhdGEpOworICAgICAgICBHVW5pcXVlT3V0UHRyPEdFcnJvcj4gZXJyb3I7Cisg ICAgICAgIEdSZWZQdHI8R1NvY2tldENvbm5lY3Rpb24+IGNvbm5lY3Rpb24gPSBhZG9wdEdSZWYo Z19zb2NrZXRfY2xpZW50X2Nvbm5lY3RfdG9faG9zdF9maW5pc2goR19TT0NLRVRfQ0xJRU5UKGNs aWVudCksIHJlc3VsdCwgJmVycm9yLm91dFB0cigpKSk7CisgICAgICAgIGlmICghY29ubmVjdGlv bikgeworICAgICAgICAgICAgaWYgKGdfZXJyb3JfbWF0Y2hlcyhlcnJvci5nZXQoKSwgR19JT19F UlJPUiwgR19JT19FUlJPUl9DT05ORUNUSU9OX1JFRlVTRUQpKSB7CisgICAgICAgICAgICAgICAg Z190aW1lb3V0X2FkZCgxMDAsIFtdKGdwb2ludGVyIHVzZXJEYXRhKSB7CisgICAgICAgICAgICAg ICAgICAgIGNvbm5lY3RUb0luc3BlY3RvclNlcnZlcihzdGF0aWNfY2FzdDxHTWFpbkxvb3AqPih1 c2VyRGF0YSkpOworICAgICAgICAgICAgICAgICAgICByZXR1cm4gR19TT1VSQ0VfUkVNT1ZFOwor ICAgICAgICAgICAgICAgIH0sIHVzZXJEYXRhKTsKKyAgICAgICAgICAgICAgICByZXR1cm47CiAg ICAgICAgICAgICB9Ci0gICAgICAgICAgICBnU2VydmVySXNSZWFkeSA9IHRydWU7Ci0gICAgICAg ICAgICBnX21haW5fbG9vcF9xdWl0KG1haW5Mb29wKTsKKworICAgICAgICAgICAgZ19wcmludGVy cigiRmFpbGVkIHRvIGNvbm5lY3QgdG8gaW5zcGVjdG9yIHNlcnZlciIpOworICAgICAgICAgICAg Z19hc3NlcnRfbm90X3JlYWNoZWQoKTsKKyAgICAgICAgfQorICAgICAgICBnU2VydmVySXNSZWFk eSA9IHRydWU7CisgICAgICAgIGdfbWFpbl9sb29wX3F1aXQobWFpbkxvb3ApOwogICAgIH0sIG1h aW5Mb29wKTsKIH0KIApAQCAtMTE4LDkgKzExOCwxMyBAQCBwdWJsaWM6CiAgICAgICAgICAgICBz aXplX3QgbWFpblJlc291cmNlRGF0YVNpemUgPSAwOwogICAgICAgICAgICAgY29uc3QgY2hhciog bWFpblJlc291cmNlRGF0YSA9IHRoaXMtPm1haW5SZXNvdXJjZURhdGEobWFpblJlc291cmNlRGF0 YVNpemUpOwogICAgICAgICAgICAgZ19hc3NlcnRfbm9ubnVsbChtYWluUmVzb3VyY2VEYXRhKTsK LSAgICAgICAgICAgIGlmIChnX3N0cnJzdHJfbGVuKG1haW5SZXNvdXJjZURhdGEsIG1haW5SZXNv dXJjZURhdGFTaXplLCAiTm8gdGFyZ2V0cyBmb3VuZCIpKQotICAgICAgICAgICAgICAgIHdhaXQo MC4xKTsKLSAgICAgICAgICAgIGVsc2UgaWYgKGdfc3RycnN0cl9sZW4obWFpblJlc291cmNlRGF0 YSwgbWFpblJlc291cmNlRGF0YVNpemUsICJJbnNwZWN0YWJsZSB0YXJnZXRzIikpCisgICAgICAg ICAgICBpZiAoZ19zdHJyc3RyX2xlbihtYWluUmVzb3VyY2VEYXRhLCBtYWluUmVzb3VyY2VEYXRh U2l6ZSwgIk5vIHRhcmdldHMgZm91bmQiKSkgeworICAgICAgICAgICAgICAgIHdlYmtpdF93ZWJf dmlld19yZWxvYWQobV93ZWJWaWV3KTsKKyAgICAgICAgICAgICAgICB3YWl0VW50aWxMb2FkRmlu aXNoZWQoKTsKKyAgICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgICAgIH0KKworICAg ICAgICAgICAgaWYgKGdfc3RycnN0cl9sZW4obWFpblJlc291cmNlRGF0YSwgbWFpblJlc291cmNl RGF0YVNpemUsICJJbnNwZWN0YWJsZSB0YXJnZXRzIikpCiAgICAgICAgICAgICAgICAgcmV0dXJu IHRydWU7CiAgICAgICAgIH0KIApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9nbGli L1Rlc3RFeHBlY3RhdGlvbnMuanNvbiBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvZ2xpYi9UZXN0RXhw ZWN0YXRpb25zLmpzb24KaW5kZXggMjU2YWU4Yjk2ZjBiLi4yZWJiNWQyZjg4ZWYgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvZ2xpYi9UZXN0RXhwZWN0YXRpb25zLmpzb24KKysrIGIv VG9vbHMvVGVzdFdlYktpdEFQSS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMuanNvbgpAQCAtODYsMTIg Kzg2LDcgQEAKICAgICAgICAgfQogICAgIH0sCiAgICAgIlRlc3RJbnNwZWN0b3JTZXJ2ZXIiOiB7 Ci0gICAgICAgICJleHBlY3RlZCI6IHsiYWxsIjogeyJzbG93IjogdHJ1ZX19LAotICAgICAgICAi c3VidGVzdHMiOiB7Ci0gICAgICAgICAgICAiL3dlYmtpdC9XZWJLaXRXZWJJbnNwZWN0b3JTZXJ2 ZXIvdGVzdC1wYWdlLWxpc3QiOiB7Ci0gICAgICAgICAgICAgICAgImV4cGVjdGVkIjogeyJhbGwi OiB7InN0YXR1cyI6IFsiRkFJTCIsICJQQVNTIl0sICJidWciOiAid2Via2l0Lm9yZy9iLzE4ODEx NSJ9fQotICAgICAgICAgICAgfQotICAgICAgICB9CisgICAgICAgICJleHBlY3RlZCI6IHsiYWxs IjogeyJzbG93IjogdHJ1ZX19CiAgICAgfSwKICAgICAiVGVzdFdlYktpdEZhdmljb25EYXRhYmFz ZSI6IHsKICAgICAgICAgInN1YnRlc3RzIjogewo=