188040 2018-07-26 01:59:13 -0700 REGRESSION(r234248) [Win] testapi.c: nonstandard extension used: non-constant aggregate initializer 2018-07-26 02:32:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1445353 0 fujii 2018-07-26 01:59:13 -0700 REGRESSION(r234248) [Win] testapi.c: nonstandard extension used: non-constant aggregate initializer Since https://trac.webkit.org/changeset/234248/ https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/10869 C:\cygwin\home\buildbot\slave\win-release\build\Source\JavaScriptCore\API\tests\testapi.c(1209): error C2220: warning treated as error - no 'object' file generated [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\JavaScriptCore\shell\testapiLib.vcxproj] C:\cygwin\home\buildbot\slave\win-release\build\Source\JavaScriptCore\API\tests\testapi.c(1209): warning C4090: 'function': different 'const' qualifiers [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\JavaScriptCore\shell\testapiLib.vcxproj] C:\cygwin\home\buildbot\slave\win-release\build\Source\JavaScriptCore\API\tests\testapi.c(1801): warning C4204: nonstandard extension used: non-constant aggregate initializer [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\JavaScriptCore\shell\testapiLib.vcxproj] C:\cygwin\home\buildbot\slave\win-release\build\Source\JavaScriptCore\API\tests\testapi.c(1805): warning C4204: nonstandard extension used: non-constant aggregate initializer [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\JavaScriptCore\shell\testapiLib.vcxproj] C:\cygwin\home\buildbot\slave\win-release\build\Source\JavaScriptCore\API\tests\testapi.c(1850): warning C4204: nonstandard extension used: non-constant aggregate initializer [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\JavaScriptCore\shell\testapiLib.vcxproj] C:\cygwin\home\buildbot\slave\win-release\build\Source\JavaScriptCore\API\tests\testapi.c(1865): warning C4204: nonstandard extension used: non-constant aggregate initializer [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\JavaScriptCore\shell\testapiLib.vcxproj] C:\cygwin\home\buildbot\slave\win-release\build\Source\JavaScriptCore\API\tests\testapi.c(1871): warning C4204: nonstandard extension used: non-constant aggregate initializer [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\JavaScriptCore\shell\testapiLib.vcxproj] C:\cygwin\home\buildbot\slave\win-release\build\Source\JavaScriptCore\API\tests\testapi.c(1878): warning C4204: nonstandard extension used: non-constant aggregate initializer [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\JavaScriptCore\shell\testapiLib.vcxproj] 1445357 1 fujii 2018-07-26 02:03:14 -0700 AppleWin port is using /WX. > # Warnings as errors (ignore narrowing conversions) > add_compile_options(/WX /Wv:18) 1445358 2 fujii 2018-07-26 02:14:02 -0700 > testapi.c(1209): warning C4090: 'function': different 'const' qualifiers Accoring to the following page, this is a bug of MSVC. Why does Visual C++ warn on implicit cast from const void ** to void * in C, but not in C++? - Stack Overflow https://stackoverflow.com/questions/10403713/why-does-visual-c-warn-on-implicit-cast-from-const-void-to-void-in-c-but 1445359 3 345836 fujii 2018-07-26 02:27:57 -0700 Created attachment 345836 Patch 1445360 4 fujii 2018-07-26 02:31:55 -0700 Committed r234252: <https://trac.webkit.org/changeset/234252> 1445361 5 webkit-bug-importer 2018-07-26 02:32:18 -0700 <rdar://problem/42617455> 345836 2018-07-26 02:27:57 -0700 2018-07-26 02:27:57 -0700 Patch bug-188040-20180726182756.patch text/plain 1794 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0MjUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw MTIzYzAxZGZlMWQ3NjQ1ODExNjhhY2Y3NTRkNmUzYzk2YjkwOTdlLi40YTI2OWEwMDIzMzI5MTE5 NzY3NWMzZWIzNmJhMjVmMzI5NzA0MjM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOC0wNy0yNiAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBz b255LmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyMzQyNDgpIFtXaW5dIHRlc3RhcGkuYzog bm9uc3RhbmRhcmQgZXh0ZW5zaW9uIHVzZWQ6IG5vbi1jb25zdGFudCBhZ2dyZWdhdGUgaW5pdGlh bGl6ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4 ODA0MAorCisgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4IGZvciBBcHBsZVdpbiBwb3J0Lgor CisgICAgICAgICogQVBJL3Rlc3RzL3Rlc3RhcGkuYzogRGlzYWJsZWQgd2FybmluZyBDNDIwNC4K KyAgICAgICAgKHRlc3RNYXJraW5nQ29uc3RyYWludHNBbmRIZWFwRmluYWxpemVycyk6IEFkZGVk IGFuIGV4cGxpY2l0IHZvaWQqIGNhc3QgZm9yIHdlYWtSZWZzLgorCiAyMDE4LTA3LTI2ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIFtKU0MgQVBJ XSBXZSBzaG91bGQgc3VwcG9ydCB0aGUgc3ltYm9sIHR5cGUgaW4gb3VyIEMvT2JqLUMgQVBJCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGkuYyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5jCmluZGV4IDVlZDllZDg1NWM4 MTlhNjhhYzRjYTRiYzZkNTBmMzQ1ZDJiYzVkNzMuLjNmYzg2MTIxOWEzMDg0NWFhOGJlODY0NDYw NThhZmIzZjYyMDdhZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVz dHMvdGVzdGFwaS5jCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvdGVzdGFw aS5jCkBAIC02Miw2ICs2MiwxMCBAQAogI2luY2x1ZGUgIlBpbmdQb25nU3RhY2tPdmVyZmxvd1Rl c3QuaCIKICNpbmNsdWRlICJUeXBlZEFycmF5Q1Rlc3QuaCIKIAorI2lmIENPTVBJTEVSKE1TVkMp CisjcHJhZ21hIHdhcm5pbmcoZGlzYWJsZTo0MjA0KQorI2VuZGlmCisKICNpZiBKU0NfT0JKQ19B UElfRU5BQkxFRAogdm9pZCB0ZXN0T2JqZWN0aXZlQ0FQSSh2b2lkKTsKICNlbmRpZgpAQCAtMTIw Niw3ICsxMjEwLDcgQEAgc3RhdGljIHZvaWQgdGVzdE1hcmtpbmdDb25zdHJhaW50c0FuZEhlYXBG aW5hbGl6ZXJzKHZvaWQpCiAKICAgICB3ZWFrUmVmcyA9IChKU1dlYWtSZWYqKWNhbGxvYyhudW1X ZWFrUmVmcywgc2l6ZW9mKEpTV2Vha1JlZikpOwogCi0gICAgSlNDb250ZXh0R3JvdXBBZGRNYXJr aW5nQ29uc3RyYWludChncm91cCwgbWFya2luZ0NvbnN0cmFpbnQsIHdlYWtSZWZzKTsKKyAgICBK U0NvbnRleHRHcm91cEFkZE1hcmtpbmdDb25zdHJhaW50KGdyb3VwLCBtYXJraW5nQ29uc3RyYWlu dCwgKHZvaWQqKXdlYWtSZWZzKTsKICAgICBKU0NvbnRleHRHcm91cEFkZEhlYXBGaW5hbGl6ZXIo Z3JvdXAsIGhlYXBGaW5hbGl6ZXIsICh2b2lkKikodWludHB0cl90KTQyKTsKICAgICAKICAgICBm b3IgKGkgPSBudW1XZWFrUmVmczsgaS0tOykK