188016 2018-07-25 13:06:38 -0700 [ews-build] Add build step UploadBuiltProduct 2018-07-25 17:24:24 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=188014 https://bugs.webkit.org/show_bug.cgi?id=188031 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap ews-watchlist lforschler webkit-bug-importer oldest_to_newest 1445127 0 aakash_jain 2018-07-25 13:06:38 -0700 Builders on OpenSource EWS buildbot should archive the built product and upload the archive to the server, so that the testers can download the archive and run the tests. This would also help in re-using the archives for various kind of testers (WK1, WK2 etc.), being more efficient and speed-up the overall system. For that, we should add UploadBuiltProduct build step. 1445157 1 345782 aakash_jain 2018-07-25 13:57:32 -0700 Created attachment 345782 Proposed patch Sample run: http://ews-build.webkit-uat.org/#/builders/2/builds/16 1445158 2 ews-watchlist 2018-07-25 14:00:19 -0700 Attachment 345782 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:28: No name 'remotetransfer' in module 'buildbot.process' [pylint/E0611] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:785: [TestUploadBuiltProduct.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:785: [TestUploadBuiltProduct.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 3 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1445206 3 aakash_jain 2018-07-25 16:17:01 -0700 Committed r234218: <https://trac.webkit.org/changeset/234218> 1445209 4 webkit-bug-importer 2018-07-25 16:22:28 -0700 <rdar://problem/42602838> 345782 2018-07-25 13:57:32 -0700 2018-07-25 15:39:30 -0700 Proposed patch ews_UploadBuiltProduct.patch text/plain 4759 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzNDIxMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE4LTA3LTI1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBBZGQgYnVpbGQgc3RlcCBVcGxvYWRCdWlsdFByb2R1 Y3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODAx NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVp bGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5OgorICAgICAgICAoVXBsb2FkQnVpbHRQ cm9kdWN0KTogQWRkZWQgYnVpbGQgc3RlcCBVcGxvYWRCdWlsdFByb2R1Y3QuCisgICAgICAgICog QnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5OiBBZGRlZCB1bml0 LXRlc3QuCisKIDIwMTgtMDctMjUgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAog ICAgICAgICBuYXZpZ2F0b3IudXNlckFnZW50IG1heSByZXR1cm4gb3V0ZGF0ZWQgdmFsdWUgYWZ0 ZXIgd2ViVmlldy5jdXN0b21Vc2VyQWdlbnQgaXMgc2V0CkluZGV4OiBUb29scy9CdWlsZFNsYXZl U3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CShyZXZpc2lvbiAyMzQyMTIpCisrKyBUb29scy9C dWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTIy LDcgKzIyLDcgQEAKIAogZnJvbSBidWlsZGJvdC5wcm9jZXNzIGltcG9ydCBidWlsZHN0ZXAsIHBy b3BlcnRpZXMKIGZyb20gYnVpbGRib3QucHJvY2Vzcy5yZXN1bHRzIGltcG9ydCBSZXN1bHRzLCBT VUNDRVNTLCBGQUlMVVJFLCBXQVJOSU5HUywgU0tJUFBFRCwgRVhDRVBUSU9OLCBSRVRSWQotZnJv bSBidWlsZGJvdC5zdGVwcyBpbXBvcnQgc2hlbGwKK2Zyb20gYnVpbGRib3Quc3RlcHMgaW1wb3J0 IHNoZWxsLCB0cmFuc2ZlcgogZnJvbSBidWlsZGJvdC5zdGVwcy5zb3VyY2UgaW1wb3J0IHN2bgog ZnJvbSB0d2lzdGVkLmludGVybmV0IGltcG9ydCBkZWZlcgogCkBAIC0yODQsMyArMjg0LDE3IEBA IGNsYXNzIFJ1bldlYktpdFRlc3RzKHNoZWxsLlRlc3QpOgogICAgICAgICBpZiBhZGRpdGlvbmFs QXJndW1lbnRzOgogICAgICAgICAgICAgc2VsZi5zZXRDb21tYW5kKHNlbGYuY29tbWFuZCArIGFk ZGl0aW9uYWxBcmd1bWVudHMpCiAgICAgICAgIHJldHVybiBzaGVsbC5UZXN0LnN0YXJ0KHNlbGYp CisKKworY2xhc3MgVXBsb2FkQnVpbHRQcm9kdWN0KHRyYW5zZmVyLkZpbGVVcGxvYWQpOgorICAg IG5hbWUgPSAndXBsb2FkLWJ1aWx0LXByb2R1Y3QnCisgICAgd29ya2Vyc3JjID0gV2l0aFByb3Bl cnRpZXMoJ1dlYktpdEJ1aWxkLyUoY29uZmlndXJhdGlvbilzLnppcCcpCisgICAgbWFzdGVyZGVz dCA9IFdpdGhQcm9wZXJ0aWVzKCdwdWJsaWNfaHRtbC9hcmNoaXZlcy8lKGZ1bGxQbGF0Zm9ybSlz LSUoYXJjaGl0ZWN0dXJlKXMtJShjb25maWd1cmF0aW9uKXMvJShld3NwYXRjaGlkKXMuemlwJykK KyAgICBoYWx0T25GYWlsdXJlID0gVHJ1ZQorCisgICAgZGVmIF9faW5pdF9fKHNlbGYsICoqa3dh cmdzKToKKyAgICAgICAga3dhcmdzWyd3b3JrZXJzcmMnXSA9IHNlbGYud29ya2Vyc3JjCisgICAg ICAgIGt3YXJnc1snbWFzdGVyZGVzdCddID0gc2VsZi5tYXN0ZXJkZXN0CisgICAgICAgIGt3YXJn c1snbW9kZSddID0gMDY0NAorICAgICAgICBrd2FyZ3NbJ2Jsb2Nrc2l6ZSddID0gMTAyNCAqIDI1 NgorICAgICAgICB0cmFuc2Zlci5GaWxlVXBsb2FkLl9faW5pdF9fKHNlbGYsICoqa3dhcmdzKQpJ bmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191 bml0dGVzdC5weQkocmV2aXNpb24gMjM0MjEyKQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv ZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yNSw4ICsyNSw5 IEBAIGltcG9ydCBvcwogaW1wb3J0IHNodXRpbAogaW1wb3J0IHRlbXBmaWxlCiAKK2Zyb20gYnVp bGRib3QucHJvY2VzcyBpbXBvcnQgcmVtb3RldHJhbnNmZXIKIGZyb20gYnVpbGRib3QucHJvY2Vz cy5yZXN1bHRzIGltcG9ydCBSZXN1bHRzLCBTVUNDRVNTLCBGQUlMVVJFLCBXQVJOSU5HUywgU0tJ UFBFRCwgRVhDRVBUSU9OLCBSRVRSWQotZnJvbSBidWlsZGJvdC50ZXN0LmZha2UucmVtb3RlY29t bWFuZCBpbXBvcnQgRXhwZWN0U2hlbGwKK2Zyb20gYnVpbGRib3QudGVzdC5mYWtlLnJlbW90ZWNv bW1hbmQgaW1wb3J0IEV4cGVjdCwgRXhwZWN0UmVtb3RlUmVmLCBFeHBlY3RTaGVsbAogZnJvbSBi dWlsZGJvdC50ZXN0LnV0aWwuc3RlcHMgaW1wb3J0IEJ1aWxkU3RlcE1peGluCiBmcm9tIHR3aXN0 ZWQuaW50ZXJuZXQgaW1wb3J0IGVycm9yLCByZWFjdG9yCiBmcm9tIHR3aXN0ZWQucHl0aG9uIGlt cG9ydCBmYWlsdXJlLCBsb2cKQEAgLTEzNSw2ICsxMzYsMTYgQEAgY2xhc3MgQnVpbGRTdGVwTWl4 aW5BZGRpdGlvbnMoQnVpbGRTdGVwTQogICAgICAgICByZXR1cm4gZGVmZXJyZWRfcmVzdWx0CiAK IAorZGVmIHVwbG9hZEZpbGVXaXRoQ29udGVudHNPZlN0cmluZyhzdHJpbmcsIHRpbWVzdGFtcD1O b25lKToKKyAgICBkZWYgYmVoYXZpb3IoY29tbWFuZCk6CisgICAgICAgIHdyaXRlciA9IGNvbW1h bmQuYXJnc1snd3JpdGVyJ10KKyAgICAgICAgd3JpdGVyLnJlbW90ZV93cml0ZShzdHJpbmcgKyAn XG4nKQorICAgICAgICB3cml0ZXIucmVtb3RlX2Nsb3NlKCkKKyAgICAgICAgaWYgdGltZXN0YW1w OgorICAgICAgICAgICAgd3JpdGVyLnJlbW90ZV91dGltZSh0aW1lc3RhbXApCisgICAgcmV0dXJu IGJlaGF2aW9yCisKKwogY2xhc3MgVGVzdENoZWNrU3R5bGUoQnVpbGRTdGVwTWl4aW5BZGRpdGlv bnMsIHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICBkZWYgc2V0VXAoc2VsZik6CiAgICAgICAgIHNl bGYubG9uZ01lc3NhZ2UgPSBUcnVlCkBAIC03NDUsNSArNzU2LDM1IEBAIGNsYXNzIFRlc3RSdW5X ZWJLaXRUZXN0cyhCdWlsZFN0ZXBNaXhpbkEKICAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgp CiAKIAorY2xhc3MgVGVzdFVwbG9hZEJ1aWx0UHJvZHVjdChCdWlsZFN0ZXBNaXhpbkFkZGl0aW9u cywgdW5pdHRlc3QuVGVzdENhc2UpOgorICAgIGRlZiBzZXRVcChzZWxmKToKKyAgICAgICAgc2Vs Zi5sb25nTWVzc2FnZSA9IFRydWUKKyAgICAgICAgcmV0dXJuIHNlbGYuc2V0VXBCdWlsZFN0ZXAo KQorCisgICAgZGVmIHRlYXJEb3duKHNlbGYpOgorICAgICAgICByZXR1cm4gc2VsZi50ZWFyRG93 bkJ1aWxkU3RlcCgpCisKKyAgICBkZWYgdGVzdF9zdWNjZXNzKHNlbGYpOgorICAgICAgICBzZWxm LnNldHVwU3RlcChVcGxvYWRCdWlsdFByb2R1Y3QoKSkKKyAgICAgICAgc2VsZi5zZXRQcm9wZXJ0 eSgnZnVsbFBsYXRmb3JtJywgJ21hYy1zaWVycmEnKQorICAgICAgICBzZWxmLnNldFByb3BlcnR5 KCdjb25maWd1cmF0aW9uJywgJ3JlbGVhc2UnKQorICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdh cmNoaXRlY3R1cmUnLCAneDg2XzY0JykKKyAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnZXdzcGF0 Y2hpZCcsICcxMjM0JykKKyAgICAgICAgc2VsZi5leHBlY3RIaWRkZW4oRmFsc2UpCisgICAgICAg IHNlbGYuZXhwZWN0UmVtb3RlQ29tbWFuZHMoCisgICAgICAgICAgICBFeHBlY3QoJ3VwbG9hZEZp bGUnLCBkaWN0KAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHdvcmtl cnNyYz0nV2ViS2l0QnVpbGQvcmVsZWFzZS56aXAnLCB3b3JrZGlyPSd3a2RpcicsCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYmxvY2tzaXplPTEwMjQgKiAyNTYsIG1h eHNpemU9Tm9uZSwga2VlcHN0YW1wPUZhbHNlLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHdyaXRlcj1FeHBlY3RSZW1vdGVSZWYocmVtb3RldHJhbnNmZXIuRmlsZVdy aXRlciksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKSkKKyAgICAgICAg ICAgICsgRXhwZWN0LmJlaGF2aW9yKHVwbG9hZEZpbGVXaXRoQ29udGVudHNPZlN0cmluZygnRHVt bXkgemlwIGZpbGUgY29udGVudC4nKSkKKyAgICAgICAgICAgICsgMCwKKyAgICAgICAgKQorICAg ICAgICBzZWxmLmV4cGVjdFVwbG9hZGVkRmlsZSgncHVibGljX2h0bWwvYXJjaGl2ZXMvbWFjLXNp ZXJyYS14ODZfNjQtcmVsZWFzZS8xMjM0LnppcCcpCisKKyAgICAgICAgc2VsZi5leHBlY3RPdXRj b21lKHJlc3VsdD1TVUNDRVNTLCBzdGF0ZV9zdHJpbmc9J3VwbG9hZGluZyByZWxlYXNlLnppcCcp CisgICAgICAgIHJldHVybiBzZWxmLnJ1blN0ZXAoKQorCisKIGlmIF9fbmFtZV9fID09ICdfX21h aW5fXyc6CiAgICAgdW5pdHRlc3QubWFpbigpCg==