188014 2018-07-25 13:02:55 -0700 [ews-build] Add build step ArchiveBuiltProduct 2018-07-25 17:24:33 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=188016 https://bugs.webkit.org/show_bug.cgi?id=188031 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap ews-watchlist lforschler webkit-bug-importer oldest_to_newest 1445121 0 aakash_jain 2018-07-25 13:02:55 -0700 Builders on OpenSource EWS buildbot should archive the built product and upload the archive to the server, so that the testers can download the archive and run the tests. This would also help in re-using the archives for various kind of testers (WK1, WK2 etc.), being more efficient and speed-up the overall system. For that, we should add ArchiveBuiltProduct build step. 1445123 1 345774 aakash_jain 2018-07-25 13:05:37 -0700 Created attachment 345774 Proposed patch Sample run: http://ews-build.webkit-uat.org/#/builders/2/builds/16 1445128 2 ews-watchlist 2018-07-25 13:09:08 -0700 Attachment 345774 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:766: [TestArchiveBuiltProduct.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:766: [TestArchiveBuiltProduct.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:780: [TestArchiveBuiltProduct.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:780: [TestArchiveBuiltProduct.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 4 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1445205 3 aakash_jain 2018-07-25 16:16:33 -0700 Committed r234217: <https://trac.webkit.org/changeset/234217> 1445210 4 webkit-bug-importer 2018-07-25 16:22:46 -0700 <rdar://problem/42602854> 345774 2018-07-25 13:05:37 -0700 2018-07-25 15:36:31 -0700 Proposed patch ews_ArchiveBuiltProduct.patch text/plain 3434 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzNDIxMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE4LTA3LTI1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBBZGQgYnVpbGQgc3RlcCBBcmNoaXZlQnVpbHRQcm9k dWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODgw MTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1 aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weToKKyAgICAgICAgKEFyY2hpdmVCdWls dFByb2R1Y3QpOiBBZGRlZCBidWlsZCBzdGVwIEFyY2hpdmVCdWlsdFByb2R1Y3QuCisgICAgICAg ICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5OiBBZGRlZCB1 bml0LXRlc3RzLgorCiAyMDE4LTA3LTI1ICBDaGFybGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlh LmNvbT4KIAogICAgICAgICBbRmxhdHBha10gUGFzcyBtb3JlIGVudmlyb25tZW50IHZhcmlhYmxl cyB0byBzYW5kYm94CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3Rl cHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0 ZXBzLnB5CShyZXZpc2lvbiAyMzQyMTApCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3Mt YnVpbGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTI4NCwzICsyODQsMTIgQEAgY2xhc3Mg UnVuV2ViS2l0VGVzdHMoc2hlbGwuVGVzdCk6CiAgICAgICAgIGlmIGFkZGl0aW9uYWxBcmd1bWVu dHM6CiAgICAgICAgICAgICBzZWxmLnNldENvbW1hbmQoc2VsZi5jb21tYW5kICsgYWRkaXRpb25h bEFyZ3VtZW50cykKICAgICAgICAgcmV0dXJuIHNoZWxsLlRlc3Quc3RhcnQoc2VsZikKKworCitj bGFzcyBBcmNoaXZlQnVpbHRQcm9kdWN0KHNoZWxsLlNoZWxsQ29tbWFuZCk6CisgICAgY29tbWFu ZCA9IFsncHl0aG9uJywgJ1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWx0LXByb2R1Y3QtYXJj aGl2ZScsCisgICAgICAgICAgICAgICBXaXRoUHJvcGVydGllcygnLS1wbGF0Zm9ybT0lKGZ1bGxQ bGF0Zm9ybSlzJyksIFdpdGhQcm9wZXJ0aWVzKCctLSUoY29uZmlndXJhdGlvbilzJyksICdhcmNo aXZlJ10KKyAgICBuYW1lID0gJ2FyY2hpdmUtYnVpbHQtcHJvZHVjdCcKKyAgICBkZXNjcmlwdGlv biA9IFsnYXJjaGl2aW5nIGJ1aWx0IHByb2R1Y3QnXQorICAgIGRlc2NyaXB0aW9uRG9uZSA9IFsn YXJjaGl2ZWQgYnVpbHQgcHJvZHVjdCddCisgICAgaGFsdE9uRmFpbHVyZSA9IFRydWUKSW5kZXg6 IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRl c3QucHkJKHJldmlzaW9uIDIzNDIxMCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1i dWlsZC9zdGVwc191bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtNzQ1LDUgKzc0NSw0MSBA QCBjbGFzcyBUZXN0UnVuV2ViS2l0VGVzdHMoQnVpbGRTdGVwTWl4aW5BCiAgICAgICAgIHJldHVy biBzZWxmLnJ1blN0ZXAoKQogCiAKK2NsYXNzIFRlc3RBcmNoaXZlQnVpbHRQcm9kdWN0KEJ1aWxk U3RlcE1peGluQWRkaXRpb25zLCB1bml0dGVzdC5UZXN0Q2FzZSk6CisgICAgZGVmIHNldFVwKHNl bGYpOgorICAgICAgICBzZWxmLmxvbmdNZXNzYWdlID0gVHJ1ZQorICAgICAgICByZXR1cm4gc2Vs Zi5zZXRVcEJ1aWxkU3RlcCgpCisKKyAgICBkZWYgdGVhckRvd24oc2VsZik6CisgICAgICAgIHJl dHVybiBzZWxmLnRlYXJEb3duQnVpbGRTdGVwKCkKKworICAgIGRlZiB0ZXN0X3N1Y2Nlc3Moc2Vs Zik6CisgICAgICAgIHNlbGYuc2V0dXBTdGVwKEFyY2hpdmVCdWlsdFByb2R1Y3QoKSkKKyAgICAg ICAgc2VsZi5zZXRQcm9wZXJ0eSgnZnVsbFBsYXRmb3JtJywgJ2lvcy1zaW11bGF0b3InKQorICAg ICAgICBzZWxmLnNldFByb3BlcnR5KCdjb25maWd1cmF0aW9uJywgJ3JlbGVhc2UnKQorICAgICAg ICBzZWxmLmV4cGVjdFJlbW90ZUNvbW1hbmRzKAorICAgICAgICAgICAgRXhwZWN0U2hlbGwod29y a2Rpcj0nd2tkaXInLAorICAgICAgICAgICAgICAgICAgICAgICAgY29tbWFuZD1bJ3B5dGhvbics ICdUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsdC1wcm9kdWN0LWFyY2hpdmUnLCAnLS1wbGF0 Zm9ybT1pb3Mtc2ltdWxhdG9yJywgICctLXJlbGVhc2UnLCAnYXJjaGl2ZSddLAorICAgICAgICAg ICAgICAgICAgICAgICAgKQorICAgICAgICAgICAgKyAwLAorICAgICAgICApCisgICAgICAgIHNl bGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9U1VDQ0VTUywgc3RhdGVfc3RyaW5nPSdhcmNoaXZlZCBi dWlsdCBwcm9kdWN0JykKKyAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCisKKyAgICBkZWYg dGVzdF9mYWlsdXJlKHNlbGYpOgorICAgICAgICBzZWxmLnNldHVwU3RlcChBcmNoaXZlQnVpbHRQ cm9kdWN0KCkpCisgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2Z1bGxQbGF0Zm9ybScsICdtYWMt c2llcnJhJykKKyAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnY29uZmlndXJhdGlvbicsICdkZWJ1 ZycpCisgICAgICAgIHNlbGYuZXhwZWN0UmVtb3RlQ29tbWFuZHMoCisgICAgICAgICAgICBFeHBl Y3RTaGVsbCh3b3JrZGlyPSd3a2RpcicsCisgICAgICAgICAgICAgICAgICAgICAgICBjb21tYW5k PVsncHl0aG9uJywgJ1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWx0LXByb2R1Y3QtYXJjaGl2 ZScsICctLXBsYXRmb3JtPW1hYy1zaWVycmEnLCAgJy0tZGVidWcnLCAnYXJjaGl2ZSddLAorICAg ICAgICAgICAgICAgICAgICAgICAgKQorICAgICAgICAgICAgKyBFeHBlY3RTaGVsbC5sb2coJ3N0 ZGlvJywgc3Rkb3V0PSdVbmV4cGVjdGVkIGZhaWx1cmUuJykKKyAgICAgICAgICAgICsgMiwKKyAg ICAgICAgKQorICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0PUZBSUxVUkUsIHN0YXRl X3N0cmluZz0nYXJjaGl2ZWQgYnVpbHQgcHJvZHVjdCAoZmFpbHVyZSknKQorICAgICAgICByZXR1 cm4gc2VsZi5ydW5TdGVwKCkKKworCiBpZiBfX25hbWVfXyA9PSAnX19tYWluX18nOgogICAgIHVu aXR0ZXN0Lm1haW4oKQo=