187922 2018-07-23 13:52:48 -0700 WebCore::primaryScreenDisplayID() always return 0 2018-07-30 08:43:15 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue ggaren simon.fraser webkit-bug-importer oldest_to_newest 1444400 0 pvollan 2018-07-23 13:52:48 -0700 This function should return a valid display ID. 1444402 1 345604 pvollan 2018-07-23 13:54:59 -0700 Created attachment 345604 Patch 1444404 2 pvollan 2018-07-23 13:56:00 -0700 <rdar://problem/42286933> 1444411 3 345604 ggaren 2018-07-23 14:19:46 -0700 Comment on attachment 345604 Patch r=me You could probably test this in an automated way if you added a function or property in window.internals to override screenProperties().primaryDisplayID. That would at least test the fact that primaryScreenDisplayID() no longer unconditionally returns 0. (You just need the test harness to remember to 1444412 4 ggaren 2018-07-23 14:20:01 -0700 ...reset the value when it's done. 1444421 5 pvollan 2018-07-23 14:46:56 -0700 (In reply to Geoffrey Garen from comment #4) > ...reset the value when it's done. Thanks for reviewing! I added https://bugs.webkit.org/show_bug.cgi?id=187922 to track adding a test. 1444438 6 345604 commit-queue 2018-07-23 15:16:38 -0700 Comment on attachment 345604 Patch Clearing flags on attachment: 345604 Committed r234113: <https://trac.webkit.org/changeset/234113> 1444439 7 commit-queue 2018-07-23 15:16:40 -0700 All reviewed patches have been landed. Closing bug. 1446212 8 pvollan 2018-07-30 08:43:15 -0700 (In reply to Per Arne Vollan from comment #5) > (In reply to Geoffrey Garen from comment #4) > > ...reset the value when it's done. > > Thanks for reviewing! I added https://bugs.webkit.org/show_bug.cgi?id=187922 > to track adding a test. Sorry, that was not the correct bug. It should be https://bugs.webkit.org/show_bug.cgi?id=187925. 345604 2018-07-23 13:54:59 -0700 2018-07-23 15:16:38 -0700 Patch bug-187922-20180723135459.patch text/plain 1438 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNDExMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA3LTIzICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJDb3JlOjpwcmltYXJ5 U2NyZWVuRGlzcGxheUlEKCkgYWx3YXlzIHJldHVybiAwCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODc5MjIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzQyMjg2OTMzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoaXMgZnVuY3Rpb24gc2hvdWxkIHJldHVybiBhIHZhbGlkIGRpc3BsYXkgSUQuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLiBUZXN0aW5nIHRoaXMgcmVxdWlyZXMgYSBkdWFsIG1vbml0b3Ig c2V0dXAuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvUGxhdGZvcm1TY3JlZW5NYWMubW06Cisg ICAgICAgIChXZWJDb3JlOjpwcmltYXJ5U2NyZWVuRGlzcGxheUlEKToKKwogMjAxOC0wNy0yMyAg WmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMQ0ZdW0lGQ10gQWRk IHN1cHBvcnQgZm9yIGh5cGhlbmF0aW9uLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bWFjL1BsYXRmb3JtU2NyZWVuTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL21hYy9QbGF0Zm9ybVNjcmVlbk1hYy5tbQkocmV2aXNpb24gMjM0MTAxKQorKysgU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1BsYXRmb3JtU2NyZWVuTWFjLm1tCSh3b3JraW5nIGNv cHkpCkBAIC0xMDIsMTEgKzEwMiw5IEBAIHN0YXRpYyBTY3JlZW5Qcm9wZXJ0aWVzJiBzY3JlZW5Q cm9wZXJ0aWUKICAgICByZXR1cm4gc2NyZWVuUHJvcGVydGllczsKIH0KIAotLy8gRklYTUU6IFRo aXMgZnVuY3Rpb24gb25seSByZXR1cm5zIDAgZm9yIG5vdy4KIHN0YXRpYyBQbGF0Zm9ybURpc3Bs YXlJRCYgcHJpbWFyeVNjcmVlbkRpc3BsYXlJRCgpCiB7Ci0gICAgc3RhdGljIFBsYXRmb3JtRGlz cGxheUlEIHByaW1hcnlTY3JlZW5EaXNwbGF5SUQgPSAwOwotICAgIHJldHVybiBwcmltYXJ5U2Ny ZWVuRGlzcGxheUlEOworICAgIHJldHVybiBzY3JlZW5Qcm9wZXJ0aWVzKCkucHJpbWFyeURpc3Bs YXlJRDsKIH0KIAogc3RhdGljIEdMaW50IHJlbmRlcmVySURGb3JEaXNwbGF5TWFzayhHTHVpbnQg ZGlzcGxheU1hc2spCg==