187918 2018-07-23 11:53:48 -0700 Resource Load Statistics: Add logging of Storage Access API use in experimental debug mode 2018-07-23 13:17:51 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wilander wilander bfulgham commit-queue jiewen_tan webkit-bug-importer oldest_to_newest 1444348 0 wilander 2018-07-23 11:53:48 -0700 We should log requests to the Storage Access API in ITP Debug Mode. 1444350 1 webkit-bug-importer 2018-07-23 11:54:13 -0700 <rdar://problem/42509062> 1444353 2 345594 wilander 2018-07-23 11:57:59 -0700 Created attachment 345594 Patch 1444377 3 345594 jiewen_tan 2018-07-23 12:50:42 -0700 Comment on attachment 345594 Patch LGTM. r+. 1444378 4 wilander 2018-07-23 12:51:02 -0700 Thank you, Jiewen! 1444383 5 345594 commit-queue 2018-07-23 13:17:50 -0700 Comment on attachment 345594 Patch Clearing flags on attachment: 345594 Committed r234108: <https://trac.webkit.org/changeset/234108> 1444384 6 commit-queue 2018-07-23 13:17:51 -0700 All reviewed patches have been landed. Closing bug. 345594 2018-07-23 11:57:59 -0700 2018-07-23 13:17:50 -0700 Patch bug-187918-20180723115759.patch text/plain 5026 wilander U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0MTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDlkMjJmNGE4M2FmNGRmNDJj NzhkYWU3YTg5NWY4YTdiZTIwNmUyMTkuLjRiZTI1MmU3Zjc4MzUzMWY5ZDNjNzYyNjgxN2Y0Y2Zm Zjc5MGZiMGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTgtMDctMjMgIEpvaG4gV2ls YW5kZXIgIDx3aWxhbmRlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmVzb3VyY2UgTG9hZCBTdGF0 aXN0aWNzOiBBZGQgbG9nZ2luZyBvZiBTdG9yYWdlIEFjY2VzcyBBUEkgdXNlIGluIGV4cGVyaW1l bnRhbCBkZWJ1ZyBtb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xODc5MTgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQyNTA5MDYyPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3RlZCBtYW51YWxs eSBieSBsb29raW5nIGF0IGxvZyBvdXRwdXQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvUmVzb3Vy Y2VMb2FkU3RhdGlzdGljc01lbW9yeVN0b3JlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UmVzb3Vy Y2VMb2FkU3RhdGlzdGljc01lbW9yeVN0b3JlOjpyZW1vdmVEYXRhUmVjb3Jkcyk6CisgICAgICAg ICAgICBUaGlzIGlzIGp1c3QgYSBjbGVhbi11cCBjaGFuZ2UuCisgICAgICAgIChXZWJLaXQ6OlJl c291cmNlTG9hZFN0YXRpc3RpY3NNZW1vcnlTdG9yZTo6cmVxdWVzdFN0b3JhZ2VBY2Nlc3MpOgor ICAgICAgICAoV2ViS2l0OjpSZXNvdXJjZUxvYWRTdGF0aXN0aWNzTWVtb3J5U3RvcmU6OnJlcXVl c3RTdG9yYWdlQWNjZXNzVW5kZXJPcGVuZXIpOgorICAgICAgICAgICAgQm90aCB0aGVzZSBub3cg bG9nIHByb3BlciBpbmZvIGluIGRlYnVnIG1vZGUuCisKIDIwMTgtMDctMjMgIFN0ZXBoYW4gU3ph Ym8gIDxzdGVwaGFuLnN6YWJvQHNvbnkuY29tPgogCiAgICAgICAgIFtXaW5DYWlyb10gRml4IGRl dGVjdGlvbiBvZiBoZWxkIG1vZGlmaWVyIGtleXMgZm9yIGtleSBldmVudHMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1Jlc291cmNlTG9hZFN0YXRpc3RpY3NNZW1vcnlTdG9y ZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzTWVt b3J5U3RvcmUuY3BwCmluZGV4IGNjZmFkMTg4OWIxYmE3YWFhMzdkZDM1MWE2YWE3NzI0NjI1ZDMx ODkuLjNlZmQ1YjIzODU4YzQ1NzVkMmJhMDIxNWQwMDFhZGEwNjY1MTZjMDUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1Jlc291cmNlTG9hZFN0YXRpc3RpY3NNZW1vcnlTdG9y ZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvUmVzb3VyY2VMb2FkU3RhdGlzdGlj c01lbW9yeVN0b3JlLmNwcApAQCAtMjM5LDggKzIzOSw3IEBAIHZvaWQgUmVzb3VyY2VMb2FkU3Rh dGlzdGljc01lbW9yeVN0b3JlOjpyZW1vdmVEYXRhUmVjb3JkcyhDb21wbGV0aW9uSGFuZGxlcjx2 b2lkCiAgICAgfQogCiAjaWYgIVJFTEVBU0VfTE9HX0RJU0FCTEVECi0gICAgaWYgKG1fZGVidWdM b2dnaW5nRW5hYmxlZCkKLSAgICAgICAgUkVMRUFTRV9MT0dfSU5GTyhSZXNvdXJjZUxvYWRTdGF0 aXN0aWNzRGVidWcsICJBYm91dCB0byByZW1vdmUgZGF0YSByZWNvcmRzIGZvciAle3B1YmxpY31z LiIsIGRvbWFpbnNUb1N0cmluZyhwcmV2YWxlbnRSZXNvdXJjZURvbWFpbnMpLnV0ZjgoKS5kYXRh KCkpOworICAgIFJFTEVBU0VfTE9HX0lORk9fSUYobV9kZWJ1Z0xvZ2dpbmdFbmFibGVkLCBSZXNv dXJjZUxvYWRTdGF0aXN0aWNzRGVidWcsICJBYm91dCB0byByZW1vdmUgZGF0YSByZWNvcmRzIGZv ciAle3B1YmxpY31zLiIsIGRvbWFpbnNUb1N0cmluZyhwcmV2YWxlbnRSZXNvdXJjZURvbWFpbnMp LnV0ZjgoKS5kYXRhKCkpOwogI2VuZGlmCiAKICAgICBzZXREYXRhUmVjb3Jkc0JlaW5nUmVtb3Zl ZCh0cnVlKTsKQEAgLTQwMywxOSArNDAyLDMyIEBAIHZvaWQgUmVzb3VyY2VMb2FkU3RhdGlzdGlj c01lbW9yeVN0b3JlOjpyZXF1ZXN0U3RvcmFnZUFjY2VzcyhTdHJpbmcmJiBzdWJGcmFtZVByCiAK ICAgICBhdXRvJiBzdWJGcmFtZVN0YXRpc3RpYyA9IGVuc3VyZVJlc291cmNlU3RhdGlzdGljc0Zv clByaW1hcnlEb21haW4oc3ViRnJhbWVQcmltYXJ5RG9tYWluKTsKICAgICBpZiAoc2hvdWxkQmxv Y2tDb29raWVzKHN1YkZyYW1lU3RhdGlzdGljKSkgeworI2lmICFSRUxFQVNFX0xPR19ESVNBQkxF RAorICAgICAgICBSRUxFQVNFX0xPR19JTkZPX0lGKG1fZGVidWdMb2dnaW5nRW5hYmxlZCwgUmVz b3VyY2VMb2FkU3RhdGlzdGljc0RlYnVnLCAiQ2Fubm90IGdyYW50IHN0b3JhZ2UgYWNjZXNzIHRv ICV7cHVibGljfXMgc2luY2UgaXRzIGNvb2tpZXMgYXJlIGJsb2NrZWQgaW4gdGhpcmQtcGFydHkg Y29udGV4dHMuIiwgc3ViRnJhbWVQcmltYXJ5RG9tYWluLnV0ZjgoKS5kYXRhKCkpOworI2VuZGlm CiAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKFN0b3JhZ2VBY2Nlc3NTdGF0dXM6OkNhbm5vdFJl cXVlc3RBY2Nlc3MpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCiAgICAgaWYgKCFzaG91bGRQ YXJ0aXRpb25Db29raWVzKHN1YkZyYW1lU3RhdGlzdGljKSkgeworI2lmICFSRUxFQVNFX0xPR19E SVNBQkxFRAorICAgICAgICBSRUxFQVNFX0xPR19JTkZPX0lGKG1fZGVidWdMb2dnaW5nRW5hYmxl ZCwgUmVzb3VyY2VMb2FkU3RhdGlzdGljc0RlYnVnLCAiTm8gbmVlZCB0byBncmFudCBzdG9yYWdl IGFjY2VzcyB0byAle3B1YmxpY31zIHNpbmNlIGl0cyBjb29raWVzIGFyZSBuZWl0aGVyIGJsb2Nr ZWQgbm9yIHBhcnRpdGlvbmVkIGluIHRoaXJkLXBhcnR5IGNvbnRleHRzLiIsIHN1YkZyYW1lUHJp bWFyeURvbWFpbi51dGY4KCkuZGF0YSgpKTsKKyNlbmRpZgogICAgICAgICBjb21wbGV0aW9uSGFu ZGxlcihTdG9yYWdlQWNjZXNzU3RhdHVzOjpIYXNBY2Nlc3MpOwogICAgICAgICByZXR1cm47CiAg ICAgfQogCiAgICAgYXV0byB1c2VyV2FzUHJvbXB0ZWRFYXJsaWVyID0gcHJvbXB0RW5hYmxlZCAm JiBoYXNVc2VyR3JhbnRlZFN0b3JhZ2VBY2Nlc3NUaHJvdWdoUHJvbXB0KHN1YkZyYW1lU3RhdGlz dGljLCB0b3BGcmFtZVByaW1hcnlEb21haW4pOwogICAgIGlmIChwcm9tcHRFbmFibGVkICYmICF1 c2VyV2FzUHJvbXB0ZWRFYXJsaWVyKSB7CisjaWYgIVJFTEVBU0VfTE9HX0RJU0FCTEVECisgICAg ICAgIFJFTEVBU0VfTE9HX0lORk9fSUYobV9kZWJ1Z0xvZ2dpbmdFbmFibGVkLCBSZXNvdXJjZUxv YWRTdGF0aXN0aWNzRGVidWcsICJBYm91dCB0byBhc2sgdGhlIHVzZXIgd2hldGhlciB0aGV5IHdh bnQgdG8gZ3JhbnQgc3RvcmFnZSBhY2Nlc3MgdG8gJXtwdWJsaWN9cyB1bmRlciAle3B1YmxpY31z IG9yIG5vdC4iLCBzdWJGcmFtZVByaW1hcnlEb21haW4udXRmOCgpLmRhdGEoKSwgdG9wRnJhbWVQ cmltYXJ5RG9tYWluLnV0ZjgoKS5kYXRhKCkpOworI2VuZGlmCiAgICAgICAgIGNvbXBsZXRpb25I YW5kbGVyKFN0b3JhZ2VBY2Nlc3NTdGF0dXM6OlJlcXVpcmVzVXNlclByb21wdCk7CiAgICAgICAg IHJldHVybjsKKyAgICB9IGVsc2UgaWYgKHVzZXJXYXNQcm9tcHRlZEVhcmxpZXIpIHsKKyNpZiAh UkVMRUFTRV9MT0dfRElTQUJMRUQKKyAgICAgICAgUkVMRUFTRV9MT0dfSU5GT19JRihtX2RlYnVn TG9nZ2luZ0VuYWJsZWQsIFJlc291cmNlTG9hZFN0YXRpc3RpY3NEZWJ1ZywgIlN0b3JhZ2UgYWNj ZXNzIHdhcyBncmFudGVkIHRvICV7cHVibGljfXMgdW5kZXIgJXtwdWJsaWN9cy4iLCBzdWJGcmFt ZVByaW1hcnlEb21haW4udXRmOCgpLmRhdGEoKSwgdG9wRnJhbWVQcmltYXJ5RG9tYWluLnV0Zjgo KS5kYXRhKCkpOworI2VuZGlmCiAgICAgfQogCiAgICAgc3ViRnJhbWVTdGF0aXN0aWMudGltZXNB Y2Nlc3NlZEFzRmlyc3RQYXJ0eUR1ZVRvU3RvcmFnZUFjY2Vzc0FQSSsrOwpAQCAtNDQ1LDcgKzQ1 Nyw3IEBAIHZvaWQgUmVzb3VyY2VMb2FkU3RhdGlzdGljc01lbW9yeVN0b3JlOjpyZXF1ZXN0U3Rv cmFnZUFjY2Vzc1VuZGVyT3BlbmVyKFN0cmluZyYmCiAgICAgICAgIHJldHVybjsKIAogI2lmICFS RUxFQVNFX0xPR19ESVNBQkxFRAotICAgIFJFTEVBU0VfTE9HX0lORk9fSUYobV9kZWJ1Z0xvZ2dp bmdFbmFibGVkLCBSZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGVidWcsICJHcmFudCBzdG9yYWdlIGFj Y2VzcyBmb3IgJXtwdWJsaWN9cyB1bmRlciBvcGVuZXIgJXtwdWJsaWN9cywgJXtwdWJsaWN9cyB1 c2VyIGludGVyYWN0aW9uLiIsIHByaW1hcnlEb21haW5Jbk5lZWRPZlN0b3JhZ2VBY2Nlc3MudXRm OCgpLmRhdGEoKSwgb3BlbmVyUHJpbWFyeURvbWFpbi51dGY4KCkuZGF0YSgpLCAoaXNUcmlnZ2Vy ZWRCeVVzZXJHZXN0dXJlID8gIndpdGgiIDogIndpdGhvdXQiKSk7CisgICAgUkVMRUFTRV9MT0df SU5GT19JRihtX2RlYnVnTG9nZ2luZ0VuYWJsZWQsIFJlc291cmNlTG9hZFN0YXRpc3RpY3NEZWJ1 ZywgIltUZW1wb3JhcnkgY29tYmF0aWJpbGl0eSBmaXhdIFN0b3JhZ2UgYWNjZXNzIHdhcyBncmFu dGVkIGZvciAle3B1YmxpY31zIHVuZGVyIG9wZW5lciBwYWdlIGZyb20gJXtwdWJsaWN9cywgJXtw dWJsaWN9cyB1c2VyIGludGVyYWN0aW9uIGluIHRoZSBvcGVuZWQgd2luZG93LiIsIHByaW1hcnlE b21haW5Jbk5lZWRPZlN0b3JhZ2VBY2Nlc3MudXRmOCgpLmRhdGEoKSwgb3BlbmVyUHJpbWFyeURv bWFpbi51dGY4KCkuZGF0YSgpLCAoaXNUcmlnZ2VyZWRCeVVzZXJHZXN0dXJlID8gIndpdGgiIDog IndpdGhvdXQiKSk7CiAjZW5kaWYKICAgICBncmFudFN0b3JhZ2VBY2Nlc3NJbnRlcm5hbChXVEZN b3ZlKHByaW1hcnlEb21haW5Jbk5lZWRPZlN0b3JhZ2VBY2Nlc3MpLCBXVEZNb3ZlKG9wZW5lclBy aW1hcnlEb21haW4pLCBzdGQ6Om51bGxvcHQsIG9wZW5lclBhZ2VJRCwgZmFsc2UsIFtdKGJvb2wp IHsgfSk7CiB9Cg==