18789 2008-04-28 10:25:54 -0700 WebView won't get closed with window in certain cases 2008-05-05 09:37:42 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 darin darin oldest_to_newest 79140 0 darin 2008-04-28 10:25:54 -0700 By code inspection: If the WebView is put into a window, then setHostWindow is called to make that same window the host window for the view, then the view is removed from the window, and then the window is closed, the WebView won't get closed. If the WebView is put into a window, then setHostWIndow is called to make that same window the host window for a view, then setHostWindow is called to change the host window back to nil, and then the window is closed, the WebView won't get closed. 79142 1 20870 darin 2008-04-28 10:26:42 -0700 Created attachment 20870 patch 79144 2 20870 mitz 2008-04-28 10:33:56 -0700 Comment on attachment 20870 patch r=me 79678 3 darin 2008-05-05 09:37:42 -0700 r32874 20870 2008-04-28 10:26:42 -0700 2008-04-28 10:33:56 -0700 patch ShouldCloseWithWindowPatch.txt text/plain 4222 darin SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiAzMjYxMSkKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDgtMDQtMjUgIERhcmluIEFkbGVyICA8ZGFyaW5A YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIC0gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4Nzg5CisgICAg ICAgICAgZml4IHNvbWUgc2hvdWxkQ2xvc2VXaXRoV2luZG93IGVkZ2UgY2FzZXMKKworICAgICAg ICAqIFdlYlZpZXcvV2ViVmlldy5tbToKKyAgICAgICAgKC1bV2ViVmlldyB2aWV3V2lsbE1vdmVU b1dpbmRvdzpdKTogRml4IGJ1ZyB3aGVyZSB3ZSB3b3VsZCBzdG9wIG9ic2VydmluZyB0aGUKKyAg ICAgICAgTlNXaW5kb3dXaWxsQ2xvc2VOb3RpZmljYXRpb24gaWYgdGhlIHZpZXcgd2FzIG1vdmVk IG91dCBvZiB0aGUgd2luZG93IGJ1dCBzdGlsbAorICAgICAgICBoYWQgdGhhdCB3aW5kb3cgc2V0 IGFzIHRoZSBob3N0IHdpbmRvdy4gQWxzbyBtYWtlIHN1cmUgdGhpcyBmdW5jdGlvbiBkb2Vzbid0 IGRvCisgICAgICAgIGFueXRoaW5nIGlmIHRoZSBXZWJWaWV3IGlzIGFscmVhZHkgY2xvc2VkLgor ICAgICAgICAoLVtXZWJWaWV3IHNldEhvc3RXaW5kb3c6XSk6IERpdHRvLgorCiAyMDA4LTA0LTIw IEFkYW0gQmFydGggPGhrOTU2NUBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRh bSBSb2JlbiBhbmQgU2FtIFdlaW5pZy4KSW5kZXg6IFdlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3 Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCShyZXZpc2lv biAzMjYxMSkKKysrIFdlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCSh3b3JraW5nIGNvcHkp CkBAIC0yMDMxLDE1ICsyMDMxLDE3IEBAIFdlYkZyYW1lTG9hZERlbGVnYXRlSW1wbGVtZW50YXRp b25DYWNoZSoKICAgICAvLyBEb24ndCBkbyBhbnl0aGluZyBpZiB3ZSBhcmVuJ3QgaW5pdGlhbGl6 ZWQuICBUaGlzIGhhcHBlbnMgd2hlbiBkZWNvZGluZyBhIFdlYlZpZXcuCiAgICAgaWYgKCFfcHJp dmF0ZSkKICAgICAgICAgcmV0dXJuOworICAgIGlmIChfcHJpdmF0ZS0+Y2xvc2VkKQorICAgICAg ICByZXR1cm47CiAgICAgCi0gICAgaWYgKFtzZWxmIHdpbmRvd10pCisgICAgaWYgKFtzZWxmIHdp bmRvd10gJiYgW3NlbGYgd2luZG93XSAhPSBbc2VsZiBob3N0V2luZG93XSkKICAgICAgICAgW1tO U05vdGlmaWNhdGlvbkNlbnRlciBkZWZhdWx0Q2VudGVyXSByZW1vdmVPYnNlcnZlcjpzZWxmIG5h bWU6TlNXaW5kb3dXaWxsQ2xvc2VOb3RpZmljYXRpb24gb2JqZWN0OltzZWxmIHdpbmRvd11dOwog CiAgICAgaWYgKHdpbmRvdykgewogICAgICAgICBbW05TTm90aWZpY2F0aW9uQ2VudGVyIGRlZmF1 bHRDZW50ZXJdIGFkZE9ic2VydmVyOnNlbGYgc2VsZWN0b3I6QHNlbGVjdG9yKF93aW5kb3dXaWxs Q2xvc2U6KSBuYW1lOk5TV2luZG93V2lsbENsb3NlTm90aWZpY2F0aW9uIG9iamVjdDp3aW5kb3dd OwogCi0gICAgICAgIC8vIEVuc3VyZSB0aGF0IHdlIHdpbGwgcmVjZWl2ZSB0aGUgZXZlbnRzIHRo YXQgV2ViSFRNTFZpZXcgKGF0IGxlYXN0KSBuZWVkcy4gSXQncyBleHBlbnNpdmUgZW5vdWdoCi0g ICAgICAgIC8vIHRoYXQgd2UgZG9uJ3Qgd2FudCB0byBjYWxsIGl0IG92ZXIgYW5kIG92ZXIuCisg ICAgICAgIC8vIEVuc3VyZSB0aGF0IHdlIHdpbGwgcmVjZWl2ZSB0aGUgZXZlbnRzIHRoYXQgV2Vi SFRNTFZpZXcgKGF0IGxlYXN0KSBuZWVkcy4KKyAgICAgICAgLy8gVGhlc2UgYXJlIGV4cGVuc2l2 ZSBlbm91Z2ggdGhhdCB3ZSBkb24ndCB3YW50IHRvIGNhbGwgdGhlbSBvdmVyIGFuZCBvdmVyLgog ICAgICAgICBbd2luZG93IHNldEFjY2VwdHNNb3VzZU1vdmVkRXZlbnRzOllFU107CiAgICAgICAg IFdLU2V0TlNXaW5kb3dTaG91bGRQb3N0RXZlbnROb3RpZmljYXRpb25zKHdpbmRvdywgWUVTKTsK ICAgICB9CkBAIC0yNDM3LDE5ICsyNDM5LDIyIEBAIFdlYkZyYW1lTG9hZERlbGVnYXRlSW1wbGVt ZW50YXRpb25DYWNoZSoKIAogLSAodm9pZClzZXRIb3N0V2luZG93OihOU1dpbmRvdyAqKWhvc3RX aW5kb3cKIHsKLSAgICBpZiAoIV9wcml2YXRlLT5jbG9zZWQgJiYgaG9zdFdpbmRvdyAhPSBfcHJp dmF0ZS0+aG9zdFdpbmRvdykgewotICAgICAgICBGcmFtZSogY29yZUZyYW1lID0gY29yZShbc2Vs ZiBtYWluRnJhbWVdKTsKLSAgICAgICAgZm9yIChGcmFtZSogZnJhbWUgPSBjb3JlRnJhbWU7IGZy YW1lOyBmcmFtZSA9IGZyYW1lLT50cmVlKCktPnRyYXZlcnNlTmV4dChjb3JlRnJhbWUpKQotICAg ICAgICAgICAgW1tba2l0KGZyYW1lKSBmcmFtZVZpZXddIGRvY3VtZW50Vmlld10gdmlld1dpbGxN b3ZlVG9Ib3N0V2luZG93Omhvc3RXaW5kb3ddOwotICAgICAgICBpZiAoX3ByaXZhdGUtPmhvc3RX aW5kb3cpCi0gICAgICAgICAgICBbW05TTm90aWZpY2F0aW9uQ2VudGVyIGRlZmF1bHRDZW50ZXJd IHJlbW92ZU9ic2VydmVyOnNlbGYgbmFtZTpOU1dpbmRvd1dpbGxDbG9zZU5vdGlmaWNhdGlvbiBv YmplY3Q6X3ByaXZhdGUtPmhvc3RXaW5kb3ddOwotICAgICAgICBpZiAoaG9zdFdpbmRvdykKLSAg ICAgICAgICAgIFtbTlNOb3RpZmljYXRpb25DZW50ZXIgZGVmYXVsdENlbnRlcl0gYWRkT2JzZXJ2 ZXI6c2VsZiBzZWxlY3RvcjpAc2VsZWN0b3IoX3dpbmRvd1dpbGxDbG9zZTopIG5hbWU6TlNXaW5k b3dXaWxsQ2xvc2VOb3RpZmljYXRpb24gb2JqZWN0Omhvc3RXaW5kb3ddOwotICAgICAgICBbX3By aXZhdGUtPmhvc3RXaW5kb3cgcmVsZWFzZV07Ci0gICAgICAgIF9wcml2YXRlLT5ob3N0V2luZG93 ID0gW2hvc3RXaW5kb3cgcmV0YWluXTsKLSAgICAgICAgZm9yIChGcmFtZSogZnJhbWUgPSBjb3Jl RnJhbWU7IGZyYW1lOyBmcmFtZSA9IGZyYW1lLT50cmVlKCktPnRyYXZlcnNlTmV4dChjb3JlRnJh bWUpKQotICAgICAgICAgICAgW1tba2l0KGZyYW1lKSBmcmFtZVZpZXddIGRvY3VtZW50Vmlld10g dmlld0RpZE1vdmVUb0hvc3RXaW5kb3ddOwotICAgIH0KKyAgICBpZiAoX3ByaXZhdGUtPmNsb3Nl ZCkKKyAgICAgICAgcmV0dXJuOworICAgIGlmIChob3N0V2luZG93ID09IF9wcml2YXRlLT5ob3N0 V2luZG93KQorICAgICAgICByZXR1cm47CisKKyAgICBGcmFtZSogY29yZUZyYW1lID0gY29yZShb c2VsZiBtYWluRnJhbWVdKTsKKyAgICBmb3IgKEZyYW1lKiBmcmFtZSA9IGNvcmVGcmFtZTsgZnJh bWU7IGZyYW1lID0gZnJhbWUtPnRyZWUoKS0+dHJhdmVyc2VOZXh0KGNvcmVGcmFtZSkpCisgICAg ICAgIFtbW2tpdChmcmFtZSkgZnJhbWVWaWV3XSBkb2N1bWVudFZpZXddIHZpZXdXaWxsTW92ZVRv SG9zdFdpbmRvdzpob3N0V2luZG93XTsKKyAgICBpZiAoX3ByaXZhdGUtPmhvc3RXaW5kb3cgJiYg W3NlbGYgd2luZG93XSAhPSBfcHJpdmF0ZS0+aG9zdFdpbmRvdykKKyAgICAgICAgW1tOU05vdGlm aWNhdGlvbkNlbnRlciBkZWZhdWx0Q2VudGVyXSByZW1vdmVPYnNlcnZlcjpzZWxmIG5hbWU6TlNX aW5kb3dXaWxsQ2xvc2VOb3RpZmljYXRpb24gb2JqZWN0Ol9wcml2YXRlLT5ob3N0V2luZG93XTsK KyAgICBpZiAoaG9zdFdpbmRvdykKKyAgICAgICAgW1tOU05vdGlmaWNhdGlvbkNlbnRlciBkZWZh dWx0Q2VudGVyXSBhZGRPYnNlcnZlcjpzZWxmIHNlbGVjdG9yOkBzZWxlY3Rvcihfd2luZG93V2ls bENsb3NlOikgbmFtZTpOU1dpbmRvd1dpbGxDbG9zZU5vdGlmaWNhdGlvbiBvYmplY3Q6aG9zdFdp bmRvd107CisgICAgW19wcml2YXRlLT5ob3N0V2luZG93IHJlbGVhc2VdOworICAgIF9wcml2YXRl LT5ob3N0V2luZG93ID0gW2hvc3RXaW5kb3cgcmV0YWluXTsKKyAgICBmb3IgKEZyYW1lKiBmcmFt ZSA9IGNvcmVGcmFtZTsgZnJhbWU7IGZyYW1lID0gZnJhbWUtPnRyZWUoKS0+dHJhdmVyc2VOZXh0 KGNvcmVGcmFtZSkpCisgICAgICAgIFtbW2tpdChmcmFtZSkgZnJhbWVWaWV3XSBkb2N1bWVudFZp ZXddIHZpZXdEaWRNb3ZlVG9Ib3N0V2luZG93XTsKIH0KIAogLSAoTlNXaW5kb3cgKilob3N0V2lu ZG93Cg==