187840 2018-07-19 18:58:39 -0700 Animation stops with object-fit:contain on an animated 2d canvas 2018-09-10 09:21:20 -0700 1 1 1 Unclassified WebKit Canvas Safari Technology Preview iPhone / iPad Other RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=188007 https://bugs.webkit.org/show_bug.cgi?id=188910 https://bugs.webkit.org/show_bug.cgi?id=188394 InRadar P2 Major --- 1 andj2223 simon.fraser commit-queue dino graouts jonlee realdawei simon.fraser tsavell webkit-bug-importer zalan oldest_to_newest 1443647 0 andj2223 2018-07-19 18:58:39 -0700 http://jsfiddle.net/n7nebbL8/17/ Expected behavior upon clicking 'Run': Diagonal line should be slowly drawn from upper-left corner to lower right corner -- one pixel at a time per frame. There should be no gaps, lag, or stoppages when the line is being drawn until it reaches the lower right corner. The performance should be quite smooth. Actual behavior: The line drawing stops for long periods of time (500ms or more) part way through, stops entirely, or is missing many segments, resulting in a dotted line. I've tested this on Safari with the latest iOS 12 beta as of this writing (16A5327f) and the problem still exists. I don't have a desktop Safari to test with, but I wouldn't be surprised to see the same issue there -- it's worth trying out. Chrome has the same bug. Firefox has the expected behavior, so that can be used as a guide for how this should behave. 1443996 1 webkit-bug-importer 2018-07-20 19:27:04 -0700 <rdar://problem/42454524> 1444916 2 simon.fraser 2018-07-24 18:04:47 -0700 This is pretty funny. Turn on repaint rects in web inspector and you can see that we fail to map the repaints through the object-fit transform. 1444925 3 345735 simon.fraser 2018-07-24 18:59:06 -0700 Created attachment 345735 Patch 1444948 4 345735 zalan 2018-07-24 20:43:03 -0700 Comment on attachment 345735 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345735&action=review > Source/WebCore/html/HTMLCanvasElement.cpp:511 > + if (is<RenderReplaced>(renderBox())) { The canvas renderer is not necessarily a RenderReplaced. 1444951 5 zalan 2018-07-24 20:45:39 -0700 (In reply to zalan from comment #4) > Comment on attachment 345735 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=345735&action=review > > > Source/WebCore/html/HTMLCanvasElement.cpp:511 > > + if (is<RenderReplaced>(renderBox())) { > > The canvas renderer is not necessarily a RenderReplaced. And the object-fit is specific to replaced elements. 1444955 6 zalan 2018-07-24 21:12:30 -0700 https://trac.webkit.org/changeset/234187/webkit 1445069 7 realdawei 2018-07-25 10:10:16 -0700 Reverted r234187 for reason: the layout test added with this change is flaky on the bots Committed r234203: <https://trac.webkit.org/changeset/234203> 1445070 8 realdawei 2018-07-25 10:18:44 -0700 (In reply to David Fenton (:realdawei) from comment #7) > Reverted r234187 for reason: > > the layout test added with this change is flaky on the bots > > Committed r234203: <https://trac.webkit.org/changeset/234203> This test was A) Failing on High Sierra WK2 and Sierra WK 2, B) Flaky on High Sierra Release WK1, High Sierra (Leaks) and C) Failing on Windows Release. So I made the decision to roll it out for now. Sample Diff: https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r234195%20(5827)/fast/repaint/canvas-object-fit-diff.txt --- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/fast/repaint/canvas-object-fit-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/fast/repaint/canvas-object-fit-actual.txt @@ -10,9 +10,6 @@ (position 8.00 8.00) (bounds 202.00 102.00) (drawsContent 1) - (repaint rects - (rect 70.00 20.00 7.00 7.00) - ) ) ) ) Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Frepaint%2Fcanvas-object-fit.html 1445072 9 realdawei 2018-07-25 10:19:58 -0700 *** Bug 188007 has been marked as a duplicate of this bug. *** 1445115 10 ryanhaddad 2018-07-25 12:35:18 -0700 *** Bug 188004 has been marked as a duplicate of this bug. *** 1445969 11 simon.fraser 2018-07-27 21:39:16 -0700 When the test flakes, there's no layer flush between the first drawing and the drawing with tracked repaints, so we've never cleared the dirty rect from the first fill, and the second draw doesn't add a new dirty rect. In the good case we flush between the load event and the zero-delay timer. 1445970 12 simon.fraser 2018-07-27 22:22:39 -0700 Re-landed in https://trac.webkit.org/changeset/234343/webkit with a fixed test. 1446662 13 tsavell 2018-07-31 14:23:15 -0700 Looks like after https://trac.webkit.org/changeset/234343/webkit, we have two tests. One is failing and the other is a timeout that fail together. Both tests are flakey. tests are failing on High Sierra Leaks bots tests: inspector/layers/layers-anonymous.html inspector/layers/layer-tree-manager.html combines history: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Flayers%2Flayers-anonymous.html%20inspector%2Flayers%2Flayer-tree-manager.html Diffs: https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r234434%20(11850)/inspector/layers/layer-tree-manager-pretty-diff.html https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r234434%20(11850)/inspector/layers/layers-anonymous-pretty-diff.html 1458138 14 tsavell 2018-09-10 09:21:20 -0700 Looks like fast/repaint/canvas-object-fit.html has been flakey sense being reintroduced in: https://trac.webkit.org/changeset/234343/webkit Test History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Frepaint%2Fcanvas-object-fit.html Reproduced with: run-webkit-tests --root testbuild-234343 fast/repaint/canvas-object-fit.html --iterations 500 -f -1 Diff: --- /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/fast/repaint/canvas-object-fit-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/fast/repaint/canvas-object-fit-actual.txt @@ -1,21 +1 @@ - (GraphicsLayer - (anchor 0.00 0.00) - (bounds 800.00 600.00) - (children 1 - (GraphicsLayer - (bounds 800.00 600.00) - (contentsOpaque 1) - (children 1 - (GraphicsLayer - (position 8.00 8.00) - (bounds 202.00 102.00) - (drawsContent 1) - (repaint rects - (rect 70.00 20.00 7.00 7.00) - ) - ) - ) - ) - ) -) 345735 2018-07-24 18:59:06 -0700 2018-07-24 20:43:03 -0700 Patch bug-187840-20180724185905.patch text/plain 10529 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0MDg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjA2M2Q0MWI0OTYxOGQ1 YzAwNzY2YzVkMDQzZjMwNzNiMTQyZTM3ZS4uM2UwZmJiYzdjMzQxZDU0MGJhNGNlY2I1YjJkNDcx NDZlNzFiMjhmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDE4LTA3LTI0ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEFuaW1hdGlvbiBz dG9wcyB3aXRoIG9iamVjdC1maXQ6Y29udGFpbiBvbiBhbiBhbmltYXRlZCAyZCBjYW52YXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4Nzg0MAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgSWYg YSBjYW52YXMgaGFzIG9iamVjdC1maXQ6IGNvdmVyIG9yIGNvbnRhaW4sIHJlcGFpbnRzIG5lZWQg dG8gbWFwcGVkIHRocm91Z2gKKyAgICAgICAgdGhlIHJlY3QgdGhhdCBpcyB1c2VkIHRvIHBvc2l0 aW9uIHRoZSBjYW52YXMgaW4gdGhlIGVsZW1lbnQgYm91bmRzLCB3aGljaCBpcyByZXBsYWNlZENv bnRlbnRSZWN0KCkuCisgICAgICAgIAorICAgICAgICBBZGQgYSB2ZXJzaW9uIG9mIHJlcGxhY2Vk Q29udGVudFJlY3QoKSB0aGF0IGRvZXNuJ3QgcmVxdWlyZSBwYXNzaW5nIHRoZSBpbnRyaW5zaWNT aXplKCkgc2luY2UKKyAgICAgICAgYWxsIGJ1dCBSZW5kZXJWaWRlbyBqdXN0IHBhc3MgdGhlIFJl bmRlclJlcGxhY2VkJ3MgaW50cmluc2ljU2l6ZS4KKworICAgICAgICBUZXN0OiBmYXN0L3JlcGFp bnQvY2FudmFzLW9iamVjdC1maXQuaHRtbAorCisgICAgICAgICogaHRtbC9IVE1MQ2FudmFzRWxl bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MQ2FudmFzRWxlbWVudDo6ZGlkRHJhdyk6 CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckhUTUxDYW52YXMuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVySFRNTENhbnZhczo6cGFpbnRSZXBsYWNlZCk6CisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlckltYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckltYWdlOjp1cGRh dGVJbm5lckNvbnRlbnRSZWN0KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckltYWdlOjpwYWlu dFJlcGxhY2VkKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQmFja2luZzo6Y29udGVudHNCb3ggY29uc3Qp OgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJSZXBsYWNlZC5oOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyUmVwbGFjZWQ6OnJlcGxhY2VkQ29udGVudFJlY3QgY29uc3QpOgorICAgICAgICAq IHJlbmRlcmluZy9zaGFwZXMvU2hhcGVPdXRzaWRlSW5mby5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpTaGFwZU91dHNpZGVJbmZvOjpjcmVhdGVTaGFwZUZvckltYWdlIGNvbnN0KToKKwogMjAxOC0w Ny0yMSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0lG Q10gQWRkIHZlcmlmaWNhdGlvbiBmb3IgaW5saW5lIHRleHQgcnVucy4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAKaW5kZXggYjg4NWVkODc0M2YwYmM2ZGQ5ZmU1Nzgw OTQ2YzU5NzlhNTM2MzU1YS4uNWZmM2VhMGRjYjAxZjY1YWZlOWE2MjM1NDA2OWYxNWRiN2YxNDA0 NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAKQEAgLTUwOCw4 ICs1MDgsOSBAQCB2b2lkIEhUTUxDYW52YXNFbGVtZW50OjpkaWREcmF3KGNvbnN0IEZsb2F0UmVj dCYgcmVjdCkKICAgICBjbGVhckNvcGllZEltYWdlKCk7CiAKICAgICBGbG9hdFJlY3QgZGlydHlS ZWN0ID0gcmVjdDsKLSAgICBpZiAoUmVuZGVyQm94KiBybyA9IHJlbmRlckJveCgpKSB7Ci0gICAg ICAgIEZsb2F0UmVjdCBkZXN0UmVjdCA9IHJvLT5jb250ZW50Qm94UmVjdCgpOworICAgIGlmIChp czxSZW5kZXJSZXBsYWNlZD4ocmVuZGVyQm94KCkpKSB7CisgICAgICAgIGF1dG8mIHJlbmRlcmVy ID0gZG93bmNhc3Q8UmVuZGVyUmVwbGFjZWQ+KCpyZW5kZXJCb3goKSk7CisgICAgICAgIEZsb2F0 UmVjdCBkZXN0UmVjdCA9IHJlbmRlcmVyLnJlcGxhY2VkQ29udGVudFJlY3QoKTsKICAgICAgICAg Ly8gSW5mbGF0ZSBkaXJ0eSByZWN0IHRvIGNvdmVyIGFudGlhbGlhc2luZyBvbiBpbWFnZSBidWZm ZXJzLgogICAgICAgICBpZiAoZHJhd2luZ0NvbnRleHQoKSAmJiBkcmF3aW5nQ29udGV4dCgpLT5z aG91bGRBbnRpYWxpYXMoKSkKICAgICAgICAgICAgIGRpcnR5UmVjdC5pbmZsYXRlKDEpOwpAQCAt NTE3LDcgKzUxOCw3IEBAIHZvaWQgSFRNTENhbnZhc0VsZW1lbnQ6OmRpZERyYXcoY29uc3QgRmxv YXRSZWN0JiByZWN0KQogICAgICAgICByLmludGVyc2VjdChkZXN0UmVjdCk7CiAgICAgICAgIGlm ICghci5pc0VtcHR5KCkgJiYgIW1fZGlydHlSZWN0LmNvbnRhaW5zKHIpKSB7CiAgICAgICAgICAg ICBtX2RpcnR5UmVjdC51bml0ZShyKTsKLSAgICAgICAgICAgIHJvLT5yZXBhaW50UmVjdGFuZ2xl KGVuY2xvc2luZ0ludFJlY3QobV9kaXJ0eVJlY3QpKTsKKyAgICAgICAgICAgIHJlbmRlcmVyLnJl cGFpbnRSZWN0YW5nbGUoZW5jbG9zaW5nSW50UmVjdChtX2RpcnR5UmVjdCkpOwogICAgICAgICB9 CiAgICAgfQogICAgIG5vdGlmeU9ic2VydmVyc0NhbnZhc0NoYW5nZWQoZGlydHlSZWN0KTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJIVE1MQ2FudmFzLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJIVE1MQ2FudmFzLmNwcAppbmRleCA5ODZk ZWZlODVlNTU4Y2U4OTFjZTA5YTI3YWRkOGQwYTM5YjAxNzkxLi5lOTY4ZTYxMTJmMjM2NDA5YTM1 NGY4MmZiM2FlODUzOWFmM2QwNmU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVySFRNTENhbnZhcy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckhUTUxDYW52YXMuY3BwCkBAIC03NCw3ICs3NCw3IEBAIHZvaWQgUmVuZGVySFRNTENhbnZh czo6cGFpbnRSZXBsYWNlZChQYWludEluZm8mIHBhaW50SW5mbywgY29uc3QgTGF5b3V0UG9pbnQm IHBhCiAKICAgICBMYXlvdXRSZWN0IGNvbnRlbnRCb3hSZWN0ID0gdGhpcy0+Y29udGVudEJveFJl Y3QoKTsKICAgICBjb250ZW50Qm94UmVjdC5tb3ZlQnkocGFpbnRPZmZzZXQpOwotICAgIExheW91 dFJlY3QgcmVwbGFjZWRDb250ZW50UmVjdCA9IHRoaXMtPnJlcGxhY2VkQ29udGVudFJlY3QoaW50 cmluc2ljU2l6ZSgpKTsKKyAgICBMYXlvdXRSZWN0IHJlcGxhY2VkQ29udGVudFJlY3QgPSB0aGlz LT5yZXBsYWNlZENvbnRlbnRSZWN0KCk7CiAgICAgcmVwbGFjZWRDb250ZW50UmVjdC5tb3ZlQnko cGFpbnRPZmZzZXQpOwogCiAgICAgLy8gTm90IGFsbG93ZWQgdG8gb3ZlcmZsb3cgdGhlIGNvbnRl bnQgYm94LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckltYWdl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbWFnZS5jcHAKaW5kZXggOTcz ZmEwMTIwMzg0MDMwMzM5MTI0Njk5ZWQyYThkY2I0YTkwMjBkOS4uNmMwOTNhNDc4ZWRhZTJiMjU0 M2I1YzU5ZjczYzcwYzQwYjBiYjZjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckltYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy SW1hZ2UuY3BwCkBAIC0yODUsNyArMjg1LDcgQEAgdm9pZCBSZW5kZXJJbWFnZTo6dXBkYXRlSW50 cmluc2ljU2l6ZUlmTmVlZGVkKGNvbnN0IExheW91dFNpemUmIG5ld1NpemUpCiB2b2lkIFJlbmRl ckltYWdlOjp1cGRhdGVJbm5lckNvbnRlbnRSZWN0KCkKIHsKICAgICAvLyBQcm9wYWdhdGUgY29u dGFpbmVyIHNpemUgdG8gaW1hZ2UgcmVzb3VyY2UuCi0gICAgSW50U2l6ZSBjb250YWluZXJTaXpl KHJlcGxhY2VkQ29udGVudFJlY3QoaW50cmluc2ljU2l6ZSgpKS5zaXplKCkpOworICAgIEludFNp emUgY29udGFpbmVyU2l6ZShyZXBsYWNlZENvbnRlbnRSZWN0KCkuc2l6ZSgpKTsKICAgICBpZiAo IWNvbnRhaW5lclNpemUuaXNFbXB0eSgpKSB7CiAgICAgICAgIFVSTCBpbWFnZVNvdXJjZVVSTDsK ICAgICAgICAgaWYgKEhUTUxJbWFnZUVsZW1lbnQqIGltYWdlRWxlbWVudCA9IGlzPEhUTUxJbWFn ZUVsZW1lbnQ+KGVsZW1lbnQoKSkgPyBkb3duY2FzdDxIVE1MSW1hZ2VFbGVtZW50PihlbGVtZW50 KCkpIDogbnVsbHB0cikKQEAgLTQ5Nyw3ICs0OTcsNyBAQCB2b2lkIFJlbmRlckltYWdlOjpwYWlu dFJlcGxhY2VkKFBhaW50SW5mbyYgcGFpbnRJbmZvLCBjb25zdCBMYXlvdXRQb2ludCYgcGFpbnRP ZgogCiAgICAgTGF5b3V0UmVjdCBjb250ZW50Qm94UmVjdCA9IHRoaXMtPmNvbnRlbnRCb3hSZWN0 KCk7CiAgICAgY29udGVudEJveFJlY3QubW92ZUJ5KHBhaW50T2Zmc2V0KTsKLSAgICBMYXlvdXRS ZWN0IHJlcGxhY2VkQ29udGVudFJlY3QgPSB0aGlzLT5yZXBsYWNlZENvbnRlbnRSZWN0KGludHJp bnNpY1NpemUoKSk7CisgICAgTGF5b3V0UmVjdCByZXBsYWNlZENvbnRlbnRSZWN0ID0gdGhpcy0+ cmVwbGFjZWRDb250ZW50UmVjdCgpOwogICAgIHJlcGxhY2VkQ29udGVudFJlY3QubW92ZUJ5KHBh aW50T2Zmc2V0KTsKICAgICBib29sIGNsaXAgPSAhY29udGVudEJveFJlY3QuY29udGFpbnMocmVw bGFjZWRDb250ZW50UmVjdCk7CiAgICAgR3JhcGhpY3NDb250ZXh0U3RhdGVTYXZlciBzdGF0ZVNh dmVyKGNvbnRleHQsIGNsaXApOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyQmFja2luZy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXJCYWNraW5nLmNwcAppbmRleCAxYzYyNTUxMWRlYWY3M2RjZmMxYjM3MWJmNzA1YjgwNzU3 NmVhYjFmLi4zNGFhZjg4ZDQ5NDFhZWU2NWI0ODhjMmVmOTZiODlhYzYzNTgwZjQwIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcApAQCAtMjM0 NCw3ICsyMzQ0LDcgQEAgTGF5b3V0UmVjdCBSZW5kZXJMYXllckJhY2tpbmc6OmNvbnRlbnRzQm94 KCkgY29uc3QKICNlbmRpZgogICAgIGlmIChpczxSZW5kZXJSZXBsYWNlZD4ocmVuZGVyQm94KSkg ewogICAgICAgICBSZW5kZXJSZXBsYWNlZCYgcmVuZGVyUmVwbGFjZWQgPSBkb3duY2FzdDxSZW5k ZXJSZXBsYWNlZD4ocmVuZGVyQm94KTsKLSAgICAgICAgY29udGVudHNSZWN0ID0gcmVuZGVyUmVw bGFjZWQucmVwbGFjZWRDb250ZW50UmVjdChyZW5kZXJCb3guaW50cmluc2ljU2l6ZSgpKTsKKyAg ICAgICAgY29udGVudHNSZWN0ID0gcmVuZGVyUmVwbGFjZWQucmVwbGFjZWRDb250ZW50UmVjdCgp OwogICAgIH0gZWxzZQogICAgICAgICBjb250ZW50c1JlY3QgPSByZW5kZXJCb3guY29udGVudEJv eFJlY3QoKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclJl cGxhY2VkLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUmVwbGFjZWQuaAppbmRl eCBhZTVkOTU0NDczZDg4ZjM0MDgyOGYzYjdiMDM5NDNhMGIxN2ZmZTE4Li4wZGUxNTI2YmFhMDNi MjQzMWFkYmMwNzhkMTI0YmE5NmVmZWQwYzc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyUmVwbGFjZWQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyUmVwbGFjZWQuaApAQCAtMzQsNiArMzQsNyBAQCBwdWJsaWM6CiAgICAgTGF5b3V0VW5p dCBjb21wdXRlUmVwbGFjZWRMb2dpY2FsSGVpZ2h0KHN0ZDo6b3B0aW9uYWw8TGF5b3V0VW5pdD4g ZXN0aW1hdGVkVXNlZFdpZHRoID0gc3RkOjpudWxsb3B0KSBjb25zdCBvdmVycmlkZTsKIAogICAg IExheW91dFJlY3QgcmVwbGFjZWRDb250ZW50UmVjdChjb25zdCBMYXlvdXRTaXplJiBpbnRyaW5z aWNTaXplKSBjb25zdDsKKyAgICBMYXlvdXRSZWN0IHJlcGxhY2VkQ29udGVudFJlY3QoKSBjb25z dCB7IHJldHVybiByZXBsYWNlZENvbnRlbnRSZWN0KGludHJpbnNpY1NpemUoKSk7IH0KIAogICAg IGJvb2wgaGFzUmVwbGFjZWRMb2dpY2FsV2lkdGgoKSBjb25zdDsKICAgICBib29sIGhhc1JlcGxh Y2VkTG9naWNhbEhlaWdodCgpIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL3NoYXBlcy9TaGFwZU91dHNpZGVJbmZvLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9zaGFwZXMvU2hhcGVPdXRzaWRlSW5mby5jcHAKaW5kZXggMjg2NmQ4MTM3MzE0NmMxNjNm MTMwYTM4Y2FhZTViYzY0NzI2OGRkYy4uMDFhYTg1NTNiZWExZGJhYjFhNmU3OTRmZTI0MDkyZGJk ZDYzYmVhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3NoYXBlcy9TaGFw ZU91dHNpZGVJbmZvLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc2hhcGVzL1No YXBlT3V0c2lkZUluZm8uY3BwCkBAIC0xNTEsNyArMTUxLDcgQEAgc3RkOjp1bmlxdWVfcHRyPFNo YXBlPiBTaGFwZU91dHNpZGVJbmZvOjpjcmVhdGVTaGFwZUZvckltYWdlKFN0eWxlSW1hZ2UqIHN0 eWxlSW0KIAogICAgIGNvbnN0IExheW91dFJlY3QmIG1hcmdpblJlY3QgPSBnZXRTaGFwZUltYWdl TWFyZ2luUmVjdChtX3JlbmRlcmVyLCBtX3JlZmVyZW5jZUJveExvZ2ljYWxTaXplKTsKICAgICBj b25zdCBMYXlvdXRSZWN0JiBpbWFnZVJlY3QgPSBpczxSZW5kZXJJbWFnZT4obV9yZW5kZXJlcikK LSAgICAgICAgPyBkb3duY2FzdDxSZW5kZXJJbWFnZT4obV9yZW5kZXJlcikucmVwbGFjZWRDb250 ZW50UmVjdChtX3JlbmRlcmVyLmludHJpbnNpY1NpemUoKSkKKyAgICAgICAgPyBkb3duY2FzdDxS ZW5kZXJJbWFnZT4obV9yZW5kZXJlcikucmVwbGFjZWRDb250ZW50UmVjdCgpCiAgICAgICAgIDog TGF5b3V0UmVjdChMYXlvdXRQb2ludCgpLCBpbWFnZVNpemUpOwogCiAgICAgQVNTRVJUKCFzdHls ZUltYWdlLT5pc1BlbmRpbmcoKSk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzFiYmY2NDNjZDNhZDA4MDBkNTQwMGRiNzA0 NmQxMWE4ZDk1Nzg2NS4uODczZGI1MzhiNWY3NTE4ZmI5YjgzOGQxYzdjODhiZDMxYzRmZWU3NyAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE4LTA3LTI0ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5m cmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEFuaW1hdGlvbiBzdG9wcyB3aXRoIG9iamVjdC1m aXQ6Y29udGFpbiBvbiBhbiBhbmltYXRlZCAyZCBjYW52YXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4Nzg0MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9yZXBhaW50L2NhbnZhcy1vYmplY3Qt Zml0LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9yZXBhaW50L2NhbnZhcy1v YmplY3QtZml0Lmh0bWw6IEFkZGVkLgorCiAyMDE4LTA3LTIwICBKb2huIFdpbGFuZGVyICA8d2ls YW5kZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJlc291cmNlIExvYWQgU3RhdGlzdGljczogRW5h YmxlIGJhc2ljIGZ1bmN0aW9uYWxpdHkgaW4gZXhwZXJpbWVudGFsIGRlYnVnIG1vZGUKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvcmVwYWludC9jYW52YXMtb2JqZWN0LWZpdC1leHBlY3Rl ZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L3JlcGFpbnQvY2FudmFzLW9iamVjdC1maXQtZXhwZWN0 ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLmJmNGZiNWFjZDA3OGMwMWQyNmE4M2M3YzQ0NDcyYzhmOWRiNmFh ZmEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3JlcGFpbnQvY2FudmFzLW9i amVjdC1maXQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMjEgQEAKKyAoR3JhcGhpY3NMYXllcgor ICAoYW5jaG9yIDAuMDAgMC4wMCkKKyAgKGJvdW5kcyA4MDAuMDAgNjAwLjAwKQorICAoY2hpbGRy ZW4gMQorICAgIChHcmFwaGljc0xheWVyCisgICAgICAoYm91bmRzIDgwMC4wMCA2MDAuMDApCisg ICAgICAoY29udGVudHNPcGFxdWUgMSkKKyAgICAgIChjaGlsZHJlbiAxCisgICAgICAgIChHcmFw aGljc0xheWVyCisgICAgICAgICAgKHBvc2l0aW9uIDguMDAgOC4wMCkKKyAgICAgICAgICAoYm91 bmRzIDIwMi4wMCAxMDIuMDApCisgICAgICAgICAgKGRyYXdzQ29udGVudCAxKQorICAgICAgICAg IChyZXBhaW50IHJlY3RzCisgICAgICAgICAgICAocmVjdCA3MC4wMCAyMC4wMCA3LjAwIDcuMDAp CisgICAgICAgICAgKQorICAgICAgICApCisgICAgICApCisgICAgKQorICApCispCisKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvcmVwYWludC9jYW52YXMtb2JqZWN0LWZpdC5odG1sIGIv TGF5b3V0VGVzdHMvZmFzdC9yZXBhaW50L2NhbnZhcy1vYmplY3QtZml0Lmh0bWwKbmV3IGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MC4uMWE1NTNmYzlkZWQyYjRkMDQ4Nzg4ZTllNDE4NThlNzZiM2MxOWU0MQotLS0gL2Rldi9udWxs CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcmVwYWludC9jYW52YXMtb2JqZWN0LWZpdC5odG1sCkBA IC0wLDAgKzEsNTAgQEAKKzwhLS0gVGVzdCBmb3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTQ2MzE5IC0tPgorPGhlYWQ+CisgICAgPHN0eWxlPgorICAgICAgICBjYW52 YXMgeworICAgICAgICAgICAgb2JqZWN0LWZpdDogY29udGFpbjsKKyAgICAgICAgICAgIGJvcmRl cjogMXB4IHNvbGlkIGJsYWNrOworICAgICAgICAgICAgd2lkdGg6IDIwMHB4OworICAgICAgICAg ICAgaGVpZ2h0OiAxMDBweDsKKyAgICAgICAgfQorICAgIDwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9k eT4KKyAgICA8Y2FudmFzIGlkPSJjYW52YXMiIHdpZHRoPSIyMDAiIGhlaWdodD0iMjAwIj48L2Nh bnZhcz4gCis8cHJlIGlkPSJsYXllcnMiPjwvcHJlPgorICAgIDxzY3JpcHQ+CisgICAgICAgIGlm ICh3aW5kb3cudGVzdFJ1bm5lcikgeworICAgICAgICAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0 KCk7CisgICAgICAgICAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKKyAgICAgICAgfQor ICAgICAgICAgICAgCisgICAgICAgIHZhciBjYW52YXMgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgnY2FudmFzJyk7CisgICAgICAgIHZhciBjdHggPSBjYW52YXMuZ2V0Q29udGV4dCgnMmQnKTsK KworICAgICAgICBjdHguZmlsbFN0eWxlID0gInJnYigwLCAxMjgsIDApIjsKKyAgICAgICAgY3R4 LmZpbGxSZWN0KDAsIDAsIDIwMCwgMjAwKTsKKyAgICAgICAgCisgICAgICAgIGZ1bmN0aW9uIHJl cGFpbnRUZXN0KCkKKyAgICAgICAgeworICAgICAgICAgICAgaWYgKHdpbmRvdy5pbnRlcm5hbHMp CisgICAgICAgICAgICAgICAgd2luZG93LmludGVybmFscy5zdGFydFRyYWNraW5nUmVwYWludHMo KTsKKworICAgICAgICAgICAgY3R4LmZpbGxTdHlsZSA9ICJyZ2IoMCwgMCwgMTI4KSI7CisgICAg ICAgICAgICBjdHguZmlsbFJlY3QoNDAsIDQwLCAxMCwgMTApOworCisgICAgICAgICAgICBpZiAo d2luZG93LmludGVybmFscykKKyAgICAgICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgnbGF5ZXJzJykudGV4dENvbnRlbnQgPSB3aW5kb3cuaW50ZXJuYWxzLmxheWVyVHJlZUFzVGV4 dChkb2N1bWVudCwgaW50ZXJuYWxzLkxBWUVSX1RSRUVfSU5DTFVERVNfUkVQQUlOVF9SRUNUUyk7 CisKKyAgICAgICAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgICAgICAgICB0 ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsKKyAgICAgICAgfQorICAgICAgICAKKyAgICAgICAgZnVu Y3Rpb24gc3RhcnRUZXN0KCkKKyAgICAgICAgeworICAgICAgICAgICAgc2V0VGltZW91dChmdW5j dGlvbigpIHsKKyAgICAgICAgICAgICAgICByZXBhaW50VGVzdCgpOworICAgICAgICAgICAgfSwg MCkKKyAgICAgICAgfQorICAgICAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcignbG9hZCcsIHN0 YXJ0VGVzdCwgZmFsc2UpOworICAgIDwvc2NyaXB0PgorPC9ib2R5Pgo=