18779 2008-04-28 02:45:14 -0700 REGRESSION(31916-31981): CanvasRenderingContext2D::drawImage no longer respects the srcRect 2008-04-28 11:18:48 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED HasReduction, Regression P1 Normal --- 1 oliver hyatt hyatt oliver oldest_to_newest 79103 0 oliver 2008-04-28 02:45:14 -0700 While trying to find the cause of another bug i found that we no longer drawImage correctly in the Canvas The issue appears to be that we no longer respect the srcRect (or at least not correctly) My money's on http://trac.webkit.org/changeset/31961 79104 1 20863 oliver 2008-04-28 02:50:49 -0700 Created attachment 20863 Test case This test case uses two canvases, in the invisible rect it draws a green square on a red background. It then draws the portion of that canvas into the other canvas, scaled to fill the entire canvas. In r31916 and before this works correctly, now the resultant image is a scaled down copy almost as though dst and src rects were reversed, although a quick tour down debugging lane would seem to imply that that is not the case. In fact it would appear that it may be Image::draw that is not handling the scaling correctly. 79147 2 20871 hyatt 2008-04-28 10:42:30 -0700 Created attachment 20871 Fix the argument reversal. Will land test case from bug. 79154 3 hyatt 2008-04-28 11:18:48 -0700 Fixed in r32651. 20863 2008-04-28 02:50:49 -0700 2008-04-28 02:50:49 -0700 Test case canvas-test.html text/html 588 oliver SWYgdGhpcyByZW5kZXJzIGNvcnJlY3RseSB5b3Ugc2hvdWxkIHNlZSBvbmUgYmlnIGZyaWVuZGx5 IGdyZWVuIHNxdWFyZS4KPGNhbnZhcyBpZD0iY2FudmFzIiB3aWR0aD0iMjAwIiBoZWlnaHQ9IjIw MCIgPjwvY2FudmFzPgo8Y2FudmFzIGlkPSJjYW52YXMyIiB3aWR0aD0iMjAwIiBoZWlnaHQ9IjIw MCIgc3R5bGU9ImRpc3BsYXk6bm9uZSIgPjwvY2FudmFzPgo8c2NyaXB0Pgp2YXIgY2FudmFzID0g ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNhbnZhcyIpOwp2YXIgY2FudmFzMiA9IGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJjYW52YXMyIik7CnZhciBjb250ZXh0ID0gY2FudmFzLmdldENvbnRl eHQoIjJkIik7CnZhciBjb250ZXh0MiA9IGNhbnZhczIuZ2V0Q29udGV4dCgiMmQiKTsKY29udGV4 dDIuZmlsbFN0eWxlID0gJ3JlZCc7CmNvbnRleHQyLmZpbGxSZWN0KDAsMCwyMDAsMjAwKTsKY29u dGV4dDIuZmlsbFN0eWxlID0gJ2dyZWVuJzsKY29udGV4dDIuZmlsbFJlY3QoNTAsNTAsMTAwLDEw MCk7CmNvbnRleHQuZHJhd0ltYWdlKGNhbnZhczIsIDUwLCA1MCwgMTAwLCAxMDAsIDAsIDAsIDIw MCwgMjAwKTsKPC9zY3JpcHQ+ 20871 2008-04-28 10:42:30 -0700 2008-04-28 10:48:52 -0700 Fix the argument reversal. patch.txt text/plain 554 hyatt SW5kZXg6IGh0bWwvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBo dG1sL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAJKHJldmlzaW9uIDMyNDA2KQorKysgaHRt bC9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05OTcsNyAr OTk3LDcgQEAgdm9pZCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OmRyYXdJbWFnZQogICAgICAg ICBtX2NhbnZhcy0+c2V0T3JpZ2luVGFpbnRlZCgpOwogCiAgICAgd2lsbERyYXcoZGVzdFJlY3Qp OwotICAgIGMtPmRyYXdJbWFnZShidWZmZXItPmltYWdlKCksIHNvdXJjZVJlY3QsIGRlc3RSZWN0 KTsKKyAgICBjLT5kcmF3SW1hZ2UoYnVmZmVyLT5pbWFnZSgpLCBkZXN0UmVjdCwgc291cmNlUmVj dCk7CiB9CiAKIC8vIEZJWE1FOiBXaHkgaXNuJ3QgdGhpcyBqdXN0IGFub3RoZXIgb3ZlcmxvYWQg b2YgZHJhd0ltYWdlPyBXaHkgaGF2ZSBhIGRpZmZlcmVudCBuYW1lPwo=