187707 2018-07-16 12:55:34 -0700 [ Sierra ] Layout Test http/tests/websocket/tests/hybi/websocket-cookie-overwrite-behavior.html is failing 2018-07-17 16:10:46 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 187541 P2 Normal --- 1 tsavell webkit-unassigned ap lforschler realdawei ryanhaddad wilander oldest_to_newest 1442481 0 tsavell 2018-07-16 12:55:34 -0700 The following layout tests is failing on Sierra WK2 http/tests/websocket/tests/hybi/websocket-cookie-overwrite-behavior.html http/tests/websocket/tests/hybi/websocket-allowed-setting-cookie-as-third-party.html Probable cause: After a change to the tests in r233830 <https://trac.webkit.org/changeset/233830/webkit> These two tests were constantly failing on Sierra WK2. We were advised to skip the test in bug: <https://bugs.webkit.org/show_bug.cgi?id=187541> by John Wilander due to "It's not setting the cookie for the third-party WebSocket so we're failing closed." Which is only an issue with Sierra. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fwebsocket-allowed-setting-cookie-as-third-party.html%20http%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fwebsocket-cookie-overwrite-behavior.html 1442499 1 345117 tsavell 2018-07-16 13:20:04 -0700 Created attachment 345117 Patch 1442510 2 wilander 2018-07-16 13:38:21 -0700 Looks good to me. Maybe add a comment that these are new tests and that they probably never passed on Sierra. 1442511 3 wilander 2018-07-16 13:38:55 -0700 *probably never would have passed on Sierra. 1442518 4 tsavell 2018-07-16 14:18:09 -0700 Taking patch out of commit queue due to other platforms having failures 1442825 5 ap 2018-07-17 15:55:49 -0700 We have other bugs about these, seems worth cleaning up so that there is no duplication. https://bugs.webkit.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&list_id=3912098&query_format=advanced&short_desc=websocket-cookie-overwrite%20websocket-allowed-setting-cookie-as-third-party&short_desc_type=anywordssubstr 1442835 6 tsavell 2018-07-17 16:10:46 -0700 *** This bug has been marked as a duplicate of bug 187541 *** 345117 2018-07-16 13:20:04 -0700 2018-07-16 14:15:29 -0700 Patch bug-187707-20180716132003.patch text/plain 1623 tsavell U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzODU4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODhhNWJiNGQwN2RmNTM5NTU3N2Iw ZTY5ZWVhNzYwNWI0ZTNjZTYxZC4uYmM0ZWQ3MzI1MmViZGY2MmEwZjc2YTUzNzQ3YjAzNDNiYjA2 ZGE2NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE4LTA3LTE2ICBUcnVpdHQgU2F2ZWxsICA8 dHNhdmVsbEBhcHBsZS5jb20+CisKKyAgICAgICAgWyBTaWVycmEgXSBMYXlvdXQgVGVzdCBodHRw L3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oeWJpL3dlYnNvY2tldC1jb29raWUtb3ZlcndyaXRlLWJl aGF2aW9yLmh0bWwgaXMgZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTg3NzA3CisKKyAgICAgICAgVW5yZXZpZXdlZCB0ZXN0IGdhcmRlbmlu Zy4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAx OC0wNy0xNiAgQWFyb24gQ2h1ICA8YWFyb25fY2h1QGFwcGxlLmNvbT4KIAogICAgICAgICBBWDog QXVkaXQgVGFiIHNob3VsZCBoYXZlIGFuIEF1ZGl0IE1hbmFnZXIKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9ucwppbmRleCAwOGM1MTJlYmM1ZGUzNTFiOGZh ZjM5YzhiZjA2ZjI0NDQ1NDI4YzVlLi4yZjMxMDk2MTZkMjA3NzdkMTRmODdjMWVhYWIzODg4ZjNm NGIwYTQxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBl Y3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRp b25zCkBAIC02NzksNiArNjc5LDkgQEAgd2Via2l0Lm9yZy9iLzE3MDk2MCBmYXN0L21lZGlhc3Ry ZWFtL2dldFVzZXJNZWRpYS13ZWJhdWRpby5odG1sIFsgUGFzcyBUaW1lb3V0IF0KIAogd2Via2l0 Lm9yZy9iLzE3MTU1MyBbIFJlbGVhc2UgXSBodHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oeWJp L2luc3BlY3Rvci9iaW5hcnkuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAKK3dlYmtpdC5vcmcvYi8x ODc3MDcgWyBTaWVycmEgXSBodHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oeWJpL3dlYnNvY2tl dC1jb29raWUtb3ZlcndyaXRlLWJlaGF2aW9yLmh0bWwgWyBTa2lwIF0KK3dlYmtpdC5vcmcvYi8x ODc3MDcgWyBTaWVycmEgXSBodHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oeWJpL3dlYnNvY2tl dC1hbGxvd2VkLXNldHRpbmctY29va2llLWFzLXRoaXJkLXBhcnR5Lmh0bWwgWyBTa2lwIF0KKwog d2Via2l0Lm9yZy9iLzE3MTc2MyBjb21wb3NpdGluZy90aWxpbmcvbm9uLWFjdGl2ZS13aW5kb3ct dGlsZXMtc2l6ZS5odG1sIFsgUGFzcyBGYWlsdXJlIF0KIAogd2Via2l0Lm9yZy9iLzE3MTgzNyBb IERlYnVnIF0gaHR0cC90ZXN0cy9zZWN1cml0eS9zdG9yYWdlLWJsb2NraW5nLWxvb3NlbmVkLXBs dWdpbi5odG1sIFsgUGFzcyBGYWlsdXJlIF0K