187674 2018-07-13 17:11:56 -0700 [ews-build] Add build step to run layout-test 2018-08-12 22:55:30 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=188498 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap ews-watchlist lforschler webkit-bug-importer oldest_to_newest 1442115 0 aakash_jain 2018-07-13 17:11:56 -0700 We should add support for running layout tests in OpenSource EWS Buildbot. 1442116 1 345006 aakash_jain 2018-07-13 17:15:43 -0700 Created attachment 345006 Proposed patch Adding the simple build step for running layout tests. This is quite similar to current EWS. Further enhancements like retrying layout-tests on failure, analyzing the results etc. would be in separate patch. 1442117 2 ews-watchlist 2018-07-13 17:18:14 -0700 Attachment 345006 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:730: [TestRunWebKitTests.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:730: [TestRunWebKitTests.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:744: [TestRunWebKitTests.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:744: [TestRunWebKitTests.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 4 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1442118 3 aakash_jain 2018-07-13 17:20:30 -0700 Style queue warnings are false positive. 1442213 4 aakash_jain 2018-07-14 09:23:48 -0700 Sample run: http://ews-build.webkit-uat.org/#/builders/11/builds/33 1443084 5 345006 lforschler 2018-07-18 11:33:23 -0700 Comment on attachment 345006 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=345006&action=review r=me, after considering typo fix. > Tools/BuildSlaveSupport/ews-build/steps.py:264 > + name = 'layout-test' should this be 'layout-tests' ? 1443094 6 aakash_jain 2018-07-18 11:42:07 -0700 Committed r233921: <https://trac.webkit.org/changeset/233921> 1443096 7 webkit-bug-importer 2018-07-18 11:43:20 -0700 <rdar://problem/42344602> 345006 2018-07-13 17:15:43 -0700 2018-07-18 11:33:23 -0700 Proposed patch ews_layout_tests.patch text/plain 5056 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzMzgyOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE4LTA3LTEzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBBZGQgYnVpbGQgc3RlcCB0byBydW4gbGF5b3V0LXRl c3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NzY3 NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVp bGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5OgorICAgICAgICAoUnVuV2ViS2l0VGVz dHMpOiBBZGRlZCBidWlsZCBzdGVwIHRvIHJ1biBsYXlvdXQtdGVzdHMuIFRoaXMgaXMgc2ltaWxh ciB0byBjdXJyZW50IEVXUy4KKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQv c3RlcHNfdW5pdHRlc3QucHk6IEFkZGVkIHVuaXQtdGVzdHMuCisgICAgICAgICogQnVpbGRTbGF2 ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllcy5weTogQWRkZWQgYnVpbGQtc3RlcCB0byBydW4g bGF5b3V0LXRlc3QgaW4gaU9TU2ltdWxhdG9yRmFjdG9yeS4KKwogMjAxOC0wNy0xMyAgVGltb3Ro eSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIF9kcmF3c0JhY2tn cm91bmQgdG8gV0tXZWJWaWV3Q29uZmlndXJhdGlvbi4KSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllcy5weQkocmV2aXNpb24gMjMzODI5KQorKysg VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllcy5weQkod29ya2luZyBj b3B5KQpAQCAtODgsNyArODgsOSBAQCBjbGFzcyBpT1NGYWN0b3J5KEJ1aWxkRmFjdG9yeSk6CiAK IAogY2xhc3MgaU9TU2ltdWxhdG9yRmFjdG9yeShCdWlsZEZhY3RvcnkpOgotICAgIHBhc3MKKyAg ICBkZWYgX19pbml0X18oc2VsZiwgcGxhdGZvcm0sIGNvbmZpZ3VyYXRpb249Tm9uZSwgYXJjaGl0 ZWN0dXJlcz1Ob25lLCBhZGRpdGlvbmFsQXJndW1lbnRzPU5vbmUsICoqa3dhcmdzKToKKyAgICAg ICAgQnVpbGRGYWN0b3J5Ll9faW5pdF9fKHNlbGYsIHBsYXRmb3JtLCBjb25maWd1cmF0aW9uLCBh cmNoaXRlY3R1cmVzLCBhZGRpdGlvbmFsQXJndW1lbnRzKQorICAgICAgICBzZWxmLmFkZFN0ZXAo UnVuV2ViS2l0VGVzdHMoKSkKIAogCiBjbGFzcyBNYWNXSzFGYWN0b3J5KEJ1aWxkRmFjdG9yeSk6 CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CShyZXZp c2lvbiAyMzM4MjkpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMu cHkJKHdvcmtpbmcgY29weSkKQEAgLTI1OCwzICsyNTgsMjkgQEAgY2xhc3MgS2lsbE9sZFByb2Nl c3NlcyhzaGVsbC5Db21waWxlKToKIAogICAgIGRlZiBfX2luaXRfXyhzZWxmLCAqKmt3YXJncyk6 CiAgICAgICAgIHN1cGVyKEtpbGxPbGRQcm9jZXNzZXMsIHNlbGYpLl9faW5pdF9fKHRpbWVvdXQ9 NjAsICoqa3dhcmdzKQorCisKK2NsYXNzIFJ1bldlYktpdFRlc3RzKHNoZWxsLlRlc3QpOgorICAg IG5hbWUgPSAnbGF5b3V0LXRlc3QnCisgICAgZGVzY3JpcHRpb24gPSBbJ2xheW91dC10ZXN0cyBy dW5uaW5nJ10KKyAgICBkZXNjcmlwdGlvbkRvbmUgPSBbJ2xheW91dC10ZXN0cyddCisgICAgcmVz dWx0RGlyZWN0b3J5ID0gJ2xheW91dC10ZXN0LXJlc3VsdHMnCisgICAgY29tbWFuZCA9IFsncHl0 aG9uJywgJ1Rvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cycsCisgICAgICAgICAgICAgICAn LS1uby1idWlsZCcsCisgICAgICAgICAgICAgICAnLS1uby1uZXctdGVzdC1yZXN1bHRzJywKKyAg ICAgICAgICAgICAgICctLW5vLXNob3ctcmVzdWx0cycsCisgICAgICAgICAgICAgICAnLS1leGl0 LWFmdGVyLW4tZmFpbHVyZXMnLCAnMzAnLAorICAgICAgICAgICAgICAgJy0tc2tpcC1mYWlsaW5n LXRlc3RzJywKKyAgICAgICAgICAgICAgIFdpdGhQcm9wZXJ0aWVzKCctLSUoY29uZmlndXJhdGlv bilzJyldCisKKyAgICBkZWYgc3RhcnQoc2VsZik6CisgICAgICAgIHBsYXRmb3JtID0gc2VsZi5n ZXRQcm9wZXJ0eSgncGxhdGZvcm0nKQorICAgICAgICBhcHBlbmRDdXN0b21CdWlsZEZsYWdzKHNl bGYsIHBsYXRmb3JtLCBzZWxmLmdldFByb3BlcnR5KCdmdWxsUGxhdGZvcm0nKSkKKyAgICAgICAg YWRkaXRpb25hbEFyZ3VtZW50cyA9IHNlbGYuZ2V0UHJvcGVydHkoJ2FkZGl0aW9uYWxBcmd1bWVu dHMnKQorCisgICAgICAgIHNlbGYuc2V0Q29tbWFuZChzZWxmLmNvbW1hbmQgKyBbJy0tcmVzdWx0 cy1kaXJlY3RvcnknLCBzZWxmLnJlc3VsdERpcmVjdG9yeV0pCisgICAgICAgIHNlbGYuc2V0Q29t bWFuZChzZWxmLmNvbW1hbmQgKyBbJy0tZGVidWctcnd0LWxvZ2dpbmcnXSkKKworICAgICAgICBp ZiBhZGRpdGlvbmFsQXJndW1lbnRzOgorICAgICAgICAgICAgc2VsZi5zZXRDb21tYW5kKHNlbGYu Y29tbWFuZCArIGFkZGl0aW9uYWxBcmd1bWVudHMpCisgICAgICAgIHJldHVybiBzaGVsbC5UZXN0 LnN0YXJ0KHNlbGYpCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3Rl cHNfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdz LWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyMzM4MjkpCisrKyBUb29scy9CdWls ZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkK QEAgLTcwOSw1ICs3MDksNDEgQEAgY2xhc3MgVGVzdFJ1bkphdmFTY3JpcHRDb3JlVGVzdHNUb1Qo QnVpbAogICAgICAgICByZXR1cm4gc2VsZi5ydW5TdGVwKCkKIAogCitjbGFzcyBUZXN0UnVuV2Vi S2l0VGVzdHMoQnVpbGRTdGVwTWl4aW5BZGRpdGlvbnMsIHVuaXR0ZXN0LlRlc3RDYXNlKToKKyAg ICBkZWYgc2V0VXAoc2VsZik6CisgICAgICAgIHNlbGYubG9uZ01lc3NhZ2UgPSBUcnVlCisgICAg ICAgIHJldHVybiBzZWxmLnNldFVwQnVpbGRTdGVwKCkKKworICAgIGRlZiB0ZWFyRG93bihzZWxm KToKKyAgICAgICAgcmV0dXJuIHNlbGYudGVhckRvd25CdWlsZFN0ZXAoKQorCisgICAgZGVmIHRl c3Rfc3VjY2VzcyhzZWxmKToKKyAgICAgICAgc2VsZi5zZXR1cFN0ZXAoUnVuV2ViS2l0VGVzdHMo KSkKKyAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnZnVsbFBsYXRmb3JtJywgJ2lvcy1zaW11bGF0 b3InKQorICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdjb25maWd1cmF0aW9uJywgJ3JlbGVhc2Un KQorICAgICAgICBzZWxmLmV4cGVjdFJlbW90ZUNvbW1hbmRzKAorICAgICAgICAgICAgRXhwZWN0 U2hlbGwod29ya2Rpcj0nd2tkaXInLAorICAgICAgICAgICAgICAgICAgICAgICAgY29tbWFuZD1b J3B5dGhvbicsICdUb29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMnLCAnLS1uby1idWlsZCcs ICctLW5vLW5ldy10ZXN0LXJlc3VsdHMnLCAnLS1uby1zaG93LXJlc3VsdHMnLCAnLS1leGl0LWFm dGVyLW4tZmFpbHVyZXMnLCAnMzAnLCAnLS1za2lwLWZhaWxpbmctdGVzdHMnLCAnLS1yZWxlYXNl JywgJy0tcmVzdWx0cy1kaXJlY3RvcnknLCAnbGF5b3V0LXRlc3QtcmVzdWx0cycsICctLWRlYnVn LXJ3dC1sb2dnaW5nJ10sCisgICAgICAgICAgICAgICAgICAgICAgICApCisgICAgICAgICAgICAr IDAsCisgICAgICAgICkKKyAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1TVUNDRVNT LCBzdGF0ZV9zdHJpbmc9J2xheW91dC10ZXN0cycpCisgICAgICAgIHJldHVybiBzZWxmLnJ1blN0 ZXAoKQorCisgICAgZGVmIHRlc3RfZmFpbHVyZShzZWxmKToKKyAgICAgICAgc2VsZi5zZXR1cFN0 ZXAoUnVuV2ViS2l0VGVzdHMoKSkKKyAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnZnVsbFBsYXRm b3JtJywgJ2lvcy1zaW11bGF0b3InKQorICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdjb25maWd1 cmF0aW9uJywgJ3JlbGVhc2UnKQorICAgICAgICBzZWxmLmV4cGVjdFJlbW90ZUNvbW1hbmRzKAor ICAgICAgICAgICAgRXhwZWN0U2hlbGwod29ya2Rpcj0nd2tkaXInLAorICAgICAgICAgICAgICAg ICAgICAgICAgY29tbWFuZD1bJ3B5dGhvbicsICdUb29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVz dHMnLCAnLS1uby1idWlsZCcsICctLW5vLW5ldy10ZXN0LXJlc3VsdHMnLCAnLS1uby1zaG93LXJl c3VsdHMnLCAnLS1leGl0LWFmdGVyLW4tZmFpbHVyZXMnLCAnMzAnLCAnLS1za2lwLWZhaWxpbmct dGVzdHMnLCAnLS1yZWxlYXNlJywgJy0tcmVzdWx0cy1kaXJlY3RvcnknLCAnbGF5b3V0LXRlc3Qt cmVzdWx0cycsICctLWRlYnVnLXJ3dC1sb2dnaW5nJ10sCisgICAgICAgICAgICAgICAgICAgICAg ICApCisgICAgICAgICAgICArIEV4cGVjdFNoZWxsLmxvZygnc3RkaW8nLCBzdGRvdXQ9JzkgZmFp bHVyZXMgZm91bmQuJykKKyAgICAgICAgICAgICsgMiwKKyAgICAgICAgKQorICAgICAgICBzZWxm LmV4cGVjdE91dGNvbWUocmVzdWx0PUZBSUxVUkUsIHN0YXRlX3N0cmluZz0nbGF5b3V0LXRlc3Rz IChmYWlsdXJlKScpCisgICAgICAgIHJldHVybiBzZWxmLnJ1blN0ZXAoKQorCisKIGlmIF9fbmFt ZV9fID09ICdfX21haW5fXyc6CiAgICAgdW5pdHRlc3QubWFpbigpCg==