187582 2018-07-12 00:03:34 -0700 Image is unexpectedly decoded 2018-11-16 05:35:05 -0800 1 1 1 Unclassified WebKit Images WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 191354 https://bugs.webkit.org/show_bug.cgi?id=170432 P2 Normal --- 1 yoshiaki.jitsukawa webkit-unassigned cgarcia clopez fujii magomez sabouhallawa simon.fraser oldest_to_newest 1441433 0 yoshiaki.jitsukawa 2018-07-12 00:03:34 -0700 JavaScript code like var img = new Image(); img.src = "foo.jpg"; unexpectedly gets the image decoded to a bitmap. I've confirmed that JPEGImageDecoder::decode() was called with onlySize == false, using the GTK port. The callstack is like as follows (Just a WebCore::Image::isNull() call caused decoding): WebCore::JPEGImageDecoder::decode(bool onlySize, bool allDataReceived) WebCore::JPEGImageDecoder::frameBufferAtIndex(size_t index) WebCore::ScalableImageDecoder::frameIsCompleteAtIndex(size_t index) WebCore::ImageSource::cacheMetadataAtIndex(size_t index, enum class WebCore::SubsamplingLevel subsamplingLevel, enum class WebCore::DecodingStatus decodingStatus) WebCore::ImageSource::frameAtIndexCacheIfNeeded(size_t index, enum class WebCore::ImageFrame::Caching caching, const std::optional<WebCore::SubsamplingLevel>& subsamplingLevel) WebCore::ImageSource::frameMetadataAtIndexCacheIfNeeded WebCore::ImageSource::size() WebCore::BitmapImage::size() WebCore::Image::isNull() 1441436 1 yoshiaki.jitsukawa 2018-07-12 00:12:54 -0700 I thought the "return m_decoder->size();" code would be taken: IntSize ImageSource::size() { #if !USE(CG) // It's possible that we have decoded the metadata, but not frame contents yet. In that case ImageDecoder claims to // have the size available, but the frame cache is empty. Return the decoder size without caching in such case. if (m_frames.isEmpty() && isDecoderAvailable()) return m_decoder->size(); #endif return frameMetadataAtIndexCacheIfNeeded<IntSize>(0, (&ImageFrame::size), &m_size, ImageFrame::Caching::Metadata, SubsamplingLevel::Default); } but actually m_frames was not empty because dataChanged() added a frame by growFrames() when EncodedDataStatus got to SizeAvailable EncodedDataStatus ImageSource::dataChanged(SharedBuffer* data, bool allDataReceived) { setData(data, allDataReceived); clearMetadata(); EncodedDataStatus status = encodedDataStatus(); if (status >= EncodedDataStatus::SizeAvailable) growFrames(); return status; } 1479363 2 fujii 2018-11-16 05:35:05 -0800 *** This bug has been marked as a duplicate of bug 191354 ***