<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>18757</bug_id>
          
          <creation_ts>2008-04-26 13:38:08 -0700</creation_ts>
          <short_desc>Add wxWebView::CanGoBack and CanGoForward methods</short_desc>
          <delta_ts>2008-04-27 22:41:27 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit wx</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Robin Dunn">robin</reporter>
          <assigned_to name="Kevin Ollivier">kevino</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>78980</commentid>
    <comment_count>0</comment_count>
    <who name="Robin Dunn">robin</who>
    <bug_when>2008-04-26 13:38:08 -0700</bug_when>
    <thetext>This is a patch that adds wxWebView::CanGoBack and CanGoForward methods</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>78981</commentid>
    <comment_count>1</comment_count>
      <attachid>20833</attachid>
    <who name="Robin Dunn">robin</who>
    <bug_when>2008-04-26 13:39:00 -0700</bug_when>
    <thetext>Created attachment 20833
patch for wxWebView</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>78993</commentid>
    <comment_count>2</comment_count>
      <attachid>20837</attachid>
    <who name="Robin Dunn">robin</who>
    <bug_when>2008-04-26 14:51:51 -0700</bug_when>
    <thetext>Created attachment 20837
removed SetTargetName

Removed the SetTargetName parts of the patch, they are part of another change.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>79084</commentid>
    <comment_count>3</comment_count>
    <who name="Kevin Ollivier">kevino</who>
    <bug_when>2008-04-27 22:41:27 -0700</bug_when>
    <thetext>Landed in r32607, thanks! Note that WebKit coding style guidelines don&apos;t add brackets for one-line if statements, but I see I did that in WebView.cpp myself, so I went ahead and cleaned it up.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>20833</attachid>
            <date>2008-04-26 13:39:00 -0700</date>
            <delta_ts>2008-04-26 14:51:51 -0700</delta_ts>
            <desc>patch for wxWebView</desc>
            <filename>webkit-webview-cango.patch</filename>
            <type>text/plain</type>
            <size>2018</size>
            <attacher name="Robin Dunn">robin</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC93eC9XZWJWaWV3LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3d4L1dlYlZp
ZXcuaAkocmV2aXNpb24gMzI1OTEpCisrKyBXZWJLaXQvd3gvV2ViVmlldy5oCSh3b3JraW5nIGNv
cHkpCkBAIC04MSw2ICs4MSw5IEBACiAgICAgYm9vbCBHb0ZvcndhcmQoKTsKICAgICB2b2lkIFN0
b3AoKTsKICAgICB2b2lkIFJlbG9hZCgpOworCisgICAgYm9vbCBDYW5Hb0JhY2soKTsKKyAgICBi
b29sIENhbkdvRm9yd2FyZCgpOwogICAgIAogICAgIGJvb2wgQ2FuQ3V0KCk7CiAgICAgYm9vbCBD
YW5Db3B5KCk7CkBAIC0yNDQsMTIgKzI0NywxNSBAQAogcHVibGljOgogICAgIHd4U3RyaW5nIEdl
dFVSTCgpIGNvbnN0IHsgcmV0dXJuIG1fdXJsOyB9CiAgICAgdm9pZCBTZXRVUkwoY29uc3Qgd3hT
dHJpbmcmIHVybCkgeyBtX3VybCA9IHVybDsgfQorICAgIHd4U3RyaW5nIEdldFRhcmdldE5hbWUo
KSBjb25zdCB7IHJldHVybiBtX3RhcmdldE5hbWU7IH0KKyAgICB2b2lkIFNldFRhcmdldE5hbWUo
Y29uc3Qgd3hTdHJpbmcmIG5hbWUpIHsgbV90YXJnZXROYW1lID0gbmFtZTsgfQogCiAgICAgd3hX
ZWJWaWV3TmV3V2luZG93RXZlbnQoIHd4V2luZG93KiB3aW4gPSBzdGF0aWNfY2FzdDx3eFdpbmRv
dyo+KE5VTEwpKTsKICAgICB3eEV2ZW50ICpDbG9uZSh2b2lkKSBjb25zdCB7IHJldHVybiBuZXcg
d3hXZWJWaWV3TmV3V2luZG93RXZlbnQoKnRoaXMpOyB9CiAKIHByaXZhdGU6CiAgICAgd3hTdHJp
bmcgbV91cmw7CisgICAgd3hTdHJpbmcgbV90YXJnZXROYW1lOwogfTsKIAogY2xhc3MgV1hETExJ
TVBFWFBfV0VCS0lUIHd4V2ViVmlld1JpZ2h0Q2xpY2tFdmVudCA6IHB1YmxpYyB3eENvbW1hbmRF
dmVudApJbmRleDogV2ViS2l0L3d4L1dlYlZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93
eC9XZWJWaWV3LmNwcAkocmV2aXNpb24gMzI1OTEpCisrKyBXZWJLaXQvd3gvV2ViVmlldy5jcHAJ
KHdvcmtpbmcgY29weSkKQEAgLTM1NCwxNCArMzU0LDMzIEBACiAgICAgaWYgKG1faW1wbC0+ZnJh
bWUgJiYgbV9pbXBsLT5mcmFtZS0+cGFnZSgpKSB7CiAgICAgICAgIHJldHVybiBtX2ltcGwtPmZy
YW1lLT5wYWdlKCktPmdvQmFjaygpOwogICAgIH0KKyAgICByZXR1cm4gZmFsc2U7CiB9CiAKIGJv
b2wgd3hXZWJWaWV3OjpHb0ZvcndhcmQoKQogewotICAgIGlmIChtX2ltcGwtPmZyYW1lICYmIG1f
aW1wbC0+ZnJhbWUtPnBhZ2UoKSkKKyAgICBpZiAobV9pbXBsLT5mcmFtZSAmJiBtX2ltcGwtPmZy
YW1lLT5wYWdlKCkpIHsKICAgICAgICAgcmV0dXJuIG1faW1wbC0+ZnJhbWUtPnBhZ2UoKS0+Z29G
b3J3YXJkKCk7CisgICAgfQorICAgIHJldHVybiBmYWxzZTsKIH0KIAorYm9vbCB3eFdlYlZpZXc6
OkNhbkdvQmFjaygpCit7CisgICAgaWYgKG1faW1wbC0+ZnJhbWUgJiYgbV9pbXBsLT5mcmFtZS0+
cGFnZSgpICYmIG1faW1wbC0+ZnJhbWUtPnBhZ2UoKS0+YmFja0ZvcndhcmRMaXN0KCkpIHsKKyAg
ICAgICAgcmV0dXJuIG1faW1wbC0+ZnJhbWUtPnBhZ2UoKS0+YmFja0ZvcndhcmRMaXN0KCktPmJh
Y2tJdGVtKCkgIT0gTlVMTDsKKyAgICB9CisgICAgcmV0dXJuIGZhbHNlOworfQorCitib29sIHd4
V2ViVmlldzo6Q2FuR29Gb3J3YXJkKCkKK3sKKyAgICBpZiAobV9pbXBsLT5mcmFtZSAmJiBtX2lt
cGwtPmZyYW1lLT5wYWdlKCkgJiYgbV9pbXBsLT5mcmFtZS0+cGFnZSgpLT5iYWNrRm9yd2FyZExp
c3QoKSkgeworICAgICAgICByZXR1cm4gbV9pbXBsLT5mcmFtZS0+cGFnZSgpLT5iYWNrRm9yd2Fy
ZExpc3QoKS0+Zm9yd2FyZEl0ZW0oKSAhPSBOVUxMOworICAgIH0KKyAgICByZXR1cm4gZmFsc2U7
Cit9CisKIGJvb2wgd3hXZWJWaWV3OjpDYW5JbmNyZWFzZVRleHRTaXplKCkgY29uc3QKIHsKICAg
ICBpZiAobV9pbXBsLT5mcmFtZSkgewo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>20837</attachid>
            <date>2008-04-26 14:51:51 -0700</date>
            <delta_ts>2008-04-27 22:40:31 -0700</delta_ts>
            <desc>removed SetTargetName</desc>
            <filename>webkit-webview-cango2.patch</filename>
            <type>text/plain</type>
            <size>1453</size>
            <attacher name="Robin Dunn">robin</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC93eC9XZWJWaWV3LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3d4L1dlYlZp
ZXcuaAkocmV2aXNpb24gMzI1OTIpCisrKyBXZWJLaXQvd3gvV2ViVmlldy5oCSh3b3JraW5nIGNv
cHkpCkBAIC04MSw2ICs4MSw5IEBACiAgICAgYm9vbCBHb0ZvcndhcmQoKTsKICAgICB2b2lkIFN0
b3AoKTsKICAgICB2b2lkIFJlbG9hZCgpOworCisgICAgYm9vbCBDYW5Hb0JhY2soKTsKKyAgICBi
b29sIENhbkdvRm9yd2FyZCgpOwogICAgIAogICAgIGJvb2wgQ2FuQ3V0KCk7CiAgICAgYm9vbCBD
YW5Db3B5KCk7CkluZGV4OiBXZWJLaXQvd3gvV2ViVmlldy5jcHAKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi
S2l0L3d4L1dlYlZpZXcuY3BwCShyZXZpc2lvbiAzMjU5MikKKysrIFdlYktpdC93eC9XZWJWaWV3
LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzU0LDE0ICszNTQsMzMgQEAKICAgICBpZiAobV9pbXBs
LT5mcmFtZSAmJiBtX2ltcGwtPmZyYW1lLT5wYWdlKCkpIHsKICAgICAgICAgcmV0dXJuIG1faW1w
bC0+ZnJhbWUtPnBhZ2UoKS0+Z29CYWNrKCk7CiAgICAgfQorICAgIHJldHVybiBmYWxzZTsKIH0K
IAogYm9vbCB3eFdlYlZpZXc6OkdvRm9yd2FyZCgpCiB7Ci0gICAgaWYgKG1faW1wbC0+ZnJhbWUg
JiYgbV9pbXBsLT5mcmFtZS0+cGFnZSgpKQorICAgIGlmIChtX2ltcGwtPmZyYW1lICYmIG1faW1w
bC0+ZnJhbWUtPnBhZ2UoKSkgewogICAgICAgICByZXR1cm4gbV9pbXBsLT5mcmFtZS0+cGFnZSgp
LT5nb0ZvcndhcmQoKTsKKyAgICB9CisgICAgcmV0dXJuIGZhbHNlOwogfQogCitib29sIHd4V2Vi
Vmlldzo6Q2FuR29CYWNrKCkKK3sKKyAgICBpZiAobV9pbXBsLT5mcmFtZSAmJiBtX2ltcGwtPmZy
YW1lLT5wYWdlKCkgJiYgbV9pbXBsLT5mcmFtZS0+cGFnZSgpLT5iYWNrRm9yd2FyZExpc3QoKSkg
eworICAgICAgICByZXR1cm4gbV9pbXBsLT5mcmFtZS0+cGFnZSgpLT5iYWNrRm9yd2FyZExpc3Qo
KS0+YmFja0l0ZW0oKSAhPSBOVUxMOworICAgIH0KKyAgICByZXR1cm4gZmFsc2U7Cit9CisKK2Jv
b2wgd3hXZWJWaWV3OjpDYW5Hb0ZvcndhcmQoKQoreworICAgIGlmIChtX2ltcGwtPmZyYW1lICYm
IG1faW1wbC0+ZnJhbWUtPnBhZ2UoKSAmJiBtX2ltcGwtPmZyYW1lLT5wYWdlKCktPmJhY2tGb3J3
YXJkTGlzdCgpKSB7CisgICAgICAgIHJldHVybiBtX2ltcGwtPmZyYW1lLT5wYWdlKCktPmJhY2tG
b3J3YXJkTGlzdCgpLT5mb3J3YXJkSXRlbSgpICE9IE5VTEw7CisgICAgfQorICAgIHJldHVybiBm
YWxzZTsKK30KKwogYm9vbCB3eFdlYlZpZXc6OkNhbkluY3JlYXNlVGV4dFNpemUoKSBjb25zdAog
ewogICAgIGlmIChtX2ltcGwtPmZyYW1lKSB7Cg==
</data>
<flag name="review"
          id="9115"
          type_id="1"
          status="+"
          setter="kevino"
    />
          </attachment>
      

    </bug>

</bugzilla>