187452 2018-07-08 14:50:23 -0700 run-benchmark should run ARES-6 1.0.1 2018-07-10 15:01:02 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo fpizlo commit-queue dean_johnson dewei_zhu ews-watchlist glenn lforschler saam sam webkit-bug-importer ysuzuki oldest_to_newest 1440264 0 fpizlo 2018-07-08 14:50:23 -0700 Patch forthcoming. 1440265 1 344552 fpizlo 2018-07-08 14:50:48 -0700 Created attachment 344552 the patch 1440266 2 344552 fpizlo 2018-07-08 14:51:17 -0700 Comment on attachment 344552 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=344552&action=review > Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:41 > + for key in os.environ: > + if key.startswith("__XPC_JSC"): > + env[key] = os.environ[key] > + Ooooops! Will revert. 1440267 3 ews-watchlist 2018-07-08 14:51:55 -0700 Attachment 344552 did not pass style-queue: ERROR: Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1440268 4 344553 fpizlo 2018-07-08 14:52:11 -0700 Created attachment 344553 the patch 1440269 5 344553 commit-queue 2018-07-08 16:18:54 -0700 Comment on attachment 344553 the patch Clearing flags on attachment: 344553 Committed r233631: <https://trac.webkit.org/changeset/233631> 1440270 6 commit-queue 2018-07-08 16:18:56 -0700 All reviewed patches have been landed. Closing bug. 1440271 7 webkit-bug-importer 2018-07-08 16:19:18 -0700 <rdar://problem/41954846> 1440461 8 saam 2018-07-09 11:11:19 -0700 Oops. Thanks for fixing this. We should keep an eye on the bots today as we should expect some change in results. 1440972 9 344553 dewei_zhu 2018-07-10 14:46:58 -0700 Comment on attachment 344553 the patch The same patch will be applied with some warnings: patching file driver.js Hunk #1 succeeded at 141 with fuzz 2 (offset 5 lines). patching file index.html I'll make a change to update the patch accoringly. 1440984 10 dewei_zhu 2018-07-10 15:01:02 -0700 Address in r233700. 344552 2018-07-08 14:50:48 -0700 2018-07-08 14:52:11 -0700 the patch blah.patch text/plain 2292 fpizlo SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzMzYzMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE4LTA3LTA4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisK KyAgICAgICAgTmVlZCBhIHNob3J0IGRlc2NyaXB0aW9uIChPT1BTISkuCisgICAgICAgIE5lZWQg dGhlIGJ1ZyBVUkwgKE9PUFMhKS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9icm93c2Vy X2RyaXZlci9vc3hfc2FmYXJpX2RyaXZlci5weToKKyAgICAgICAgKE9TWFNhZmFyaURyaXZlci5s YXVuY2hfdXJsKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2JlbmNobWFya19ydW5uZXIv ZGF0YS9wbGFucy9hcmVzNi5wbGFuOgorCiAyMDE4LTA3LTA3ICBZb3Vlbm4gRmFibGV0ICA8eW91 ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBXUFQgaW1wb3J0ZXIgc2hvdWxkIGNyZWF0ZSBkdW1t eSBIVE1MIGZpbGVzIGZvciAqLndpbmRvdy5qcyBzY3JpcHQgZmlsZXMKSW5kZXg6IFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9icm93c2VyX2RyaXZlci9vc3hfc2FmYXJp X2RyaXZlci5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2JlbmNobWFy a19ydW5uZXIvYnJvd3Nlcl9kcml2ZXIvb3N4X3NhZmFyaV9kcml2ZXIucHkJKHJldmlzaW9uIDIz MzQwNikKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9icm93c2Vy X2RyaXZlci9vc3hfc2FmYXJpX2RyaXZlci5weQkod29ya2luZyBjb3B5KQpAQCAtMzUsNiArMzUs MTAgQEAgY2xhc3MgT1NYU2FmYXJpRHJpdmVyKE9TWEJyb3dzZXJEcml2ZXIpOgogICAgICAgICAg ICAgZWxzZToKICAgICAgICAgICAgICAgICBfbG9nLmluZm8oJ0NvdWxkIG5vdCBmaW5kIFNhZmFy aS5hcHAgYXQgJXMsIHVzaW5nIHRoZSBzeXN0ZW0gU2FmYXJpIGluc3RlYWQnICUgc2FmYXJpX2Fw cF9pbl9idWlsZF9wYXRoKQogCisgICAgICAgIGZvciBrZXkgaW4gb3MuZW52aXJvbjoKKyAgICAg ICAgICAgIGlmIGtleS5zdGFydHN3aXRoKCJfX1hQQ19KU0MiKToKKyAgICAgICAgICAgICAgICBl bnZba2V5XSA9IG9zLmVudmlyb25ba2V5XQorCiAgICAgICAgIGFyZ3MuZXh0ZW5kKHNlbGYuX3Nh ZmFyaV9wcmVmZXJlbmNlcykKICAgICAgICAgX2xvZy5pbmZvKCdMYXVuY2hpbmcgc2FmYXJpOiAl cyB3aXRoIHVybDogJXMnICUgKGFyZ3NbMF0sIHVybCkpCiAgICAgICAgIHNlbGYuX3NhZmFyaV9w cm9jZXNzID0gT1NYU2FmYXJpRHJpdmVyLl9sYXVuY2hfcHJvY2Vzc193aXRoX2NhZmZpbmF0ZShh cmdzLCBlbnYpCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2JlbmNobWFya19ydW5uZXIv ZGF0YS9wbGFucy9hcmVzNi5wbGFuCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvYmVuY2htYXJrX3J1bm5lci9kYXRhL3BsYW5zL2FyZXM2LnBsYW4JKHJldmlzaW9uIDIzMzQw NikKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9kYXRhL3BsYW5z L2FyZXM2LnBsYW4JKHdvcmtpbmcgY29weSkKQEAgLTEsNyArMSw3IEBACiB7CiAgICAgInRpbWVv dXQiOiA2MDAsCiAgICAgImNvdW50IjogMywKLSAgICAic3ZuX3NvdXJjZSI6ICJodHRwczovL3N2 bi53ZWJraXQub3JnL3JlcG9zaXRvcnkvd2Via2l0L3RydW5rL1BlcmZvcm1hbmNlVGVzdHMvQVJF Uy02L0ByMjE2NTM4IiwKKyAgICAic3ZuX3NvdXJjZSI6ICJodHRwczovL3N2bi53ZWJraXQub3Jn L3JlcG9zaXRvcnkvd2Via2l0L3RydW5rL1BlcmZvcm1hbmNlVGVzdHMvQVJFUy02L0ByMjMzNDA2 IiwKICAgICAid2Vic2VydmVyX2JlbmNobWFya19wYXRjaCI6ICJkYXRhL3BhdGNoZXMvd2Vic2Vy dmVyL0FSRVMtNi5wYXRjaCIsCiAgICAgIndlYmRyaXZlcl9iZW5jaG1hcmtfcGF0Y2giOiAiZGF0 YS9wYXRjaGVzL3dlYmRyaXZlci9BUkVTLTYucGF0Y2giLAogICAgICJlbnRyeV9wb2ludCI6ICJp bmRleC5odG1sIiwK 344553 2018-07-08 14:52:11 -0700 2018-07-08 16:18:54 -0700 the patch blah.patch text/plain 1384 fpizlo SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzMzYzMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE4LTA3LTA4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisK KyAgICAgICAgcnVuLWJlbmNobWFyayBzaG91bGQgcnVuIEFSRVMtNiAxLjAuMQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3NDUyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBXZSBmb3Jnb3Qg dG8gdXBkYXRlIHRoaXMgd2hlbiB3ZSByZWxlYXNlZCAxLjAuMSEKKworICAgICAgICAqIFNjcmlw dHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9kYXRhL3BsYW5zL2FyZXM2LnBsYW46CisKIDIw MTgtMDctMDcgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFdQ VCBpbXBvcnRlciBzaG91bGQgY3JlYXRlIGR1bW15IEhUTUwgZmlsZXMgZm9yICoud2luZG93Lmpz IHNjcmlwdCBmaWxlcwpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVu bmVyL2RhdGEvcGxhbnMvYXJlczYucGxhbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dl YmtpdHB5L2JlbmNobWFya19ydW5uZXIvZGF0YS9wbGFucy9hcmVzNi5wbGFuCShyZXZpc2lvbiAy MzM0MDYpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2JlbmNobWFya19ydW5uZXIvZGF0YS9w bGFucy9hcmVzNi5wbGFuCSh3b3JraW5nIGNvcHkpCkBAIC0xLDcgKzEsNyBAQAogewogICAgICJ0 aW1lb3V0IjogNjAwLAogICAgICJjb3VudCI6IDMsCi0gICAgInN2bl9zb3VyY2UiOiAiaHR0cHM6 Ly9zdm4ud2Via2l0Lm9yZy9yZXBvc2l0b3J5L3dlYmtpdC90cnVuay9QZXJmb3JtYW5jZVRlc3Rz L0FSRVMtNi9AcjIxNjUzOCIsCisgICAgInN2bl9zb3VyY2UiOiAiaHR0cHM6Ly9zdm4ud2Via2l0 Lm9yZy9yZXBvc2l0b3J5L3dlYmtpdC90cnVuay9QZXJmb3JtYW5jZVRlc3RzL0FSRVMtNi9AcjIz MzQwNiIsCiAgICAgIndlYnNlcnZlcl9iZW5jaG1hcmtfcGF0Y2giOiAiZGF0YS9wYXRjaGVzL3dl YnNlcnZlci9BUkVTLTYucGF0Y2giLAogICAgICJ3ZWJkcml2ZXJfYmVuY2htYXJrX3BhdGNoIjog ImRhdGEvcGF0Y2hlcy93ZWJkcml2ZXIvQVJFUy02LnBhdGNoIiwKICAgICAiZW50cnlfcG9pbnQi OiAiaW5kZXguaHRtbCIsCg==