187437 2018-07-07 12:07:50 -0700 [JSC] Optimize layout of SymbolTable to reduce padding 2018-07-09 16:16:14 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki commit-queue ews-watchlist keith_miller mark.lam msaboff saam simon.fraser webkit-bug-importer oldest_to_newest 1440148 0 ysuzuki 2018-07-07 12:07:50 -0700 [JSC] Optimize layout of SymbolTable to reduce padding 1440149 1 344525 ysuzuki 2018-07-07 12:08:50 -0700 Created attachment 344525 Patch 1440156 2 344525 mark.lam 2018-07-07 12:58:06 -0700 Comment on attachment 344525 Patch r=me 1440165 3 344525 commit-queue 2018-07-07 13:29:44 -0700 Comment on attachment 344525 Patch Rejecting attachment 344525 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 344525, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=344525&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=187437&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 344525 from bug 187437. Fetching: https://bugs.webkit.org/attachment.cgi?id=344525 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/JavaScriptCore/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/JavaScriptCore/ChangeLog' is out of date W: 9275b13b53daac58e42e9cb6f9b6eaceea6bf497 and refs/remotes/origin/master differ, using rebase: :040000 040000 3791fe035b112bc47a3de7dea08c289b80d8040b d2d5b5667dcd84554ec6d384dbe77d5eeb0d8e5c M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/JavaScriptCore/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/JavaScriptCore/ChangeLog' is out of date W: 9275b13b53daac58e42e9cb6f9b6eaceea6bf497 and refs/remotes/origin/master differ, using rebase: :040000 040000 3791fe035b112bc47a3de7dea08c289b80d8040b d2d5b5667dcd84554ec6d384dbe77d5eeb0d8e5c M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit b9585f197cc..28ef0a0651a master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 233616 = b9585f197cca3cb59b51c5003895d1d34140a2f1 r233620 = 28ef0a0651af6a904f78aefd20ed11387d4095c8 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/8468693 1440168 4 344525 commit-queue 2018-07-07 13:46:35 -0700 Comment on attachment 344525 Patch Clearing flags on attachment: 344525 Committed r233622: <https://trac.webkit.org/changeset/233622> 1440169 5 commit-queue 2018-07-07 13:46:37 -0700 All reviewed patches have been landed. Closing bug. 1440170 6 webkit-bug-importer 2018-07-07 13:47:18 -0700 <rdar://problem/41934653> 1440235 7 simon.fraser 2018-07-08 09:43:00 -0700 I'm liking these padding optimizations. Are you using dump-class-layout? 1440240 8 ysuzuki 2018-07-08 09:54:09 -0700 (In reply to Simon Fraser (smfr) from comment #7) > I'm liking these padding optimizations. Are you using dump-class-layout? Yeah, I saw your nice optimizations, and I'm attempting to perform these things in JSC's long-live objects! 1440246 9 simon.fraser 2018-07-08 10:43:10 -0700 The most frequently-allocated JSC objects (that 'heap' shows with Malloc=1) are: JSC::DirectJITCode JSC::StructureStubClearingWatchpoint JSC::CodeBlockJettisoningWatchpoint JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint JSC::ProxyableAccessCase JSC::JITStubRoutine JSC::NativeJITCode JSC::AccessCase JSC::GCAwareJITStubRoutine JSC::GetterSetterAccessCase JSC::StringSourceProvider JSC::FunctionRareData::AllocationProfileClearingWatchpoint JSC::WeakGCMap<std::__1::pair<WTF::UniquedStringImpl* JSC::DFG::AdaptiveInferredPropertyValueWatchpoint JSC::DFG::JITCode JSC::DFG::AdaptiveStructureWatchpoint so these are good targets for padding optimizations. 1440376 10 ysuzuki 2018-07-09 07:09:34 -0700 (In reply to Simon Fraser (smfr) from comment #9) > The most frequently-allocated JSC objects (that 'heap' shows with Malloc=1) > are: > > JSC::DirectJITCode > JSC::StructureStubClearingWatchpoint > JSC::CodeBlockJettisoningWatchpoint > JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint > JSC::ProxyableAccessCase > JSC::JITStubRoutine > JSC::NativeJITCode > JSC::AccessCase > JSC::GCAwareJITStubRoutine > JSC::GetterSetterAccessCase > JSC::StringSourceProvider > JSC::FunctionRareData::AllocationProfileClearingWatchpoint > JSC::WeakGCMap<std::__1::pair<WTF::UniquedStringImpl* > JSC::DFG::AdaptiveInferredPropertyValueWatchpoint > JSC::DFG::JITCode > JSC::DFG::AdaptiveStructureWatchpoint > > so these are good targets for padding optimizations. That's nice! A bit unfortunate thing is that Instruments cannot get type information if the object does not have vtable pointer (runtime type information). Is there any way to annotate allocation to inform the object lifetimes to Instruments (like, API to map address to name for Instruments)? If we have such annotations, it is quite useful. 1440562 11 simon.fraser 2018-07-09 14:43:50 -0700 (In reply to Yusuke Suzuki from comment #10) > Is there any way to annotate allocation to inform the object lifetimes to > Instruments (like, API to map address to name for Instruments)? > If we have such annotations, it is quite useful. I don't know of any, sadly. 1440609 12 saam 2018-07-09 16:16:14 -0700 Maybe we could artificially give things we're interested in a VTable just for profiling purposes in some special build mode? 344525 2018-07-07 12:08:50 -0700 2018-07-07 13:46:35 -0700 Patch bug-187437-20180708040849.patch text/plain 1961 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzNjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 ZjBjZGMxMDQzNWZhMzQ1MWE5OWQyMTY0NGRiMmI3MWIwN2UyNzAwLi4yMWYxYjY5N2JiNDA4YTBh NWM5OGQzNDMzZTA3ZWM0NTMzZTBhMTc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxOC0wNy0wNyAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXSBPcHRpbWl6ZSBsYXlvdXQgb2YgU3ltYm9sVGFibGUgdG8g cmVkdWNlIHBhZGRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE4NzQzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFycmFuZ2UgdGhlIGxheW91dCBvZiBTeW1ib2xUYWJsZSB0byByZWR1Y2UgdGhlIHNp emUgZnJvbSA4OCB0byA3Mi4KKworICAgICAgICAqIHJ1bnRpbWUvU3ltYm9sVGFibGUuaDoKKwog MjAxOC0wNy0wNSAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBQ cm9ncmFtRXhlY3V0YWJsZSBtYXkgYmUgY29sbGVjdGVkIGFzIHdlIGNoZWNrU3ludGF4IG9uIGl0 CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TeW1ib2xUYWJsZS5o IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3ltYm9sVGFibGUuaAppbmRleCAzNDJh ZjJlZTA0MGJkMzY2NzcxN2VkYTM3YTJkOWI0MTg4MjEwNmNmLi45MTU3ZDViODI5MjAwZmI2YTk2 NWVhM2JjNzg2OTZlNTMyYTkyYjk1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9TeW1ib2xUYWJsZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L1N5bWJvbFRhYmxlLmgKQEAgLTY5Niw2ICs2OTYsMTIgQEAgY2xhc3MgU3ltYm9sVGFibGUgZmlu YWwgOiBwdWJsaWMgSlNDZWxsIHsKIAogICAgIE1hcCBtX21hcDsKICAgICBTY29wZU9mZnNldCBt X21heFNjb3BlT2Zmc2V0OworcHVibGljOgorICAgIG11dGFibGUgQ29uY3VycmVudEpTTG9jayBt X2xvY2s7Citwcml2YXRlOgorICAgIHVuc2lnbmVkIG1fdXNlc05vblN0cmljdEV2YWwgOiAxOwor ICAgIHVuc2lnbmVkIG1fbmVzdGVkTGV4aWNhbFNjb3BlIDogMTsgLy8gTm9uLWZ1bmN0aW9uIExl eGljYWxTY29wZS4KKyAgICB1bnNpZ25lZCBtX3Njb3BlVHlwZSA6IDM7IC8vIFNjb3BlVHlwZQog ICAgIAogICAgIHN0cnVjdCBTeW1ib2xUYWJsZVJhcmVEYXRhIHsKICAgICAgICAgVW5pcXVlSURN YXAgbV91bmlxdWVJRE1hcDsKQEAgLTcwNSwxNyArNzExLDEwIEBAIGNsYXNzIFN5bWJvbFRhYmxl IGZpbmFsIDogcHVibGljIEpTQ2VsbCB7CiAgICAgfTsKICAgICBzdGQ6OnVuaXF1ZV9wdHI8U3lt Ym9sVGFibGVSYXJlRGF0YT4gbV9yYXJlRGF0YTsKIAotICAgIGJvb2wgbV91c2VzTm9uU3RyaWN0 RXZhbCA6IDE7Ci0gICAgYm9vbCBtX25lc3RlZExleGljYWxTY29wZSA6IDE7IC8vIE5vbi1mdW5j dGlvbiBMZXhpY2FsU2NvcGUuCi0gICAgdW5zaWduZWQgbV9zY29wZVR5cGUgOiAzOyAvLyBTY29w ZVR5cGUKLSAgICAKICAgICBXcml0ZUJhcnJpZXI8U2NvcGVkQXJndW1lbnRzVGFibGU+IG1fYXJn dW1lbnRzOwogICAgIFdyaXRlQmFycmllcjxJbmZlcnJlZFZhbHVlPiBtX3NpbmdsZXRvblNjb3Bl OwogICAgIAogICAgIHN0ZDo6dW5pcXVlX3B0cjxMb2NhbFRvRW50cnlWZWM+IG1fbG9jYWxUb0Vu dHJ5OwotCi1wdWJsaWM6Ci0gICAgbXV0YWJsZSBDb25jdXJyZW50SlNMb2NrIG1fbG9jazsKIH07 CiAKIH0gLy8gbmFtZXNwYWNlIEpTQwo=