187363 2018-07-05 14:40:08 -0700 iPad: Scrolling with hardware keyboard while SELECT popover is visible scrolls the page, detaches popover 2019-03-21 12:13:37 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=196102 InRadar P2 Normal --- 1 obarnett webkit-unassigned commit-queue megan_gardner thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1439561 0 obarnett 2018-07-05 14:40:08 -0700 iPad: Scrolling with hardware keyboard while SELECT popover is visible scrolls the page, detaches popover 1439562 1 344368 obarnett 2018-07-05 14:41:37 -0700 Created attachment 344368 Patch 1439571 2 344368 thorton 2018-07-05 14:51:33 -0700 Comment on attachment 344368 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344368&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3686 > + if (_assistedNodeInformation.elementType != InputType::Select) { I don't think this is quite right, because pageup/pagedown and spacebar will still scroll. Instead, I think you should bail at the top of the function similar to what we do in the isContentEditable case. 1439592 3 344374 obarnett 2018-07-05 15:29:08 -0700 Created attachment 344374 Patch 1439628 4 344374 thorton 2018-07-05 17:12:12 -0700 Comment on attachment 344374 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344374&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3645 > + if (_assistedNodeInformation.elementType == InputType::Select) We probably want to add other types to this list (are there other kinds of assisted nodes that use popovers?), but this is a good start. 1439643 5 344374 commit-queue 2018-07-05 17:40:29 -0700 Comment on attachment 344374 Patch Clearing flags on attachment: 344374 Committed r233553: <https://trac.webkit.org/changeset/233553> 1439644 6 commit-queue 2018-07-05 17:40:31 -0700 All reviewed patches have been landed. Closing bug. 1439646 7 webkit-bug-importer 2018-07-05 17:41:19 -0700 <rdar://problem/41872234> 344368 2018-07-05 14:41:37 -0700 2018-07-05 15:29:06 -0700 Patch bug-187363-20180705144136.patch text/plain 2360 obarnett U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg5NmNiMDRiOWM4ZGFiMDFm NTc5NWI1NDNiNmYzN2RjYjEzN2Q5NGQuLmM3NzU4NWU3MTc2ZTkxYmFjNWRkZTA5NDkzMTFiZTdm NWQ4OGM0MTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDctMDUgIE9saXZpYSBC YXJuZXR0ICA8b2Jhcm5ldHRAYXBwbGUuY29tPgorCisgICAgICAgIGlQYWQ6IFNjcm9sbGluZyB3 aXRoIGhhcmR3YXJlIGtleWJvYXJkIHdoaWxlIFNFTEVDVCBwb3BvdmVyIGlzIHZpc2libGUgc2Ny b2xscyB0aGUgcGFnZSwgZGV0YWNoZXMgcG9wb3ZlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3MzYzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80 MTEwNjMwNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGRlZCBleHRyYSBjaGVjayB0byBwcmV2ZW50IGtleWJvYXJkIHNjcm9sbGluZyB3aGVuIHRo ZSBzZWxlY3QgYm94IGlzIG9wZW4uCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVu dFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfc2Nyb2xsT2Zm c2V0Rm9yRXZlbnQ6XSk6CisKIDIwMTgtMDYtMjYgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBh cHBsZS5jb20+CiAKICAgICAgICAgUHJvdmlkZSBhIHdheSBmb3IgSW5qZWN0ZWQgQnVuZGxlcyB0 byBpbmRpY2F0ZSBjbGFzc2VzIGFwcHJvdmVkIGZvciBOU1NlY3VyZUNvZGluZwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5t bSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24u bW0KaW5kZXggN2ZjMmUxYzY3NmRjYWIyMTM2ZDNkOTdlYzNjNDVhMTcxODE5NDNiNC4uOWEzNTFk OTc0NjVmYWMwZmQyZGVkMGRkNWY5NDI3NWUwNTFkNTM4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC0z NjgzLDExICszNjgzLDEyIEBAIHN0YXRpYyBOU1N0cmluZyAqY29udGVudFR5cGVGcm9tRmllbGRO YW1lKFdlYkNvcmU6OkF1dG9maWxsRmllbGROYW1lIGZpZWxkTmFtZSkKICAgICAgICAgaW5jcmVt ZW50Rm9yVmVydGljYWxBcnJvd0tleSA9IFBhZ2U7CiAgICAgZWxzZSBpZiAoZXZlbnQubW9kaWZp ZXJGbGFncyAmIFdlYkV2ZW50RmxhZ01hc2tDb21tYW5kKQogICAgICAgICBpbmNyZW1lbnRGb3JW ZXJ0aWNhbEFycm93S2V5ID0gRG9jdW1lbnQ7Ci0gICAgaWYgKFtjaGFyYWN0ZXJzSWdub3JpbmdN b2RpZmllcnMgaXNFcXVhbFRvU3RyaW5nOlVJS2V5SW5wdXRVcEFycm93XSkKLSAgICAgICAgcmV0 dXJuIGNvbXB1dGVPZmZzZXQoaW5jcmVtZW50Rm9yVmVydGljYWxBcnJvd0tleSwgVXApOwotICAg IGlmIChbY2hhcmFjdGVyc0lnbm9yaW5nTW9kaWZpZXJzIGlzRXF1YWxUb1N0cmluZzpVSUtleUlu cHV0RG93bkFycm93XSkKLSAgICAgICAgcmV0dXJuIGNvbXB1dGVPZmZzZXQoaW5jcmVtZW50Rm9y VmVydGljYWxBcnJvd0tleSwgRG93bik7Ci0KKyAgICBpZiAoX2Fzc2lzdGVkTm9kZUluZm9ybWF0 aW9uLmVsZW1lbnRUeXBlICE9IElucHV0VHlwZTo6U2VsZWN0KSB7CisgICAgICAgIGlmIChbY2hh cmFjdGVyc0lnbm9yaW5nTW9kaWZpZXJzIGlzRXF1YWxUb1N0cmluZzpVSUtleUlucHV0VXBBcnJv d10pCisgICAgICAgICAgICByZXR1cm4gY29tcHV0ZU9mZnNldChpbmNyZW1lbnRGb3JWZXJ0aWNh bEFycm93S2V5LCBVcCk7CisgICAgICAgIGlmIChbY2hhcmFjdGVyc0lnbm9yaW5nTW9kaWZpZXJz IGlzRXF1YWxUb1N0cmluZzpVSUtleUlucHV0RG93bkFycm93XSkKKyAgICAgICAgICAgIHJldHVy biBjb21wdXRlT2Zmc2V0KGluY3JlbWVudEZvclZlcnRpY2FsQXJyb3dLZXksIERvd24pOworICAg IH0KICAgICBpZiAoW2NoYXJhY3RlcnNJZ25vcmluZ01vZGlmaWVycyBpc0VxdWFsVG9TdHJpbmc6 VUlLZXlJbnB1dFBhZ2VEb3duXSkKICAgICAgICAgcmV0dXJuIGNvbXB1dGVPZmZzZXQoUGFnZSwg RG93bik7CiAgICAgaWYgKFtjaGFyYWN0ZXJzSWdub3JpbmdNb2RpZmllcnMgaXNFcXVhbFRvU3Ry aW5nOlVJS2V5SW5wdXRQYWdlVXBdKQo= 344374 2018-07-05 15:29:08 -0700 2018-07-05 17:40:29 -0700 Patch bug-187363-20180705152908.patch text/plain 1664 obarnett U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg5NmNiMDRiOWM4ZGFiMDFm NTc5NWI1NDNiNmYzN2RjYjEzN2Q5NGQuLmM3NzU4NWU3MTc2ZTkxYmFjNWRkZTA5NDkzMTFiZTdm NWQ4OGM0MTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDctMDUgIE9saXZpYSBC YXJuZXR0ICA8b2Jhcm5ldHRAYXBwbGUuY29tPgorCisgICAgICAgIGlQYWQ6IFNjcm9sbGluZyB3 aXRoIGhhcmR3YXJlIGtleWJvYXJkIHdoaWxlIFNFTEVDVCBwb3BvdmVyIGlzIHZpc2libGUgc2Ny b2xscyB0aGUgcGFnZSwgZGV0YWNoZXMgcG9wb3ZlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3MzYzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80 MTEwNjMwNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGRlZCBleHRyYSBjaGVjayB0byBwcmV2ZW50IGtleWJvYXJkIHNjcm9sbGluZyB3aGVuIHRo ZSBzZWxlY3QgYm94IGlzIG9wZW4uCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVu dFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfc2Nyb2xsT2Zm c2V0Rm9yRXZlbnQ6XSk6CisKIDIwMTgtMDYtMjYgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBh cHBsZS5jb20+CiAKICAgICAgICAgUHJvdmlkZSBhIHdheSBmb3IgSW5qZWN0ZWQgQnVuZGxlcyB0 byBpbmRpY2F0ZSBjbGFzc2VzIGFwcHJvdmVkIGZvciBOU1NlY3VyZUNvZGluZwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5t bSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24u bW0KaW5kZXggN2ZjMmUxYzY3NmRjYWIyMTM2ZDNkOTdlYzNjNDVhMTcxODE5NDNiNC4uNmYzOGE5 OWM1YTk0ZWEyZTQwYzgzZTE5Yjk5MzQwNzEyMGRhZTY3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC0z NjQxLDYgKzM2NDEsOSBAQCBzdGF0aWMgTlNTdHJpbmcgKmNvbnRlbnRUeXBlRnJvbUZpZWxkTmFt ZShXZWJDb3JlOjpBdXRvZmlsbEZpZWxkTmFtZSBmaWVsZE5hbWUpCiAKICAgICBpZiAoX3BhZ2Ut PmVkaXRvclN0YXRlKCkuaXNDb250ZW50RWRpdGFibGUpCiAgICAgICAgIHJldHVybiBzdGQ6Om51 bGxvcHQ7CisgICAgCisgICAgaWYgKF9hc3Npc3RlZE5vZGVJbmZvcm1hdGlvbi5lbGVtZW50VHlw ZSA9PSBJbnB1dFR5cGU6OlNlbGVjdCkKKyAgICAgICAgcmV0dXJuIHN0ZDo6bnVsbG9wdDsKIAog ICAgIE5TU3RyaW5nICpjaGFyYWN0ZXJzSWdub3JpbmdNb2RpZmllcnMgPSBldmVudC5jaGFyYWN0 ZXJzSWdub3JpbmdNb2RpZmllcnM7CiAgICAgaWYgKCFjaGFyYWN0ZXJzSWdub3JpbmdNb2RpZmll cnMubGVuZ3RoKQo=