187360 2018-07-05 13:05:33 -0700 Fix iOS crash when starting loads with no active DocumentLoader 2019-07-08 11:19:32 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=199580 InRadar P2 Normal --- 1 achristensen achristensen aestes beidson cdumez dbates ews-watchlist ggaren japhet webkit-bug-importer oldest_to_newest 1439509 0 achristensen 2018-07-05 13:05:33 -0700 Fix iOS crash when starting loads with no active DocumentLoader 1439510 1 344355 achristensen 2018-07-05 13:09:06 -0700 Created attachment 344355 Patch 1439545 2 344355 dbates 2018-07-05 14:07:02 -0700 Comment on attachment 344355 Patch Can you please give an example (even better a test case since this is crash) of when m_documentLoader is null when this function is called? ResourceLoader assumes we always have a non-null pointer to a document loader unless it explicitly nullified it in ResourceLoader::releaseResources(). I mean, even in this function, we assume a non-null m_documentLoader when we ASSERT(!m_documentLoader->isSubstituteLoadPending(this)) at the top of this function. 1439546 3 achristensen 2018-07-05 14:08:23 -0700 I can't reproduce this. I'm only reading logs. 1439554 4 dbates 2018-07-05 14:16:14 -0700 (In reply to Alex Christensen from comment #3) > I can't reproduce this. I'm only reading logs. I take it is not straightforward to read the code and look at the callers and/or use a debugger to try to piece together a scenario that explains the crash? Are you able to post the crash report? Maybe we can leverage more minds to help identify the cause. 1439555 5 dbates 2018-07-05 14:17:11 -0700 <rdar://problem/29389084> 1545461 6 ggaren 2019-06-17 16:37:19 -0700 We do generally accept crash fixes for top crashes based on field data, even if we only have a limited understanding of the data. So, I'm inclined to say r+. That said, I do agree that it's surprising, and probably bad style, to null-check m_documentLoader after having used m_documentLoader. Alex, could you put the null check at the top of the function, with an explicit comment linking to a bug report, explaining the m_documentLoader is not expected to be null, but is observed to be in some crash reports? 1545468 7 372294 achristensen 2019-06-17 16:58:00 -0700 Created attachment 372294 Patch 1545475 8 372294 ggaren 2019-06-17 17:09:34 -0700 Comment on attachment 372294 Patch r=me Side note: should we really call cancel() here? cancel() seems to dereference m_documentLoader, so we might just move the crash point. 1545481 9 achristensen 2019-06-17 17:15:12 -0700 http://trac.webkit.org/r246525 344355 2018-07-05 13:09:06 -0700 2019-06-17 16:57:59 -0700 Patch bug-187360-20180705130905.patch text/plain 1583 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMzUzNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA3LTA1ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGlPUyBj cmFzaCB3aGVuIHN0YXJ0aW5nIGxvYWRzIHdpdGggbm8gYWN0aXZlIERvY3VtZW50TG9hZGVyCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODczNjAKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI5Mzg5MDg0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gRnJhbWVMb2FkZXI6OmFjdGl2ZURvY3VtZW50 TG9hZGVyIHJldHVybnMgbnVsbCBpbiB0aGUgUmVzb3VyY2VMb2FkZXIgY29uc3RydWN0b3IsCisg ICAgICAgIG9uIGlPUyB3ZSB3aWxsIGRlcmVmZXJlbmNlIGl0IHRvIGFzayBpZiBpdCBoYXMgYSBm cmFtZSBpbiBhbiBlYXJseSByZXR1cm4gaW4gaW5pdC4KKyAgICAgICAgTGV0J3Mgbm90LiAgSWYg d2UgZG9uJ3QgaGF2ZSBhIERvY3VtZW50TG9hZGVyLCB3ZSBkb24ndCBoYXZlIGEgZnJhbWUgYW5k IHNob3VsZCBmYWlsLgorCisgICAgICAgICogbG9hZGVyL1Jlc291cmNlTG9hZGVyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJlc291cmNlTG9hZGVyOjppbml0KToKKwogMjAxOC0wNy0wNSAgRXJp YyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBWaWRlbyBzb21l dGltZXMgZmxpY2tlcnMgd2hlbiBwbGF5aW5nIHRvIEFwcGxlVFYKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2xvYWRlci9SZXNvdXJjZUxvYWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvbG9hZGVyL1Jlc291cmNlTG9hZGVyLmNwcAkocmV2aXNpb24gMjMzNTIxKQorKysgU291cmNl L1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTIz LDcgKzEyMyw3IEBAIHZvaWQgUmVzb3VyY2VMb2FkZXI6OmluaXQoUmVzb3VyY2VSZXF1ZXMKICNp ZiBQTEFURk9STShJT1MpCiAgICAgLy8gSWYgdGhlIGRvY3VtZW50TG9hZGVyIHdhcyBkZXRhY2hl ZCB3aGlsZSB0aGlzIFJlc291cmNlTG9hZGVyIHdhcyB3YWl0aW5nIGl0cyB0dXJuCiAgICAgLy8g aW4gUmVzb3VyY2VMb2FkU2NoZWR1bGVyIHF1ZXVlLCBkb24ndCBjb250aW51ZS4KLSAgICBpZiAo IW1fZG9jdW1lbnRMb2FkZXItPmZyYW1lKCkpIHsKKyAgICBpZiAoIW1fZG9jdW1lbnRMb2FkZXIg fHwgIW1fZG9jdW1lbnRMb2FkZXItPmZyYW1lKCkpIHsKICAgICAgICAgY2FuY2VsKCk7CiAgICAg ICAgIHJldHVybiBjb21wbGV0aW9uSGFuZGxlcihmYWxzZSk7CiAgICAgfQo= 372294 2019-06-17 16:58:00 -0700 2019-06-17 17:09:34 -0700 Patch bug-187360-20190617165759.patch text/plain 1978 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0NjUyMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE5LTA2LTE3ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGlPUyBj cmFzaCB3aGVuIHN0YXJ0aW5nIGxvYWRzIHdpdGggbm8gYWN0aXZlIERvY3VtZW50TG9hZGVyCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODczNjAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIEZyYW1l TG9hZGVyOjphY3RpdmVEb2N1bWVudExvYWRlciByZXR1cm5zIG51bGwgaW4gdGhlIFJlc291cmNl TG9hZGVyIGNvbnN0cnVjdG9yLAorICAgICAgICBvbiBpT1Mgd2Ugd2lsbCBkZXJlZmVyZW5jZSBp dCB0byBhc2sgaWYgaXQgaGFzIGEgZnJhbWUgaW4gYW4gZWFybHkgcmV0dXJuIGluIGluaXQuCisg ICAgICAgIExldCdzIG5vdC4gIElmIHdlIGRvbid0IGhhdmUgYSBEb2N1bWVudExvYWRlciwgd2Ug ZG9uJ3QgaGF2ZSBhIGZyYW1lIGFuZCBzaG91bGQgZmFpbC4KKworICAgICAgICBDcmFzaCByZXBv cnRzIGluZGljYXRlIHRoaXMgY3Jhc2ggaXMgcmVsYXRlZCB0byBCZWFjb24gYW5kIG90aGVyIHVz ZXMgb2YgTG9hZGVyU3RyYXRlZ3k6OnN0YXJ0UGluZ0xvYWQsCisgICAgICAgIGJ1dCBhdHRlbXB0 cyB0byBtYWtlIGEgdW5pdCB0ZXN0IHRvIHJlcHJvZHVjZSB0aGUgY3Jhc2ggd2VyZSB1bnN1Y2Nl c3NmdWwuCisKKyAgICAgICAgKiBsb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6UmVzb3VyY2VMb2FkZXI6OmluaXQpOgorCiAyMDE5LTA2LTE3ICBSb2JpbiBNb3Jp c3NldCAgPHJtb3Jpc3NldEBhcHBsZS5jb20+CiAKICAgICAgICAgW1dITFNMXSBSZW1vdmUgYmFj a3RyYWNraW5nIGZyb20gcGFyc2VBdHRyaWJ1dGVCbG9jawpJbmRleDogU291cmNlL1dlYkNvcmUv bG9hZGVyL1Jlc291cmNlTG9hZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9s b2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwCShyZXZpc2lvbiAyNDY1MTYpCisrKyBTb3VyY2UvV2Vi Q29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTksNiAr MTE5LDE1IEBAIHZvaWQgUmVzb3VyY2VMb2FkZXI6OnJlbGVhc2VSZXNvdXJjZXMoKQogCiB2b2lk IFJlc291cmNlTG9hZGVyOjppbml0KFJlc291cmNlUmVxdWVzdCYmIGNsaWVudFJlcXVlc3QsIENv bXBsZXRpb25IYW5kbGVyPHZvaWQoYm9vbCk+JiYgY29tcGxldGlvbkhhbmRsZXIpCiB7CisjaWYg UExBVEZPUk0oSU9TX0ZBTUlMWSkKKyAgICBpZiAoIW1fZG9jdW1lbnRMb2FkZXIpIHsKKyAgICAg ICAgLy8gV2Ugc2hvdWxkIGFsd2F5cyBoYXZlIGEgRG9jdW1lbnRMb2FkZXIgYXQgdGhpcyBwb2lu dCwgYnV0IGNyYXNoIHJlcG9ydHMgaW5kaWNhdGUgdGhhdCBpdCBpcyBzb21ldGltZXMgbnVsbC4K KyAgICAgICAgLy8gU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x ODczNjAKKyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgIGNhbmNlbCgpOwor ICAgICAgICByZXR1cm4gY29tcGxldGlvbkhhbmRsZXIoZmFsc2UpOworICAgIH0KKyNlbmRpZgog ICAgIEFTU0VSVCghbV9oYW5kbGUpOwogICAgIEFTU0VSVChtX3JlcXVlc3QuaXNOdWxsKCkpOwog ICAgIEFTU0VSVChtX2RlZmVycmVkUmVxdWVzdC5pc051bGwoKSk7Cg==