18735 2008-04-24 23:22:40 -0700 SQUIRRELFISH: closures are sometimes given an incorrect 'this' value when called 2008-04-24 23:50:29 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 18624 1 zwarich webkit-unassigned oldest_to_newest 78880 0 zwarich 2008-04-24 23:22:40 -0700 Consider the following example: --- var text = "PASS"; function a() { var text = "FAIL"; function b() { alert(this.text); } this.c = function() { b(); } b(); } (new a()).c(); --- This code should print PASS twice, but instead prints PASS once and then FAIL. This affects the JavaScriptCore test js1_5/Scope/scope-003.js. 78881 1 20812 zwarich 2008-04-24 23:28:01 -0700 Created attachment 20812 Proposed patch This patch fixes js1_5/Scope/scope-003.js, and it also fixes ecma/String/15.5.4.6-2.js. 78882 2 20813 zwarich 2008-04-24 23:32:06 -0700 Created attachment 20813 Revised proposed patch The ecma/String/15.5.4.6-2.js fix doesn't seem legitimate, so I modified the ChangeLog to reflect this. 78883 3 zwarich 2008-04-24 23:41:47 -0700 (In reply to comment #2) > Created an attachment (id=20813) [edit] > Revised proposed patch SunSpider shows no change for this patch. 78884 4 20813 ggaren 2008-04-24 23:45:36 -0700 Comment on attachment 20813 Revised proposed patch r=me 78885 5 ggaren 2008-04-24 23:48:19 -0700 Committed revision 32536. 78886 6 zwarich 2008-04-24 23:50:29 -0700 Upon further review, this patch really did legitimately fix that test case after all. 20812 2008-04-24 23:28:01 -0700 2008-04-24 23:32:06 -0700 Proposed patch scope.diff text/plain 1708 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDMyNTMz KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDgtMDQt MjQgIENhbWVyb24gWndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDE4NzM1OiBTUVVJUlJF TEZJU0g6IGNsb3N1cmVzIGFyZSBzb21ldGltZXMgZ2l2ZW4gYW4gaW5jb3JyZWN0ICd0aGlzJyB2 YWx1ZSB3aGVuIGNhbGxlZAorICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4NzM1PgorCisgICAgICAgIFRoZSBvdmVybG9hZGVkIHRvVGhpc09iamVjdCBt ZXRob2Qgd2FzIG5vdCBjb3BpZWQgb3ZlciB0byBKU0FjdGl2YXRpb24uCisKKyAgICAgICAgRml4 ZXMgMiBtb3JlIHJlZ3Jlc3Npb24gdGVzdHMuCisKKyAgICAgICAgKiBranMvSlNBY3RpdmF0aW9u LmNwcDoKKyAgICAgICAgKEtKUzo6SlNBY3RpdmF0aW9uOjp0b1RoaXNPYmplY3QpOgorICAgICAg ICAqIGtqcy9KU0FjdGl2YXRpb24uaDoKKwogMjAwOC0wNC0yNCAgT2xpdmVyIEh1bnQgIDxvbGl2 ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llai4KSW5kZXg6IGtqcy9K U0FjdGl2YXRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGtqcy9KU0FjdGl2YXRpb24uY3BwCShyZXZp c2lvbiAzMjUzMykKKysrIGtqcy9KU0FjdGl2YXRpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x MjEsNiArMTIxLDExIEBAIGJvb2wgSlNBY3RpdmF0aW9uOjpkZWxldGVQcm9wZXJ0eShFeGVjU3QK ICAgICByZXR1cm4gQmFzZTo6ZGVsZXRlUHJvcGVydHkoZXhlYywgcHJvcGVydHlOYW1lKTsKIH0K IAorSlNPYmplY3QqIEpTQWN0aXZhdGlvbjo6dG9UaGlzT2JqZWN0KEV4ZWNTdGF0ZSogZXhlYykg Y29uc3QKK3sKKyAgICByZXR1cm4gZXhlYy0+Z2xvYmFsVGhpc1ZhbHVlKCk7Cit9CisKIHZvaWQg SlNBY3RpdmF0aW9uOjptYXJrKCkKIHsKICAgICBCYXNlOjptYXJrKCk7CkluZGV4OiBranMvSlNB Y3RpdmF0aW9uLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0ga2pzL0pTQWN0aXZhdGlvbi5oCShyZXZpc2lvbiAz MjUzMykKKysrIGtqcy9KU0FjdGl2YXRpb24uaAkod29ya2luZyBjb3B5KQpAQCAtNTIsNiArNTIs OCBAQCBuYW1lc3BhY2UgS0pTIHsKICAgICAgICAgdmlydHVhbCB2b2lkIHB1dFdpdGhBdHRyaWJ1 dGVzKEV4ZWNTdGF0ZSosIGNvbnN0IElkZW50aWZpZXImLCBKU1ZhbHVlKiwgdW5zaWduZWQgYXR0 cmlidXRlcyk7CiAgICAgICAgIHZpcnR1YWwgYm9vbCBkZWxldGVQcm9wZXJ0eShFeGVjU3RhdGUq LCBjb25zdCBJZGVudGlmaWVyJiBwcm9wZXJ0eU5hbWUpOwogCisgICAgICAgIHZpcnR1YWwgSlNP YmplY3QqIHRvVGhpc09iamVjdChFeGVjU3RhdGUqKSBjb25zdDsKKwogICAgICAgICB2aXJ0dWFs IHZvaWQgbWFyaygpOwogICAgICAgICAKICAgICAgICAgdm9pZCBjb3B5UmVnaXN0ZXJzKCk7Cg== 20813 2008-04-24 23:32:06 -0700 2008-04-24 23:45:36 -0700 Revised proposed patch scope.diff text/plain 1765 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDMyNTMz KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDgtMDQt MjQgIENhbWVyb24gWndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDE4NzM1OiBTUVVJUlJF TEZJU0g6IGNsb3N1cmVzIGFyZSBzb21ldGltZXMgZ2l2ZW4gYW4gaW5jb3JyZWN0ICd0aGlzJyB2 YWx1ZSB3aGVuIGNhbGxlZAorICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4NzM1PgorCisgICAgICAgIFRoZSBvdmVybG9hZGVkIHRvVGhpc09iamVjdCBt ZXRob2Qgd2FzIG5vdCBjb3BpZWQgb3ZlciB0byBKU0FjdGl2YXRpb24uCisKKyAgICAgICAgTGVn aXRpbWF0ZWx5IGZpeGVzIGEgcmVncmVzc2lvbiB0ZXN0LCBidXQgYWxzbyBsZXRzIGFub3RoZXIg dGVzdCBwYXNzIHRoYXQgc2hvdWxkIGZhaWwuCisKKyAgICAgICAgKiBranMvSlNBY3RpdmF0aW9u LmNwcDoKKyAgICAgICAgKEtKUzo6SlNBY3RpdmF0aW9uOjp0b1RoaXNPYmplY3QpOgorICAgICAg ICAqIGtqcy9KU0FjdGl2YXRpb24uaDoKKwogMjAwOC0wNC0yNCAgT2xpdmVyIEh1bnQgIDxvbGl2 ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llai4KSW5kZXg6IGtqcy9K U0FjdGl2YXRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGtqcy9KU0FjdGl2YXRpb24uY3BwCShyZXZp c2lvbiAzMjUzMykKKysrIGtqcy9KU0FjdGl2YXRpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x MjEsNiArMTIxLDExIEBAIGJvb2wgSlNBY3RpdmF0aW9uOjpkZWxldGVQcm9wZXJ0eShFeGVjU3QK ICAgICByZXR1cm4gQmFzZTo6ZGVsZXRlUHJvcGVydHkoZXhlYywgcHJvcGVydHlOYW1lKTsKIH0K IAorSlNPYmplY3QqIEpTQWN0aXZhdGlvbjo6dG9UaGlzT2JqZWN0KEV4ZWNTdGF0ZSogZXhlYykg Y29uc3QKK3sKKyAgICByZXR1cm4gZXhlYy0+Z2xvYmFsVGhpc1ZhbHVlKCk7Cit9CisKIHZvaWQg SlNBY3RpdmF0aW9uOjptYXJrKCkKIHsKICAgICBCYXNlOjptYXJrKCk7CkluZGV4OiBranMvSlNB Y3RpdmF0aW9uLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0ga2pzL0pTQWN0aXZhdGlvbi5oCShyZXZpc2lvbiAz MjUzMykKKysrIGtqcy9KU0FjdGl2YXRpb24uaAkod29ya2luZyBjb3B5KQpAQCAtNTIsNiArNTIs OCBAQCBuYW1lc3BhY2UgS0pTIHsKICAgICAgICAgdmlydHVhbCB2b2lkIHB1dFdpdGhBdHRyaWJ1 dGVzKEV4ZWNTdGF0ZSosIGNvbnN0IElkZW50aWZpZXImLCBKU1ZhbHVlKiwgdW5zaWduZWQgYXR0 cmlidXRlcyk7CiAgICAgICAgIHZpcnR1YWwgYm9vbCBkZWxldGVQcm9wZXJ0eShFeGVjU3RhdGUq LCBjb25zdCBJZGVudGlmaWVyJiBwcm9wZXJ0eU5hbWUpOwogCisgICAgICAgIHZpcnR1YWwgSlNP YmplY3QqIHRvVGhpc09iamVjdChFeGVjU3RhdGUqKSBjb25zdDsKKwogICAgICAgICB2aXJ0dWFs IHZvaWQgbWFyaygpOwogICAgICAgICAKICAgICAgICAgdm9pZCBjb3B5UmVnaXN0ZXJzKCk7Cg==