187331 2018-07-04 14:01:19 -0700 [ews-build] WebKitPy-Tests-EWS should output result in json 2018-09-07 10:56:10 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=187148 https://bugs.webkit.org/show_bug.cgi?id=189417 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap ddkilzer lforschler webkit-bug-importer oldest_to_newest 1439275 0 aakash_jain 2018-07-04 14:01:19 -0700 WebKitPy-Tests-EWS should output result in json format. This would be useful in easily parsing the errors. 1439276 1 344300 aakash_jain 2018-07-04 14:04:40 -0700 Created attachment 344300 Proposed patch Sample run: http://ews-build.webkit-uat.org/#/builders/16/builds/26 1439433 2 344300 ddkilzer 2018-07-05 10:19:02 -0700 Comment on attachment 344300 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=344300&action=review r=me > Tools/BuildSlaveSupport/ews-build/steps_unittest.py:313 > + command=['Tools/Scripts/test-webkitpy', '--json-output=webkitpy_test_results.json'], > + logfiles={'json': 'webkitpy_test_results.json'}, Nit: Don't repeat yourself by extracting `jsonFileName` variable as is done in steps.py. > Tools/BuildSlaveSupport/ews-build/steps_unittest.py:326 > + command=['Tools/Scripts/test-webkitpy', '--json-output=webkitpy_test_results.json'], > + logfiles={'json': 'webkitpy_test_results.json'}, Nit: Don't repeat yourself by extracting `jsonFileName` variable as is done in steps.py. 1439437 3 aakash_jain 2018-07-05 10:25:43 -0700 (In reply to David Kilzer (:ddkilzer) from comment #2) > Nit: Don't repeat yourself by extracting `jsonFileName` variable as is done > in steps.py. Sure, will re-use the variable. 1439438 4 aakash_jain 2018-07-05 10:26:51 -0700 Committed r233527: <https://trac.webkit.org/changeset/233527>. 1439439 5 webkit-bug-importer 2018-07-05 10:34:44 -0700 <rdar://problem/41853334> 1439465 6 aakash_jain 2018-07-05 11:38:17 -0700 Committed r233528. 344300 2018-07-04 14:04:40 -0700 2018-07-05 10:19:02 -0700 Proposed patch ews_json_webkitpy.patch text/plain 2811 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzMzUwOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE4LTA3LTA0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBXZWJLaXRQeS1UZXN0cy1FV1Mgc2hvdWxkIG91dHB1 dCByZXN1bHQgaW4ganNvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTg3MzMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisgICAgICAg IChSdW5XZWJLaXRQeVRlc3RzKTogUGFzc2VkIC0tanNvbi1vdXRwdXQgcGFyYW1ldGVyIHRvIHRl c3Qtd2Via2l0cHkuCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBz X3VuaXR0ZXN0LnB5OiBVcGRhdGVkIHVuaXQtdGVzdHMuCisKIDIwMTgtMDctMDQgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgSW50cm9kdWNlIFBMQVRG T1JNKElPU01BQykKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVw cy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3Rl cHMucHkJKHJldmlzaW9uIDIzMzUwOSkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1i dWlsZC9zdGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAtOTgsNyArOTgsOSBAQCBjbGFzcyBSdW5X ZWJLaXRQeVRlc3RzKHNoZWxsLlNoZWxsQ29tbWFuCiAgICAgZGVzY3JpcHRpb24gPSBbJ3dlYmtp dHB5LXRlc3RzIHJ1bm5pbmcnXQogICAgIGRlc2NyaXB0aW9uRG9uZSA9IFsnd2Via2l0cHktdGVz dHMnXQogICAgIGZsdW5rT25GYWlsdXJlID0gVHJ1ZQotICAgIGNvbW1hbmQgPSBbJ1Rvb2xzL1Nj cmlwdHMvdGVzdC13ZWJraXRweSddCisgICAganNvbkZpbGVOYW1lID0gJ3dlYmtpdHB5X3Rlc3Rf cmVzdWx0cy5qc29uJworICAgIGxvZ2ZpbGVzID0geydqc29uJzoganNvbkZpbGVOYW1lfQorICAg IGNvbW1hbmQgPSBbJ1Rvb2xzL1NjcmlwdHMvdGVzdC13ZWJraXRweScsICctLWpzb24tb3V0cHV0 PXswfScuZm9ybWF0KGpzb25GaWxlTmFtZSldCiAKICAgICBkZWYgX19pbml0X18oc2VsZiwgKipr d2FyZ3MpOgogICAgICAgICBzdXBlcihSdW5XZWJLaXRQeVRlc3RzLCBzZWxmKS5fX2luaXRfXyh0 aW1lb3V0PTIgKiA2MCwgKiprd2FyZ3MpCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9l d3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyMzM1MDkpCisr KyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkJKHdv cmtpbmcgY29weSkKQEAgLTMwOSw3ICszMDksOCBAQCBjbGFzcyBUZXN0V2ViS2l0UHlUZXN0cyhC dWlsZFN0ZXBNaXhpbkFkCiAgICAgICAgIHNlbGYuc2V0dXBTdGVwKFJ1bldlYktpdFB5VGVzdHMo KSkKICAgICAgICAgc2VsZi5leHBlY3RSZW1vdGVDb21tYW5kcygKICAgICAgICAgICAgIEV4cGVj dFNoZWxsKHdvcmtkaXI9J3drZGlyJywKLSAgICAgICAgICAgICAgICAgICAgICAgIGNvbW1hbmQ9 WydUb29scy9TY3JpcHRzL3Rlc3Qtd2Via2l0cHknXSwKKyAgICAgICAgICAgICAgICAgICAgICAg IGNvbW1hbmQ9WydUb29scy9TY3JpcHRzL3Rlc3Qtd2Via2l0cHknLCAnLS1qc29uLW91dHB1dD13 ZWJraXRweV90ZXN0X3Jlc3VsdHMuanNvbiddLAorICAgICAgICAgICAgICAgICAgICAgICAgbG9n ZmlsZXM9eydqc29uJzogJ3dlYmtpdHB5X3Rlc3RfcmVzdWx0cy5qc29uJ30sCiAgICAgICAgICAg ICAgICAgICAgICAgICB0aW1lb3V0PTEyMCwKICAgICAgICAgICAgICAgICAgICAgICAgICkKICAg ICAgICAgICAgICsgMCwKQEAgLTMyMSw3ICszMjIsOCBAQCBjbGFzcyBUZXN0V2ViS2l0UHlUZXN0 cyhCdWlsZFN0ZXBNaXhpbkFkCiAgICAgICAgIHNlbGYuc2V0dXBTdGVwKFJ1bldlYktpdFB5VGVz dHMoKSkKICAgICAgICAgc2VsZi5leHBlY3RSZW1vdGVDb21tYW5kcygKICAgICAgICAgICAgIEV4 cGVjdFNoZWxsKHdvcmtkaXI9J3drZGlyJywKLSAgICAgICAgICAgICAgICAgICAgICAgIGNvbW1h bmQ9WydUb29scy9TY3JpcHRzL3Rlc3Qtd2Via2l0cHknXSwKKyAgICAgICAgICAgICAgICAgICAg ICAgIGNvbW1hbmQ9WydUb29scy9TY3JpcHRzL3Rlc3Qtd2Via2l0cHknLCAnLS1qc29uLW91dHB1 dD13ZWJraXRweV90ZXN0X3Jlc3VsdHMuanNvbiddLAorICAgICAgICAgICAgICAgICAgICAgICAg bG9nZmlsZXM9eydqc29uJzogJ3dlYmtpdHB5X3Rlc3RfcmVzdWx0cy5qc29uJ30sCiAgICAgICAg ICAgICAgICAgICAgICAgICB0aW1lb3V0PTEyMCwKICAgICAgICAgICAgICAgICAgICAgICAgICkK ICAgICAgICAgICAgICsgRXhwZWN0U2hlbGwubG9nKCdzdGRpbycsIHN0ZG91dD0nJydSYW4gMTc0 NCB0ZXN0cyBpbiA1LjkxM3MK