187330 2018-07-04 13:56:45 -0700 [ews-build] Bindings-tests-EWS should output result in json 2018-09-07 10:54:39 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=187014 https://bugs.webkit.org/show_bug.cgi?id=189417 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap ddkilzer lforschler webkit-bug-importer oldest_to_newest 1439273 0 aakash_jain 2018-07-04 13:56:45 -0700 Bindings-tests-EWS should output result in json. This would be useful in easily parsing the errors. 1439274 1 344299 aakash_jain 2018-07-04 14:00:03 -0700 Created attachment 344299 Proposed patch Sample run: http://ews-build.webkit-uat.org/#/builders/14/builds/22 1439432 2 344299 ddkilzer 2018-07-05 10:18:25 -0700 Comment on attachment 344299 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=344299&action=review r=me > Tools/BuildSlaveSupport/ews-build/steps_unittest.py:244 > + command=['Tools/Scripts/run-bindings-tests', '--json-output=bindings_test_results.json'], > + logfiles={'json': 'bindings_test_results.json'}, Nit: Don't repeat yourself by extracting `jsonFileName` variable as is done in steps.py. > Tools/BuildSlaveSupport/ews-build/steps_unittest.py:256 > + command=['Tools/Scripts/run-bindings-tests', '--json-output=bindings_test_results.json'], > + logfiles={'json': 'bindings_test_results.json'}, Nit: Don't repeat yourself by extracting `jsonFileName` variable as is done in steps.py. 1439463 3 aakash_jain 2018-07-05 11:36:58 -0700 Committed r233531: <https://trac.webkit.org/changeset/233531>. 1439464 4 webkit-bug-importer 2018-07-05 11:37:20 -0700 <rdar://problem/41856838> 344299 2018-07-04 14:00:03 -0700 2018-07-05 10:18:25 -0700 Proposed patch ews_json_bindings.patch text/plain 2745 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzMzUwOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE4LTA3LTA0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBCaW5kaW5ncy10ZXN0cy1FV1Mgc2hvdWxkIG91dHB1 dCByZXN1bHQgaW4ganNvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTg3MzMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisgICAgICAg IChSdW5CaW5kaW5nc1Rlc3RzKTogUGFzc2VkIC0tanNvbi1vdXRwdXQgcGFyYW1ldGVyIHRvIHJ1 bi1iaW5kaW5ncy10ZXN0cy4KKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQv c3RlcHNfdW5pdHRlc3QucHk6IFVwZGF0ZWQgdW5pdC10ZXN0cy4KKwogMjAxOC0wNy0wNCAgVGlt IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBJbnRyb2R1Y2Ug UExBVEZPUk0oSU9TTUFDKQpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxk L3N0ZXBzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWls ZC9zdGVwcy5weQkocmV2aXNpb24gMjMzNTA5KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv ZXdzLWJ1aWxkL3N0ZXBzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC03OSw3ICs3OSw5IEBAIGNsYXNz IFJ1bkJpbmRpbmdzVGVzdHMoc2hlbGwuU2hlbGxDb21tYW4KICAgICBkZXNjcmlwdGlvbiA9IFsn YmluZGluZ3MtdGVzdHMgcnVubmluZyddCiAgICAgZGVzY3JpcHRpb25Eb25lID0gWydiaW5kaW5n cy10ZXN0cyddCiAgICAgZmx1bmtPbkZhaWx1cmUgPSBUcnVlCi0gICAgY29tbWFuZCA9IFsnVG9v bHMvU2NyaXB0cy9ydW4tYmluZGluZ3MtdGVzdHMnXQorICAgIGpzb25GaWxlTmFtZSA9ICdiaW5k aW5nc190ZXN0X3Jlc3VsdHMuanNvbicKKyAgICBsb2dmaWxlcyA9IHsnanNvbic6IGpzb25GaWxl TmFtZX0KKyAgICBjb21tYW5kID0gWydUb29scy9TY3JpcHRzL3J1bi1iaW5kaW5ncy10ZXN0cycs ICctLWpzb24tb3V0cHV0PXswfScuZm9ybWF0KGpzb25GaWxlTmFtZSldCiAKIAogY2xhc3MgUnVu V2ViS2l0UGVybFRlc3RzKHNoZWxsLlNoZWxsQ29tbWFuZCk6CkluZGV4OiBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CShyZXZpc2lv biAyMzM1MDkpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5p dHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTI0MCw3ICsyNDAsOCBAQCBjbGFzcyBUZXN0UnVu QmluZGluZ3NUZXN0cyhCdWlsZFN0ZXBNaXhpCiAgICAgICAgIHNlbGYuc2V0dXBTdGVwKFJ1bkJp bmRpbmdzVGVzdHMoKSkKICAgICAgICAgc2VsZi5leHBlY3RSZW1vdGVDb21tYW5kcygKICAgICAg ICAgICAgIEV4cGVjdFNoZWxsKHdvcmtkaXI9J3drZGlyJywKLSAgICAgICAgICAgICAgICAgICAg ICAgIGNvbW1hbmQ9WydUb29scy9TY3JpcHRzL3J1bi1iaW5kaW5ncy10ZXN0cyddLAorICAgICAg ICAgICAgICAgICAgICAgICAgY29tbWFuZD1bJ1Rvb2xzL1NjcmlwdHMvcnVuLWJpbmRpbmdzLXRl c3RzJywgJy0tanNvbi1vdXRwdXQ9YmluZGluZ3NfdGVzdF9yZXN1bHRzLmpzb24nXSwKKyAgICAg ICAgICAgICAgICAgICAgICAgIGxvZ2ZpbGVzPXsnanNvbic6ICdiaW5kaW5nc190ZXN0X3Jlc3Vs dHMuanNvbid9LAogICAgICAgICAgICAgICAgICAgICAgICAgKQogICAgICAgICAgICAgKyAwLAog ICAgICAgICApCkBAIC0yNTEsNyArMjUyLDggQEAgY2xhc3MgVGVzdFJ1bkJpbmRpbmdzVGVzdHMo QnVpbGRTdGVwTWl4aQogICAgICAgICBzZWxmLnNldHVwU3RlcChSdW5CaW5kaW5nc1Rlc3RzKCkp CiAgICAgICAgIHNlbGYuZXhwZWN0UmVtb3RlQ29tbWFuZHMoCiAgICAgICAgICAgICBFeHBlY3RT aGVsbCh3b3JrZGlyPSd3a2RpcicsCi0gICAgICAgICAgICAgICAgICAgICAgICBjb21tYW5kPVsn VG9vbHMvU2NyaXB0cy9ydW4tYmluZGluZ3MtdGVzdHMnXSwKKyAgICAgICAgICAgICAgICAgICAg ICAgIGNvbW1hbmQ9WydUb29scy9TY3JpcHRzL3J1bi1iaW5kaW5ncy10ZXN0cycsICctLWpzb24t b3V0cHV0PWJpbmRpbmdzX3Rlc3RfcmVzdWx0cy5qc29uJ10sCisgICAgICAgICAgICAgICAgICAg ICAgICBsb2dmaWxlcz17J2pzb24nOiAnYmluZGluZ3NfdGVzdF9yZXN1bHRzLmpzb24nfSwKICAg ICAgICAgICAgICAgICAgICAgICAgICkKICAgICAgICAgICAgICsgRXhwZWN0U2hlbGwubG9nKCdz dGRpbycsIHN0ZG91dD0nRkFJTDogKEpTKSBKU1Rlc3RJbnRlcmZhY2UuY3BwJykKICAgICAgICAg ICAgICsgMiwK