18732 2008-04-24 21:45:01 -0700 SQUIRRELFISH: exceptions thrown by native constructors are ignored 2008-04-25 01:33:30 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 18624 1 zwarich webkit-unassigned oldest_to_newest 78867 0 zwarich 2008-04-24 21:45:01 -0700 This problem is seen in the JavaScriptCore regression test js1_5/Regress/regress-118849.js. There is only one easy way of fixing this, adding an exception check to op_construct, so hopefully that doesn't regress performance. 78870 1 20808 zwarich 2008-04-24 21:56:15 -0700 Created attachment 20808 Proposed patch Here's the natural patch. It fixes the test, and is either a slight speedup on SunSpider or no regression. 78871 2 20808 mjs 2008-04-24 21:58:37 -0700 Comment on attachment 20808 Proposed patch r=me 78872 3 20809 zwarich 2008-04-24 22:05:59 -0700 Created attachment 20809 Revised proposed patch We should do the exception check before writing to any register. The code currently doing the check after writing is incorrect. This version does slightly better on SunSpider, for a pretty definite 0.4% progression. 78873 4 20809 mjs 2008-04-24 22:06:46 -0700 Comment on attachment 20809 Revised proposed patch r=me 78893 5 oliver 2008-04-25 01:33:30 -0700 Landed r 32538 20808 2008-04-24 21:56:15 -0700 2008-04-24 22:05:59 -0700 Proposed patch construct.diff text/plain 1038 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDMyNTMy KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMDQt MjQgIENhbWVyb24gWndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDE4NzMyOiBTUVVJUlJF TEZJU0g6IGV4Y2VwdGlvbnMgdGhyb3duIGJ5IG5hdGl2ZSBjb25zdHJ1Y3RvcnMgYXJlIGlnbm9y ZWQKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODcz Mj4KKworICAgICAgICBGaXhlcyBhbm90aGVyIHJlZ3Jlc3Npb24gdGVzdC4KKworICAgICAgICAq IFZNL01hY2hpbmUuY3BwOgorICAgICAgICAoS0pTOjpNYWNoaW5lOjpwcml2YXRlRXhlY3V0ZSk6 CisKIDIwMDgtMDQtMjQgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4KSW5kZXg6IFZNL01hY2hpbmUuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFZNL01hY2hpbmUuY3BwCShyZXZpc2lvbiAzMjUzMSkKKysrIFZNL01hY2hpbmUu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDQ1LDYgKzE0NDUsOCBAQCBKU1ZhbHVlKiBNYWNoaW5l Ojpwcml2YXRlRXhlY3V0ZShFeGVjdXRpCiAgICAgICAgICAgICByID0gKCpyZWdpc3RlckJhc2Up ICsgcmVnaXN0ZXJPZmZzZXQ7CiAgICAgICAgICAgICByW3IwXS51LmpzVmFsdWUgPSByZXR1cm5W YWx1ZTsKICAgICAgICAgICAgIAorICAgICAgICAgICAgVk1fQ0hFQ0tfRVhDRVBUSU9OKCk7Cisg ICAgICAgICAgICAKICAgICAgICAgICAgICsrdlBDOwogICAgICAgICAgICAgTkVYVF9PUENPREU7 CiAgICAgICAgIH0K 20809 2008-04-24 22:05:59 -0700 2008-04-24 22:06:46 -0700 Revised proposed patch construct.diff text/plain 1069 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDMyNTMy KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMDQt MjQgIENhbWVyb24gWndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDE4NzMyOiBTUVVJUlJF TEZJU0g6IGV4Y2VwdGlvbnMgdGhyb3duIGJ5IG5hdGl2ZSBjb25zdHJ1Y3RvcnMgYXJlIGlnbm9y ZWQKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODcz Mj4KKworICAgICAgICBGaXhlcyBhbm90aGVyIHJlZ3Jlc3Npb24gdGVzdC4KKworICAgICAgICAq IFZNL01hY2hpbmUuY3BwOgorICAgICAgICAoS0pTOjpNYWNoaW5lOjpwcml2YXRlRXhlY3V0ZSk6 CisKIDIwMDgtMDQtMjQgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4KSW5kZXg6IFZNL01hY2hpbmUuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFZNL01hY2hpbmUuY3BwCShyZXZpc2lvbiAzMjUzMSkKKysrIFZNL01hY2hpbmUu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDQzLDYgKzE0NDMsNyBAQCBKU1ZhbHVlKiBNYWNoaW5l Ojpwcml2YXRlRXhlY3V0ZShFeGVjdXRpCiAgICAgICAgICAgICBKU1ZhbHVlKiByZXR1cm5WYWx1 ZSA9IGNvbnN0cnVjdG9yLT5jb25zdHJ1Y3QoZXhlYywgYXJncyk7CiAgICAgICAgIAogICAgICAg ICAgICAgciA9ICgqcmVnaXN0ZXJCYXNlKSArIHJlZ2lzdGVyT2Zmc2V0OworICAgICAgICAgICAg Vk1fQ0hFQ0tfRVhDRVBUSU9OKCk7CiAgICAgICAgICAgICByW3IwXS51LmpzVmFsdWUgPSByZXR1 cm5WYWx1ZTsKICAgICAgICAgICAgIAogICAgICAgICAgICAgKyt2UEM7Cg==