187317 2018-07-04 01:43:27 -0700 Rename HTMLTreeBuilder::didCreateCustomOrCallbackElement 2018-07-06 00:49:24 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 154908 183586 1 fred.wang fred.wang cdumez commit-queue esprehn+autocc ews-watchlist gyuyoung.kim rniwa rwlbuis webkit-bug-importer oldest_to_newest 1439162 0 fred.wang 2018-07-04 01:43:27 -0700 In bug r197463, a new function HTMLTreeBuilder::didCreateCustomOrCallbackElement was introduced. It seems that what is meant is a really *Fallback* element, so we should rename the function. 1439164 1 344269 fred.wang 2018-07-04 02:01:01 -0700 Created attachment 344269 Patch 1439722 2 344269 commit-queue 2018-07-06 00:48:57 -0700 Comment on attachment 344269 Patch Clearing flags on attachment: 344269 Committed r233572: <https://trac.webkit.org/changeset/233572> 1439723 3 commit-queue 2018-07-06 00:48:59 -0700 All reviewed patches have been landed. Closing bug. 1439724 4 webkit-bug-importer 2018-07-06 00:49:24 -0700 <rdar://problem/41882574> 344269 2018-07-04 02:01:01 -0700 2018-07-06 00:48:57 -0700 Patch bug-187317-20180704110100.patch text/plain 3706 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzNDk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTcyOWZiMzIxMTgxOTU5 NjY4MTE2YjQzMzk2ZTQzZTQyZDI3YjM1Yi4uMDg3NWQ4ZjdmZjA0ZDM5ZDM3YzRmMDdhNTMyMmYw Yzc0ZmJkZGFjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE4LTA3LTA0ICBGcmVk ZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbT4KKworICAgICAgICBSZW5hbWUgSFRNTFRyZWVC dWlsZGVyOjpkaWRDcmVhdGVDdXN0b21PckNhbGxiYWNrRWxlbWVudAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3MzE3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBmdW5jdGlvbiBpcyBjYWxsZWQg d2l0aCBhIG5ldyBjdXN0b20gZWxlbWVudCBvciB0aGUgZmFsbGJhY2sgSFRNTFVua25vd25FbGVt ZW50IGVsZW1lbnQKKyAgICAgICAgc28gd2UgcmVuYW1lIGl0IGRpZENyZWF0ZUN1c3RvbU9yRmFs bGJhY2tFbGVtZW50LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYmVoYXZpb3IgdW5jaGFuZ2Vk LgorCisgICAgICAgICogaHRtbC9wYXJzZXIvSFRNTERvY3VtZW50UGFyc2VyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkhUTUxEb2N1bWVudFBhcnNlcjo6cnVuU2NyaXB0c0ZvclBhdXNlZFRyZWVC dWlsZGVyKToKKyAgICAgICAgKiBodG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxkZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6SFRNTFRyZWVCdWlsZGVyOjpkaWRDcmVhdGVDdXN0b21PckZhbGxiYWNr RWxlbWVudCk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVHJlZUJ1aWxkZXI6OmRpZENyZWF0ZUN1 c3RvbU9yQ2FsbGJhY2tFbGVtZW50KTogRGVsZXRlZC4KKyAgICAgICAgKiBodG1sL3BhcnNlci9I VE1MVHJlZUJ1aWxkZXIuaDoKKwogMjAxOC0wNy0wMyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBOdWxscHRyIGNyYXNoIGFjY2Vzc2luZyBEb2N1bWVudCBpbiBH ZW5lcmljRXZlbnRRdWV1ZTo6ZGlzcGF0Y2hPbmVFdmVudCgpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL3BhcnNlci9IVE1MRG9jdW1lbnRQYXJzZXIuY3BwIGIvU291cmNlL1dlYkNv cmUvaHRtbC9wYXJzZXIvSFRNTERvY3VtZW50UGFyc2VyLmNwcAppbmRleCBkY2Y0OWU5MDMxY2Yz N2RlYjM5MWI4NWU2ZDFiYTk3NmJmZDZhYTE2Li4zNGExMmEyOTcxMDZkNWE5NDEwY2I2MWEzMzgy ZDM5ZjRhYjliODc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1M RG9jdW1lbnRQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxE b2N1bWVudFBhcnNlci5jcHAKQEAgLTIwMCw3ICsyMDAsNyBAQCB2b2lkIEhUTUxEb2N1bWVudFBh cnNlcjo6cnVuU2NyaXB0c0ZvclBhdXNlZFRyZWVCdWlsZGVyKCkKICAgICAgICAgLy8gaHR0cHM6 Ly9odG1sLnNwZWMud2hhdHdnLm9yZy8jY3JlYXRlLWFuLWVsZW1lbnQtZm9yLXRoZS10b2tlbgog ICAgICAgICBhdXRvJiBlbGVtZW50SW50ZXJmYWNlID0gY29uc3RydWN0aW9uRGF0YS0+ZWxlbWVu dEludGVyZmFjZS5nZXQoKTsKICAgICAgICAgYXV0byBuZXdFbGVtZW50ID0gZWxlbWVudEludGVy ZmFjZS5jb25zdHJ1Y3RFbGVtZW50V2l0aEZhbGxiYWNrKCpkb2N1bWVudCgpLCBjb25zdHJ1Y3Rp b25EYXRhLT5uYW1lKTsKLSAgICAgICAgbV90cmVlQnVpbGRlci0+ZGlkQ3JlYXRlQ3VzdG9tT3JD YWxsYmFja0VsZW1lbnQoV1RGTW92ZShuZXdFbGVtZW50KSwgKmNvbnN0cnVjdGlvbkRhdGEpOwor ICAgICAgICBtX3RyZWVCdWlsZGVyLT5kaWRDcmVhdGVDdXN0b21PckZhbGxiYWNrRWxlbWVudChX VEZNb3ZlKG5ld0VsZW1lbnQpLCAqY29uc3RydWN0aW9uRGF0YSk7CiAgICAgICAgIHJldHVybjsK ICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxUcmVl QnVpbGRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxkZXIu Y3BwCmluZGV4IDRiN2ZjOGZjM2MzMDMxMmYwOWY1NDhiYTFlNGFlNzI3ZDc0MWRkNjUuLmU0MGY5 YTg4NmYxNTkwNGU2MmYwZjI2ODhhODY5YTY5ODg5YjRhODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxUcmVlQnVpbGRlci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvaHRtbC9wYXJzZXIvSFRNTFRyZWVCdWlsZGVyLmNwcApAQCAtODczLDcgKzg3Myw3IEBAIGlu bGluZSB2b2lkIEhUTUxUcmVlQnVpbGRlcjo6aW5zZXJ0R2VuZXJpY0hUTUxFbGVtZW50KEF0b21p Y0hUTUxUb2tlbiYmIHRva2VuKQogICAgIG1fY3VzdG9tRWxlbWVudFRvQ29uc3RydWN0ID0gbV90 cmVlLmluc2VydEhUTUxFbGVtZW50T3JGaW5kQ3VzdG9tRWxlbWVudEludGVyZmFjZShXVEZNb3Zl KHRva2VuKSk7CiB9CiAKLXZvaWQgSFRNTFRyZWVCdWlsZGVyOjpkaWRDcmVhdGVDdXN0b21PckNh bGxiYWNrRWxlbWVudChSZWY8RWxlbWVudD4mJiBlbGVtZW50LCBDdXN0b21FbGVtZW50Q29uc3Ry dWN0aW9uRGF0YSYgZGF0YSkKK3ZvaWQgSFRNTFRyZWVCdWlsZGVyOjpkaWRDcmVhdGVDdXN0b21P ckZhbGxiYWNrRWxlbWVudChSZWY8RWxlbWVudD4mJiBlbGVtZW50LCBDdXN0b21FbGVtZW50Q29u c3RydWN0aW9uRGF0YSYgZGF0YSkKIHsKICAgICBtX3RyZWUuaW5zZXJ0Q3VzdG9tRWxlbWVudChX VEZNb3ZlKGVsZW1lbnQpLCBkYXRhLm5hbWUsIFdURk1vdmUoZGF0YS5hdHRyaWJ1dGVzKSk7CiB9 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxkZXIu aCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxUcmVlQnVpbGRlci5oCmluZGV4IGFl Y2NhYjQ1ZGE1NTBjZTM5YTY4OTY4MGIwY2Y0NGNjNTAyZjFmMWQuLmM1NjNhYmFmYTBjOWQ0MzMz MWJmOWVmMDY1YTYzODJlNmMzYjAzNWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv cGFyc2VyL0hUTUxUcmVlQnVpbGRlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2Vy L0hUTUxUcmVlQnVpbGRlci5oCkBAIC02Niw3ICs2Niw3IEBAIHB1YmxpYzoKICAgICBSZWZQdHI8 U2NyaXB0RWxlbWVudD4gdGFrZVNjcmlwdFRvUHJvY2VzcyhUZXh0UG9zaXRpb24mIHNjcmlwdFN0 YXJ0UG9zaXRpb24pOwogCiAgICAgc3RkOjp1bmlxdWVfcHRyPEN1c3RvbUVsZW1lbnRDb25zdHJ1 Y3Rpb25EYXRhPiB0YWtlQ3VzdG9tRWxlbWVudENvbnN0cnVjdGlvbkRhdGEoKSB7IHJldHVybiBX VEZNb3ZlKG1fY3VzdG9tRWxlbWVudFRvQ29uc3RydWN0KTsgfQotICAgIHZvaWQgZGlkQ3JlYXRl Q3VzdG9tT3JDYWxsYmFja0VsZW1lbnQoUmVmPEVsZW1lbnQ+JiYsIEN1c3RvbUVsZW1lbnRDb25z dHJ1Y3Rpb25EYXRhJik7CisgICAgdm9pZCBkaWRDcmVhdGVDdXN0b21PckZhbGxiYWNrRWxlbWVu dChSZWY8RWxlbWVudD4mJiwgQ3VzdG9tRWxlbWVudENvbnN0cnVjdGlvbkRhdGEmKTsKIAogICAg IC8vIERvbmUsIGNsb3NlIGFueSBvcGVuIHRhZ3MsIGV0Yy4KICAgICB2b2lkIGZpbmlzaGVkKCk7 Cg==