18728 2008-04-24 21:18:34 -0700 SQUIRRELFISH: invalid regular expression constants should throw exceptions 2008-04-25 01:33:08 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 18624 1 zwarich webkit-unassigned oldest_to_newest 78860 0 zwarich 2008-04-24 21:18:34 -0700 Currently, SquirrelFish doesn't throw exceptions for invalid regular expression constants. The exception gets created, but there is no VM_CHECK_EXCEPTION() in the body of op_new_regexp, so it gets ignored. However, we should really just create the code to throw the exception at compile time. This affects the JavaScriptCore regression test ecma_3/RegExp/regress-188206.js. 78861 1 20807 zwarich 2008-04-24 21:29:39 -0700 Created attachment 20807 Proposed patch This patch fixes the test and is a 0.7% progression on SunSpider, because of the better code path in op_new_regexp. 78868 2 20807 mjs 2008-04-24 21:49:06 -0700 Comment on attachment 20807 Proposed patch r=me 78892 3 oliver 2008-04-25 01:33:08 -0700 Landed r32537 20807 2008-04-24 21:29:39 -0700 2008-04-24 21:49:06 -0700 Proposed patch regexp.diff text/plain 2110 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDMyNTMy KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMDQt MjQgIENhbWVyb24gWndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDE4NzI4OiBTUVVJUlJF TEZJU0g6IGludmFsaWQgcmVndWxhciBleHByZXNzaW9uIGNvbnN0YW50cyBzaG91bGQgdGhyb3cg ZXhjZXB0aW9ucworICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4NzI4PgorCisgICAgICAgIEZpeGVzIGFub3RoZXIgcmVncmVzc2lvbiB0ZXN0LgorCisg ICAgICAgICoga2pzL25vZGVzLmNwcDoKKyAgICAgICAgKEtKUzo6UmVnRXhwTm9kZTo6ZW1pdENv ZGUpOgorCiAyMDA4LTA0LTI0ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCkluZGV4OiBWTS9NYWNoaW5lLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBWTS9NYWNoaW5lLmNwcAkocmV2aXNpb24gMzI1MzEpCisrKyBWTS9NYWNo aW5lLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzExLDcgKzcxMSw3IEBAIEpTVmFsdWUqIE1hY2hp bmU6OnByaXZhdGVFeGVjdXRlKEV4ZWN1dGkKICAgICBCRUdJTl9PUENPREUob3BfbmV3X3JlZ2V4 cCkgewogICAgICAgICBpbnQgcjAgPSAoKyt2UEMpLT51Lm9wZXJhbmQ7CiAgICAgICAgIGludCBy ZTAgPSAoKyt2UEMpLT51Lm9wZXJhbmQ7Ci0gICAgICAgIHJbcjBdLnUuanNWYWx1ZSA9IGV4ZWMt PmxleGljYWxHbG9iYWxPYmplY3QoKS0+cmVnRXhwQ29uc3RydWN0b3IoKS0+Y3JlYXRlUmVnRXhw SW1wKGV4ZWMsIGNvZGVCbG9jay0+cmVnZXhwc1tyZTBdKTsKKyAgICAgICAgcltyMF0udS5qc1Zh bHVlID0gbmV3IFJlZ0V4cEltcChzdGF0aWNfY2FzdDxSZWdFeHBQcm90b3R5cGUqPihleGVjLT5s ZXhpY2FsR2xvYmFsT2JqZWN0KCktPnJlZ0V4cFByb3RvdHlwZSgpKSwgY29kZUJsb2NrLT5yZWdl eHBzW3JlMF0pOwogCiAgICAgICAgICsrdlBDOwogICAgICAgICBORVhUX09QQ09ERTsKSW5kZXg6 IGtqcy9ub2Rlcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0ga2pzL25vZGVzLmNwcAkocmV2aXNpb24gMzI1 MzEpCisrKyBranMvbm9kZXMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NjksNyArNTY5LDEzIEBA IGJvb2wgU3RyaW5nTm9kZTo6ZXZhbHVhdGVUb0Jvb2xlYW4oT2xkSW4KIAogUmVnaXN0ZXJJRCog UmVnRXhwTm9kZTo6ZW1pdENvZGUoQ29kZUdlbmVyYXRvciYgZ2VuZXJhdG9yLCBSZWdpc3RlcklE KiBkc3QpCiB7Ci0gICAgcmV0dXJuIGdlbmVyYXRvci5lbWl0TmV3UmVnRXhwKGdlbmVyYXRvci5m aW5hbERlc3RpbmF0aW9uKGRzdCksIG1fcmVnRXhwLmdldCgpKTsKKyAgICBpZiAobV9yZWdFeHAt PmlzVmFsaWQoKSkKKyAgICAgICAgcmV0dXJuIGdlbmVyYXRvci5lbWl0TmV3UmVnRXhwKGdlbmVy YXRvci5maW5hbERlc3RpbmF0aW9uKGRzdCksIG1fcmVnRXhwLmdldCgpKTsKKyAgICAKKyAgICBV U3RyaW5nIGVycm9yTWVzc2FnZVN0cmluZyA9IFVTdHJpbmcoIkludmFsaWQgcmVndWxhciBleHBy ZXNzaW9uOiAiKS5hcHBlbmQobV9yZWdFeHAtPmVycm9yTWVzc2FnZSgpKTsKKyAgICBSZWdpc3Rl cklEKiByMCA9IGdlbmVyYXRvci5lbWl0Q3JlYXRlRXJyb3IoZ2VuZXJhdG9yLnRlbXBEZXN0aW5h dGlvbihkc3QpLCBTeW50YXhFcnJvciwganNPd25lZFN0cmluZyhlcnJvck1lc3NhZ2VTdHJpbmcp KTsKKyAgICBnZW5lcmF0b3IuZW1pdFRocm93KHIwKTsKKyAgICByZXR1cm4gMDsKIH0KIAogSlNW YWx1ZSogUmVnRXhwTm9kZTo6ZXZhbHVhdGUoT2xkSW50ZXJwcmV0ZXJFeGVjU3RhdGUqIGV4ZWMp Cg==