187229 2018-06-30 19:53:23 -0700 test-webkitpy never rebuilds lldbWebKitTester 2018-07-02 11:07:44 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Mac macOS 10.13 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=187132 InRadar P2 Normal --- 1 dbates dbates ddkilzer ews-watchlist glenn lforschler simon.fraser webkit-bug-importer oldest_to_newest 1438265 0 dbates 2018-06-30 19:53:23 -0700 Currently once lldbWebKitTester is built for the active configuration (see script set-webkit-configuration) then it is never rebuilt by test-webkitpy regardless of whether the source for lldbWebKitTester has changed. 1438266 1 344037 dbates 2018-06-30 19:59:16 -0700 Created attachment 344037 Patch 1438276 2 344037 ddkilzer 2018-06-30 21:39:33 -0700 Comment on attachment 344037 Patch r=me 1438282 3 dbates 2018-06-30 23:00:43 -0700 Committed r233407: <https://trac.webkit.org/changeset/233407> 1438283 4 webkit-bug-importer 2018-06-30 23:01:24 -0700 <rdar://problem/41688400> 1438557 5 simon.fraser 2018-07-02 11:07:44 -0700 Thanks for the fix! 344037 2018-06-30 19:59:16 -0700 2018-06-30 21:39:33 -0700 Patch bug-187229-20180630195916.patch text/plain 2891 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzNDA2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzk2MWE3NjVjNDY2NWQ2MDZkMTY2MjVjOWU0YjdjOGQy NjI0MDBkMy4uOGRhMTFmY2Q4OTliMTgyNmI5Y2Y2YjZjOTJiMDBmODUyODViM2QyZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDE4LTA2LTMwICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICB0ZXN0LXdlYmtpdHB5IG5ldmVyIHJlYnVpbGRzIGxsZGJXZWJLaXRUZXN0ZXIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NzIyOQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhhdmUgdGVzdC13ZWJr aXRweSBhbHdheXMgY2FsbCBzY3JpcHQgYnVpbGQtbGxkYndlYmtpdHRlc3RlciB0byBidWlsZCBs bGRiV2ViS2l0VGVzdGVyLCBpZiBuZWVkZWQuCisKKyAgICAgICAgQ3VycmVudGx5IHRlc3Qtd2Vi a2l0cHkgb25seSBjYWxscyBzY3JpcHQgYnVpbGQtbGxkYndlYmtpdHRlc3RlciBpZiBsbGRiV2Vi S2l0VGVzdGVyIGRvZXMgbm90CisgICAgICAgIGV4aXN0IGluIHRoZSBidWlsZCBwcm9kdWN0cyBk aXJlY3RvcnkgZm9yIHRoZSBhY3RpdmUgY29uZmlndXJhdGlvbiAoZS5nLiBEZWJ1Zyk7ID0+IHdl IGRvIG5vdAorICAgICAgICBidWlsZCBsbGRiV2ViS2l0VGVzdGVyIGFnYWluIGlmIGl0cyBzb3Vy Y2UgY2hhbmdlcyAoc2F5LCBhcyBhIHJlc3VsdCBvZiBoYWNraW5nIG9uIGxsZGJXZWJLaXRUZXN0 ZXIpLgorICAgICAgICBJbnN0ZWFkIHdlIHNob3VsZCBoYXZlIHRlc3Qtd2Via2l0cHkgdW5jb25k aXRpb25hbGx5IGNhbGwgYnVpbGQtbGxkYndlYmtpdHRlc3RlciB0byBlbnN1cmUKKyAgICAgICAg dGhhdCB3ZSBoYXZlIGFuIHVwLXRvLWRhdGUgYnVpbGQgb2YgbGxkYldlYktpdFRlc3Rlci4KKwor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdGVzdC9tYWluLnB5OgorICAgICAgICAoVGVzdGVy Ll9ydW5fdGVzdHMpOgorICAgICAgICAoX2ZpbmRfbGxkYl93ZWJraXRfdGVzdGVyKTogRGVsZXRl ZC4KKwogMjAxOC0wNi0zMCAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5j b20+CiAKICAgICAgICAgW0NNYWtlXSBidWlsZC13ZWJraXQgc2hvdWxkIGJlIGFibGUgdG8gZW5h YmxlIGFkZHJlc3Mgc2FuaXRpemVyCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rlc3QvbWFpbi5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdGVzdC9tYWluLnB5CmluZGV4 IDcyMzdhNjA4YmQxNDFhNDRlMGE2ZDYxODEwYTE0MDNlZDBlNGNiMmEuLjQ2ZDU4ZGZlZTdhZTJj ZjViYmI2ODQxY2I2MDg3MThlNzliMjE0NzcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvdGVzdC9tYWluLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdGVzdC9tYWlu LnB5CkBAIC01MiwxMiArNTIsNiBAQCBfaG9zdCA9IFN5c3RlbUhvc3QoKQogX3dlYmtpdF9yb290 ID0gTm9uZQogCiAKLWRlZiBfZmluZF9sbGRiX3dlYmtpdF90ZXN0ZXIoKToKLSAgICBjb25maWcg PSBDb25maWcoX2hvc3QuZXhlY3V0aXZlLCBfaG9zdC5maWxlc3lzdGVtKQotICAgIGxsZGJfd2Vi a2l0X3Rlc3Rlcl9leGVjdXRhYmxlID0gb3MucGF0aC5qb2luKGNvbmZpZy5idWlsZF9kaXJlY3Rv cnkoY29uZmlnLmRlZmF1bHRfY29uZmlndXJhdGlvbigpKSwgJ2xsZGJXZWJLaXRUZXN0ZXInKQot ICAgIHJldHVybiBvcy5wYXRoLmlzZmlsZShsbGRiX3dlYmtpdF90ZXN0ZXJfZXhlY3V0YWJsZSkg YW5kIG9zLmFjY2VzcyhsbGRiX3dlYmtpdF90ZXN0ZXJfZXhlY3V0YWJsZSwgb3MuWF9PSykKLQot CiBkZWYgX2J1aWxkX2xsZGJfd2Via2l0X3Rlc3RlcigpOgogICAgIGlmIG5vdCBfaG9zdC5wbGF0 Zm9ybS5pc19tYWMoKToKICAgICAgICAgX2xvZy5lcnJvcignbGxkYldlYktpdFRlc3RlciBpcyBu b3Qgc3VwcG9ydGVkIG9uIHRoaXMgcGxhdGZvcm0uJykKQEAgLTE5NCwxMiArMTg4LDEwIEBAIGNs YXNzIFRlc3RlcihvYmplY3QpOgogICAgICAgICBhdXRvaW5zdGFsbF9ldmVyeXRoaW5nKCkKIAog ICAgICAgICBpZiB3aWxsX3J1bl9sbGRiX3dlYmtpdF90ZXN0czoKLSAgICAgICAgICAgIHNlbGYu cHJpbnRlci53cml0ZV91cGRhdGUoIkNoZWNraW5nIGxsZGJXZWJLaXRUZXN0ZXIgLi4uIikKLSAg ICAgICAgICAgIGlmIG5vdCBfZmluZF9sbGRiX3dlYmtpdF90ZXN0ZXIoKToKLSAgICAgICAgICAg ICAgICBzZWxmLnByaW50ZXIud3JpdGVfdXBkYXRlKCJCdWlsZGluZyBsbGRiV2ViS2l0VGVzdGVy IC4uLiIpCi0gICAgICAgICAgICAgICAgaWYgbm90IF9idWlsZF9sbGRiX3dlYmtpdF90ZXN0ZXIo KToKLSAgICAgICAgICAgICAgICAgICAgX2xvZy5lcnJvcignRmFpbGVkIHRvIGJ1aWxkIGxsZGJX ZWJLaXRUZXN0ZXIuJykKLSAgICAgICAgICAgICAgICAgICAgcmV0dXJuIEZhbHNlCisgICAgICAg ICAgICBzZWxmLnByaW50ZXIud3JpdGVfdXBkYXRlKCJCdWlsZGluZyBsbGRiV2ViS2l0VGVzdGVy IC4uLiIpCisgICAgICAgICAgICBpZiBub3QgX2J1aWxkX2xsZGJfd2Via2l0X3Rlc3RlcigpOgor ICAgICAgICAgICAgICAgIF9sb2cuZXJyb3IoJ0ZhaWxlZCB0byBidWlsZCBsbGRiV2ViS2l0VGVz dGVyLicpCisgICAgICAgICAgICAgICAgcmV0dXJuIEZhbHNlCiAKICAgICAgICAgaWYgc2VsZi5f b3B0aW9ucy5jb3ZlcmFnZToKICAgICAgICAgICAgIF9sb2cud2FybmluZygiQ2hlY2tpbmcgY29k ZSBjb3ZlcmFnZSwgc28gcnVubmluZyB0aGluZ3Mgc2VyaWFsbHkiKQo=