187224 2018-06-30 14:41:44 -0700 Fix clang static analyzer warnings: Garbage return value 2018-06-30 19:13:00 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=186968 InRadar P2 Normal --- 1 ddkilzer ddkilzer bfulgham cdumez commit-queue dbates eric.carlson joepeck msaboff rniwa webkit-bug-importer wenson_hsieh oldest_to_newest 1438217 0 ddkilzer 2018-06-30 14:41:44 -0700 Fix clang static analyzer warnings: Garbage return value. 1438218 1 webkit-bug-importer 2018-06-30 14:42:08 -0700 <rdar://problem/41683170> 1438219 2 344023 ddkilzer 2018-06-30 14:47:25 -0700 Created attachment 344023 Patch v1 1438227 3 344023 eric.carlson 2018-06-30 16:39:03 -0700 Comment on attachment 344023 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=344023&action=review > Source/WebCore/platform/mediastream/MediaConstraints.h:245 > ValueType max = capabilityMax; Ditto 1438229 4 344023 commit-queue 2018-06-30 17:06:45 -0700 Comment on attachment 344023 Patch v1 Clearing flags on attachment: 344023 Committed r233403: <https://trac.webkit.org/changeset/233403> 1438230 5 commit-queue 2018-06-30 17:06:46 -0700 All reviewed patches have been landed. Closing bug. 1438241 6 344023 ddkilzer 2018-06-30 17:44:06 -0700 Comment on attachment 344023 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=344023&action=review >> Source/WebCore/platform/mediastream/MediaConstraints.h:245 >> ValueType max = capabilityMax; > > Ditto What did you mean here? Did you want me to change these lines to this? ValueType min { capabilityMin }; ValueType max { capabilityMax }; 1438260 7 ddkilzer 2018-06-30 19:13:00 -0700 (In reply to David Kilzer (:ddkilzer) from comment #6) > Comment on attachment 344023 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=344023&action=review > > >> Source/WebCore/platform/mediastream/MediaConstraints.h:245 > >> ValueType max = capabilityMax; > > > > Ditto > > What did you mean here? Did you want me to change these lines to this? > > ValueType min { capabilityMin }; > ValueType max { capabilityMax }; Follow-up fix committed here: Committed r233406: <https://trac.webkit.org/changeset/233403> 344023 2018-06-30 14:47:25 -0700 2018-06-30 17:06:45 -0700 Patch v1 bug-187224-20180630144725.patch text/plain 11880 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMzcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj YjBhYWIyODI0NGEzZTViYzRjYmM1YTBjNjZmODU4NWRkMTEyMDEwLi4xYTBkODJmZjZiY2JjZWY1 OTM2NTJhM2Y1ODEwZWMxNzBmODAzM2U4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOC0wNi0zMCAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29t PgorCisgICAgICAgIEZpeCBjbGFuZyBzdGF0aWMgYW5hbHl6ZXIgd2FybmluZ3M6IEdhcmJhZ2Ug cmV0dXJuIHZhbHVlCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xODcyMjQ+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBieXRlY29kZS9V bmxpbmtlZENvZGVCbG9jay5jcHA6CisgICAgICAgIChKU0M6OlVubGlua2VkQ29kZUJsb2NrOjps aW5lTnVtYmVyRm9yQnl0ZWNvZGVPZmZzZXQpOgorICAgICAgICAtIFVzZSBicmFjZSBpbml0aWFs aXphdGlvbiBmb3IgbG9jYWwgdmFyaWFibGVzLgorICAgICAgICAqIGRlYnVnZ2VyL0RlYnVnZ2Vy Q2FsbEZyYW1lLmNwcDoKKyAgICAgICAgKGNsYXNzIEpTQzo6TGluZUFuZENvbHVtbkZ1bmN0b3Ip OgorICAgICAgICAtIFVzZSBjbGFzcyBtZW1iZXIgaW5pdGlhbGl6YXRpb24gZm9yIG1lbWJlciB2 YXJpYWJsZXMuCisKIDIwMTgtMDYtMjggIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5j b20+CiAgIAogICAgICAgICBJc29DZWxsU2V0Ojpzd2VlcFRvRnJlZUxpc3QoKSBub3Qgc2FmZSB3 aGVuIEZ1bGwgR0MgaW4gcHJvY2VzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDdkMjRiNDk2ZTc4NjViYzhkMzIy NDBlYzU1OTRiYWJjZTBhMjNiYTMuLjlhYWZiZGFjMjY3MzFhY2VjNGFjYjNiZDFmMWEwNzg3YmIw M2NhMTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxOC0wNi0zMCAgRGF2aWQgS2ls emVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBjbGFuZyBzdGF0aWMgYW5h bHl6ZXIgd2FybmluZ3M6IEdhcmJhZ2UgcmV0dXJuIHZhbHVlCisgICAgICAgIDxodHRwczovL3dl YmtpdC5vcmcvYi8xODcyMjQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBwbGF0Zm9ybS9tZWRpYXN0cmVhbS9NZWRpYUNvbnN0cmFpbnRzLmg6Cisg ICAgICAgIChXZWJDb3JlOjpOdW1lcmljQ29uc3RyYWludDo6dmFsdWVGb3JDYXBhYmlsaXR5UmFu Z2UgY29uc3QpOgorICAgICAgICAtIFVzZSBicmFjZSBpbml0aWFsaXphdGlvbiBmb3IgbG9jYWwg dmFyaWFibGVzLgorCiAyMDE4LTA2LTI5ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5j b20+CiAKICAgICAgICAgU3BsaXQgSW5saW5lVGV4dEJveDo6ZW1waGFzaXNNYXJrRXhpc3RzQW5k SXNBYm92ZSgpIGludG8gdHdvIG1ldGhvZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hh bmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggNmI5ZjA0ZTVhMDExMTgxNzc0 MDVlOTQyYmU4OWQ0ODI2ZjNjZGZkNi4uMzJhOGQ5ZmYyZWZhZWRhNmI3OTkxNGZmNWJhYjQ2MmUy M2JiZWIzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAxOC0wNi0zMCAgRGF2aWQgS2ls emVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBjbGFuZyBzdGF0aWMgYW5h bHl6ZXIgd2FybmluZ3M6IEdhcmJhZ2UgcmV0dXJuIHZhbHVlCisgICAgICAgIDxodHRwczovL3dl YmtpdC5vcmcvYi8xODcyMjQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYlBsYXRmb3JtU3RyYXRl Z2llcy5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBsYXRmb3JtU3RyYXRlZ2llczo6Y2hhbmdl Q291bnQpOgorICAgICAgICAoV2ViS2l0OjpXZWJQbGF0Zm9ybVN0cmF0ZWdpZXM6OmFkZFR5cGVz KToKKyAgICAgICAgKFdlYktpdDo6V2ViUGxhdGZvcm1TdHJhdGVnaWVzOjpzZXRUeXBlcyk6Cisg ICAgICAgIChXZWJLaXQ6OldlYlBsYXRmb3JtU3RyYXRlZ2llczo6c2V0QnVmZmVyRm9yVHlwZSk6 CisgICAgICAgIChXZWJLaXQ6OldlYlBsYXRmb3JtU3RyYXRlZ2llczo6c2V0UGF0aG5hbWVzRm9y VHlwZSk6CisgICAgICAgIChXZWJLaXQ6OldlYlBsYXRmb3JtU3RyYXRlZ2llczo6c2V0U3RyaW5n Rm9yVHlwZSk6CisgICAgICAgIChXZWJLaXQ6OldlYlBsYXRmb3JtU3RyYXRlZ2llczo6Z2V0TnVt YmVyT2ZGaWxlcyk6CisgICAgICAgIChXZWJLaXQ6OldlYlBsYXRmb3JtU3RyYXRlZ2llczo6Z2V0 UGFzdGVib2FyZEl0ZW1zQ291bnQpOgorICAgICAgICAoV2ViS2l0OjpXZWJQbGF0Zm9ybVN0cmF0 ZWdpZXM6OndyaXRlQ3VzdG9tRGF0YSk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJDb3JlU3Vw cG9ydC9tYWMvV2ViRWRpdG9yQ2xpZW50TWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJFZGl0 b3JDbGllbnQ6OnN1YnN0aXR1dGlvbnNQYW5lbElzU2hvd2luZyk6CisgICAgICAgIC0gVXNlIGJy YWNlIGluaXRpYWxpemF0aW9uIGZvciBsb2NhbCB2YXJpYWJsZXMuCisKIDIwMTgtMDYtMjkgIENo cmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZWdyZXNzaW9uKHIyMzMz NTkpOiBDYXVzZWQgSVRQIHRlc3RzIHRvIGJlIGZsYWt5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvYnl0ZWNvZGUvVW5saW5rZWRDb2RlQmxvY2suY3BwIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2J5dGVjb2RlL1VubGlua2VkQ29kZUJsb2NrLmNwcAppbmRleCBjZWZlM2NlNDE4 OGYxODQ5ZTVhZDI1YjZlMTFmMWE1ZjkzNjdkZDVkLi4zMGVlNjY0ODI4ZmE3ZDMzYTZlMjc1NmY3 NjkwZWM2YTliMmRiYzI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNv ZGUvVW5saW5rZWRDb2RlQmxvY2suY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRl Y29kZS9VbmxpbmtlZENvZGVCbG9jay5jcHAKQEAgLTExOCwxMSArMTE4LDExIEBAIHNpemVfdCBV bmxpbmtlZENvZGVCbG9jazo6ZXN0aW1hdGVkU2l6ZShKU0NlbGwqIGNlbGwpCiBpbnQgVW5saW5r ZWRDb2RlQmxvY2s6OmxpbmVOdW1iZXJGb3JCeXRlY29kZU9mZnNldCh1bnNpZ25lZCBieXRlY29k ZU9mZnNldCkKIHsKICAgICBBU1NFUlQoYnl0ZWNvZGVPZmZzZXQgPCBpbnN0cnVjdGlvbnMoKS5j b3VudCgpKTsKLSAgICBpbnQgZGl2b3Q7Ci0gICAgaW50IHN0YXJ0T2Zmc2V0OwotICAgIGludCBl bmRPZmZzZXQ7Ci0gICAgdW5zaWduZWQgbGluZTsKLSAgICB1bnNpZ25lZCBjb2x1bW47CisgICAg aW50IGRpdm90IHsgMCB9OworICAgIGludCBzdGFydE9mZnNldCB7IDAgfTsKKyAgICBpbnQgZW5k T2Zmc2V0IHsgMCB9OworICAgIHVuc2lnbmVkIGxpbmUgeyAwIH07CisgICAgdW5zaWduZWQgY29s dW1uIHsgMCB9OwogICAgIGV4cHJlc3Npb25SYW5nZUZvckJ5dGVjb2RlT2Zmc2V0KGJ5dGVjb2Rl T2Zmc2V0LCBkaXZvdCwgc3RhcnRPZmZzZXQsIGVuZE9mZnNldCwgbGluZSwgY29sdW1uKTsKICAg ICByZXR1cm4gbGluZTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1 Z2dlci9EZWJ1Z2dlckNhbGxGcmFtZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdn ZXIvRGVidWdnZXJDYWxsRnJhbWUuY3BwCmluZGV4IDU2NTMyOTZiZjYyMjdiYjU0ZGNhNmFiYmVi YmNhYjdjODQwZDJmZGYuLjg2YWZjNjkxYzJiNzI1MThjMWNmZGI5OTljNjlhNTMzMTU2MWRmNTUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dlci9EZWJ1Z2dlckNhbGxG cmFtZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2VyQ2Fs bEZyYW1lLmNwcApAQCAtNTcsOCArNTcsOCBAQCBwdWJsaWM6CiAgICAgdW5zaWduZWQgY29sdW1u KCkgY29uc3QgeyByZXR1cm4gbV9jb2x1bW47IH0KIAogcHJpdmF0ZToKLSAgICBtdXRhYmxlIHVu c2lnbmVkIG1fbGluZTsKLSAgICBtdXRhYmxlIHVuc2lnbmVkIG1fY29sdW1uOworICAgIG11dGFi bGUgdW5zaWduZWQgbV9saW5lIHsgMCB9OworICAgIG11dGFibGUgdW5zaWduZWQgbV9jb2x1bW4g eyAwIH07CiB9OwogCiBSZWY8RGVidWdnZXJDYWxsRnJhbWU+IERlYnVnZ2VyQ2FsbEZyYW1lOjpj cmVhdGUoVk0mIHZtLCBDYWxsRnJhbWUqIGNhbGxGcmFtZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhQ29uc3RyYWludHMuaCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhQ29uc3RyYWludHMuaAppbmRleCA0MWUw ZTc2OTY5MTdlNTBiNDFmMWI1ODRmNWVhMGZmNGZlYjdhMjY4Li5kYTk2MmNmZDY0MjE4MmE4Njk3 YmRjMWY5M2E5MzdjMmM5N2E5MmExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9tZWRpYXN0cmVhbS9NZWRpYUNvbnN0cmFpbnRzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWVkaWFzdHJlYW0vTWVkaWFDb25zdHJhaW50cy5oCkBAIC0yNDAsNyArMjQwLDcgQEAg cHVibGljOgogCiAgICAgVmFsdWVUeXBlIHZhbHVlRm9yQ2FwYWJpbGl0eVJhbmdlKFZhbHVlVHlw ZSBjdXJyZW50LCBWYWx1ZVR5cGUgY2FwYWJpbGl0eU1pbiwgVmFsdWVUeXBlIGNhcGFiaWxpdHlN YXgpIGNvbnN0CiAgICAgewotICAgICAgICBWYWx1ZVR5cGUgdmFsdWU7CisgICAgICAgIFZhbHVl VHlwZSB2YWx1ZSB7IDAgfTsKICAgICAgICAgVmFsdWVUeXBlIG1pbiA9IGNhcGFiaWxpdHlNaW47 CiAgICAgICAgIFZhbHVlVHlwZSBtYXggPSBjYXBhYmlsaXR5TWF4OwogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViUGxhdGZvcm1TdHJhdGVn aWVzLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJQbGF0 Zm9ybVN0cmF0ZWdpZXMuY3BwCmluZGV4IDE1OWYzZGE5YjFkMjI2Yzk1N2M0ODAzN2IxZmQ5ZDVi MDI2NzFkZDUuLmVkZjJiMDU1MjczNWFmZDJkMjc2ZTIwZjg5OGQxZjZkOGE5NGQyOTggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJQbGF0Zm9y bVN0cmF0ZWdpZXMuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3Vw cG9ydC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuY3BwCkBAIC0xODIsNyArMTgyLDcgQEAgUmVmUHRy PFdlYkNvcmU6OlNoYXJlZEJ1ZmZlcj4gV2ViUGxhdGZvcm1TdHJhdGVnaWVzOjpidWZmZXJGb3JU eXBlKGNvbnN0IFN0cmluZyYKIAogICAgIC8vIEZhbGxiYWNrIHRvIG1lc3NhZ2luZyB0aGUgVUkg cHJvY2VzcyBmb3IgbmF0aXZlIHBhc3RlYm9hcmQgY29udGVudC4KICAgICBTaGFyZWRNZW1vcnk6 OkhhbmRsZSBoYW5kbGU7Ci0gICAgdWludDY0X3Qgc2l6ZSA9IDA7CisgICAgdWludDY0X3Qgc2l6 ZSB7IDAgfTsKICAgICBXZWJQcm9jZXNzOjpzaW5nbGV0b24oKS5wYXJlbnRQcm9jZXNzQ29ubmVj dGlvbigpLT5zZW5kU3luYyhNZXNzYWdlczo6V2ViUGFzdGVib2FyZFByb3h5OjpHZXRQYXN0ZWJv YXJkQnVmZmVyRm9yVHlwZShwYXN0ZWJvYXJkTmFtZSwgcGFzdGVib2FyZFR5cGUpLCBNZXNzYWdl czo6V2ViUGFzdGVib2FyZFByb3h5OjpHZXRQYXN0ZWJvYXJkQnVmZmVyRm9yVHlwZTo6UmVwbHko aGFuZGxlLCBzaXplKSwgMCk7CiAgICAgaWYgKGhhbmRsZS5pc051bGwoKSkKICAgICAgICAgcmV0 dXJuIG51bGxwdHI7CkBAIC0yMTEsNyArMjExLDcgQEAgU3RyaW5nIFdlYlBsYXRmb3JtU3RyYXRl Z2llczo6c3RyaW5nRm9yVHlwZShjb25zdCBTdHJpbmcmIHBhc3RlYm9hcmRUeXBlLCBjb25zdAog CiBsb25nIFdlYlBsYXRmb3JtU3RyYXRlZ2llczo6Y2hhbmdlQ291bnQoY29uc3QgV1RGOjpTdHJp bmcgJnBhc3RlYm9hcmROYW1lKQogewotICAgIHVpbnQ2NF90IGNoYW5nZUNvdW50OworICAgIHVp bnQ2NF90IGNoYW5nZUNvdW50IHsgMCB9OwogICAgIFdlYlByb2Nlc3M6OnNpbmdsZXRvbigpLnBh cmVudFByb2Nlc3NDb25uZWN0aW9uKCktPnNlbmRTeW5jKE1lc3NhZ2VzOjpXZWJQYXN0ZWJvYXJk UHJveHk6OkdldFBhc3RlYm9hcmRDaGFuZ2VDb3VudChwYXN0ZWJvYXJkTmFtZSksIE1lc3NhZ2Vz OjpXZWJQYXN0ZWJvYXJkUHJveHk6OkdldFBhc3RlYm9hcmRDaGFuZ2VDb3VudDo6UmVwbHkoY2hh bmdlQ291bnQpLCAwKTsKICAgICByZXR1cm4gY2hhbmdlQ291bnQ7CiB9CkBAIC0yMzksMTQgKzIz OSwxNCBAQCBVUkwgV2ViUGxhdGZvcm1TdHJhdGVnaWVzOjp1cmwoY29uc3QgU3RyaW5nJiBwYXN0 ZWJvYXJkTmFtZSkKIAogbG9uZyBXZWJQbGF0Zm9ybVN0cmF0ZWdpZXM6OmFkZFR5cGVzKGNvbnN0 IFZlY3RvcjxTdHJpbmc+JiBwYXN0ZWJvYXJkVHlwZXMsIGNvbnN0IFN0cmluZyYgcGFzdGVib2Fy ZE5hbWUpCiB7Ci0gICAgdWludDY0X3QgbmV3Q2hhbmdlQ291bnQ7CisgICAgdWludDY0X3QgbmV3 Q2hhbmdlQ291bnQgeyAwIH07CiAgICAgV2ViUHJvY2Vzczo6c2luZ2xldG9uKCkucGFyZW50UHJv Y2Vzc0Nvbm5lY3Rpb24oKS0+c2VuZFN5bmMoTWVzc2FnZXM6OldlYlBhc3RlYm9hcmRQcm94eTo6 QWRkUGFzdGVib2FyZFR5cGVzKHBhc3RlYm9hcmROYW1lLCBwYXN0ZWJvYXJkVHlwZXMpLCBNZXNz YWdlczo6V2ViUGFzdGVib2FyZFByb3h5OjpBZGRQYXN0ZWJvYXJkVHlwZXM6OlJlcGx5KG5ld0No YW5nZUNvdW50KSwgMCk7CiAgICAgcmV0dXJuIG5ld0NoYW5nZUNvdW50OwogfQogCiBsb25nIFdl YlBsYXRmb3JtU3RyYXRlZ2llczo6c2V0VHlwZXMoY29uc3QgVmVjdG9yPFN0cmluZz4mIHBhc3Rl Ym9hcmRUeXBlcywgY29uc3QgU3RyaW5nJiBwYXN0ZWJvYXJkTmFtZSkKIHsKLSAgICB1aW50NjRf dCBuZXdDaGFuZ2VDb3VudDsKKyAgICB1aW50NjRfdCBuZXdDaGFuZ2VDb3VudCB7IDAgfTsKICAg ICBXZWJQcm9jZXNzOjpzaW5nbGV0b24oKS5wYXJlbnRQcm9jZXNzQ29ubmVjdGlvbigpLT5zZW5k U3luYyhNZXNzYWdlczo6V2ViUGFzdGVib2FyZFByb3h5OjpTZXRQYXN0ZWJvYXJkVHlwZXMocGFz dGVib2FyZE5hbWUsIHBhc3RlYm9hcmRUeXBlcyksIE1lc3NhZ2VzOjpXZWJQYXN0ZWJvYXJkUHJv eHk6OlNldFBhc3RlYm9hcmRUeXBlczo6UmVwbHkobmV3Q2hhbmdlQ291bnQpLCAwKTsKICAgICBy ZXR1cm4gbmV3Q2hhbmdlQ291bnQ7CiB9CkBAIC0yNjMsMjggKzI2MywyOCBAQCBsb25nIFdlYlBs YXRmb3JtU3RyYXRlZ2llczo6c2V0QnVmZmVyRm9yVHlwZShTaGFyZWRCdWZmZXIqIGJ1ZmZlciwg Y29uc3QgU3RyaW5nJgogICAgICAgICAgICAgc2hhcmVkTWVtb3J5QnVmZmVyLT5jcmVhdGVIYW5k bGUoaGFuZGxlLCBTaGFyZWRNZW1vcnk6OlByb3RlY3Rpb246OlJlYWRPbmx5KTsKICAgICAgICAg fQogICAgIH0KLSAgICB1aW50NjRfdCBuZXdDaGFuZ2VDb3VudDsKKyAgICB1aW50NjRfdCBuZXdD aGFuZ2VDb3VudCB7IDAgfTsKICAgICBXZWJQcm9jZXNzOjpzaW5nbGV0b24oKS5wYXJlbnRQcm9j ZXNzQ29ubmVjdGlvbigpLT5zZW5kU3luYyhNZXNzYWdlczo6V2ViUGFzdGVib2FyZFByb3h5OjpT ZXRQYXN0ZWJvYXJkQnVmZmVyRm9yVHlwZShwYXN0ZWJvYXJkTmFtZSwgcGFzdGVib2FyZFR5cGUs IGhhbmRsZSwgYnVmZmVyID8gYnVmZmVyLT5zaXplKCkgOiAwKSwgTWVzc2FnZXM6OldlYlBhc3Rl Ym9hcmRQcm94eTo6U2V0UGFzdGVib2FyZEJ1ZmZlckZvclR5cGU6OlJlcGx5KG5ld0NoYW5nZUNv dW50KSwgMCk7CiAgICAgcmV0dXJuIG5ld0NoYW5nZUNvdW50OwogfQogCiBsb25nIFdlYlBsYXRm b3JtU3RyYXRlZ2llczo6c2V0UGF0aG5hbWVzRm9yVHlwZShjb25zdCBWZWN0b3I8U3RyaW5nPiYg cGF0aG5hbWVzLCBjb25zdCBTdHJpbmcmIHBhc3RlYm9hcmRUeXBlLCBjb25zdCBTdHJpbmcmIHBh c3RlYm9hcmROYW1lKQogewotICAgIHVpbnQ2NF90IG5ld0NoYW5nZUNvdW50OworICAgIHVpbnQ2 NF90IG5ld0NoYW5nZUNvdW50IHsgMCB9OwogICAgIFdlYlByb2Nlc3M6OnNpbmdsZXRvbigpLnBh cmVudFByb2Nlc3NDb25uZWN0aW9uKCktPnNlbmRTeW5jKE1lc3NhZ2VzOjpXZWJQYXN0ZWJvYXJk UHJveHk6OlNldFBhc3RlYm9hcmRQYXRobmFtZXNGb3JUeXBlKHBhc3RlYm9hcmROYW1lLCBwYXN0 ZWJvYXJkVHlwZSwgcGF0aG5hbWVzKSwgTWVzc2FnZXM6OldlYlBhc3RlYm9hcmRQcm94eTo6U2V0 UGFzdGVib2FyZFBhdGhuYW1lc0ZvclR5cGU6OlJlcGx5KG5ld0NoYW5nZUNvdW50KSwgMCk7CiAg ICAgcmV0dXJuIG5ld0NoYW5nZUNvdW50OwogfQogCiBsb25nIFdlYlBsYXRmb3JtU3RyYXRlZ2ll czo6c2V0U3RyaW5nRm9yVHlwZShjb25zdCBTdHJpbmcmIHN0cmluZywgY29uc3QgU3RyaW5nJiBw YXN0ZWJvYXJkVHlwZSwgY29uc3QgU3RyaW5nJiBwYXN0ZWJvYXJkTmFtZSkKIHsKLSAgICB1aW50 NjRfdCBuZXdDaGFuZ2VDb3VudDsKKyAgICB1aW50NjRfdCBuZXdDaGFuZ2VDb3VudCB7IDAgfTsK ICAgICBXZWJQcm9jZXNzOjpzaW5nbGV0b24oKS5wYXJlbnRQcm9jZXNzQ29ubmVjdGlvbigpLT5z ZW5kU3luYyhNZXNzYWdlczo6V2ViUGFzdGVib2FyZFByb3h5OjpTZXRQYXN0ZWJvYXJkU3RyaW5n Rm9yVHlwZShwYXN0ZWJvYXJkTmFtZSwgcGFzdGVib2FyZFR5cGUsIHN0cmluZyksIE1lc3NhZ2Vz OjpXZWJQYXN0ZWJvYXJkUHJveHk6OlNldFBhc3RlYm9hcmRTdHJpbmdGb3JUeXBlOjpSZXBseShu ZXdDaGFuZ2VDb3VudCksIDApOwogICAgIHJldHVybiBuZXdDaGFuZ2VDb3VudDsKIH0KIAogaW50 IFdlYlBsYXRmb3JtU3RyYXRlZ2llczo6Z2V0TnVtYmVyT2ZGaWxlcyhjb25zdCBTdHJpbmcmIHBh c3RlYm9hcmROYW1lKQogewotICAgIHVpbnQ2NF90IG51bWJlck9mRmlsZXM7CisgICAgdWludDY0 X3QgbnVtYmVyT2ZGaWxlcyB7IDAgfTsKICAgICBXZWJQcm9jZXNzOjpzaW5nbGV0b24oKS5wYXJl bnRQcm9jZXNzQ29ubmVjdGlvbigpLT5zZW5kU3luYyhNZXNzYWdlczo6V2ViUGFzdGVib2FyZFBy b3h5OjpHZXROdW1iZXJPZkZpbGVzKHBhc3RlYm9hcmROYW1lKSwgTWVzc2FnZXM6OldlYlBhc3Rl Ym9hcmRQcm94eTo6R2V0TnVtYmVyT2ZGaWxlczo6UmVwbHkobnVtYmVyT2ZGaWxlcyksIDApOwog ICAgIHJldHVybiBudW1iZXJPZkZpbGVzOwogfQpAQCAtMzE3LDcgKzMxNyw3IEBAIHZvaWQgV2Vi UGxhdGZvcm1TdHJhdGVnaWVzOjp3cml0ZVRvUGFzdGVib2FyZChjb25zdCBTdHJpbmcmIHBhc3Rl Ym9hcmRUeXBlLCBjb25zCiAKIGludCBXZWJQbGF0Zm9ybVN0cmF0ZWdpZXM6OmdldFBhc3RlYm9h cmRJdGVtc0NvdW50KGNvbnN0IFN0cmluZyYgcGFzdGVib2FyZE5hbWUpCiB7Ci0gICAgdWludDY0 X3QgaXRlbXNDb3VudDsKKyAgICB1aW50NjRfdCBpdGVtc0NvdW50IHsgMCB9OwogICAgIFdlYlBy b2Nlc3M6OnNpbmdsZXRvbigpLnBhcmVudFByb2Nlc3NDb25uZWN0aW9uKCktPnNlbmRTeW5jKE1l c3NhZ2VzOjpXZWJQYXN0ZWJvYXJkUHJveHk6OkdldFBhc3RlYm9hcmRJdGVtc0NvdW50KHBhc3Rl Ym9hcmROYW1lKSwgTWVzc2FnZXM6OldlYlBhc3RlYm9hcmRQcm94eTo6R2V0UGFzdGVib2FyZEl0 ZW1zQ291bnQ6OlJlcGx5KGl0ZW1zQ291bnQpLCAwKTsKICAgICByZXR1cm4gaXRlbXNDb3VudDsK IH0KQEAgLTM0NCw3ICszNDQsNyBAQCB2b2lkIFdlYlBsYXRmb3JtU3RyYXRlZ2llczo6dXBkYXRl U3VwcG9ydGVkVHlwZUlkZW50aWZpZXJzKGNvbnN0IFZlY3RvcjxTdHJpbmc+JgogUmVmUHRyPFdl YkNvcmU6OlNoYXJlZEJ1ZmZlcj4gV2ViUGxhdGZvcm1TdHJhdGVnaWVzOjpyZWFkQnVmZmVyRnJv bVBhc3RlYm9hcmQoaW50IGluZGV4LCBjb25zdCBTdHJpbmcmIHBhc3RlYm9hcmRUeXBlLCBjb25z dCBTdHJpbmcmIHBhc3RlYm9hcmROYW1lKQogewogICAgIFNoYXJlZE1lbW9yeTo6SGFuZGxlIGhh bmRsZTsKLSAgICB1aW50NjRfdCBzaXplID0gMDsKKyAgICB1aW50NjRfdCBzaXplIHsgMCB9Owog ICAgIFdlYlByb2Nlc3M6OnNpbmdsZXRvbigpLnBhcmVudFByb2Nlc3NDb25uZWN0aW9uKCktPnNl bmRTeW5jKE1lc3NhZ2VzOjpXZWJQYXN0ZWJvYXJkUHJveHk6OlJlYWRCdWZmZXJGcm9tUGFzdGVi b2FyZChpbmRleCwgcGFzdGVib2FyZFR5cGUsIHBhc3RlYm9hcmROYW1lKSwgTWVzc2FnZXM6Oldl YlBhc3RlYm9hcmRQcm94eTo6UmVhZEJ1ZmZlckZyb21QYXN0ZWJvYXJkOjpSZXBseShoYW5kbGUs IHNpemUpLCAwKTsKICAgICBpZiAoaGFuZGxlLmlzTnVsbCgpKQogICAgICAgICByZXR1cm4gbnVs bHB0cjsKQEAgLTQyMyw3ICs0MjMsNyBAQCBWZWN0b3I8U3RyaW5nPiBXZWJQbGF0Zm9ybVN0cmF0 ZWdpZXM6OnR5cGVzU2FmZUZvckRPTVRvUmVhZEFuZFdyaXRlKGNvbnN0IFN0cmluZwogCiBsb25n IFdlYlBsYXRmb3JtU3RyYXRlZ2llczo6d3JpdGVDdXN0b21EYXRhKGNvbnN0IFdlYkNvcmU6OlBh c3RlYm9hcmRDdXN0b21EYXRhJiBkYXRhLCBjb25zdCBTdHJpbmcmIHBhc3RlYm9hcmROYW1lKQog ewotICAgIHVpbnQ2NF90IG5ld0NoYW5nZUNvdW50OworICAgIHVpbnQ2NF90IG5ld0NoYW5nZUNv dW50IHsgMCB9OwogICAgIFdlYlByb2Nlc3M6OnNpbmdsZXRvbigpLnBhcmVudFByb2Nlc3NDb25u ZWN0aW9uKCktPnNlbmRTeW5jKE1lc3NhZ2VzOjpXZWJQYXN0ZWJvYXJkUHJveHk6OldyaXRlQ3Vz dG9tRGF0YShkYXRhLCBwYXN0ZWJvYXJkTmFtZSksIE1lc3NhZ2VzOjpXZWJQYXN0ZWJvYXJkUHJv eHk6OldyaXRlQ3VzdG9tRGF0YTo6UmVwbHkobmV3Q2hhbmdlQ291bnQpLCAwKTsKICAgICByZXR1 cm4gbmV3Q2hhbmdlQ291bnQ7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvV2ViQ29yZVN1cHBvcnQvbWFjL1dlYkVkaXRvckNsaWVudE1hYy5tbSBiL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9tYWMvV2ViRWRpdG9yQ2xpZW50TWFjLm1tCmlu ZGV4IDVmMWViMjkxYTA0Mzc1NmY0MWI2MGI1OTZkNmRiMzk4YTNlMzgwNWMuLmE2ZGYzZDY2Mjk1 OWRkMjlmYjIwZTNlMDc2YWFhMjYzNTgzYmFkNTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9tYWMvV2ViRWRpdG9yQ2xpZW50TWFjLm1tCisrKyBi L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9tYWMvV2ViRWRpdG9yQ2xp ZW50TWFjLm1tCkBAIC0xMDAsNyArMTAwLDcgQEAgdm9pZCBXZWJFZGl0b3JDbGllbnQ6OnNob3dT dWJzdGl0dXRpb25zUGFuZWwoYm9vbCkKIAogYm9vbCBXZWJFZGl0b3JDbGllbnQ6OnN1YnN0aXR1 dGlvbnNQYW5lbElzU2hvd2luZygpCiB7Ci0gICAgYm9vbCBpc1Nob3dpbmc7CisgICAgYm9vbCBp c1Nob3dpbmcgeyBmYWxzZSB9OwogICAgIG1fcGFnZS0+c2VuZFN5bmMoTWVzc2FnZXM6OldlYlBh Z2VQcm94eTo6U3Vic3RpdHV0aW9uc1BhbmVsSXNTaG93aW5nKCksIE1lc3NhZ2VzOjpXZWJQYWdl UHJveHk6OlN1YnN0aXR1dGlvbnNQYW5lbElzU2hvd2luZzo6UmVwbHkoaXNTaG93aW5nKSk7CiAg ICAgcmV0dXJuIGlzU2hvd2luZzsKIH0K