187201 2018-06-29 16:11:33 -0700 [ews-build] Add support for JSC-Tests-EWS 2018-07-05 15:03:24 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=187365 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap ews-watchlist lforschler webkit-bug-importer oldest_to_newest 1437958 0 aakash_jain 2018-06-29 16:11:33 -0700 We should add support for JSC-Tests-EWS. It would involve two main steps: building (Tools/Scripts/build-jsc), and then running jsc tests (Tools/Scripts/run-javascriptcore-tests). 1437963 1 343964 aakash_jain 2018-06-29 16:18:13 -0700 Created attachment 343964 Patch for compiling JSC This is part 1 - to compile JSC. Part 2 to run JSC tests will be in separate patch. CompileJSCOnly class is similar to https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py#L253 Sample run: http://ews-build.webkit-uat.org/#/builders/17/builds/5 1437965 2 ews-watchlist 2018-06-29 16:21:02 -0700 Attachment 343964 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:423: [TestCompileWebKit.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:423: [TestCompileWebKit.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:437: [TestCompileWebKit.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:437: [TestCompileWebKit.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:459: [TestCompileJSCOnly.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:459: [TestCompileJSCOnly.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:473: [TestCompileJSCOnly.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:473: [TestCompileJSCOnly.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 8 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1439575 3 aakash_jain 2018-07-05 15:02:04 -0700 Committed r233471: <https://trac.webkit.org/changeset/233471> 1439578 4 webkit-bug-importer 2018-07-05 15:03:24 -0700 <rdar://problem/41866045> 343964 2018-06-29 16:18:13 -0700 2018-07-03 11:23:52 -0700 Patch for compiling JSC ews_jsc_build.patch text/plain 5789 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzMzM3NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE4LTA2LTI5ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBBZGQgc3VwcG9ydCBmb3IgSlNDLVRlc3RzLUVXUwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3MjAxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNs YXZlU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzLnB5OgorICAgICAgICAoSlNDVGVzdHNGYWN0 b3J5KTogQWRkZWQgSlNDVGVzdHNGYWN0b3J5LgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0 L2V3cy1idWlsZC9zdGVwcy5weToKKyAgICAgICAgKENvbXBpbGVKU0NPbmx5KTogQ29tbWFuZCB0 byBjb21waWxlIEpTQy4KKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3Rl cHNfdW5pdHRlc3QucHk6IFVwZGF0ZWQgdW5pdC10ZXN0cy4KKyAgICAgICAgKiBCdWlsZFNsYXZl U3VwcG9ydC9ld3MtYnVpbGQvY29uZmlnLmpzb246IENoYW5nZWQgcGxhdGZvcm0gdG8ganNjLW9u bHkuIFRoaXMgbWF0Y2hlcyB3aXRoIGJ1aWxkLndlYmtpdC5vcmcgY29uZmlndXJhdGlvbi4KKwog MjAxOC0wNi0yOSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFdl YktpdExlZ2FjeTogQ2FuIHRyaWdnZXIgcmVjdXJzaXZlIGxvYWRzIHRyaWdnZXJpbmcgZGVidWcg YXNzZXJ0aW9ucwpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2NvbmZp Zy5qc29uCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9j b25maWcuanNvbgkocmV2aXNpb24gMjMzMzc0KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv ZXdzLWJ1aWxkL2NvbmZpZy5qc29uCSh3b3JraW5nIGNvcHkpCkBAIC0xMzQsMTEgKzEzNCwxMSBA QAogICAgIH0sCiAgICAgewogICAgICAgIm5hbWUiOiAiZXdzMTI3IiwKLSAgICAgICJwbGF0Zm9y bSI6ICIqIgorICAgICAgInBsYXRmb3JtIjogImpzYy1vbmx5IgogICAgIH0sCiAgICAgewogICAg ICAgIm5hbWUiOiAiZXdzMTI4IiwKLSAgICAgICJwbGF0Zm9ybSI6ICIqIgorICAgICAgInBsYXRm b3JtIjogImpzYy1vbmx5IgogICAgIH0sCiAgICAgewogICAgICAgIm5hbWUiOiAiZXdzMjAwIiwK QEAgLTI1Nyw5ICsyNTcsMTAgQEAKICAgICAgICJ3b3JrZXJuYW1lcyI6IFsiaWdhbGlhLXdwZS1l d3MiLCAiYXBlcmV6LXdwZS1nY2M1LWV3cyIsICJhcGVyZXotd3BlLWdjYzYtZXdzIl0KICAgICB9 LAogICAgIHsKLSAgICAgICJuYW1lIjogIkpTQy10ZXN0cy1FV1MiLAorICAgICAgIm5hbWUiOiAi SlNDLVRlc3RzLUVXUyIsCiAgICAgICAiZmFjdG9yeSI6ICJKU0NUZXN0c0ZhY3RvcnkiLAotICAg ICAgInBsYXRmb3JtIjogIioiLAorICAgICAgInBsYXRmb3JtIjogImpzYy1vbmx5IiwKKyAgICAg ICJjb25maWd1cmF0aW9uIjogInJlbGVhc2UiLAogICAgICAgIndvcmtlcm5hbWVzIjogWyJld3Mx MjciLCAiZXdzMTI4Il0KICAgICB9LAogICAgIHsKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2V3cy1idWlsZC9mYWN0b3JpZXMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllcy5weQkocmV2aXNpb24gMjMzMzc0KQorKysgVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllcy5weQkod29ya2luZyBjb3B5 KQpAQCAtNjUsNiArNjUsMTIgQEAgY2xhc3MgQnVpbGRGYWN0b3J5KEZhY3RvcnkpOgogICAgICAg ICBzZWxmLmFkZFN0ZXAoQ29tcGlsZVdlYktpdCgpKQogCiAKK2NsYXNzIEpTQ1Rlc3RzRmFjdG9y eShGYWN0b3J5KToKKyAgICBkZWYgX19pbml0X18oc2VsZiwgcGxhdGZvcm0sIGNvbmZpZ3VyYXRp b249J3JlbGVhc2UnLCBhcmNoaXRlY3R1cmVzPU5vbmUsIGFkZGl0aW9uYWxBcmd1bWVudHM9Tm9u ZSwgKiprd2FyZ3MpOgorICAgICAgICBGYWN0b3J5Ll9faW5pdF9fKHNlbGYsIHBsYXRmb3JtLCBj b25maWd1cmF0aW9uLCBhcmNoaXRlY3R1cmVzLCBGYWxzZSwgYWRkaXRpb25hbEFyZ3VtZW50cykK KyAgICAgICAgc2VsZi5hZGRTdGVwKENvbXBpbGVKU0NPbmx5KCkpCisKKwogY2xhc3MgR1RLRmFj dG9yeShGYWN0b3J5KToKICAgICBwYXNzCiAKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2V3cy1idWlsZC9zdGVwcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9y dC9ld3MtYnVpbGQvc3RlcHMucHkJKHJldmlzaW9uIDIzMzM3NCkKKysrIFRvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAtMTE3LDggKzEx Nyw4IEBAIGRlZiBhcHBlbmRDdXN0b21CdWlsZEZsYWdzKHN0ZXAsIHBsYXRmb3IKIAogY2xhc3Mg Q29tcGlsZVdlYktpdChzaGVsbC5Db21waWxlKToKICAgICBuYW1lID0gImNvbXBpbGUtd2Via2l0 IgotICAgIGRlc2NyaXB0aW9uID0gWyJjb21waWxpbmcgd2Via2l0Il0KLSAgICBkZXNjcmlwdGlv bkRvbmUgPSBbImNvbXBpbGVkIHdlYmtpdCJdCisgICAgZGVzY3JpcHRpb24gPSBbImNvbXBpbGlu ZyJdCisgICAgZGVzY3JpcHRpb25Eb25lID0gWyJjb21waWxlZCJdCiAgICAgZW52ID0geydNRkxB R1MnOiAnJ30KICAgICB3YXJuaW5nUGF0dGVybiA9ICIuKmFybmluZzogLioiCiAgICAgY29tbWFu ZCA9IFsicGVybCIsICJUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCIsIFdpdGhQcm9wZXJ0aWVz KCItLSUoY29uZmlndXJhdGlvbilzIildCkBAIC0xNDcsNiArMTQ3LDEwIEBAIGNsYXNzIENvbXBp bGVXZWJLaXQoc2hlbGwuQ29tcGlsZSk6CiAgICAgICAgIHJldHVybiBzaGVsbC5Db21waWxlLnN0 YXJ0KHNlbGYpCiAKIAorY2xhc3MgQ29tcGlsZUpTQ09ubHkoQ29tcGlsZVdlYktpdCk6CisgICAg Y29tbWFuZCA9IFsicGVybCIsICJUb29scy9TY3JpcHRzL2J1aWxkLWpzYyIsIFdpdGhQcm9wZXJ0 aWVzKCItLSUoY29uZmlndXJhdGlvbilzIildCisKKwogY2xhc3MgQ2xlYW5CdWlsZChzaGVsbC5D b21waWxlKToKICAgICBuYW1lID0gImRlbGV0ZS1XZWJLaXRCdWlsZC1kaXJlY3RvcnkiCiAgICAg ZGVzY3JpcHRpb24gPSBbImRlbGV0aW5nIFdlYktpdEJ1aWxkIGRpcmVjdG9yeSJdCkluZGV4OiBU b29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0 LnB5CShyZXZpc2lvbiAyMzMzNzQpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVp bGQvc3RlcHNfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTQyMCw3ICs0MjAsNyBAQCBj bGFzcyBUZXN0Q29tcGlsZVdlYktpdChCdWlsZFN0ZXBNaXhpbkFkCiAgICAgICAgICAgICAgICAg ICAgICAgICApCiAgICAgICAgICAgICArIDAsCiAgICAgICAgICkKLSAgICAgICAgc2VsZi5leHBl Y3RPdXRjb21lKHJlc3VsdD1TVUNDRVNTLCBzdGF0ZV9zdHJpbmc9J2NvbXBpbGVkIHdlYmtpdCcp CisgICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9U1VDQ0VTUywgc3RhdGVfc3RyaW5n PSdjb21waWxlZCcpCiAgICAgICAgIHJldHVybiBzZWxmLnJ1blN0ZXAoKQogCiAgICAgZGVmIHRl c3RfZmFpbHVyZShzZWxmKToKQEAgLTQzNCw3ICs0MzQsNDMgQEAgY2xhc3MgVGVzdENvbXBpbGVX ZWJLaXQoQnVpbGRTdGVwTWl4aW5BZAogICAgICAgICAgICAgKyBFeHBlY3RTaGVsbC5sb2coJ3N0 ZGlvJywgc3Rkb3V0PScxIGVycm9yIGdlbmVyYXRlZC4nKQogICAgICAgICAgICAgKyAyLAogICAg ICAgICApCi0gICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9RkFJTFVSRSwgc3RhdGVf c3RyaW5nPSdjb21waWxlZCB3ZWJraXQgKGZhaWx1cmUpJykKKyAgICAgICAgc2VsZi5leHBlY3RP dXRjb21lKHJlc3VsdD1GQUlMVVJFLCBzdGF0ZV9zdHJpbmc9J2NvbXBpbGVkIChmYWlsdXJlKScp CisgICAgICAgIHJldHVybiBzZWxmLnJ1blN0ZXAoKQorCisKK2NsYXNzIFRlc3RDb21waWxlSlND T25seShCdWlsZFN0ZXBNaXhpbkFkZGl0aW9ucywgdW5pdHRlc3QuVGVzdENhc2UpOgorICAgIGRl ZiBzZXRVcChzZWxmKToKKyAgICAgICAgc2VsZi5sb25nTWVzc2FnZSA9IFRydWUKKyAgICAgICAg cmV0dXJuIHNlbGYuc2V0VXBCdWlsZFN0ZXAoKQorCisgICAgZGVmIHRlYXJEb3duKHNlbGYpOgor ICAgICAgICByZXR1cm4gc2VsZi50ZWFyRG93bkJ1aWxkU3RlcCgpCisKKyAgICBkZWYgdGVzdF9z dWNjZXNzKHNlbGYpOgorICAgICAgICBzZWxmLnNldHVwU3RlcChDb21waWxlSlNDT25seSgpKQor ICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdmdWxsUGxhdGZvcm0nLCAnanNjLW9ubHknKQorICAg ICAgICBzZWxmLnNldFByb3BlcnR5KCdjb25maWd1cmF0aW9uJywgJ3JlbGVhc2UnKQorICAgICAg ICBzZWxmLmV4cGVjdFJlbW90ZUNvbW1hbmRzKAorICAgICAgICAgICAgRXhwZWN0U2hlbGwod29y a2Rpcj0nd2tkaXInLAorICAgICAgICAgICAgICAgICAgICAgICAgY29tbWFuZD1bInBlcmwiLCAi VG9vbHMvU2NyaXB0cy9idWlsZC1qc2MiLCAnLS1yZWxlYXNlJ10sCisgICAgICAgICAgICAgICAg ICAgICAgICApCisgICAgICAgICAgICArIDAsCisgICAgICAgICkKKyAgICAgICAgc2VsZi5leHBl Y3RPdXRjb21lKHJlc3VsdD1TVUNDRVNTLCBzdGF0ZV9zdHJpbmc9J2NvbXBpbGVkJykKKyAgICAg ICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCisKKyAgICBkZWYgdGVzdF9mYWlsdXJlKHNlbGYpOgor ICAgICAgICBzZWxmLnNldHVwU3RlcChDb21waWxlSlNDT25seSgpKQorICAgICAgICBzZWxmLnNl dFByb3BlcnR5KCdmdWxsUGxhdGZvcm0nLCAnanNjLW9ubHknKQorICAgICAgICBzZWxmLnNldFBy b3BlcnR5KCdjb25maWd1cmF0aW9uJywgJ2RlYnVnJykKKyAgICAgICAgc2VsZi5leHBlY3RSZW1v dGVDb21tYW5kcygKKyAgICAgICAgICAgIEV4cGVjdFNoZWxsKHdvcmtkaXI9J3drZGlyJywKKyAg ICAgICAgICAgICAgICAgICAgICAgIGNvbW1hbmQ9WyJwZXJsIiwgIlRvb2xzL1NjcmlwdHMvYnVp bGQtanNjIiwgJy0tZGVidWcnXSwKKyAgICAgICAgICAgICAgICAgICAgICAgICkKKyAgICAgICAg ICAgICsgRXhwZWN0U2hlbGwubG9nKCdzdGRpbycsIHN0ZG91dD0nMSBlcnJvciBnZW5lcmF0ZWQu JykKKyAgICAgICAgICAgICsgMiwKKyAgICAgICAgKQorICAgICAgICBzZWxmLmV4cGVjdE91dGNv bWUocmVzdWx0PUZBSUxVUkUsIHN0YXRlX3N0cmluZz0nY29tcGlsZWQgKGZhaWx1cmUpJykKICAg ICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCiAKIAo=