187189 2018-06-29 12:14:10 -0700 Regression(r233359): Caused ITP tests to be flaky 2018-06-29 14:01:32 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 187165 1 cdumez cdumez bfulgham commit-queue ryanhaddad webkit-bug-importer wilander youennf oldest_to_newest 1437855 0 cdumez 2018-06-29 12:14:10 -0700 r233359 caused ITP tests to be flaky. 1437859 1 343929 cdumez 2018-06-29 12:23:24 -0700 Created attachment 343929 Patch 1437861 2 343930 cdumez 2018-06-29 12:27:24 -0700 Created attachment 343930 Patch 1437873 3 343930 youennf 2018-06-29 13:19:31 -0700 Comment on attachment 343930 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343930&action=review > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1481 > + resolveDirectoriesIfNecessary(); That seems a bit odd to call it there but I guess this is fine since this is a method called only by our test infrastructure. 1437894 4 343930 commit-queue 2018-06-29 14:00:56 -0700 Comment on attachment 343930 Patch Clearing flags on attachment: 343930 Committed r233371: <https://trac.webkit.org/changeset/233371> 1437895 5 commit-queue 2018-06-29 14:00:58 -0700 All reviewed patches have been landed. Closing bug. 1437896 6 webkit-bug-importer 2018-06-29 14:01:32 -0700 <rdar://problem/41651469> 343929 2018-06-29 12:23:24 -0700 2018-06-29 12:27:23 -0700 Patch bug-187189-20180629122323.patch text/plain 3255 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMzY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFkN2ViNzk2OWVmOGQ5OTE2 ZTZhMmM3NjIzYmQzZjRhODQ2NTg4NGEuLmExNGE3ZjY5NjJmYTcwYmE1NWZlZGRkN2RhMjZkZTZj OWRkZTVlN2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTgtMDYtMjkgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIyMzMzNTkpOiBD YXVzZWQgSVRQIHRlc3RzIHRvIGJlIGZsYWt5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xODcxODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICByMjMzMzU5IHN0YXJ0ZWQgdXNpbmcgbV9yZXNvbHZlZENvbmZp Z3VyYXRpb24ucmVzb3VyY2VMb2FkU3RhdGlzdGljc0RpcmVjdG9yeSBpbnN0ZWFkIG9mCisgICAg ICAgIG1fY29uZmlndXJhdGlvbi5yZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGlyZWN0b3J5IGZvciB0 aGUgSVRQIHBhdGguIFRoaXMgaXMgY29uc2lzdGVudAorICAgICAgICB3aXRoIHdoYXQgd2UgZG8g Zm9yIG90aGVyIGRhdGFiYXNlIHBhdGhzIHNvIHRoYXQgdGhpbmdzIGxpa2UgJ34nIGluIHBhdGhz IGdldCByZXNvbHZlZC4KKworICAgICAgICBUaGlzIGludHJvZHVjZWQgZmxha2luZXNzIGJlY2F1 c2UgdGhlIHJlc291cmNlTG9hZFN0YXRpc3RpY3NEaXJlY3Rvcnkgd2FzIG5ldmVyIGdldHRpbmcK KyAgICAgICAgcmVzb2x2ZWQgYW5kIG1fcmVzb2x2ZWRDb25maWd1cmF0aW9uLnJlc291cmNlTG9h ZFN0YXRpc3RpY3NEaXJlY3Rvcnkgd2FzIG5vdCBzZXQuCisgICAgICAgIFVwZGF0ZSB0aGUgV2Vi c2l0ZURhdGFTdG9yZSBzbyB0aGF0IG1fcmVzb2x2ZWRDb25maWd1cmF0aW9uLnJlc291cmNlTG9h ZFN0YXRpc3RpY3NEaXJlY3RvcnkKKyAgICAgICAgcHJvcGVybHkgZ2V0cyBzZXQgdG8gdGhlIHJl c29sdmVkIHZlcnNpb24gb2YgbV9jb25maWd1cmF0aW9uLnJlc291cmNlTG9hZFN0YXRpc3RpY3NE aXJlY3RvcnkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFT dG9yZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYnNpdGVEYXRhU3RvcmU6OnJlc29sdmVEaXJl Y3Rvcmllc0lmTmVjZXNzYXJ5KToKKyAgICAgICAgKFdlYktpdDo6V2Vic2l0ZURhdGFTdG9yZTo6 ZW5hYmxlUmVzb3VyY2VMb2FkU3RhdGlzdGljc0FuZFNldFRlc3RpbmdDYWxsYmFjayk6CisKIDIw MTgtMDYtMjkgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBTdG9w IHVzaW5nIGxhbWJkYXMgZm9yIFdlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZSB0byBpbnRl cmFjdCB3aXRoIGl0cyBXZWJzaXRlRGF0YVN0b3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVN0b3JlLmNwcCBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwCmluZGV4IDFmYmRm NTYyNTFkZDE0Y2Y4ZDlmM2RlY2E2ZTAxYTRkNzc4ZTViMjQuLmM1YmE5YzVjYjQzMTFkMzEyOTgy NmQ3ODdlMzlmZWZlODdiYTQ4N2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwCkBAIC0xNjIsNiArMTYyLDgg QEAgdm9pZCBXZWJzaXRlRGF0YVN0b3JlOjpyZXNvbHZlRGlyZWN0b3JpZXNJZk5lY2Vzc2FyeSgp CiAgICAgICAgIG1fcmVzb2x2ZWRDb25maWd1cmF0aW9uLndlYlNRTERhdGFiYXNlRGlyZWN0b3J5 ID0gcmVzb2x2ZUFuZENyZWF0ZVJlYWRXcml0ZURpcmVjdG9yeUZvclNhbmRib3hFeHRlbnNpb24o bV9jb25maWd1cmF0aW9uLndlYlNRTERhdGFiYXNlRGlyZWN0b3J5KTsKICAgICBpZiAoIW1fY29u ZmlndXJhdGlvbi5pbmRleGVkREJEYXRhYmFzZURpcmVjdG9yeS5pc0VtcHR5KCkpCiAgICAgICAg IG1fcmVzb2x2ZWRDb25maWd1cmF0aW9uLmluZGV4ZWREQkRhdGFiYXNlRGlyZWN0b3J5ID0gcmVz b2x2ZUFuZENyZWF0ZVJlYWRXcml0ZURpcmVjdG9yeUZvclNhbmRib3hFeHRlbnNpb24obV9jb25m aWd1cmF0aW9uLmluZGV4ZWREQkRhdGFiYXNlRGlyZWN0b3J5KTsKKyAgICBpZiAoIW1fY29uZmln dXJhdGlvbi5yZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGlyZWN0b3J5LmlzRW1wdHkoKSkKKyAgICAg ICAgbV9yZXNvbHZlZENvbmZpZ3VyYXRpb24ucmVzb3VyY2VMb2FkU3RhdGlzdGljc0RpcmVjdG9y eSA9IHJlc29sdmVQYXRoRm9yU2FuZGJveEV4dGVuc2lvbihtX2NvbmZpZ3VyYXRpb24ucmVzb3Vy Y2VMb2FkU3RhdGlzdGljc0RpcmVjdG9yeSk7CiAgICAgaWYgKCFtX2NvbmZpZ3VyYXRpb24uc2Vy dmljZVdvcmtlclJlZ2lzdHJhdGlvbkRpcmVjdG9yeS5pc0VtcHR5KCkgJiYgbV9yZXNvbHZlZENv bmZpZ3VyYXRpb24uc2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbkRpcmVjdG9yeS5pc0VtcHR5KCkp CiAgICAgICAgIG1fcmVzb2x2ZWRDb25maWd1cmF0aW9uLnNlcnZpY2VXb3JrZXJSZWdpc3RyYXRp b25EaXJlY3RvcnkgPSByZXNvbHZlQW5kQ3JlYXRlUmVhZFdyaXRlRGlyZWN0b3J5Rm9yU2FuZGJv eEV4dGVuc2lvbihtX2NvbmZpZ3VyYXRpb24uc2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbkRpcmVj dG9yeSk7CiAgICAgaWYgKCFtX2NvbmZpZ3VyYXRpb24uamF2YVNjcmlwdENvbmZpZ3VyYXRpb25E aXJlY3RvcnkuaXNFbXB0eSgpKQpAQCAtMTQ3Niw2ICsxNDc4LDcgQEAgdm9pZCBXZWJzaXRlRGF0 YVN0b3JlOjplbmFibGVSZXNvdXJjZUxvYWRTdGF0aXN0aWNzQW5kU2V0VGVzdGluZ0NhbGxiYWNr KEZ1bmN0aW8KICAgICAgICAgcmV0dXJuOwogICAgIH0KIAorICAgIHJlc29sdmVEaXJlY3Rvcmll c0lmTmVjZXNzYXJ5KCk7CiAgICAgbV9yZXNvdXJjZUxvYWRTdGF0aXN0aWNzID0gV2ViUmVzb3Vy Y2VMb2FkU3RhdGlzdGljc1N0b3JlOjpjcmVhdGUoKnRoaXMpOwogICAgIG1fcmVzb3VyY2VMb2Fk U3RhdGlzdGljcy0+c2V0U3RhdGlzdGljc1Rlc3RpbmdDYWxsYmFjayhXVEZNb3ZlKGNhbGxiYWNr KSk7CiAK 343930 2018-06-29 12:27:24 -0700 2018-06-29 14:00:56 -0700 Patch bug-187189-20180629122724.patch text/plain 3278 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMzY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFkN2ViNzk2OWVmOGQ5OTE2 ZTZhMmM3NjIzYmQzZjRhODQ2NTg4NGEuLmExNGE3ZjY5NjJmYTcwYmE1NWZlZGRkN2RhMjZkZTZj OWRkZTVlN2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTgtMDYtMjkgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIyMzMzNTkpOiBD YXVzZWQgSVRQIHRlc3RzIHRvIGJlIGZsYWt5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xODcxODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICByMjMzMzU5IHN0YXJ0ZWQgdXNpbmcgbV9yZXNvbHZlZENvbmZp Z3VyYXRpb24ucmVzb3VyY2VMb2FkU3RhdGlzdGljc0RpcmVjdG9yeSBpbnN0ZWFkIG9mCisgICAg ICAgIG1fY29uZmlndXJhdGlvbi5yZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGlyZWN0b3J5IGZvciB0 aGUgSVRQIHBhdGguIFRoaXMgaXMgY29uc2lzdGVudAorICAgICAgICB3aXRoIHdoYXQgd2UgZG8g Zm9yIG90aGVyIGRhdGFiYXNlIHBhdGhzIHNvIHRoYXQgdGhpbmdzIGxpa2UgJ34nIGluIHBhdGhz IGdldCByZXNvbHZlZC4KKworICAgICAgICBUaGlzIGludHJvZHVjZWQgZmxha2luZXNzIGJlY2F1 c2UgdGhlIHJlc291cmNlTG9hZFN0YXRpc3RpY3NEaXJlY3Rvcnkgd2FzIG5ldmVyIGdldHRpbmcK KyAgICAgICAgcmVzb2x2ZWQgYW5kIG1fcmVzb2x2ZWRDb25maWd1cmF0aW9uLnJlc291cmNlTG9h ZFN0YXRpc3RpY3NEaXJlY3Rvcnkgd2FzIG5vdCBzZXQuCisgICAgICAgIFVwZGF0ZSB0aGUgV2Vi c2l0ZURhdGFTdG9yZSBzbyB0aGF0IG1fcmVzb2x2ZWRDb25maWd1cmF0aW9uLnJlc291cmNlTG9h ZFN0YXRpc3RpY3NEaXJlY3RvcnkKKyAgICAgICAgcHJvcGVybHkgZ2V0cyBzZXQgdG8gdGhlIHJl c29sdmVkIHZlcnNpb24gb2YgbV9jb25maWd1cmF0aW9uLnJlc291cmNlTG9hZFN0YXRpc3RpY3NE aXJlY3RvcnkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFT dG9yZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYnNpdGVEYXRhU3RvcmU6OnJlc29sdmVEaXJl Y3Rvcmllc0lmTmVjZXNzYXJ5KToKKyAgICAgICAgKFdlYktpdDo6V2Vic2l0ZURhdGFTdG9yZTo6 ZW5hYmxlUmVzb3VyY2VMb2FkU3RhdGlzdGljc0FuZFNldFRlc3RpbmdDYWxsYmFjayk6CisKIDIw MTgtMDYtMjkgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBTdG9w IHVzaW5nIGxhbWJkYXMgZm9yIFdlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZSB0byBpbnRl cmFjdCB3aXRoIGl0cyBXZWJzaXRlRGF0YVN0b3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVN0b3JlLmNwcCBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwCmluZGV4IDFmYmRm NTYyNTFkZDE0Y2Y4ZDlmM2RlY2E2ZTAxYTRkNzc4ZTViMjQuLjQ3YjFjYzAwYzBjZjg0MGVlODRm NmUwNGI3Y2I5NTY3YzJkNTExOTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwCkBAIC0xNjIsNiArMTYyLDgg QEAgdm9pZCBXZWJzaXRlRGF0YVN0b3JlOjpyZXNvbHZlRGlyZWN0b3JpZXNJZk5lY2Vzc2FyeSgp CiAgICAgICAgIG1fcmVzb2x2ZWRDb25maWd1cmF0aW9uLndlYlNRTERhdGFiYXNlRGlyZWN0b3J5 ID0gcmVzb2x2ZUFuZENyZWF0ZVJlYWRXcml0ZURpcmVjdG9yeUZvclNhbmRib3hFeHRlbnNpb24o bV9jb25maWd1cmF0aW9uLndlYlNRTERhdGFiYXNlRGlyZWN0b3J5KTsKICAgICBpZiAoIW1fY29u ZmlndXJhdGlvbi5pbmRleGVkREJEYXRhYmFzZURpcmVjdG9yeS5pc0VtcHR5KCkpCiAgICAgICAg IG1fcmVzb2x2ZWRDb25maWd1cmF0aW9uLmluZGV4ZWREQkRhdGFiYXNlRGlyZWN0b3J5ID0gcmVz b2x2ZUFuZENyZWF0ZVJlYWRXcml0ZURpcmVjdG9yeUZvclNhbmRib3hFeHRlbnNpb24obV9jb25m aWd1cmF0aW9uLmluZGV4ZWREQkRhdGFiYXNlRGlyZWN0b3J5KTsKKyAgICBpZiAoIW1fY29uZmln dXJhdGlvbi5yZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGlyZWN0b3J5LmlzRW1wdHkoKSkKKyAgICAg ICAgbV9yZXNvbHZlZENvbmZpZ3VyYXRpb24ucmVzb3VyY2VMb2FkU3RhdGlzdGljc0RpcmVjdG9y eSA9IHJlc29sdmVBbmRDcmVhdGVSZWFkV3JpdGVEaXJlY3RvcnlGb3JTYW5kYm94RXh0ZW5zaW9u KG1fY29uZmlndXJhdGlvbi5yZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGlyZWN0b3J5KTsKICAgICBp ZiAoIW1fY29uZmlndXJhdGlvbi5zZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uRGlyZWN0b3J5Lmlz RW1wdHkoKSAmJiBtX3Jlc29sdmVkQ29uZmlndXJhdGlvbi5zZXJ2aWNlV29ya2VyUmVnaXN0cmF0 aW9uRGlyZWN0b3J5LmlzRW1wdHkoKSkKICAgICAgICAgbV9yZXNvbHZlZENvbmZpZ3VyYXRpb24u c2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbkRpcmVjdG9yeSA9IHJlc29sdmVBbmRDcmVhdGVSZWFk V3JpdGVEaXJlY3RvcnlGb3JTYW5kYm94RXh0ZW5zaW9uKG1fY29uZmlndXJhdGlvbi5zZXJ2aWNl V29ya2VyUmVnaXN0cmF0aW9uRGlyZWN0b3J5KTsKICAgICBpZiAoIW1fY29uZmlndXJhdGlvbi5q YXZhU2NyaXB0Q29uZmlndXJhdGlvbkRpcmVjdG9yeS5pc0VtcHR5KCkpCkBAIC0xNDc2LDYgKzE0 NzgsNyBAQCB2b2lkIFdlYnNpdGVEYXRhU3RvcmU6OmVuYWJsZVJlc291cmNlTG9hZFN0YXRpc3Rp Y3NBbmRTZXRUZXN0aW5nQ2FsbGJhY2soRnVuY3RpbwogICAgICAgICByZXR1cm47CiAgICAgfQog CisgICAgcmVzb2x2ZURpcmVjdG9yaWVzSWZOZWNlc3NhcnkoKTsKICAgICBtX3Jlc291cmNlTG9h ZFN0YXRpc3RpY3MgPSBXZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmU6OmNyZWF0ZSgqdGhp cyk7CiAgICAgbV9yZXNvdXJjZUxvYWRTdGF0aXN0aWNzLT5zZXRTdGF0aXN0aWNzVGVzdGluZ0Nh bGxiYWNrKFdURk1vdmUoY2FsbGJhY2spKTsKIAo=