187187 2018-06-29 11:19:53 -0700 REGRESSION(r233362): check_flatpak() should not be verbose when flatpak environment has not been initialized 2018-07-01 22:40:39 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 186771 1 clopez webkit-unassigned bugs-noreply calvaris commit-queue mcatanzaro tsaunier oldest_to_newest 1437839 0 clopez 2018-06-29 11:19:53 -0700 It happens that when the flatpak environment has not been initialized, the scripts still try to run the flatpak binary in the function check_flatpak() in flatpakutils.py For example, If i just uninstall flatpak and I try to run I get $ Tools/Scripts/run-webkit-tests --gtk --release You need to install flatpak >= 0.10.0 to be able to use the 'Tools/Scripts/run-webkit-tests' script. You can find some informations about how to install it for your distribution at: * http://flatpak.org/ 20:15:13.186 21463 Using port 'gtk-wk2' [...] Or on the bots, just check the ouput generate-jsc-bundle from the release bot, the noise about flatpak there: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/13303/steps/generate-jsc-bundle/logs/stdio I think this should be avoided. The function check_flatpak() should avoid doing any check (or print any warning) if the flatpak environment has not been initialized 1438150 1 344011 tsaunier 2018-06-30 04:48:39 -0700 Created attachment 344011 Patch. 1438163 2 344011 commit-queue 2018-06-30 07:24:28 -0700 Comment on attachment 344011 Patch. Clearing flags on attachment: 344011 Committed r233395: <https://trac.webkit.org/changeset/233395> 1438164 3 commit-queue 2018-06-30 07:24:30 -0700 All reviewed patches have been landed. Closing bug. 344011 2018-06-30 04:48:39 -0700 2018-06-30 07:24:28 -0700 Patch. httpsbugswebkitorgshowbugcgiid187187.patch text/plain 2819 tsaunier RnJvbSBjY2EzOTIwMDVhZTMyZjE4OGMzYjZiMGU3OGU5MGQzZDdkZTNhYWFjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaGliYXVsdCBTYXVuaWVyIDx0c2F1bmllckBpZ2FsaWEuY29t PgpEYXRlOiBTYXQsIDMwIEp1biAyMDE4IDA3OjQ1OjI0IC0wNDAwClN1YmplY3Q6IFtQQVRDSCB4 c2VydmVyXSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3MTg3Cgot LS0KIFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgIHwgMTAgKysrKysrKysrKwogVG9vbHMv ZmxhdHBhay9mbGF0cGFrdXRpbHMucHkgfCAxNyArKysrKysrKystLS0tLS0tLQogMiBmaWxlcyBj aGFuZ2VkLCAxOSBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1Rv b2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0NTYyMWRkNWVjNC4uZjJiNmZi OTNlYjcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxMyBAQAorMjAxOC0wNi0zMCAgVGhpYmF1bHQgU2F1bmllciAgPHRzYXVuaWVy QGlnYWxpYS5jb20+CisKKyAgICAgICAgTWFrZSBjaGVja19mbGF0cGFrKCkgbm90IHZlcmJvc2Ug d2hlbiBvbmx5IHRyeWluZyB0byBydW4gY29tbWFuZCBpbnNpZGUgZmxhdHBhaworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3MTg3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmbGF0cGFrL2ZsYXRwYWt1 dGlscy5weToKKyAgICAgICAgKHJ1bl9pbl9zYW5kYm94X2lmX2F2YWlsYWJsZSk6CisKIDIwMTgt MDYtMjkgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAg cnVuLWpzYyBzaG91bGQgcHJpbnQgd2hlbiBqc2MgZXhpdHMgd2l0aCBub24temVybyBzdGF0dXMK ZGlmZiAtLWdpdCBhL1Rvb2xzL2ZsYXRwYWsvZmxhdHBha3V0aWxzLnB5IGIvVG9vbHMvZmxhdHBh ay9mbGF0cGFrdXRpbHMucHkKaW5kZXggYTU0ZDQ0NjQ5MWEuLmUzYmNhMDlmYzQ4IDEwMDY0NAot LS0gYS9Ub29scy9mbGF0cGFrL2ZsYXRwYWt1dGlscy5weQorKysgYi9Ub29scy9mbGF0cGFrL2Zs YXRwYWt1dGlscy5weQpAQCAtNzUsNyArNzUsNyBAQCBjbGFzcyBDb25zb2xlOgogICAgICAgICBz eXMuc3Rkb3V0LmZsdXNoKCkKIAogCi1kZWYgY2hlY2tfZmxhdHBhaygpOgorZGVmIGNoZWNrX2Zs YXRwYWsodmVyYm9zZT1UcnVlKToKICAgICAjIEZsYXRwYWsgaXMgb25seSBzdXBwb3J0ZWQgb24g TGludXguCiAgICAgaWYgbm90IHN5cy5wbGF0Zm9ybS5zdGFydHN3aXRoKCJsaW51eCIpOgogICAg ICAgICByZXR1cm4gRmFsc2UKQEAgLTg0LDEyICs4NCwxMyBAQCBkZWYgY2hlY2tfZmxhdHBhaygp OgogICAgICAgICB0cnk6CiAgICAgICAgICAgICBvdXRwdXQgPSBzdWJwcm9jZXNzLmNoZWNrX291 dHB1dChbYXBwLCAiLS12ZXJzaW9uIl0pCiAgICAgICAgIGV4Y2VwdCAoc3VicHJvY2Vzcy5DYWxs ZWRQcm9jZXNzRXJyb3IsIE9TRXJyb3IpOgotICAgICAgICAgICAgQ29uc29sZS5tZXNzYWdlKCJc biVzWW91IG5lZWQgdG8gaW5zdGFsbCAlcyA+PSAlcyIKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAiIHRvIGJlIGFibGUgdG8gdXNlIHRoZSAnJXMnIHNjcmlwdC5cblxuIgotICAgICAgICAg ICAgICAgICAgICAgICAgICAgICJZb3UgY2FuIGZpbmQgc29tZSBpbmZvcm1hdGlvbnMgYWJvdXQi Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgIiBob3cgdG8gaW5zdGFsbCBpdCBmb3IgeW91 ciBkaXN0cmlidXRpb24gYXQ6XG4iCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgIiAgICAq IGh0dHA6Ly9mbGF0cGFrLm9yZy8lc1xuIiwgQ29sb3JzLkZBSUwsCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgYXBwLCByZXF1aXJlZF92ZXJzaW9uLCBzeXMuYXJndlswXSwgQ29sb3JzLkVO REMpCisgICAgICAgICAgICBpZiB2ZXJib3NlOgorICAgICAgICAgICAgICAgIENvbnNvbGUubWVz c2FnZSgiXG4lc1lvdSBuZWVkIHRvIGluc3RhbGwgJXMgPj0gJXMiCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICIgdG8gYmUgYWJsZSB0byB1c2UgdGhlICclcycgc2NyaXB0LlxuXG4i CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJZb3UgY2FuIGZpbmQgc29tZSBpbmZv cm1hdGlvbnMgYWJvdXQiCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICIgaG93IHRv IGluc3RhbGwgaXQgZm9yIHlvdXIgZGlzdHJpYnV0aW9uIGF0OlxuIgorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAiICAgICogaHR0cDovL2ZsYXRwYWsub3JnLyVzXG4iLCBDb2xvcnMu RkFJTCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYXBwLCByZXF1aXJlZF92ZXJz aW9uLCBzeXMuYXJndlswXSwgQ29sb3JzLkVOREMpCiAgICAgICAgICAgICByZXR1cm4gRmFsc2UK IAogICAgICAgICBkZWYgY29tcGFyYWJsZV92ZXJzaW9uKHZlcnNpb24pOgpAQCAtODEwLDcgKzgx MSw3IEBAIGRlZiBydW5faW5fc2FuZGJveF9pZl9hdmFpbGFibGUoYXJncyk6CiAgICAgaWYgaXNf c2FuZGJveGVkKCk6CiAgICAgICAgIHJldHVybiBOb25lCiAKLSAgICBpZiBub3QgY2hlY2tfZmxh dHBhaygpOgorICAgIGlmIG5vdCBjaGVja19mbGF0cGFrKHZlcmJvc2U9RmFsc2UpOgogICAgICAg ICByZXR1cm4gTm9uZQogCiAgICAgZmxhdHBha19ydW5uZXIgPSBXZWJraXRGbGF0cGFrLmxvYWRf ZnJvbV9hcmdzKGFyZ3MpCi0tIAoyLjE4LjA=