187161 2018-06-28 15:52:05 -0700 Don't force black text when TextIndicator draws backgrounds or all content 2018-06-28 16:23:40 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue thorton webkit-bug-importer oldest_to_newest 1437604 0 timothy 2018-06-28 15:52:05 -0700 This can lead to bad results in dark mode. 1437605 1 timothy 2018-06-28 15:52:13 -0700 <rdar://problem/40434644> 1437607 2 343867 timothy 2018-06-28 15:53:43 -0700 Created attachment 343867 Patch 1437608 3 thorton 2018-06-28 15:57:38 -0700 (In reply to Timothy Hatcher from comment #0) > This can lead to bad results in dark mode. I bet it can lead to bad results in any mode :P white-text-on-dark-background in normal web content would be a problem, no? 1437615 4 343867 commit-queue 2018-06-28 16:23:39 -0700 Comment on attachment 343867 Patch Clearing flags on attachment: 343867 Committed r233338: <https://trac.webkit.org/changeset/233338> 1437616 5 commit-queue 2018-06-28 16:23:40 -0700 All reviewed patches have been landed. Closing bug. 343867 2018-06-28 15:53:43 -0700 2018-06-28 16:23:39 -0700 Patch bug-187161-20180628155341.patch text/plain 2071 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMzE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDY5ZTdlYTQwYzRmNTUx ZTJhYzgyNjk1Yjg0NDgwNzc0OTU0NzZiOC4uM2JiYzJmNmYzNGM5MzAzM2Y4NDAxNDY3YzA5Y2U3 ZmM0NGU1YjZiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA2LTI4ICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBEb24ndCBmb3JjZSBi bGFjayB0ZXh0IHdoZW4gVGV4dEluZGljYXRvciBkcmF3cyBiYWNrZ3JvdW5kcyBvciBhbGwgY29u dGVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4 NzE2MQorICAgICAgICByZGFyOi8vcHJvYmxlbS80MDQzNDY0NAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFnZS9UZXh0SW5kaWNhdG9yLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OnNuYXBzaG90T3B0aW9uc0ZvclRleHRJbmRpY2F0b3JPcHRpb25z KToKKyAgICAgICAgT25seSBzZXQgU25hcHNob3RPcHRpb25zRm9yY2VCbGFja1RleHQgd2hlbiBU ZXh0SW5kaWNhdG9yT3B0aW9uUmVzcGVjdFRleHRDb2xvciBhbmQKKyAgICAgICAgVGV4dEluZGlj YXRvck9wdGlvblBhaW50QmFja2dyb3VuZHMgYXJlIG5vdCBzZXQuCisKIDIwMTgtMDYtMjggIEFk aXR5YSBLZWVydGhpICA8YWtlZXJ0aGlAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04g KHIyMzIwNDApOiBDdXJzb3IganVtcGluZyBpbiBTYWZhcmkgdGV4dCBmaWVsZHMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvVGV4dEluZGljYXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL1RleHRJbmRpY2F0b3IuY3BwCmluZGV4IDc5NTQ2NTExODVkOWUzNWU1ZTJhZWUyZDJl Zjg5ZjZmNWMwOGE1Y2IuLjYxMTU4NWQyZDI3MTlkZWEzNGY1OTAzZjBjYTU3Y2EwMzZmMmFhNDcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvVGV4dEluZGljYXRvci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGFnZS9UZXh0SW5kaWNhdG9yLmNwcApAQCAtMTM0LDE0ICsxMzQsMTYg QEAgc3RhdGljIGJvb2wgaGFzTm9uSW5saW5lT3JSZXBsYWNlZEVsZW1lbnRzKGNvbnN0IFJhbmdl JiByYW5nZSkKIHN0YXRpYyBTbmFwc2hvdE9wdGlvbnMgc25hcHNob3RPcHRpb25zRm9yVGV4dElu ZGljYXRvck9wdGlvbnMoVGV4dEluZGljYXRvck9wdGlvbnMgb3B0aW9ucykKIHsKICAgICBTbmFw c2hvdE9wdGlvbnMgc25hcHNob3RPcHRpb25zID0gU25hcHNob3RPcHRpb25zTm9uZTsKLSAgICBp ZiAoIShvcHRpb25zICYgVGV4dEluZGljYXRvck9wdGlvblJlc3BlY3RUZXh0Q29sb3IpKQotICAg ICAgICBzbmFwc2hvdE9wdGlvbnMgfD0gU25hcHNob3RPcHRpb25zRm9yY2VCbGFja1RleHQ7CiAK ICAgICBpZiAoIShvcHRpb25zICYgVGV4dEluZGljYXRvck9wdGlvblBhaW50QWxsQ29udGVudCkp IHsKICAgICAgICAgaWYgKG9wdGlvbnMgJiBUZXh0SW5kaWNhdG9yT3B0aW9uUGFpbnRCYWNrZ3Jv dW5kcykKICAgICAgICAgICAgIHNuYXBzaG90T3B0aW9ucyB8PSBTbmFwc2hvdE9wdGlvbnNQYWlu dFNlbGVjdGlvbkFuZEJhY2tncm91bmRzT25seTsKLSAgICAgICAgZWxzZQorICAgICAgICBlbHNl IHsKICAgICAgICAgICAgIHNuYXBzaG90T3B0aW9ucyB8PSBTbmFwc2hvdE9wdGlvbnNQYWludFNl bGVjdGlvbk9ubHk7CisKKyAgICAgICAgICAgIGlmICghKG9wdGlvbnMgJiBUZXh0SW5kaWNhdG9y T3B0aW9uUmVzcGVjdFRleHRDb2xvcikpCisgICAgICAgICAgICAgICAgc25hcHNob3RPcHRpb25z IHw9IFNuYXBzaG90T3B0aW9uc0ZvcmNlQmxhY2tUZXh0OworICAgICAgICB9CiAgICAgfSBlbHNl CiAgICAgICAgIHNuYXBzaG90T3B0aW9ucyB8PSBTbmFwc2hvdE9wdGlvbnNFeGNsdWRlU2VsZWN0 aW9uSGlnaGxpZ2h0aW5nOwogCg==