18716 2008-04-24 09:59:55 -0700 SQUIRRELFISH: typeof should return undefined for an undefined variable reference 2008-04-24 10:17:22 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 zwarich webkit-unassigned oldest_to_newest 78783 0 zwarich 2008-04-24 09:59:55 -0700 The expression "typeof x" throws an exception when x is undefined, but it should return undefined instead. This affects the JavaScriptCore regression tests ecma/Expressions/11.4.1.js and js1_5/Array/regress-157652.js. 78784 1 20795 zwarich 2008-04-24 10:01:55 -0700 Created attachment 20795 Proposed patch This fixes the two tests. 78785 2 ggaren 2008-04-24 10:08:28 -0700 r=me if you use resolveBaseAndProperty instead. 78786 3 20795 ggaren 2008-04-24 10:11:25 -0700 Comment on attachment 20795 Proposed patch Cameron pointed out that resolveBaseAndProperty throws an exception for undefined variables. Doh! r=me 78787 4 ggaren 2008-04-24 10:15:11 -0700 r32494 20795 2008-04-24 10:01:55 -0700 2008-04-24 10:11:25 -0700 Proposed patch typeof.diff text/plain 1462 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDMyNDky KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMDQt MjQgIENhbWVyb24gWndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDE4NzE2OiBTUVVJUlJF TEZJU0g6IHR5cGVvZiBzaG91bGQgcmV0dXJuIHVuZGVmaW5lZCBmb3IgYW4gdW5kZWZpbmVkIHZh cmlhYmxlIHJlZmVyZW5jZQorICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4NzE2PgorCisgICAgICAgIFRoaXMgZml4ZXMgMiBtb3JlIHJlZ3Jlc3Npb24g dGVzdHMuCisKKyAgICAgICAgKiBranMvbm9kZXMuY3BwOgorICAgICAgICAoS0pTOjpUeXBlT2ZS ZXNvbHZlTm9kZTo6ZW1pdENvZGUpOgorCiAyMDA4LTA0LTIzICBDYW1lcm9uIFp3YXJpY2ggIDxj d3p3YXJpY2hAdXdhdGVybG9vLmNhPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llai4KSW5k ZXg6IGtqcy9ub2Rlcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0ga2pzL25vZGVzLmNwcAkocmV2aXNpb24g MzI0OTApCisrKyBranMvbm9kZXMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMjY3LDggKzIyNjcs OSBAQCBSZWdpc3RlcklEKiBUeXBlT2ZSZXNvbHZlTm9kZTo6ZW1pdENvZGUoCiAgICAgaWYgKFJl Z2lzdGVySUQqIHIwID0gZ2VuZXJhdG9yLnJlZ2lzdGVyRm9yTG9jYWwobV9pZGVudCkpCiAgICAg ICAgIHJldHVybiBnZW5lcmF0b3IuZW1pdFR5cGVPZihnZW5lcmF0b3IuZmluYWxEZXN0aW5hdGlv bihkc3QpLCByMCk7CiAKLSAgICBSZWdpc3RlcklEKiByMCA9IGdlbmVyYXRvci5lbWl0UmVzb2x2 ZShnZW5lcmF0b3IudGVtcERlc3RpbmF0aW9uKGRzdCksIG1faWRlbnQpOwotICAgIHJldHVybiBn ZW5lcmF0b3IuZW1pdFR5cGVPZihnZW5lcmF0b3IuZmluYWxEZXN0aW5hdGlvbihkc3QsIHIwKSwg cjApOworICAgIFJlZlB0cjxSZWdpc3RlcklEPiByMCA9IGdlbmVyYXRvci5lbWl0UmVzb2x2ZUJh c2UoZ2VuZXJhdG9yLnRlbXBEZXN0aW5hdGlvbihkc3QpLCBtX2lkZW50KTsKKyAgICBnZW5lcmF0 b3IuZW1pdEdldFByb3BJZChyMC5nZXQoKSwgcjAuZ2V0KCksIG1faWRlbnQpOworICAgIHJldHVy biBnZW5lcmF0b3IuZW1pdFR5cGVPZihnZW5lcmF0b3IuZmluYWxEZXN0aW5hdGlvbihkc3QsIHIw LmdldCgpKSwgcjAuZ2V0KCkpOwogfQogCiBKU1ZhbHVlKiBUeXBlT2ZSZXNvbHZlTm9kZTo6ZXZh bHVhdGUoT2xkSW50ZXJwcmV0ZXJFeGVjU3RhdGUqIGV4ZWMpCg==