187148 2018-06-28 11:48:46 -0700 [ews-build] Add support for WebKitPy-Tests-EWS 2018-07-05 09:47:20 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=187023 https://bugs.webkit.org/show_bug.cgi?id=187331 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap don.olmstead ews-watchlist lforschler webkit-bug-importer oldest_to_newest 1437445 0 aakash_jain 2018-06-28 11:48:46 -0700 We should add support for WebKitPy-Tests-EWS in EWS Buildbot. 1437449 1 don.olmstead 2018-06-28 11:51:08 -0700 Any concerns about certain platforms failing WebKit python tests? I know Windows without cygwin has problems still. 1437454 2 343827 aakash_jain 2018-06-28 11:54:27 -0700 Created attachment 343827 Proposed patch 1437456 3 ews-watchlist 2018-06-28 11:57:14 -0700 Attachment 343827 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:314: [TestunWebKitPyTests.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:314: [TestunWebKitPyTests.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:327: [TestunWebKitPyTests.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:327: [TestunWebKitPyTests.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 4 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1437460 4 aakash_jain 2018-06-28 12:00:29 -0700 (In reply to Don Olmstead from comment #1) > Any concerns about certain platforms failing WebKit python tests? I know > Windows without cygwin has problems still. The current plan is to run this webkitpy EWS on a macOS machine. We might consider running webkitpy tests on multiple platforms in future. 1437463 5 don.olmstead 2018-06-28 12:04:19 -0700 (In reply to Aakash Jain from comment #4) > (In reply to Don Olmstead from comment #1) > > Any concerns about certain platforms failing WebKit python tests? I know > > Windows without cygwin has problems still. > The current plan is to run this webkitpy EWS on a macOS machine. We might > consider running webkitpy tests on multiple platforms in future. Ok cool. We'd be interested in doing a bot. The only concern is that it wouldn't get too much work to do. If EWS goes Buildbot then a latent worker would probably make sense. 1437468 6 343827 don.olmstead 2018-06-28 12:06:19 -0700 Comment on attachment 343827 Proposed patch Informal review looks good to me. One thing you might want to consider is expanding the space in Bugzilla for the EWS bubbles. It currently cuts things off currently and more bots just make things worse. 1437487 7 aakash_jain 2018-06-28 12:44:54 -0700 (In reply to Don Olmstead from comment #5) > Ok cool. We'd be interested in doing a bot. The only concern is that it > wouldn't get too much work to do. If EWS goes Buildbot then a latent worker would probably make sense. Yes, I am working on EWS Buildbot configuration. See: http://ews-build.webkit-uat.org/#/builders We can explore using latent worker, that make sense. > Informal review looks good to me. Thanks > One thing you might want to consider is expanding the space in Bugzilla for the EWS bubbles. Yes, I will take care of that soon. 1437490 8 343827 lforschler 2018-06-28 12:48:40 -0700 Comment on attachment 343827 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=343827&action=review r=me after fixing type and ensuring unit tests run. > Tools/BuildSlaveSupport/ews-build/steps_unittest.py:298 > +class TestunWebKitPyTests(BuildStepMixinAdditions, unittest.TestCase): typo here 1437491 9 aakash_jain 2018-06-28 12:53:28 -0700 Committed r233318: <https://trac.webkit.org/changeset/233318>. 1437493 10 webkit-bug-importer 2018-06-28 12:54:29 -0700 <rdar://problem/41595909> 343827 2018-06-28 11:54:27 -0700 2018-06-28 12:48:40 -0700 Proposed patch ews_webkitpy.patch text/plain 5352 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzMzMxNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE4LTA2LTI4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBBZGQgc3VwcG9ydCBmb3IgV2ViS2l0UHktVGVzdHMt RVdTCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODcx NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1 aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXMucHk6IEFkZGVkIFdlYktpdFB5RmFj dG9yeS4KKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6IEFk ZGVkIGJ1aWxkIHN0ZXAgUnVuV2ViS2l0UHlUZXN0cy4KKyAgICAgICAgKiBCdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHk6IEFkZGVkIHVuaXQtdGVzdHMuCisgICAg ICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2NvbmZpZy5qc29uOiBVcGRhdGVkIHRv IHVzZSBDYW1lbENhc2UuIAorCiAyMDE4LTA2LTI4ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFw cGxlLmNvbT4KIAogICAgICAgICBGaXggdGhlIGlPUyBidWlsZCBmb2xsb3dpbmcgcjIzMzI5OQpJ bmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2NvbmZpZy5qc29uCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9jb25maWcuanNvbgko cmV2aXNpb24gMjMzMzE0KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2Nv bmZpZy5qc29uCSh3b3JraW5nIGNvcHkpCkBAIC0yNjksOCArMjY5LDggQEAKICAgICAgICJ3b3Jr ZXJuYW1lcyI6IFsid2Via2l0LW1pc2MiXQogICAgIH0sCiAgICAgewotICAgICAgIm5hbWUiOiAi V2Via2l0cHktdGVzdHMtRVdTIiwKLSAgICAgICJmYWN0b3J5IjogIldlYmtpdHB5RmFjdG9yeSIs CisgICAgICAibmFtZSI6ICJXZWJLaXRQeS1UZXN0cy1FV1MiLAorICAgICAgImZhY3RvcnkiOiAi V2ViS2l0UHlGYWN0b3J5IiwKICAgICAgICJwbGF0Zm9ybSI6ICIqIiwKICAgICAgICJ3b3JrZXJu YW1lcyI6IFsid2Via2l0LW1pc2MiXQogICAgIH0sCkBAIC0yODgsNyArMjg4LDcgQEAKICAgICAg ICJwb3J0IjogNTU1NSwKICAgICAgICJidWlsZGVyTmFtZXMiOiBbIlN0eWxlLUVXUyIsICJKU0Mt dGVzdHMtRVdTIiwgIm1hY09TLVNpZXJyYS1SZWxlYXNlLVdLMS1FV1MiLCAiR1RLLVdlYmtpdDIt RVdTIiwgIm1hY09TLVNpZXJyYS1SZWxlYXNlLVdLMi1FV1MiLAogICAgICAgICAgICAgICAgICAg ICAgICAibWFjT1MtSGlnaC1TaWVycmEtUmVsZWFzZS0zMmJpdC1XSzItRVdTIiwgIldQRS1FV1Mi LCAiV2luZG93cy1FV1MiLCAiaU9TLTExLUVXUyIsICJXaW5DYWlyby1FV1MiLCAiaU9TLTExLVNp bXVsYXRvci1FV1MiLAotICAgICAgICAgICAgICAgICAgICAgICAiV2Via2l0cHktdGVzdHMtRVdT IiwgIldlYktpdFBlcmwtVGVzdHMtRVdTIiwgIm1hY09TLVNpZXJyYS1EZWJ1Zy1XSzEtRVdTIiwg IkJpbmRpbmdzLXRlc3RzLUVXUyJdCisgICAgICAgICAgICAgICAgICAgICAgICJXZWJLaXRQeS1U ZXN0cy1FV1MiLCAiV2ViS2l0UGVybC1UZXN0cy1FV1MiLCAibWFjT1MtU2llcnJhLURlYnVnLVdL MS1FV1MiLCAiQmluZGluZ3MtdGVzdHMtRVdTIl0KICAgICB9CiAgIF0KIH0KSW5kZXg6IFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXMucHkKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllcy5weQkocmV2aXNpb24g MjMzMzE0KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllcy5w eQkod29ya2luZyBjb3B5KQpAQCAtNTEsNiArNTEsMTIgQEAgY2xhc3MgV2ViS2l0UGVybEZhY3Rv cnkoRmFjdG9yeSk6CiAgICAgICAgIHNlbGYuYWRkU3RlcChSdW5XZWJLaXRQZXJsVGVzdHMoKSkK IAogCitjbGFzcyBXZWJLaXRQeUZhY3RvcnkoRmFjdG9yeSk6CisgICAgZGVmIF9faW5pdF9fKHNl bGYsIHBsYXRmb3JtLCBjb25maWd1cmF0aW9uPU5vbmUsIGFyY2hpdGVjdHVyZXM9Tm9uZSwgYWRk aXRpb25hbEFyZ3VtZW50cz1Ob25lLCAqKmt3YXJncyk6CisgICAgICAgIEZhY3RvcnkuX19pbml0 X18oc2VsZiwgcGxhdGZvcm0sIGNvbmZpZ3VyYXRpb24sIGFyY2hpdGVjdHVyZXMsIEZhbHNlLCBh ZGRpdGlvbmFsQXJndW1lbnRzKQorICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuV2ViS2l0UHlUZXN0 cygpKQorCisKIGNsYXNzIEJ1aWxkRmFjdG9yeShGYWN0b3J5KToKICAgICBkZWYgX19pbml0X18o c2VsZiwgcGxhdGZvcm0sIGNvbmZpZ3VyYXRpb249Tm9uZSwgYXJjaGl0ZWN0dXJlcz1Ob25lLCBh ZGRpdGlvbmFsQXJndW1lbnRzPU5vbmUsICoqa3dhcmdzKToKICAgICAgICAgRmFjdG9yeS5fX2lu aXRfXyhzZWxmLCBwbGF0Zm9ybSwgY29uZmlndXJhdGlvbiwgYXJjaGl0ZWN0dXJlcywgRmFsc2Us IGFkZGl0aW9uYWxBcmd1bWVudHMpCkBAIC05Myw3ICs5OSwzIEBAIGNsYXNzIFdQRUZhY3Rvcnko RmFjdG9yeSk6CiAKIGNsYXNzIEpTQ1Rlc3RzRmFjdG9yeShGYWN0b3J5KToKICAgICBwYXNzCi0K LQotY2xhc3MgV2Via2l0cHlGYWN0b3J5KEZhY3RvcnkpOgotICAgIHBhc3MKSW5kZXg6IFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHJldmlzaW9uIDIzMzMxNCkK KysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBj b3B5KQpAQCAtOTAsNiArOTAsMTQgQEAgY2xhc3MgUnVuV2ViS2l0UGVybFRlc3RzKHNoZWxsLlNo ZWxsQ29tbQogICAgIGNvbW1hbmQgPSBbJ1Rvb2xzL1NjcmlwdHMvdGVzdC13ZWJraXRwZXJsJ10K IAogCitjbGFzcyBSdW5XZWJLaXRQeVRlc3RzKHNoZWxsLlNoZWxsQ29tbWFuZCk6CisgICAgbmFt ZSA9ICd3ZWJraXRweS10ZXN0cycKKyAgICBkZXNjcmlwdGlvbiA9IFsnd2Via2l0cHktdGVzdHMg cnVubmluZyddCisgICAgZGVzY3JpcHRpb25Eb25lID0gWyd3ZWJraXRweS10ZXN0cyddCisgICAg Zmx1bmtPbkZhaWx1cmUgPSBUcnVlCisgICAgY29tbWFuZCA9IFsnVG9vbHMvU2NyaXB0cy90ZXN0 LXdlYmtpdHB5J10KKworCiBkZWYgYXBwZW5kQ3VzdG9tQnVpbGRGbGFncyhzdGVwLCBwbGF0Zm9y bSwgZnVsbFBsYXRmb3JtKToKICAgICAjIEZJWE1FOiBNYWtlIGEgY29tbW9uICdzdXBwb3J0ZWQg cGxhdGZvcm1zJyBsaXN0LgogICAgIGlmIHBsYXRmb3JtIG5vdCBpbiAoJ2d0aycsICd3aW5jYWly bycsICdpb3MnLCAnanNjLW9ubHknLCAnd3BlJyk6CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVp bGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyMzMz MTQpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3Qu cHkJKHdvcmtpbmcgY29weSkKQEAgLTI5NSw2ICsyOTUsMzkgQEAgRmFpbGVkIDEvNDAgdGVzdCBw cm9ncmFtcy4gMTAvNjMwIHN1YnRlcwogICAgICAgICByZXR1cm4gc2VsZi5ydW5TdGVwKCkKIAog CitjbGFzcyBUZXN0dW5XZWJLaXRQeVRlc3RzKEJ1aWxkU3RlcE1peGluQWRkaXRpb25zLCB1bml0 dGVzdC5UZXN0Q2FzZSk6CisgICAgZGVmIHNldFVwKHNlbGYpOgorICAgICAgICBzZWxmLmxvbmdN ZXNzYWdlID0gVHJ1ZQorICAgICAgICByZXR1cm4gc2VsZi5zZXRVcEJ1aWxkU3RlcCgpCisKKyAg ICBkZWYgdGVhckRvd24oc2VsZik6CisgICAgICAgIHJldHVybiBzZWxmLnRlYXJEb3duQnVpbGRT dGVwKCkKKworICAgIGRlZiB0ZXN0X3N1Y2Nlc3Moc2VsZik6CisgICAgICAgIHNlbGYuc2V0dXBT dGVwKFJ1bldlYktpdFB5VGVzdHMoKSkKKyAgICAgICAgc2VsZi5leHBlY3RSZW1vdGVDb21tYW5k cygKKyAgICAgICAgICAgIEV4cGVjdFNoZWxsKHdvcmtkaXI9J3drZGlyJywKKyAgICAgICAgICAg ICAgICAgICAgICAgIGNvbW1hbmQ9WydUb29scy9TY3JpcHRzL3Rlc3Qtd2Via2l0cHknXSwKKyAg ICAgICAgICAgICAgICAgICAgICAgICkKKyAgICAgICAgICAgICsgMCwKKyAgICAgICAgKQorICAg ICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0PVNVQ0NFU1MsIHN0YXRlX3N0cmluZz0nd2Vi a2l0cHktdGVzdHMnKQorICAgICAgICByZXR1cm4gc2VsZi5ydW5TdGVwKCkKKworICAgIGRlZiB0 ZXN0X2ZhaWx1cmUoc2VsZik6CisgICAgICAgIHNlbGYuc2V0dXBTdGVwKFJ1bldlYktpdFB5VGVz dHMoKSkKKyAgICAgICAgc2VsZi5leHBlY3RSZW1vdGVDb21tYW5kcygKKyAgICAgICAgICAgIEV4 cGVjdFNoZWxsKHdvcmtkaXI9J3drZGlyJywKKyAgICAgICAgICAgICAgICAgICAgICAgIGNvbW1h bmQ9WydUb29scy9TY3JpcHRzL3Rlc3Qtd2Via2l0cHknXSwKKyAgICAgICAgICAgICAgICAgICAg ICAgICkKKyAgICAgICAgICAgICsgRXhwZWN0U2hlbGwubG9nKCdzdGRpbycsIHN0ZG91dD0nJydS YW4gMTc0NCB0ZXN0cyBpbiA1LjkxM3MKK0ZBSUxFRCAoZmFpbHVyZXM9MSwgZXJyb3JzPTApJycn KQorICAgICAgICAgICAgKyAyLAorICAgICAgICApCisgICAgICAgIHNlbGYuZXhwZWN0T3V0Y29t ZShyZXN1bHQ9RkFJTFVSRSwgc3RhdGVfc3RyaW5nPSd3ZWJraXRweS10ZXN0cyAoZmFpbHVyZSkn KQorICAgICAgICByZXR1cm4gc2VsZi5ydW5TdGVwKCkKKworCiBjbGFzcyBUZXN0S2lsbE9sZFBy b2Nlc3NlcyhCdWlsZFN0ZXBNaXhpbkFkZGl0aW9ucywgdW5pdHRlc3QuVGVzdENhc2UpOgogICAg IGRlZiBzZXRVcChzZWxmKToKICAgICAgICAgc2VsZi5sb25nTWVzc2FnZSA9IFRydWUK