187142 2018-06-28 09:11:12 -0700 REGRESSION (r232040): Cursor jumping in Safari text fields 2018-06-28 10:12:13 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build iPhone / iPad Other RESOLVED FIXED InRadar P2 Major --- 1 pxlcoder webkit-unassigned commit-queue megan_gardner thorton wenson_hsieh oldest_to_newest 1437365 0 pxlcoder 2018-06-28 09:11:12 -0700 Summary: If you then tap at various points in an editable node with text, the cursor jumps. Steps to reproduce: 1. Navigate to reddit.com 2. Sign in and begin a new post 3. Enter some text for the post title 4. Tap at various points in the input field Regression: This is a regression caused by r232040, which enabled click events on nodes that are already being edited (iOS). 1437368 1 pxlcoder 2018-06-28 09:12:08 -0700 <rdar://problem/41397577> 1437375 2 343810 pxlcoder 2018-06-28 09:24:10 -0700 Created attachment 343810 Patch 1437401 3 343810 commit-queue 2018-06-28 10:12:12 -0700 Comment on attachment 343810 Patch Clearing flags on attachment: 343810 Committed r233311: <https://trac.webkit.org/changeset/233311> 1437402 4 commit-queue 2018-06-28 10:12:13 -0700 All reviewed patches have been landed. Closing bug. 343810 2018-06-28 09:24:10 -0700 2018-06-28 10:12:12 -0700 Patch bug-187142-20180628092409.patch text/plain 6266 pxlcoder U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyOTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDdjNmVjNTYyZjNkZjU3 ZWNjNzJjMWYzYzkxYzk4ZjYwMGM3YzE3NC4uOTBiYTE3MjRhN2FlZjc4NWZjN2UzODc3YzMyOTc4 MDg2YjMxNzAxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE4LTA2LTI3ICBBZGl0 eWEgS2VlcnRoaSAgPGFrZWVydGhpQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChy MjMyMDQwKTogQ3Vyc29yIGp1bXBpbmcgaW4gU2FmYXJpIHRleHQgZmllbGRzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODcxNDIKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzQxMzk3NTc3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIHIyMzIwNDAgZW5hYmxlZCBjbGljayBldmVudHMgdG8gZmlyZSBvbiBu b2RlcyB0aGF0IGFyZSBhbHJlYWR5IGJlaW5nIGVkaXRlZCBpbgorICAgICAgICBpT1MuIFRoaXMg cmVzdWx0ZWQgRnJhbWVTZWxlY3Rpb246OnNldFNlbGVjdGlvbiBiZWluZyBjYWxsZWQgdHdpY2Uu IE9uZSBjYWxsCisgICAgICAgIG9yaWdpbmF0ZWQgZnJvbSB0aGUgVUlXS1RleHRJbnRlcmFjdGlv bkFzc2lzdGFudCwgd2hpY2ggc25hcHMgdGhlIGNhcmV0IHRvIHdvcmQKKyAgICAgICAgYm91bmRh cmllcy4gVGhlIG90aGVyIGNhbGwgb3JpZ2luYXRlcyBmcm9tIGhhbmRsZU1vdXNlUHJlc3NFdmVu dCBpbiBFdmVudEhhbmRsZXIsCisgICAgICAgIGFuZCB1c2VzIGNoYXJhY3RlciBib3VuZGFyaWVz LiBDb25zZXF1ZW50bHksIHdlIHNlZSB0aGUgY2FyZXQganVtcGluZyBhcm91bmQuCisKKyAgICAg ICAgVG8gZml4IHRoaXMgaXNzdWUsIGFuIGVhcmx5IHJldHVybiB3YXMgYWRkZWQgaW4gdGhlIGhh bmRsZU1vdXNlUHJlc3NFdmVudAorICAgICAgICBjb2RlcGF0aCwgd2hpY2ggcHJldmVudHMgRnJh bWVTZWxlY3Rpb246OnNldFNlbGVjdGlvbiBmcm9tIGJlaW5nIGNhbGxlZCB3aGVuCisgICAgICAg IGNsaWNraW5nIG9uIGEgbm9kZSB0aGF0IGlzIGFscmVhZHkgYmVpbmcgZWRpdGVkLiBUaGlzIGVu c3VyZXMgdGhhdCB0aGUKKyAgICAgICAgVUlXS1RleHRJbnRlcmFjdGlvbkFzc2lzdGFudCBjb2Rl cGF0aCBpcyB0aGUgb25seSBpbmZsdWVuY2Ugb24gdGhlIGNhcmV0IHBvc2l0aW9uLgorCisgICAg ICAgIFRlc3Q6IGZhc3QvZXZlbnRzL2lvcy9jbGljay1zZWxlY3Rpb25jaGFuZ2Utb25jZS5odG1s CisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpF dmVudEhhbmRsZXI6OmhhbmRsZU1vdXNlUHJlc3NFdmVudFNpbmdsZUNsaWNrKToKKwogMjAxOC0w Ni0xOSAgQWRpdHlhIEtlZXJ0aGkgIDxha2VlcnRoaUBhcHBsZS5jb20+CiAKICAgICAgICAgW0Rh dGFsaXN0XVttYWNPU10gQWRkIHN1Z2dlc3Rpb25zIFVJIGZvciBUZXh0RmllbGRJbnB1dFR5cGVz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKaW5kZXggYTViYmY5MDQzNGE1ZGQ5Mzlh ZGRkZDQwMmQ0OGUwMzU3ZDA1MTJiZi4uZDQ4ODY4NTAzMGJjYTdlOGY4MTVhMTEyMGQxY2ZhZmI3 ODY3MTBjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcApAQCAtNjgxLDYgKzY4 MSwxMiBAQCBib29sIEV2ZW50SGFuZGxlcjo6aGFuZGxlTW91c2VQcmVzc0V2ZW50U2luZ2xlQ2xp Y2soY29uc3QgTW91c2VFdmVudFdpdGhIaXRUZXN0UgogICAgIFZpc2libGVTZWxlY3Rpb24gbmV3 U2VsZWN0aW9uID0gbV9mcmFtZS5zZWxlY3Rpb24oKS5zZWxlY3Rpb24oKTsKICAgICBUZXh0R3Jh bnVsYXJpdHkgZ3JhbnVsYXJpdHkgPSBDaGFyYWN0ZXJHcmFudWxhcml0eTsKIAorI2lmIFBMQVRG T1JNKElPUykKKyAgICAvLyBUaGUgdGV4dCBzZWxlY3Rpb24gYXNzaXN0YW50IHdpbGwgaGFuZGxl IHNlbGVjdGlvbiBpbiB0aGUgY2FzZSB3aGVyZSB3ZSBhcmUgYWxyZWFkeSBlZGl0aW5nIHRoZSBu b2RlCisgICAgaWYgKG5ld1NlbGVjdGlvbi5yb290RWRpdGFibGVFbGVtZW50KCkgPT0gdGFyZ2V0 Tm9kZS0+cm9vdEVkaXRhYmxlRWxlbWVudCgpKQorICAgICAgICByZXR1cm4gdHJ1ZTsKKyNlbmRp ZgorCiAgICAgaWYgKGV4dGVuZFNlbGVjdGlvbiAmJiBuZXdTZWxlY3Rpb24uaXNDYXJldE9yUmFu Z2UoKSkgewogICAgICAgICBWaXNpYmxlU2VsZWN0aW9uIHNlbGVjdGlvbkluVXNlclNlbGVjdEFs bCA9IGV4cGFuZFNlbGVjdGlvblRvUmVzcGVjdFNlbGVjdE9uTW91c2VEb3duKCp0YXJnZXROb2Rl LCBWaXNpYmxlU2VsZWN0aW9uKHBvcykpOwogICAgICAgICBpZiAoc2VsZWN0aW9uSW5Vc2VyU2Vs ZWN0QWxsLmlzUmFuZ2UoKSkgewpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDY0Zjc5MzcyODg2NGVhY2Y2ZDgxMDRlZDdhNGFm MWNlZDIwZDczMjMuLjJhOWY1M2RlZjUzOGFjZDMwYjFiYTU4ZmE2OWMyZDNjNjQzYmNmZTMgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNyBAQAorMjAxOC0wNi0yNyAgQWRpdHlhIEtlZXJ0aGkgIDxha2VlcnRo aUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjIzMjA0MCk6IEN1cnNvciBqdW1w aW5nIGluIFNhZmFyaSB0ZXh0IGZpZWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTg3MTQyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MTM5NzU3 Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRl ZCB0ZXN0IHRvIGVuc3VyZSB0aGF0IHRoZSAnc2VsZWN0aW9uY2hhbmdlJyBldmVudCBpcyBvbmx5 IGZpcmVkIG9uY2UgcGVyCisgICAgICAgIGNsaWNrIGluIGFuIGVkaXRhYmxlIG5vZGUuCisKKyAg ICAgICAgKiBmYXN0L2V2ZW50cy9pb3MvY2xpY2stc2VsZWN0aW9uY2hhbmdlLW9uY2UtZXhwZWN0 ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2V2ZW50cy9pb3MvY2xpY2stc2VsZWN0aW9u Y2hhbmdlLW9uY2UuaHRtbDogQWRkZWQuCisKIDIwMTgtMDYtMTkgIEFkaXR5YSBLZWVydGhpICA8 YWtlZXJ0aGlAYXBwbGUuY29tPgogCiAgICAgICAgIFtEYXRhbGlzdF1bbWFjT1NdIEFkZCBzdWdn ZXN0aW9ucyBVSSBmb3IgVGV4dEZpZWxkSW5wdXRUeXBlcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZmFzdC9ldmVudHMvaW9zL2NsaWNrLXNlbGVjdGlvbmNoYW5nZS1vbmNlLWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2lvcy9jbGljay1zZWxlY3Rpb25jaGFuZ2Utb25j ZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNGY1MWE4ODk0ZGM4NDkwMzgwNjFmYWFiNjllMDM0 Njg3NTkxY2YxNwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2lv cy9jbGljay1zZWxlY3Rpb25jaGFuZ2Utb25jZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMiBA QAorUEFTUyBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnc2VsZWN0aW9uQ2hhbmdlJykudGV4dENv bnRlbnQgaXMgIjEiCitQQVNTIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdzZWxlY3Rpb25TdGFy dCcpLnRleHRDb250ZW50IGlzICI0NSIKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUK KworVEVTVCBDT01QTEVURQorVGhlIHNlbGVjdGlvbmNoYW5nZSBldmVudCBzaG91bGQgb25seSBi ZSBmaXJlZCBvbmNlIHdoZW4gY2xpY2tpbmcgYSBub2RlIHRoYXQgaXMgYmVpbmcgZWRpdGVkLgor CitUaGUgc2VsZWN0aW9uY2hhbmdlIGNvdW50IGluIHRoZSBlZGl0YWJsZSBub2RlIGlzOiAxCisK K1RoZSBjYXJldCBwb3NpdGlvbiBpbiB0aGUgZWRpdGFibGUgbm9kZSBpczogNDUKKworCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9pb3MvY2xpY2stc2VsZWN0aW9uY2hhbmdl LW9uY2UuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2lvcy9jbGljay1zZWxlY3Rpb25j aGFuZ2Utb25jZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjg2MjEwYWJlYTBhNzRmYmQzM2VlMWVmZTM2NTk1 MzdiNDMxYmZmMDMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9p b3MvY2xpY2stc2VsZWN0aW9uY2hhbmdlLW9uY2UuaHRtbApAQCAtMCwwICsxLDQ0IEBACis8IURP Q1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+CisgICAgPG1ldGEgbmFtZT0idmlld3BvcnQiIGNv bnRlbnQ9IndpZHRoPWRldmljZS13aWR0aCwgaW5pdGlhbC1zY2FsZT0xIj4KKyAgICA8c2NyaXB0 IHNyYz0iLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKyAgICA8 c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3VyY2VzL3VpLWhlbHBlci5qcyI+PC9zY3JpcHQ+Cis8 L2hlYWQ+Cis8Ym9keT4KKyAgICA8ZGl2IGlkPSJkZXNjcmlwdGlvbiI+CisgICAgICAgIDxwPlRo ZSBzZWxlY3Rpb25jaGFuZ2UgZXZlbnQgc2hvdWxkIG9ubHkgYmUgZmlyZWQgb25jZSB3aGVuIGNs aWNraW5nIGEgbm9kZSB0aGF0IGlzIGJlaW5nIGVkaXRlZC48L3A+CisgICAgICAgIDxwPlRoZSBz ZWxlY3Rpb25jaGFuZ2UgY291bnQgaW4gdGhlIGVkaXRhYmxlIG5vZGUgaXM6IDxzcGFuIGlkPSJz ZWxlY3Rpb25DaGFuZ2UiPjA8L3NwYW4+PC9wPgorICAgICAgICA8cD5UaGUgY2FyZXQgcG9zaXRp b24gaW4gdGhlIGVkaXRhYmxlIG5vZGUgaXM6IDxzcGFuIGlkPSJzZWxlY3Rpb25TdGFydCI+MDwv c3Bhbj48L3A+CisgICAgPC9kaXY+CisgICAgPGlucHV0IGlkPSJpbnB1dCIgc3R5bGU6IndpZHRo OiAxMDAlIi8+Cis8L2JvZHk+Cis8c2NyaXB0PgorCitpZiAod2luZG93LnRlc3RSdW5uZXIpIHsK KyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKyAgICBqc1Rlc3RJc0FzeW5jID0gdHJ1ZTsK KworICAgIGNvbnN0IHggPSBpbnB1dC5vZmZzZXRMZWZ0OworICAgIGNvbnN0IHkgPSBpbnB1dC5v ZmZzZXRUb3AgKyBpbnB1dC5vZmZzZXRIZWlnaHQgLyAyOworICAgIGNvbnN0IHN0cmluZyA9ICJU aGlzaXNhcmVhbGx5bG9uZ3N0cmluZ3RoYXRmaWxsc3RoZWlucHV0ZmllbGQiOworICAgIGlucHV0 LnZhbHVlID0gc3RyaW5nOworCisgICAgVUlIZWxwZXIuYWN0aXZhdGVBbmRXYWl0Rm9ySW5wdXRT ZXNzaW9uQXQoeCwgeSkudGhlbigoKSA9PiB7CisgICAgICAgIHNlbGVjdGlvbkNoYW5nZUNvdW50 ID0gMDsKKyAgICAgICAgZG9jdW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigic2VsZWN0aW9uY2hhbmdl IiwgZnVuY3Rpb24oZSkgeworICAgICAgICAgICAgc2VsZWN0aW9uQ2hhbmdlQ291bnQgKz0gMTsK KyAgICAgICAgICAgIHNlbGVjdGlvbkNoYW5nZS50ZXh0Q29udGVudCA9IHNlbGVjdGlvbkNoYW5n ZUNvdW50OworICAgICAgICAgICAgc2VsZWN0aW9uU3RhcnQudGV4dENvbnRlbnQgPSBpbnB1dC5z ZWxlY3Rpb25TdGFydDsKKyAgICAgICAgfSk7CisKKyAgICAgICAgVUlIZWxwZXIuYWN0aXZhdGVF bGVtZW50KGlucHV0KS50aGVuKCgpID0+IHsKKyAgICAgICAgICAgIHNob3VsZEJlRXF1YWxUb1N0 cmluZygiZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3NlbGVjdGlvbkNoYW5nZScpLnRleHRDb250 ZW50IiwgYCR7c2VsZWN0aW9uQ2hhbmdlQ291bnR9YCk7CisgICAgICAgICAgICBzaG91bGRCZUVx dWFsVG9TdHJpbmcoImRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdzZWxlY3Rpb25TdGFydCcpLnRl eHRDb250ZW50IiwgYCR7c3RyaW5nLmxlbmd0aH1gKTsKKyAgICAgICAgICAgIGZpbmlzaEpTVGVz dCgpOworICAgICAgICB9KTsKKyAgICB9KTsKK30KKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4u Ly4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9odG1sPgo=