187132 2018-06-27 21:02:21 -0700 The lldb vector summary provider always shows zero capacity 2018-07-01 06:28:10 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=187229 InRadar P2 Normal --- 1 simon.fraser simon.fraser dbates ddkilzer jer.noble realdawei ryanhaddad sam simon.fraser webkit-bug-importer oldest_to_newest 1437254 0 simon.fraser 2018-06-27 21:02:21 -0700 The lldb vector summary provider always shows zero capacity 1437255 1 343789 simon.fraser 2018-06-27 21:03:30 -0700 Created attachment 343789 Patch 1437256 2 simon.fraser 2018-06-27 21:05:06 -0700 First patch adds a regression test based on the functionality added in bug 183744. 1437257 3 343790 simon.fraser 2018-06-27 21:05:45 -0700 Created attachment 343790 Patch for lldb_webkit.py only 1437348 4 simon.fraser 2018-06-28 08:38:10 -0700 Thanks Dan! https://trac.webkit.org/changeset/233306/webkit 1437350 5 webkit-bug-importer 2018-06-28 08:39:17 -0700 <rdar://problem/41582463> 1437358 6 simon.fraser 2018-06-28 08:52:55 -0700 *** Bug 143921 has been marked as a duplicate of this bug. *** 1437492 7 realdawei 2018-06-28 12:53:29 -0700 (In reply to Simon Fraser (smfr) from comment #4) > Thanks Dan! > https://trac.webkit.org/changeset/233306/webkit Looks like this patch is causing errors in Sierra debug, High Sierra debug and iOS sample run: https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK2%20%28Tests%29/builds/3876/steps/webkitpy-test/logs/stdio Traceback (most recent call last): File "/Volumes/Data/slave/highsierra-debug-tests-wk2/build/Tools/lldb/lldb_webkit_unittest.py", line 150, in serial_test_WTFVectorProvider_vector_size_and_capacity self.assertEqual(summary, "{ size = 1, capacity = 16 }") AssertionError: '{ size = 0, capacity = 0 }' != '{ size = 1, capacity = 16 }' 1437533 8 simon.fraser 2018-06-28 14:12:40 -0700 Cannot reproduce that failure locally. 1437582 9 realdawei 2018-06-28 15:14:52 -0700 (In reply to Simon Fraser (smfr) from comment #8) > Cannot reproduce that failure locally. Interesting, it appears this is a new test added in this revision and has been failing since it was merged: ... def serial_test_WTFVectorProvider_vector_size_and_capacity(self): 149 summary = lldb_webkit.WTFVector_SummaryProvider(self._sbFrame.FindVariable('aVectorWithOneItem'), {}) 150 self.assertEqual(summary, "{ size = 1, capacity = 16 }") ... iOS: https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20WK2%20%28Tests%29/builds/5861/steps/webkitpy-test/logs/stdio iOS Debug https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Debug%20WK2%20%28Tests%29/builds/5088/steps/webkitpy-test/logs/stdio High Sierra Debug https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK2%20%28Tests%29/builds/3876/steps/webkitpy-test/logs/stdio Sierra Debug: https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20%28Tests%29/builds/7032/steps/webkitpy-test/logs/stdio 1437586 10 ryanhaddad 2018-06-28 15:25:37 -0700 Looks like a fix was attempted in https://trac.webkit.org/changeset/233330/webkit 1437649 11 ryanhaddad 2018-06-28 17:32:25 -0700 (In reply to Ryan Haddad from comment #10) > Looks like a fix was attempted in > https://trac.webkit.org/changeset/233330/webkit Still failing on the bots as of 233331: https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/builds/5876 1438261 12 ddkilzer 2018-06-30 19:33:24 -0700 BTW, when running the test locally, it doesn't seem like Tools/lldb/lldbWebKitTester/main.cpp forces lldbWebKitTester to be rebuilt! 1438267 13 dbates 2018-06-30 20:01:51 -0700 (In reply to David Kilzer (:ddkilzer) from comment #12) > BTW, when running the test locally, it doesn't seem like > Tools/lldb/lldbWebKitTester/main.cpp forces lldbWebKitTester to be rebuilt! Filed bug #187229. 1438277 14 ddkilzer 2018-06-30 21:49:31 -0700 (In reply to Ryan Haddad from comment #10) > Looks like a fix was attempted in > https://trac.webkit.org/changeset/233330/webkit So if I modify Tools/lldb/lldbWebKitTester/main.cpp like this: --- a/Tools/lldb/lldbWebKitTester/main.cpp +++ b/Tools/lldb/lldbWebKitTester/main.cpp @@ -60,6 +60,9 @@ static void testSummaryProviders() aVectorWithOneItem.reserveCapacity(16); aVectorWithOneItem.append(1); + fprintf(stderr, "anEmptyVector.size() = %zu capacity() = %zu\n", anEmptyVector.size(), anEmptyVector.capacity()); + fprintf(stderr, "aVectorWithOneItem.size() = %zu capacity() = %zu\n", aVectorWithOneItem.size(), aVectorWithOneItem.capacity()); + breakForTestingSummaryProviders(); } And then run it directly, I get this output: $ /var/build/Debug/lldbWebKitTester anEmptyVector.size() = 0 capacity() = 0 aVectorWithOneItem.size() = 1 capacity() = 16 This executable does nothing and is only meant for debugging lldb_webkit.py. So my guess is that the order/offset of the fields for WTF::Vector are wrong in Tools/lldb/lldb_webkit.py. Recall that WTF::Vector inherits from WTF::VectorBuffer which inherits from WTF::VectorBufferBase, and it's WTF::VectorBufferBase that defines the member variables in this order: T* m_buffer; unsigned m_capacity; unsigned m_size; // Only used by the Vector subclass, but placed here to avoid padding the struct. I tried "fixing" the order of the member variables in lldb_webkit.py, but that didn't work, and was just a blind guess anyway. (Can lldb get all these member various without casting the object to the base class first?) 1438298 15 ddkilzer 2018-07-01 04:48:22 -0700 (In reply to Daniel Bates from comment #13) > (In reply to David Kilzer (:ddkilzer) from comment #12) > > BTW, when running the test locally, it doesn't seem like > > Tools/lldb/lldbWebKitTester/main.cpp forces lldbWebKitTester to be rebuilt! > > Filed bug #187229. So this appears to have fixed the test failures on the bots! I seem to be able to reproduce the failure locally, but I just realized (a) I'm using a Debug+ASan build and (b) I need to rebuild WebKit, too. 1438301 16 dbates 2018-07-01 06:28:10 -0700 (In reply to David Kilzer (:ddkilzer) from comment #15) > (In reply to Daniel Bates from comment #13) > > (In reply to David Kilzer (:ddkilzer) from comment #12) > > > BTW, when running the test locally, it doesn't seem like > > > Tools/lldb/lldbWebKitTester/main.cpp forces lldbWebKitTester to be rebuilt! > > > > Filed bug #187229. > > So this appears to have fixed the test failures on the bots! > Yay! 343789 2018-06-27 21:03:30 -0700 2018-06-27 22:08:01 -0700 Patch bug-187132-20180627210329.patch text/plain 3715 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMjk3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTc0MzUwYjhlZWRmNWNlZTBkZjA1YjUyM2Q4NWEzZGQw NDUwZDRkZi4uOTM1NDIxZjlmZWMyOTRjOWZiMmQ1NTFjMWEyYTJkYzBmODViOTU2NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDE4LTA2LTI3ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgor CisgICAgICAgIFRoZSBsbGRiIHZlY3RvciBzdW1tYXJ5IHByb3ZpZGVyIGFsd2F5cyBzaG93cyB6 ZXJvIGNhcGFjaXR5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODcxMzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAg ICAgCisgICAgICAgIFdURlZlY3RvclByb3ZpZGVyIGluIGxsZGJfd2Via2l0LnB5IHdhcyBjYWxs aW5nIEdldENoaWxkTWVtYmVyV2l0aE5hbWUoJ21fY2FwYWNpdHknKQorICAgICAgICBvbiB0aGUg YnVmZmVyIGluc3RlYWQgb2YgdGhlIHZhbG9iai4KKworICAgICAgICAqIGxsZGIvbGxkYldlYktp dFRlc3Rlci9tYWluLmNwcDoKKyAgICAgICAgKHRlc3RTdW1tYXJ5UHJvdmlkZXJzKToKKyAgICAg ICAgKiBsbGRiL2xsZGJfd2Via2l0LnB5OgorICAgICAgICAoV1RGVmVjdG9yUHJvdmlkZXIudXBk YXRlKToKKyAgICAgICAgKiBsbGRiL2xsZGJfd2Via2l0X3VuaXR0ZXN0LnB5OgorICAgICAgICAo VGVzdFN1bW1hcnlQcm92aWRlcnMuc2VyaWFsX3Rlc3RfV1RGU3RyaW5nX1N1bW1hcnlQcm92aWRl cl8xNmJpdF9zdHJpbmcpOgorICAgICAgICAoVGVzdFN1bW1hcnlQcm92aWRlcnMpOgorICAgICAg ICAoVGVzdFN1bW1hcnlQcm92aWRlcnMuc2VyaWFsX3Rlc3RfV1RGVmVjdG9yUHJvdmlkZXJfZW1w dHlfdmVjdG9yKToKKyAgICAgICAgKFRlc3RTdW1tYXJ5UHJvdmlkZXJzLnNlcmlhbF90ZXN0X1dU RlZlY3RvclByb3ZpZGVyX3ZlY3Rvcl9zaXplX2FuZF9jYXBhY2l0eSk6CisKIDIwMTgtMDYtMDEg IERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBzb21lIHRl c3RzIGZvciBsbGRiX3dlYmtpdC5weQpkaWZmIC0tZ2l0IGEvVG9vbHMvbGxkYi9sbGRiV2ViS2l0 VGVzdGVyL21haW4uY3BwIGIvVG9vbHMvbGxkYi9sbGRiV2ViS2l0VGVzdGVyL21haW4uY3BwCmlu ZGV4IDVhZjgyZmU1OGE4YmZlMDk2ODZmYzMzZGFiNmZiNDZiNzE0YzI5MDAuLjRlMTFhYjc5MTIy NjE5ZTBhYTY4M2I4MWZhMjBhYjcyOTMxNDhiNDUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2xsZGIvbGxk YldlYktpdFRlc3Rlci9tYWluLmNwcAorKysgYi9Ub29scy9sbGRiL2xsZGJXZWJLaXRUZXN0ZXIv bWFpbi5jcHAKQEAgLTU0LDYgKzU0LDEyIEBAIHN0YXRpYyB2b2lkIHRlc3RTdW1tYXJ5UHJvdmlk ZXJzKCkKICAgICBTdHJpbmcgYTE2Qml0U3RyaW5nID0gdXRmMTZTdHJpbmcodSJcdTE2ODBDYXBw dWNjaW5vXHUxNjgwIik7CiAgICAgU3RyaW5nSW1wbCogYTE2Qml0U3RyaW5nSW1wbCA9IGExNkJp dFN0cmluZy5pbXBsKCk7CiAKKworICAgIFZlY3RvcjxpbnQ+IGFuRW1wdHlWZWN0b3I7CisgICAg VmVjdG9yPGludD4gYVZlY3RvcldpdGhPbmVJdGVtOworICAgIGFWZWN0b3JXaXRoT25lSXRlbS5y ZXNlcnZlQ2FwYWNpdHkoMTYpOworICAgIGFWZWN0b3JXaXRoT25lSXRlbS5hcHBlbmQoMSk7CisK ICAgICBicmVha0ZvclRlc3RpbmdTdW1tYXJ5UHJvdmlkZXJzKCk7CiB9CiAKZGlmZiAtLWdpdCBh L1Rvb2xzL2xsZGIvbGxkYl93ZWJraXQucHkgYi9Ub29scy9sbGRiL2xsZGJfd2Via2l0LnB5Cmlu ZGV4IGU5N2VmOWE2NTUxYTAyYzA1MDI2Y2Y1Yjk4YzA3OTE5NWY2YmEyNzYuLjM0YzY0YzM0NTMy OWUwNmE3NTgzMDkxNjkwN2QzMWM3Yzc0ZjUzNzYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2xsZGIvbGxk Yl93ZWJraXQucHkKKysrIGIvVG9vbHMvbGxkYi9sbGRiX3dlYmtpdC5weQpAQCAtMzgzLDcgKzM4 Myw3IEBAIGNsYXNzIFdURlZlY3RvclByb3ZpZGVyOgogICAgIGRlZiB1cGRhdGUoc2VsZik6CiAg ICAgICAgIHNlbGYuYnVmZmVyID0gc2VsZi52YWxvYmouR2V0Q2hpbGRNZW1iZXJXaXRoTmFtZSgn bV9idWZmZXInKQogICAgICAgICBzZWxmLnNpemUgPSBzZWxmLnZhbG9iai5HZXRDaGlsZE1lbWJl cldpdGhOYW1lKCdtX3NpemUnKS5HZXRWYWx1ZUFzVW5zaWduZWQoMCkKLSAgICAgICAgc2VsZi5j YXBhY2l0eSA9IHNlbGYuYnVmZmVyLkdldENoaWxkTWVtYmVyV2l0aE5hbWUoJ21fY2FwYWNpdHkn KS5HZXRWYWx1ZUFzVW5zaWduZWQoMCkKKyAgICAgICAgc2VsZi5jYXBhY2l0eSA9IHNlbGYudmFs b2JqLkdldENoaWxkTWVtYmVyV2l0aE5hbWUoJ21fY2FwYWNpdHknKS5HZXRWYWx1ZUFzVW5zaWdu ZWQoMCkKICAgICAgICAgc2VsZi5kYXRhX3R5cGUgPSBzZWxmLmJ1ZmZlci5HZXRUeXBlKCkuR2V0 UG9pbnRlZVR5cGUoKQogICAgICAgICBzZWxmLmRhdGFfc2l6ZSA9IHNlbGYuZGF0YV90eXBlLkdl dEJ5dGVTaXplKCkKIApkaWZmIC0tZ2l0IGEvVG9vbHMvbGxkYi9sbGRiX3dlYmtpdF91bml0dGVz dC5weSBiL1Rvb2xzL2xsZGIvbGxkYl93ZWJraXRfdW5pdHRlc3QucHkKaW5kZXggN2Y2MmY0NTYx N2NiZDk1YjIzYjVkNDZkNzhkNmJhZGU2NTRmYmYzZC4uOTE0MGVkYzRjYzhlZjZjMzNjODNjYTU3 NTg3ZTY5MzVmYTZmYmFkZSAxMDA3NTUKLS0tIGEvVG9vbHMvbGxkYi9sbGRiX3dlYmtpdF91bml0 dGVzdC5weQorKysgYi9Ub29scy9sbGRiL2xsZGJfd2Via2l0X3VuaXR0ZXN0LnB5CkBAIC0xMzcs MyArMTM3LDEzIEBAIGNsYXNzIFRlc3RTdW1tYXJ5UHJvdmlkZXJzKHVuaXR0ZXN0LlRlc3RDYXNl KToKICAgICBkZWYgc2VyaWFsX3Rlc3RfV1RGU3RyaW5nX1N1bW1hcnlQcm92aWRlcl8xNmJpdF9z dHJpbmcoc2VsZik6CiAgICAgICAgIHN1bW1hcnkgPSBsbGRiX3dlYmtpdC5XVEZTdHJpbmdfU3Vt bWFyeVByb3ZpZGVyKHNlbGYuX3NiRnJhbWUuRmluZFZhcmlhYmxlKCdhMTZCaXRTdHJpbmcnKSwg e30pCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoc3VtbWFyeSwgdSJ7IGxlbmd0aCA9IDEzLCBj b250ZW50cyA9ICdcXHUxNjgwQ2FwcHVjY2lub1xcdTE2ODBcXHgwMCcgfSIpCisKKyAgICAjIE1B Uks6IFdURlN0cmluZ19TdW1tYXJ5UHJvdmlkZXIgdGVzdCBjYXNlcworCisgICAgZGVmIHNlcmlh bF90ZXN0X1dURlZlY3RvclByb3ZpZGVyX2VtcHR5X3ZlY3RvcihzZWxmKToKKyAgICAgICAgc3Vt bWFyeSA9IGxsZGJfd2Via2l0LldURlZlY3Rvcl9TdW1tYXJ5UHJvdmlkZXIoc2VsZi5fc2JGcmFt ZS5GaW5kVmFyaWFibGUoJ2FuRW1wdHlWZWN0b3InKSwge30pCisgICAgICAgIHNlbGYuYXNzZXJ0 RXF1YWwoc3VtbWFyeSwgInsgc2l6ZSA9IDAsIGNhcGFjaXR5ID0gMCB9IikKKworICAgIGRlZiBz ZXJpYWxfdGVzdF9XVEZWZWN0b3JQcm92aWRlcl92ZWN0b3Jfc2l6ZV9hbmRfY2FwYWNpdHkoc2Vs Zik6CisgICAgICAgIHN1bW1hcnkgPSBsbGRiX3dlYmtpdC5XVEZWZWN0b3JfU3VtbWFyeVByb3Zp ZGVyKHNlbGYuX3NiRnJhbWUuRmluZFZhcmlhYmxlKCdhVmVjdG9yV2l0aE9uZUl0ZW0nKSwge30p CisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoc3VtbWFyeSwgInsgc2l6ZSA9IDEsIGNhcGFjaXR5 ID0gMTYgfSIpCg== 343790 2018-06-27 21:05:45 -0700 2018-06-27 22:08:15 -0700 Patch for lldb_webkit.py only lldb_vector.patch text/plain 1504 simon.fraser ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5NzQz NTBiOGVlZGY1Y2VlMGRmMDViNTIzZDg1YTNkZDA0NTBkNGRmLi45MzU0MjFmOWZlYzI5NGM5ZmIy ZDU1MWMxYTJhMmRjMGY4NWI5NTY0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTgtMDYtMjcgIFNpbW9uIEZyYXNl ciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgVGhlIGxsZGIgdmVjdG9yIHN1 bW1hcnkgcHJvdmlkZXIgYWx3YXlzIHNob3dzIHplcm8gY2FwYWNpdHkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NzEzMgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgV1RGVmVjdG9yUHJvdmlk ZXIgaW4gbGxkYl93ZWJraXQucHkgd2FzIGNhbGxpbmcgR2V0Q2hpbGRNZW1iZXJXaXRoTmFtZSgn bV9jYXBhY2l0eScpCisgICAgICAgIG9uIHRoZSBidWZmZXIgaW5zdGVhZCBvZiB0aGUgdmFsb2Jq LgorCisgICAgICAgICogbGxkYi9sbGRiX3dlYmtpdC5weToKKyAgICAgICAgKFdURlZlY3RvclBy b3ZpZGVyLnVwZGF0ZSk6CisKIDIwMTgtMDYtMDEgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBw bGUuY29tPgogCiAgICAgICAgIEFkZCBzb21lIHRlc3RzIGZvciBsbGRiX3dlYmtpdC5weQpkaWZm IC0tZ2l0IGEvVG9vbHMvbGxkYi9sbGRiX3dlYmtpdC5weSBiL1Rvb2xzL2xsZGIvbGxkYl93ZWJr aXQucHkKaW5kZXggZTk3ZWY5YTY1NTFhMDJjMDUwMjZjZjViOThjMDc5MTk1ZjZiYTI3Ni4uMzRj NjRjMzQ1MzI5ZTA2YTc1ODMwOTE2OTA3ZDMxYzdjNzRmNTM3NiAxMDA2NDQKLS0tIGEvVG9vbHMv bGxkYi9sbGRiX3dlYmtpdC5weQorKysgYi9Ub29scy9sbGRiL2xsZGJfd2Via2l0LnB5CkBAIC0z ODMsNyArMzgzLDcgQEAgY2xhc3MgV1RGVmVjdG9yUHJvdmlkZXI6CiAgICAgZGVmIHVwZGF0ZShz ZWxmKToKICAgICAgICAgc2VsZi5idWZmZXIgPSBzZWxmLnZhbG9iai5HZXRDaGlsZE1lbWJlcldp dGhOYW1lKCdtX2J1ZmZlcicpCiAgICAgICAgIHNlbGYuc2l6ZSA9IHNlbGYudmFsb2JqLkdldENo aWxkTWVtYmVyV2l0aE5hbWUoJ21fc2l6ZScpLkdldFZhbHVlQXNVbnNpZ25lZCgwKQotICAgICAg ICBzZWxmLmNhcGFjaXR5ID0gc2VsZi5idWZmZXIuR2V0Q2hpbGRNZW1iZXJXaXRoTmFtZSgnbV9j YXBhY2l0eScpLkdldFZhbHVlQXNVbnNpZ25lZCgwKQorICAgICAgICBzZWxmLmNhcGFjaXR5ID0g c2VsZi52YWxvYmouR2V0Q2hpbGRNZW1iZXJXaXRoTmFtZSgnbV9jYXBhY2l0eScpLkdldFZhbHVl QXNVbnNpZ25lZCgwKQogICAgICAgICBzZWxmLmRhdGFfdHlwZSA9IHNlbGYuYnVmZmVyLkdldFR5 cGUoKS5HZXRQb2ludGVlVHlwZSgpCiAgICAgICAgIHNlbGYuZGF0YV9zaXplID0gc2VsZi5kYXRh X3R5cGUuR2V0Qnl0ZVNpemUoKQogCg==