187120 2018-06-27 16:01:13 -0700 style-queue "AttributeError: 'NoneType' object has no attribute 'is_obsolete'" when processing security patch 2018-06-27 16:44:23 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates aakash_jain ddkilzer ews-watchlist glenn lforschler webkit-bug-importer oldest_to_newest 1437148 0 dbates 2018-06-27 16:01:13 -0700 Today I noticed that the style-queue raised an exception when trying to process a security-sensitive attachment: 2018-06-27 11:31:01,380 - Fetching next work item for style-queue 2018-06-27 11:31:01,752 - Fetching: https://bugs.webkit.org/attachment.cgi?id=343639&action=edit 2018-06-27 11:31:01,950 - You don't have permission to view this attachment. 2018-06-27 11:31:01,951 - Fetching: https://webkit-queues.webkit.org/attachment/metadata/343639 2018-06-27 11:31:02,275 - Fetching: https://webkit-queues.webkit.org/attachment/data/343639 2018-06-27 11:31:02,500 - Started processing patch 2018-06-27 11:31:03,057 - Fetching: https://bugs.webkit.org/attachment.cgi?id=343639&action=edit 2018-06-27 11:31:03,248 - You don't have permission to view this attachment. 2018-06-27 11:31:03,248 - Unable to parse bug_id from attachment 343639 Traceback (most recent call last): File "/Volumes/.../Tools/Scripts/webkitpy/tool/bot/queueengine.py", line 103, in run if not self._delegate.process_work_item(work_item): File "/Volumes/.../Tools/Scripts/webkitpy/tool/commands/queues.py", line 467, in process_work_item passed = self.review_patch(patch) File "/Volumes/.../Tools/Scripts/webkitpy/tool/commands/queues.py", line 491, in review_patch style_check_succeeded = task.run() File "/Volumes/.../Tools/Scripts/webkitpy/tool/bot/stylequeuetask.py", line 69, in run if not self._clean(): File "/Volumes/.../Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py", line 113, in _clean "Unable to clean working directory") File "/Volumes/.../Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py", line 97, in _run_command if not self.validate(): File "/Volumes/.../Tools/Scripts/webkitpy/tool/bot/stylequeuetask.py", line 40, in validate if self._patch.is_obsolete(): AttributeError: 'NoneType' object has no attribute 'is_obsolete' 1437165 1 343767 dbates 2018-06-27 16:32:25 -0700 Created attachment 343767 Patch 1437168 2 343767 ddkilzer 2018-06-27 16:41:15 -0700 Comment on attachment 343767 Patch r=me 1437170 3 dbates 2018-06-27 16:43:31 -0700 Committed r233288: <https://trac.webkit.org/changeset/233288> 1437171 4 webkit-bug-importer 2018-06-27 16:44:23 -0700 <rdar://problem/41551615> 343767 2018-06-27 16:32:25 -0700 2018-06-27 16:41:15 -0700 Patch bug-187120-20180627163225.patch text/plain 6082 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMjYyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTJlMzY4NjVlMTZlMjliNDMwMzJjMzViOTVlN2RiY2Vh MmUwYmM0MS4uYjM5OWI5YTAyMTEzNTY5ZTM1YWVkOGEyMzgzMWFmMWJhMTc5MWMxNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDE4LTA2LTI3ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBzdHlsZS1xdWV1ZSAiQXR0cmlidXRlRXJyb3I6ICdOb25lVHlwZScgb2JqZWN0IGhhcyBu byBhdHRyaWJ1dGUgJ2lzX29ic29sZXRlJyIgd2hlbiBwcm9jZXNzaW5nIHNlY3VyaXR5IHBhdGNo CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODcxMjAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZWFjaCB0 aGUgc3R5bGUgcXVldWUgaG93IHRvIHJlZmV0Y2ggYSBwYXRjaCBmcm9tIHRoZSBzdGF0dXMgc2Vy dmVyIGFzIHdlIGRpZCBmb3Igbm9uLVN0eWxlCisgICAgICAgIEVXUyBxdWV1ZXMuCisKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3N0eWxlcXVldWV0YXNrLnB5OgorICAgICAg ICAoU3R5bGVRdWV1ZVRhc2sudmFsaWRhdGUpOiBTaW1pbGFyIHRvIGNoYW5nZSBtYWRlIHRvIEVh cmx5V2FybmluZ1N5c3RlbVRhc2sudmFsaWRhdGUoKSBpbiByMjMzMTA3LAorICAgICAgICBvbmx5 IGNoZWNrIGlmIHRoZSBidWcgYXNzb2NpYXRlZCB3aXRoIHRoZSBwYXRjaCB3ZSBhcmUgcHJvY2Vz c2luZyBpcyBjbG9zZWQgaWYgdGhlIGF0dGFjaG1lbnQgaGFzIGEKKyAgICAgICAgbm9uLU5vbmUg QnVnIG9iamVjdC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFy bHl3YXJuaW5nc3lzdGVtLnB5OgorICAgICAgICAoQWJzdHJhY3RFYXJseVdhcm5pbmdTeXN0ZW0u cmVmZXRjaF9wYXRjaCk6IEV4dHJhY3QgbG9naWMgdG8gcmVmZXRjaCBhIHBhdGNoIGZyb20gaGVy ZS4uLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXMucHk6 CisgICAgICAgIChQYXRjaFByb2Nlc3NpbmdRdWV1ZS5fcmVmZXRjaF9wYXRjaCk6IC4uLiB0byBo ZXJlLgorICAgICAgICAoU3R5bGVRdWV1ZS5yZWZldGNoX3BhdGNoKTogVHVybiBhcm91bmQgYW5k IGNhbGwgUGF0Y2hQcm9jZXNzaW5nUXVldWUuX3JlZmV0Y2hfcGF0Y2goKS4KKwogMjAxOC0wNi0y NyAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgd2Via2l0LXBh dGNoIHNob3VsZCBpZ25vcmUgbm9uLUFTQ0lJIGNoYXJhY3RlcnMgaW4gdGhlIHN0YXR1cyBzZXJ2 ZXIgQVBJIGtleQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9z dHlsZXF1ZXVldGFzay5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qvc3R5bGVx dWV1ZXRhc2sucHkKaW5kZXggODVlZGUwNzJkNjQ4NWEzMGQ0NTI1YzExMjNmYTA2ZGU5NTFlZjA4 OC4uMTZjYjY5ZjdiZWRiZmQ0ZDUzMDBkMjQwMWY2ZmE3ZDQ5MzMxOWFjYSAxMDA2NDQKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9zdHlsZXF1ZXVldGFzay5weQorKysgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3N0eWxlcXVldWV0YXNrLnB5CkBAIC0zNiwx MSArMzYsMTUgQEAgY2xhc3MgU3R5bGVRdWV1ZVRhc2tEZWxlZ2F0ZShQYXRjaEFuYWx5c2lzVGFz a0RlbGVnYXRlKToKIAogY2xhc3MgU3R5bGVRdWV1ZVRhc2soUGF0Y2hBbmFseXNpc1Rhc2spOgog ICAgIGRlZiB2YWxpZGF0ZShzZWxmKToKKyAgICAgICAgIyBGSVhNRTogTmVlZCBhIHdheSB0byBh c2sgdGhlIHN0YXR1cyBzZXJ2ZXIgZm9yIGxhdGVzdCBzdGF0dXMgb2YgYSBzZWN1cml0eSBidWcu CisgICAgICAgICMgQXR0YWNobWVudHMgZG93bmxvYWRlZCBmcm9tIHRoZSBzdGF0dXMgc2VydmVy IGRvIG5vdCBoYXZlIGFuIGFzc29jaWF0ZWQgYnVnIGFuZAorICAgICAgICAjIHJlZmxlY3QgdGhl IEJ1Z3ppbGxhIHN0YXRlIGF0IHRoZSB0aW1lIHRoZXkgd2VyZSB1cGxvYWRlZCB0byB0aGUgc3Rh dHVzIHNlcnZlci4KKyAgICAgICAgIyBTZWUgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xODY4MTc+LgogICAgICAgICBzZWxmLl9wYXRjaCA9IHNlbGYuX2RlbGVnYXRl LnJlZmV0Y2hfcGF0Y2goc2VsZi5fcGF0Y2gpCiAgICAgICAgIGlmIHNlbGYuX3BhdGNoLmlzX29i c29sZXRlKCk6CiAgICAgICAgICAgICBzZWxmLmVycm9yID0gIlBhdGNoIGlzIG9ic29sZXRlLiIK ICAgICAgICAgICAgIHJldHVybiBGYWxzZQotICAgICAgICBpZiBzZWxmLl9wYXRjaC5idWcoKS5p c19jbG9zZWQoKToKKyAgICAgICAgaWYgc2VsZi5fcGF0Y2guYnVnKCkgYW5kIHNlbGYuX3BhdGNo LmJ1ZygpLmlzX2Nsb3NlZCgpOgogICAgICAgICAgICAgc2VsZi5lcnJvciA9ICJCdWcgaXMgYWxy ZWFkeSBjbG9zZWQuIgogICAgICAgICAgICAgcmV0dXJuIEZhbHNlCiAgICAgICAgIGlmIHNlbGYu X3BhdGNoLnJldmlldygpID09ICItIjoKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW0ucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtLnB5CmluZGV4IDc0ZmZlOGU4 MWNjMWZjMDY5YWEwMzJiOTBmMDcxMWFhZDFjNDg1OGYuLjZiYjZiZTIwZGNmZjUxZTAyN2ZjNTgz OWY2NzRkMTUwZjE4N2RhOWIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9v bC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW0ucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5weQpAQCAtMzQsNyArMzQsNiBA QCBmcm9tIG9wdHBhcnNlIGltcG9ydCBtYWtlX29wdGlvbgogCiBmcm9tIHdlYmtpdHB5LmNvbW1v bi5jb25maWcuY29tbWl0dGVycyBpbXBvcnQgQ29tbWl0dGVyTGlzdAogZnJvbSB3ZWJraXRweS5j b21tb24uY29uZmlnLnBvcnRzIGltcG9ydCBEZXByZWNhdGVkUG9ydAotZnJvbSB3ZWJraXRweS5j b21tb24ubmV0LmJ1Z3ppbGxhIGltcG9ydCBCdWd6aWxsYQogZnJvbSB3ZWJraXRweS5jb21tb24u c3lzdGVtLmZpbGVzeXN0ZW0gaW1wb3J0IEZpbGVTeXN0ZW0KIGZyb20gd2Via2l0cHkuY29tbW9u LnN5c3RlbS5leGVjdXRpdmUgaW1wb3J0IFNjcmlwdEVycm9yCiBmcm9tIHdlYmtpdHB5LnRvb2wu Ym90LmVhcmx5d2FybmluZ3N5c3RlbXRhc2sgaW1wb3J0IEVhcmx5V2FybmluZ1N5c3RlbVRhc2ss IEVhcmx5V2FybmluZ1N5c3RlbVRhc2tEZWxlZ2F0ZQpAQCAtMTUzLDE2ICsxNTIsNyBAQCBjbGFz cyBBYnN0cmFjdEVhcmx5V2FybmluZ1N5c3RlbShBYnN0cmFjdFJldmlld1F1ZXVlLCBFYXJseVdh cm5pbmdTeXN0ZW1UYXNrRGVsZQogICAgICAgICByZXR1cm4gc2VsZi5fZ3JvdXAKIAogICAgIGRl ZiByZWZldGNoX3BhdGNoKHNlbGYsIHBhdGNoKToKLSAgICAgICAgcGF0Y2hfaWQgPSBwYXRjaC5p ZCgpCi0gICAgICAgIHRyeToKLSAgICAgICAgICAgIHBhdGNoID0gc2VsZi5fdG9vbC5idWdzLmZl dGNoX2F0dGFjaG1lbnQocGF0Y2hfaWQsIHRocm93X29uX2FjY2Vzc19lcnJvcj1UcnVlKQotICAg ICAgICBleGNlcHQgQnVnemlsbGEuQWNjZXNzRXJyb3IgYXMgZToKLSAgICAgICAgICAgICMgRklY TUU6IE5lZWQgYSB3YXkgdG8gYXNrIHRoZSBzdGF0dXMgc2VydmVyIHRvIGZldGNoIHRoZSBwYXRj aCBhZ2Fpbi4gRm9yIG5vdwotICAgICAgICAgICAgIyB3ZSByZXR1cm4gdGhlIGF0dGFjaG1lbnQg YXMgaXQgd2FzIHdoZW4gaXQgd2FzIG9yaWdpbmFsbHkgdXBsb2FkZWQgdG8gdGhlCi0gICAgICAg ICAgICAjIHN0YXR1cyBzZXJ2ZXIuIFNlZSA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4NjgxNz4uCi0gICAgICAgICAgICBpZiBlLmVycm9yX2NvZGUgPT0gQnVnemls bGEuQWNjZXNzRXJyb3IuTk9UX1BFUk1JVFRFRDoKLSAgICAgICAgICAgICAgICBwYXRjaCA9IHNl bGYuX3Rvb2wuc3RhdHVzX3NlcnZlci5mZXRjaF9hdHRhY2htZW50KHBhdGNoX2lkKQotICAgICAg ICByZXR1cm4gcGF0Y2gKKyAgICAgICAgcmV0dXJuIHN1cGVyKEFic3RyYWN0RWFybHlXYXJuaW5n U3lzdGVtLCBzZWxmKS5fcmVmZXRjaF9wYXRjaChwYXRjaCkKIAogICAgIGRlZiByZXBvcnRfZmxh a3lfdGVzdHMoc2VsZiwgcGF0Y2gsIGZsYWt5X3Rlc3RfcmVzdWx0cywgcmVzdWx0c19hcmNoaXZl KToKICAgICAgICAgcGFzcwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s L2NvbW1hbmRzL3F1ZXVlcy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5k cy9xdWV1ZXMucHkKaW5kZXggMmIzM2Y5ODBlOWM2MGYwY2Q4MDYzZDRmY2ZiNDU5YTRkZWE1NmEz Zi4uN2ZkMjQzMDZjNTMzZjhhNjIzOWVmMjQxMWExMTVjMzNjZWFiNzA0MCAxMDA2NDQKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlcy5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5CkBAIC0zMjgsNiArMzI4 LDE4IEBAIGNsYXNzIFBhdGNoUHJvY2Vzc2luZ1F1ZXVlKEFic3RyYWN0UGF0Y2hRdWV1ZSk6CiAg ICAgICAgIGlmIHNlbGYuX2Nhbl9hY2Nlc3NfYnVnKHBhdGNoLmJ1Z19pZCgpKToKICAgICAgICAg ICAgIHNlbGYuX3Rvb2wuYnVncy5hZGRfYXR0YWNobWVudF90b19idWcocGF0Y2guYnVnX2lkKCks IHJlc3VsdHNfYXJjaGl2ZV9maWxlLCBkZXNjcmlwdGlvbiwgZmlsZW5hbWU9ImxheW91dC10ZXN0 LXJlc3VsdHMuemlwIiwgY29tbWVudF90ZXh0PWNvbW1lbnRfdGV4dCkKIAorICAgIGRlZiBfcmVm ZXRjaF9wYXRjaChzZWxmLCBwYXRjaCk6CisgICAgICAgIHBhdGNoX2lkID0gcGF0Y2guaWQoKQor ICAgICAgICB0cnk6CisgICAgICAgICAgICBwYXRjaCA9IHNlbGYuX3Rvb2wuYnVncy5mZXRjaF9h dHRhY2htZW50KHBhdGNoX2lkLCB0aHJvd19vbl9hY2Nlc3NfZXJyb3I9VHJ1ZSkKKyAgICAgICAg ZXhjZXB0IEJ1Z3ppbGxhLkFjY2Vzc0Vycm9yIGFzIGU6CisgICAgICAgICAgICAjIEZJWE1FOiBO ZWVkIGEgd2F5IHRvIGFzayB0aGUgc3RhdHVzIHNlcnZlciB0byBmZXRjaCB0aGUgcGF0Y2ggYWdh aW4uIEZvciBub3cKKyAgICAgICAgICAgICMgd2UgcmV0dXJuIHRoZSBhdHRhY2htZW50IGFzIGl0 IHdhcyB3aGVuIGl0IHdhcyBvcmlnaW5hbGx5IHVwbG9hZGVkIHRvIHRoZQorICAgICAgICAgICAg IyBzdGF0dXMgc2VydmVyLiBTZWUgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODY4MTc+LgorICAgICAgICAgICAgaWYgZS5lcnJvcl9jb2RlID09IEJ1Z3ppbGxhLkFj Y2Vzc0Vycm9yLk5PVF9QRVJNSVRURUQ6CisgICAgICAgICAgICAgICAgcGF0Y2ggPSBzZWxmLl90 b29sLnN0YXR1c19zZXJ2ZXIuZmV0Y2hfYXR0YWNobWVudChwYXRjaF9pZCkKKyAgICAgICAgcmV0 dXJuIHBhdGNoCisKIAogY2xhc3MgQ29tbWl0UXVldWUoUGF0Y2hQcm9jZXNzaW5nUXVldWUsIFN0 ZXBTZXF1ZW5jZUVycm9ySGFuZGxlciwgQ29tbWl0UXVldWVUYXNrRGVsZWdhdGUpOgogICAgIGRl ZiBfX2luaXRfXyhzZWxmLCBjb21taXRfcXVldWVfdGFza19jbGFzcz1Db21taXRRdWV1ZVRhc2sp OgpAQCAtNTIzLDQgKzUzNSw0IEBAIGNsYXNzIFN0eWxlUXVldWUoQWJzdHJhY3RSZXZpZXdRdWV1 ZSwgU3R5bGVRdWV1ZVRhc2tEZWxlZ2F0ZSk6CiAgICAgICAgIHJldHVybiBOb25lCiAKICAgICBk ZWYgcmVmZXRjaF9wYXRjaChzZWxmLCBwYXRjaCk6Ci0gICAgICAgIHJldHVybiBzZWxmLl90b29s LmJ1Z3MuZmV0Y2hfYXR0YWNobWVudChwYXRjaC5pZCgpKQorICAgICAgICByZXR1cm4gc3VwZXIo U3R5bGVRdWV1ZSwgc2VsZikuX3JlZmV0Y2hfcGF0Y2gocGF0Y2gpCg==