187107 2018-06-27 11:02:55 -0700 webkit-patch should ignore non-ASCII characters in the status server API key 2018-06-27 14:11:31 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates aakash_jain ews-watchlist glenn jbedard lforschler webkit-bug-importer oldest_to_newest 1437012 0 dbates 2018-06-27 11:02:55 -0700 webkit-patch should ignore non-ASCII characters in the status server API key. 1437018 1 dbates 2018-06-27 11:08:10 -0700 Currently specifying non-ASCII characters in the API key will cause a UnicodeEncodeError exception when webkit-patch tries to post a status update. You can reproduce this by running an EWS: 1. In the top-level WebKit checkout, run `git config webkit.status-api-key ‘test’`. 2. Run, `Tools/Scripts/webkit-patch mac-wk2-ews`. Then we you will eventually see a backtrace of the form: [[ Traceback (most recent call last): File "./Tools/Scripts/webkit-patch", line 84, in <module> main() File "./Tools/Scripts/webkit-patch", line 79, in main WebKitPatch(os.path.abspath(__file__)).main() File "/Volumes/.../Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/Volumes/.../Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Volumes/.../Tools/Scripts/webkitpy/tool/commands/queues.py", line 154, in execute return engine(self.name, self, self._tool.wakeup_event, self._options.seconds_to_sleep).run() File "/Volumes/.../Tools/Scripts/webkitpy/tool/bot/queueengine.py", line 93, in run self._delegate.begin_work_queue() File "/Volumes/.../Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py", line 61, in begin_work_queue AbstractReviewQueue.begin_work_queue(self) File "/Volumes/.../Tools/Scripts/webkitpy/tool/commands/queues.py", line 460, in begin_work_queue PatchProcessingQueue.begin_work_queue(self) File "/Volumes/.../Tools/Scripts/webkitpy/tool/commands/queues.py", line 294, in begin_work_queue AbstractPatchQueue.begin_work_queue(self) File "/Volumes/.../Tools/Scripts/webkitpy/tool/commands/queues.py", line 131, in begin_work_queue self._tool.status_server.update_status(self.name, "Starting Queue") File "/Volumes/.../Tools/Scripts/webkitpy/common/net/statusserver.py", line 198, in update_status return NetworkTransaction().run(lambda: self._post_status_to_server(queue_name, status, patch, results_file)) File "/Volumes/.../Tools/Scripts/webkitpy/common/net/networktransaction.py", line 53, in run return request() File "/Volumes/.../Tools/Scripts/webkitpy/common/net/statusserver.py", line 198, in <lambda> return NetworkTransaction().run(lambda: self._post_status_to_server(queue_name, status, patch, results_file)) File "/Volumes/.../Tools/Scripts/webkitpy/common/net/statusserver.py", line 107, in _post_status_to_server self._browser.open(update_status_url) File "/Volumes/.../Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open return self._mech_open(url, data, timeout=timeout) File "/Volumes/.../Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 230, in _mech_open response = UserAgentBase.open(self, request, data) File "/Volumes/.../Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_opener.py", line 193, in open response = urlopen(self, req, data) File "/Volumes/.../Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 344, in _open '_open', req) File "/Volumes/.../Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/Volumes/.../Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/Volumes/.../Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1115, in do_open h.request(req.get_method(), req.get_selector(), req.data, headers) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 1053, in request self._send_request(method, url, body, headers) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 1092, in _send_request self.putheader(hdr, value) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 1028, in putheader values = [str(v) for v in values] UnicodeEncodeError: 'ascii' codec can't encode character u'\u2018' in position 7: ordinal not in range(128) ]] 1437029 2 343731 dbates 2018-06-27 11:27:43 -0700 Created attachment 343731 Patch 1437093 3 343731 dbates 2018-06-27 14:10:28 -0700 Comment on attachment 343731 Patch Clearing flags on attachment: 343731 Committed r233276: <https://trac.webkit.org/changeset/233276> 1437094 4 dbates 2018-06-27 14:10:30 -0700 All reviewed patches have been landed. Closing bug. 1437095 5 webkit-bug-importer 2018-06-27 14:11:31 -0700 <rdar://problem/41542531> 343731 2018-06-27 11:27:43 -0700 2018-06-27 14:10:28 -0700 Patch bug-187107-20180627112743.patch text/plain 2586 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMjYyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmExZTI4N2NiYTAzZGVlMGQ1Y2ZlOTFkMWEwNGI5NTI2 MjIwZGE2Yy4uYTJlMzY4NjVlMTZlMjliNDMwMzJjMzViOTVlN2RiY2VhMmUwYmM0MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE4LTA2LTI3ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICB3ZWJraXQtcGF0Y2ggc2hvdWxkIGlnbm9yZSBub24tQVNDSUkgY2hhcmFjdGVycyBpbiB0 aGUgc3RhdHVzIHNlcnZlciBBUEkga2V5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xODcxMDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGUgQVBJIGtleSBzaG91bGQgb25seSBjb25zaXN0cyBvZiBBU0NJ SSBjaGFyYWN0ZXJzLiBJZiBpdCBjb250YWlucyBhbnkKKyAgICAgICAgbm9uLUFTQ0lJIGNoYXJh Y3RlcnMgdGhlbiBsb2cgYSB3YXJuaW5nIGFuZCBpZ25vcmUgdGhlbS4KKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9zdGF0dXNzZXJ2ZXIucHk6CisgICAgICAgIChTdGF0 dXNTZXJ2ZXIuc2V0X2FwaV9rZXkpOiBGb3JjZSBjb252ZXJzaW9uIHRvIEFTQ0lJLgorICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9tYWluLnB5OgorICAgICAgICAoV2ViS2l0UGF0Y2gu X3N0YXR1c19zZXJ2ZXJfYXBpX2tleSk6IENvbnZlcnQgdG8gQVNDSUksIGlnbm9yaW5nIG5vbi1B U0NJSQorICAgICAgICBjaGFyYWN0ZXJzIGFuZCBsb2dnaW5nIGEgd2FybmluZy4KKwogMjAxOC0w Ni0yNyAgUm9iaW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUuY29tPgogCiAgICAgICAgIFtX U0xdIEFkZCBhIGNvbnRyb2wtZmxvdyBzdGFjayB0byB0aGUgZXhlY3V0aW9uIHJ1bGVzIGluIFdT TC5vdHQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9zdGF0 dXNzZXJ2ZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvc3RhdHVzc2Vy dmVyLnB5CmluZGV4IDlhYTgyNzQ2MWY5ODdmMzg3OWZkMDU1M2VjODg2Y2Y5MTY2NzIzZDUuLjNm NWJlYjEwYmNjOTg3MWNlNjRjMzc4NzRlMzNjMTg5NTZkN2Q5ZDAgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9zdGF0dXNzZXJ2ZXIucHkKKysrIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L3N0YXR1c3NlcnZlci5weQpAQCAtNjMsNyArNjMs NyBAQCBjbGFzcyBTdGF0dXNTZXJ2ZXI6CiAgICAgICAgIHNlbGYuYm90X2lkID0gYm90X2lkCiAK ICAgICBkZWYgc2V0X2FwaV9rZXkoc2VsZiwgYXBpX2tleSk6Ci0gICAgICAgIHNlbGYuX2FwaV9r ZXkgPSBhcGlfa2V5CisgICAgICAgIHNlbGYuX2FwaV9rZXkgPSBzdHIoYXBpX2tleSkKICAgICAg ICAgbmV3X2hlYWRlcnMgPSBmaWx0ZXIobGFtYmRhIGhlYWRlcjogaGVhZGVyWzBdICE9IHNlbGYu X0FVVEhPUklaQVRJT05fSEVBREVSX05BTUUsIHNlbGYuX2Jyb3dzZXIuYWRkaGVhZGVycykKICAg ICAgICAgaWYgYXBpX2tleToKICAgICAgICAgICAgIG5ld19oZWFkZXJzLmFwcGVuZChzZWxmLl9h dXRob3JpemF0aW9uX2hlYWRlcl9uYW1lX2FuZF92YWx1ZV9wYWlyKCkpCmRpZmYgLS1naXQgYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvbWFpbi5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvdG9vbC9tYWluLnB5CmluZGV4IGU3N2I4M2FjNThkMWI4MTkxMjZlMjQ3YWE1NjEyZWQxN2Nm NWYyNGUuLjc4M2EzZmRjMDc3NGYwMzU1MmFmZTUyZDE4MTUwMjA1ZThhY2U3MDcgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9tYWluLnB5CisrKyBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvdG9vbC9tYWluLnB5CkBAIC0xMTEsNiArMTExLDExIEBAIGNsYXNzIFdlYktp dFBhdGNoKE11bHRpQ29tbWFuZFRvb2wsIEhvc3QpOgogICAgICAgICBhcGlfa2V5ID0gb3MuZW52 aXJvbi5nZXQoJ1dFQktJVF9TVEFUVVNfQVBJX0tFWScpCiAgICAgICAgIGlmIG5vdCBhcGlfa2V5 OgogICAgICAgICAgICAgYXBpX2tleSA9IFdlYktpdFBhdGNoLl9zdGF0dXNfc2VydmVyX2FwaV9r ZXlfZnJvbV9naXQoKQorICAgICAgICB0cnk6CisgICAgICAgICAgICBhcGlfa2V5ID0gc3RyKGFw aV9rZXkpCisgICAgICAgIGV4Y2VwdCBVbmljb2RlRW5jb2RlRXJyb3I6CisgICAgICAgICAgICBf bG9nLndhcm5pbmcoJ0lnbm9yaW5nIG5vbi1BU0NJSSBjaGFyYWN0ZXJzIGluIEFQSSBrZXkuJykK KyAgICAgICAgICAgIGFwaV9rZXkgPSBhcGlfa2V5LmVuY29kZSgnYXNjaWknLCAnaWdub3JlJykK ICAgICAgICAgcmV0dXJuIGFwaV9rZXkKIAogICAgICMgRklYTUU6IFRoaXMgbWF5IGJlIHVubmVj ZXNzYXJ5IHNpbmNlIHdlIHBhc3MgZ2xvYmFsIG9wdGlvbnMgdG8gYWxsIGNvbW1hbmRzIGR1cmlu ZyBleGVjdXRlKCkgYXMgd2VsbC4K