187099 2018-06-27 08:56:12 -0700 REGRESSION(r233208): Completion handler does not get called on GTK port 2018-06-28 06:25:56 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 186903 1 cdumez cdumez beidson bfulgham commit-queue fred.wang ggaren koivisto mcatanzaro webkit-bug-importer wilander oldest_to_newest 1436955 0 cdumez 2018-06-27 08:56:12 -0700 Regression(r233208): Completion handler does not get called on GTK port: Thread 1 (Thread 0x7fac3d9906c0 (LWP 38186)): #0 0x00005630fe15d3c8 in WTFCrash () at /home/slave/webkitgtk/gtk-linux-64-debug/build/Source/WTF/wtf/Assertions.cpp:267 #1 0x00007fac55a42fc0 in WTF::CompletionHandler<void()>::~CompletionHandler(void) (this=0x7fff1fef7d08, __in_chrg=<optimized out>) at DerivedSources/ForwardingHeaders/wtf/CompletionHandler.h:51 #2 0x00007fac56355de4 in (anonymous namespace)::WebResourceLoadStatisticsStore::<lambda()>::operator()(void) (__closure=0x7fac3d0d3060) at ../../Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:1360 #3 0x00007fac563824aa in WTF::Function<void()>::CallableWrapper<WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains(const WTF::Vector<WTF::String>&, const WTF::Vector<WTF::String>&, const WTF::Vector<WTF::String>&, WebKit::ShouldClearFirst, WTF::CompletionHandler<void()>&&)::<lambda()> >::call(void) (this=0x7fac3d0d3058) at DerivedSources/ForwardingHeaders/wtf/Function.h:101 #4 0x00005630fe17ca8a in WTF::Function<void()>::operator()(void) const (this=0x7fff1fef7d98) at ../../Source/WTF/wtf/Function.h:56 #5 0x00005630fe1908b5 in WTF::RunLoop::performWork (this=0x7fac3d0f7000) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Source/WTF/wtf/RunLoop.cpp:123 #6 0x00005630fe1de684 in WTF::RunLoop::<lambda(gpointer)>::operator()(gpointer) const (__closure=0x0, userData=0x7fac3d0f7000) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Source/WTF/wtf/glib/RunLoopGLib.cpp:68 #7 0x00005630fe1de6a8 in WTF::RunLoop::<lambda(gpointer)>::_FUN(gpointer) () at /home/slave/webkitgtk/gtk-linux-64-debug/build/Source/WTF/wtf/glib/RunLoopGLib.cpp:70 #8 0x00005630fe1de624 in WTF::<lambda(GSource*, GSourceFunc, gpointer)>::operator()(GSource *, GSourceFunc, gpointer) const (__closure=0x0, source=0x5630fe5d9110, callback=0x5630fe1de68b <WTF::RunLoop::<lambda(gpointer)>::_FUN(gpointer)>, userData=0x7fac3d0f7000) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Source/WTF/wtf/glib/RunLoopGLib.cpp:45 #9 0x00005630fe1de653 in WTF::<lambda(GSource*, GSourceFunc, gpointer)>::_FUN(GSource *, GSourceFunc, gpointer) () at /home/slave/webkitgtk/gtk-linux-64-debug/build/Source/WTF/wtf/glib/RunLoopGLib.cpp:46 #10 0x00007fac4ca4f81a in g_main_dispatch () at /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3148 #11 g_main_context_dispatch () at /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3813 #12 0x00007fac4ca4fba8 in g_main_context_iterate () at /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3886 #13 0x00007fac4ca4fec2 in g_main_loop_run () at /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:4082 #14 0x00005630fe1deb61 in WTF::RunLoop::run () at /home/slave/webkitgtk/gtk-linux-64-debug/build/Source/WTF/wtf/glib/RunLoopGLib.cpp:96 #15 0x00005630fe15c38c in WTR::TestController::platformRunUntil (this=0x7fff1fef8c70, timeout=7.5) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp:88 #16 0x00005630fe11fb3b in WTR::TestController::runUntil (this=0x7fff1fef8c70, done=@0x7fff1fef8d6c: false, timeout=7.5) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Tools/WebKitTestRunner/TestController.cpp:1322 #17 0x00005630fe11dd44 in WTR::TestController::resetStateToConsistentValues (this=0x7fff1fef8c70, options=...) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Tools/WebKitTestRunner/TestController.cpp:909 #18 0x00005630fe11cce4 in WTR::TestController::ensureViewSupportsOptionsForTest (this=0x7fff1fef8c70, test=...) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Tools/WebKitTestRunner/TestController.cpp:672 #19 0x00005630fe11f083 in WTR::TestController::configureViewForTest (this=0x7fff1fef8c70, test=...) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Tools/WebKitTestRunner/TestController.cpp:1174 #20 0x00005630fe13639a in WTR::TestInvocation::invoke (this=0x5630feb67ca0) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Tools/WebKitTestRunner/TestInvocation.cpp:152 #21 0x00005630fe11f96b in WTR::TestController::runTest (this=0x7fff1fef8c70, inputLine=0x7fff1fef83e0 "/home/slave/webkitgtk/gtk-linux-64-debug-tests/build/LayoutTests/accessibility/accessibility-crash-setattribute.html'--timeout'30000") at /home/slave/webkitgtk/gtk-linux-64-debug/build/Tools/WebKitTestRunner/TestController.cpp:1283 #22 0x00005630fe11fa4e in WTR::TestController::runTestingServerLoop (this=0x7fff1fef8c70) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Tools/WebKitTestRunner/TestController.cpp:1300 #23 0x00005630fe11fa82 in WTR::TestController::run (this=0x7fff1fef8c70) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Tools/WebKitTestRunner/TestController.cpp:1308 #24 0x00005630fe11adfd in WTR::TestController::TestController (this=0x7fff1fef8c70, argc=2, argv=0x7fff1fef8f48) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Tools/WebKitTestRunner/TestController.cpp:130 #25 0x00005630fe15cd29 in main (argc=2, argv=0x7fff1fef8f48) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Tools/WebKitTestRunner/gtk/main.cpp:46 1436958 1 343714 cdumez 2018-06-27 08:57:47 -0700 Created attachment 343714 Patch 1436974 2 343714 commit-queue 2018-06-27 09:36:49 -0700 Comment on attachment 343714 Patch Clearing flags on attachment: 343714 Committed r233261: <https://trac.webkit.org/changeset/233261> 1436975 3 commit-queue 2018-06-27 09:36:51 -0700 All reviewed patches have been landed. Closing bug. 1436976 4 webkit-bug-importer 2018-06-27 09:39:28 -0700 <rdar://problem/41527898> 1437326 5 fred.wang 2018-06-28 06:25:56 -0700 @Chris: Thanks, that solved the issue indeed! 343714 2018-06-27 08:57:47 -0700 2018-06-27 09:36:49 -0700 Patch bug-187099-20180627085812.patch text/plain 3766 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDgyYjlhOWEzOTNhMjE4NTRi YThiMGM5NWJlNGJhYWY1YWRmMmJhN2QuLmUzMDI1OGQ5YjY0MzViMTMyNDc2ZWQ3ODg2YjQyMGRi MDQ4NjE0ODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMDYtMjcgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIyMzMyMDgpOiBD b21wbGV0aW9uIGhhbmRsZXIgZG9lcyBub3QgZ2V0IGNhbGxlZCBvbiBHVEsgcG9ydAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3MDk5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBzdXJlIFVwZGF0 ZVByZXZhbGVudERvbWFpbnNUb1BhcnRpdGlvbk9yQmxvY2tDb29raWVzSGFuZGxlcidzIGNvbXBs ZXRpb24gaGFuZGxlcgorICAgICAgICBnZXRzIGNhbGxlZCBvbiBub24tQ09DT0EgcG9ydHMuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlLmg6CisK IDIwMTgtMDYtMjYgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAg ICAgICAgUHJvbW90ZSBzb21lIGV4cGVyaW1lbnRhbCBmZWF0dXJlcyB0byB0cmFkaXRpb25hbCBm ZWF0dXJlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUmVzb3VyY2VM b2FkU3RhdGlzdGljc1N0b3JlLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJSZXNvdXJj ZUxvYWRTdGF0aXN0aWNzU3RvcmUuaAppbmRleCA5NmE1MjlmNDg0YmM1NmQ0ZDJjNjdmZDBlODcy ZTEyOGJhY2QzYmEyLi4zNTljNTlkNDExNzY3NWZiZjdmZGM0MTI2MDk0MDUyNzYyZDg0ZDQxIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJSZXNvdXJjZUxvYWRTdGF0aXN0 aWNzU3RvcmUuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJSZXNvdXJjZUxvYWRT dGF0aXN0aWNzU3RvcmUuaApAQCAtNzMsNyArNzMsNyBAQCBwdWJsaWM6CiAgICAgdXNpbmcgR3Jh bnRTdG9yYWdlQWNjZXNzSGFuZGxlciA9IFdURjo6RnVuY3Rpb248dm9pZChjb25zdCBTdHJpbmcm IHJlc291cmNlRG9tYWluLCBjb25zdCBTdHJpbmcmIGZpcnN0UGFydHlEb21haW4sIHN0ZDo6b3B0 aW9uYWw8dWludDY0X3Q+IGZyYW1lSUQsIHVpbnQ2NF90IHBhZ2VJRCwgV1RGOjpGdW5jdGlvbjx2 b2lkKGJvb2wgd2FzR3JhbnRlZCk+JiYgY2FsbGJhY2spPjsKICAgICB1c2luZyBSZW1vdmVBbGxT dG9yYWdlQWNjZXNzSGFuZGxlciA9IFdURjo6RnVuY3Rpb248dm9pZCgpPjsKICAgICB1c2luZyBS ZW1vdmVQcmV2YWxlbnREb21haW5zSGFuZGxlciA9IFdURjo6RnVuY3Rpb248dm9pZCAoY29uc3Qg VmVjdG9yPFN0cmluZz4mKT47Ci0gICAgc3RhdGljIFJlZjxXZWJSZXNvdXJjZUxvYWRTdGF0aXN0 aWNzU3RvcmU+IGNyZWF0ZShjb25zdCBTdHJpbmcmIHJlc291cmNlTG9hZFN0YXRpc3RpY3NEaXJl Y3RvcnksIEZ1bmN0aW9uPHZvaWQgKGNvbnN0IFN0cmluZyYpPiYmIHRlc3RpbmdDYWxsYmFjaywg Ym9vbCBpc0VwaGVtZXJhbCwgVXBkYXRlUHJldmFsZW50RG9tYWluc1RvUGFydGl0aW9uT3JCbG9j a0Nvb2tpZXNIYW5kbGVyJiYgdXBkYXRlUHJldmFsZW50RG9tYWluc1RvUGFydGl0aW9uT3JCbG9j a0Nvb2tpZXNIYW5kbGVyID0gW10oY29uc3QgV1RGOjpWZWN0b3I8U3RyaW5nPiYsIGNvbnN0IFdU Rjo6VmVjdG9yPFN0cmluZz4mLCBjb25zdCBXVEY6OlZlY3RvcjxTdHJpbmc+JiwgU2hvdWxkQ2xl YXJGaXJzdCwgQ29tcGxldGlvbkhhbmRsZXI8dm9pZCgpPiYmIGNhbGxiYWNrID0gW10oKSB7IH0p IHsgfSwgSGFzU3RvcmFnZUFjY2Vzc0ZvckZyYW1lSGFuZGxlciYmIGhhc1N0b3JhZ2VBY2Nlc3NG b3JGcmFtZUhhbmRsZXIgPSBbXShjb25zdCBTdHJpbmcmLCBjb25zdCBTdHJpbmcmLCB1aW50NjRf dCwgdWludDY0X3QsIFdURjo6RnVuY3Rpb248dm9pZChib29sKT4mJikgeyB9LCBHcmFudFN0b3Jh Z2VBY2Nlc3NIYW5kbGVyJiYgZ3JhbnRTdG9yYWdlQWNjZXNzSGFuZGxlciA9IFtdKGNvbnN0IFN0 cmluZyYsIGNvbnN0IFN0cmluZyYsIHN0ZDo6b3B0aW9uYWw8dWludDY0X3Q+LCB1aW50NjRfdCwg V1RGOjpGdW5jdGlvbjx2b2lkKGJvb2wpPiYmKSB7IH0sIFJlbW92ZUFsbFN0b3JhZ2VBY2Nlc3NI YW5kbGVyJiYgcmVtb3ZlQWxsU3RvcmFnZUFjY2Vzc0hhbmRsZXIgPSBbXSgpIHsgfSwgUmVtb3Zl UHJldmFsZW50RG9tYWluc0hhbmRsZXImJiByZW1vdmVEb21haW5zSGFuZGxlciA9IFtdIChjb25z dCBXVEY6OlZlY3RvcjxTdHJpbmc+JikgeyB9KQorICAgIHN0YXRpYyBSZWY8V2ViUmVzb3VyY2VM b2FkU3RhdGlzdGljc1N0b3JlPiBjcmVhdGUoY29uc3QgU3RyaW5nJiByZXNvdXJjZUxvYWRTdGF0 aXN0aWNzRGlyZWN0b3J5LCBGdW5jdGlvbjx2b2lkIChjb25zdCBTdHJpbmcmKT4mJiB0ZXN0aW5n Q2FsbGJhY2ssIGJvb2wgaXNFcGhlbWVyYWwsIFVwZGF0ZVByZXZhbGVudERvbWFpbnNUb1BhcnRp dGlvbk9yQmxvY2tDb29raWVzSGFuZGxlciYmIHVwZGF0ZVByZXZhbGVudERvbWFpbnNUb1BhcnRp dGlvbk9yQmxvY2tDb29raWVzSGFuZGxlciA9IFtdKGNvbnN0IFdURjo6VmVjdG9yPFN0cmluZz4m LCBjb25zdCBXVEY6OlZlY3RvcjxTdHJpbmc+JiwgY29uc3QgV1RGOjpWZWN0b3I8U3RyaW5nPiYs IFNob3VsZENsZWFyRmlyc3QsIENvbXBsZXRpb25IYW5kbGVyPHZvaWQoKT4mJiBjYWxsYmFjaykg eyBjYWxsYmFjaygpOyB9LCBIYXNTdG9yYWdlQWNjZXNzRm9yRnJhbWVIYW5kbGVyJiYgaGFzU3Rv cmFnZUFjY2Vzc0ZvckZyYW1lSGFuZGxlciA9IFtdKGNvbnN0IFN0cmluZyYsIGNvbnN0IFN0cmlu ZyYsIHVpbnQ2NF90LCB1aW50NjRfdCwgV1RGOjpGdW5jdGlvbjx2b2lkKGJvb2wpPiYmKSB7IH0s IEdyYW50U3RvcmFnZUFjY2Vzc0hhbmRsZXImJiBncmFudFN0b3JhZ2VBY2Nlc3NIYW5kbGVyID0g W10oY29uc3QgU3RyaW5nJiwgY29uc3QgU3RyaW5nJiwgc3RkOjpvcHRpb25hbDx1aW50NjRfdD4s IHVpbnQ2NF90LCBXVEY6OkZ1bmN0aW9uPHZvaWQoYm9vbCk+JiYpIHsgfSwgUmVtb3ZlQWxsU3Rv cmFnZUFjY2Vzc0hhbmRsZXImJiByZW1vdmVBbGxTdG9yYWdlQWNjZXNzSGFuZGxlciA9IFtdKCkg eyB9LCBSZW1vdmVQcmV2YWxlbnREb21haW5zSGFuZGxlciYmIHJlbW92ZURvbWFpbnNIYW5kbGVy ID0gW10gKGNvbnN0IFdURjo6VmVjdG9yPFN0cmluZz4mKSB7IH0pCiAgICAgewogICAgICAgICBy ZXR1cm4gYWRvcHRSZWYoKm5ldyBXZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmUocmVzb3Vy Y2VMb2FkU3RhdGlzdGljc0RpcmVjdG9yeSwgV1RGTW92ZSh0ZXN0aW5nQ2FsbGJhY2spLCBpc0Vw aGVtZXJhbCwgV1RGTW92ZSh1cGRhdGVQcmV2YWxlbnREb21haW5zVG9QYXJ0aXRpb25PckJsb2Nr Q29va2llc0hhbmRsZXIpLCBXVEZNb3ZlKGhhc1N0b3JhZ2VBY2Nlc3NGb3JGcmFtZUhhbmRsZXIp LCBXVEZNb3ZlKGdyYW50U3RvcmFnZUFjY2Vzc0hhbmRsZXIpLCBXVEZNb3ZlKHJlbW92ZUFsbFN0 b3JhZ2VBY2Nlc3NIYW5kbGVyKSwgV1RGTW92ZShyZW1vdmVEb21haW5zSGFuZGxlcikpKTsKICAg ICB9Cg==