187091 2018-06-27 02:19:01 -0700 DFG's compileReallocatePropertyStorage() and compileAllocatePropertyStorage() slow paths should also clear unused properties 2018-07-03 07:48:51 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam fpizlo keith_miller msaboff rmorisset saam simon.fraser tsavell tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1436905 0 mark.lam 2018-06-27 02:19:01 -0700 <rdar://problem/41395624> 1436907 1 343704 mark.lam 2018-06-27 02:31:05 -0700 Created attachment 343704 proposed patch. 1436910 2 343704 ysuzuki 2018-06-27 02:40:23 -0700 Comment on attachment 343704 proposed patch. r=me 1436917 3 mark.lam 2018-06-27 04:21:06 -0700 Thanks for the review. Landed in r233253: <http://trac.webkit.org/r233253>. 1436919 4 mark.lam 2018-06-27 04:24:24 -0700 *** Bug 187057 has been marked as a duplicate of this bug. *** 1438846 5 mark.lam 2018-07-03 07:48:51 -0700 *** Bug 186989 has been marked as a duplicate of this bug. *** 343704 2018-06-27 02:31:05 -0700 2018-06-27 02:40:23 -0700 proposed patch. bug-187091.patch text/plain 5369 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzMyNTApCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE4LTA2LTI3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBERkcncyBjb21waWxlUmVhbGxvY2F0ZVByb3BlcnR5U3RvcmFnZSgpIGFu ZCBjb21waWxlQWxsb2NhdGVQcm9wZXJ0eVN0b3JhZ2UoKSBzbG93IHBhdGhzIHNob3VsZCBhbHNv IGNsZWFyIHVudXNlZCBwcm9wZXJ0aWVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTg3MDkxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MTM5NTYy ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0 cmVzcy9yZWdyZXNzLTE4NzA5MS5qczogQWRkZWQuCisKIDIwMTgtMDYtMjYgIE1hcmsgTGFtICA8 bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIGV2YWwoKSBpcyB3cm9uZyBhYm91dCB0aGUg TGl0ZXJhbFBhcnNlciBuZXZlciB0aHJvd2luZyBhbnkgZXhjZXB0aW9ucy4KSW5kZXg6IEpTVGVz dHMvc3RyZXNzL3JlZ3Jlc3MtMTg3MDkxLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNz L3JlZ3Jlc3MtMTg3MDkxLmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL3JlZ3Jl c3MtMTg3MDkxLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMjAgQEAKKy8vIFRoaXMgdGVz dCBzaG91bGQgbm90IGNyYXNoLgorCitmdW5jdGlvbiBmb28oeCkgeworICAgIHguYTAgPSAwOwor ICAgIE9iamVjdC5kZWZpbmVQcm9wZXJ0eSh4LCAiYTAiLCB7IHZhbHVlOiA0MiB9KTsKKyAgICB4 LmE2ID0gNjsKK30KK25vSW5saW5lKGZvbyk7CisKK2ZvciAodmFyIGkgPSAwOyBpIDwgMTAwMDA7 ICsraSkgeworICAgIHZhciB4ID0geyB9CisgICAgeC5hMSA9IDE7CisgICAgeC5hMiA9IDI7Cisg ICAgeC5hMyA9IDM7CisgICAgeC5hNCA9IDQ7CisgICAgeC5hNyA9IDc7CisgICAgeC5hNSA9IDU7 CisKKyAgICBmb28oeCk7Cit9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9u IDIzMzI1MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w eSkKQEAgLTEsMyArMSwyMSBAQAorMjAxOC0wNi0yNyAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBs ZS5jb20+CisKKyAgICAgICAgREZHJ3MgY29tcGlsZVJlYWxsb2NhdGVQcm9wZXJ0eVN0b3JhZ2Uo KSBhbmQgY29tcGlsZUFsbG9jYXRlUHJvcGVydHlTdG9yYWdlKCkgc2xvdyBwYXRocyBzaG91bGQg YWxzbyBjbGVhciB1bnVzZWQgcHJvcGVydGllcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NzA5MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDEz OTU2MjQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UHJldmlvdXNseSwgd2hlbiBjb21waWxlUmVhbGxvY2F0ZVByb3BlcnR5U3RvcmFnZSgpIGFuZCBj b21waWxlQWxsb2NhdGVQcm9wZXJ0eVN0b3JhZ2UoKQorICAgICAgICB0YWtlIHRoZWlyIHNsb3cg cGF0aHMsIHRoZSBzbG93IHBhdGggd291bGQganVtcCBiYWNrIHRvIHRoZSBmYXN0IHBhdGggcmln aHQgYWZ0ZXIKKyAgICAgICAgdGhlIGVtaXR0ZWQgY29kZSB3aGljaCBjbGVhcnMgdGhlIHVudXNl ZCBwcm9wZXJ0eSB2YWx1ZXMuICBBcyBhIHJlc3VsdCwgdGhlCisgICAgICAgIHVudXNlZCBwcm9w ZXJ0aWVzIGFyZSBub3QgaW5pdGlhbGl6ZWQuICBXZSd2ZSBmaXhlZCB0aGlzIGJ5IGFkZGluZyB0 aGUgc2xvdyBwYXRoCisgICAgICAgIGdlbmVyYXRvcnMgYmVmb3JlIHdlIGVtaXQgdGhlIGNvZGUg dG8gY2xlYXIgdGhlIHVudXNlZCBwcm9wZXJ0aWVzLgorCisgICAgICAgICogZGZnL0RGR1NwZWN1 bGF0aXZlSklULmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6Y29tcGls ZUFsbG9jYXRlUHJvcGVydHlTdG9yYWdlKToKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2 ZUpJVDo6Y29tcGlsZVJlYWxsb2NhdGVQcm9wZXJ0eVN0b3JhZ2UpOgorCiAyMDE4LTA2LTI2ICBZ dXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFtKU0NdIFBh c3MgVk0mIHRvIGZ1bmN0aW9ucyBtb3JlCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR1NwZWN1bGF0aXZlSklULmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAkocmV2aXNpb24gMjMzMjUwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTg5MzYsMTMgKzg5MzYsMTMgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZUFsbG9j YXRlUHJvcAogICAgIEpJVENvbXBpbGVyOjpKdW1wTGlzdCBzbG93UGF0aDsKICAgICBtX2ppdC5l bWl0QWxsb2NhdGUoc2NyYXRjaEdQUjEsIEpJVEFsbG9jYXRvcjo6Y29uc3RhbnQoYWxsb2NhdG9y KSwgc2NyYXRjaEdQUjIsIHNjcmF0Y2hHUFIzLCBzbG93UGF0aCk7CiAgICAgbV9qaXQuYWRkUHRy KEpJVENvbXBpbGVyOjpUcnVzdGVkSW1tMzIoc2l6ZSArIHNpemVvZihJbmRleGluZ0hlYWRlcikp LCBzY3JhdGNoR1BSMSk7Ci0gICAgCi0gICAgZm9yIChwdHJkaWZmX3Qgb2Zmc2V0ID0gMDsgb2Zm c2V0IDwgc3RhdGljX2Nhc3Q8cHRyZGlmZl90PihzaXplKTsgb2Zmc2V0ICs9IHNpemVvZih2b2lk KikpCi0gICAgICAgIG1faml0LnN0b3JlUHRyKFRydXN0ZWRJbW1QdHIobnVsbHB0ciksIEpJVENv bXBpbGVyOjpBZGRyZXNzKHNjcmF0Y2hHUFIxLCAtKG9mZnNldCArIHNpemVvZihKU1ZhbHVlKSAr IHNpemVvZih2b2lkKikpKSk7Ci0gICAgICAgIAorCiAgICAgYWRkU2xvd1BhdGhHZW5lcmF0b3Io CiAgICAgICAgIHNsb3dQYXRoQ2FsbChzbG93UGF0aCwgdGhpcywgb3BlcmF0aW9uQWxsb2NhdGVT aW1wbGVQcm9wZXJ0eVN0b3JhZ2VXaXRoSW5pdGlhbENhcGFjaXR5LCBzY3JhdGNoR1BSMSkpOwog CisgICAgZm9yIChwdHJkaWZmX3Qgb2Zmc2V0ID0gMDsgb2Zmc2V0IDwgc3RhdGljX2Nhc3Q8cHRy ZGlmZl90PihzaXplKTsgb2Zmc2V0ICs9IHNpemVvZih2b2lkKikpCisgICAgICAgIG1faml0LnN0 b3JlUHRyKFRydXN0ZWRJbW1QdHIobnVsbHB0ciksIEpJVENvbXBpbGVyOjpBZGRyZXNzKHNjcmF0 Y2hHUFIxLCAtKG9mZnNldCArIHNpemVvZihKU1ZhbHVlKSArIHNpemVvZih2b2lkKikpKSk7CisK ICAgICBzdG9yYWdlUmVzdWx0KHNjcmF0Y2hHUFIxLCBub2RlKTsKIH0KIApAQCAtODk3Myw3ICs4 OTczLDcgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZVJlYWxsb2NhdGVQcgogICAgIEdQ UlRlbXBvcmFyeSBzY3JhdGNoMSh0aGlzKTsKICAgICBHUFJUZW1wb3Jhcnkgc2NyYXRjaDIodGhp cyk7CiAgICAgR1BSVGVtcG9yYXJ5IHNjcmF0Y2gzKHRoaXMpOwotICAgICAgICAKKwogICAgIEdQ UlJlZyBvbGRTdG9yYWdlR1BSID0gb2xkU3RvcmFnZS5ncHIoKTsKICAgICBHUFJSZWcgc2NyYXRj aEdQUjEgPSBzY3JhdGNoMS5ncHIoKTsKICAgICBHUFJSZWcgc2NyYXRjaEdQUjIgPSBzY3JhdGNo Mi5ncHIoKTsKQEAgLTg5ODMsMTkgKzg5ODMsMTkgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29t cGlsZVJlYWxsb2NhdGVQcgogICAgIG1faml0LmVtaXRBbGxvY2F0ZShzY3JhdGNoR1BSMSwgSklU QWxsb2NhdG9yOjpjb25zdGFudChhbGxvY2F0b3IpLCBzY3JhdGNoR1BSMiwgc2NyYXRjaEdQUjMs IHNsb3dQYXRoKTsKICAgICAKICAgICBtX2ppdC5hZGRQdHIoSklUQ29tcGlsZXI6OlRydXN0ZWRJ bW0zMihuZXdTaXplICsgc2l6ZW9mKEluZGV4aW5nSGVhZGVyKSksIHNjcmF0Y2hHUFIxKTsKLSAg ICAgICAgCi0gICAgZm9yIChwdHJkaWZmX3Qgb2Zmc2V0ID0gb2xkU2l6ZTsgb2Zmc2V0IDwgc3Rh dGljX2Nhc3Q8cHRyZGlmZl90PihuZXdTaXplKTsgb2Zmc2V0ICs9IHNpemVvZih2b2lkKikpCi0g ICAgICAgIG1faml0LnN0b3JlUHRyKFRydXN0ZWRJbW1QdHIobnVsbHB0ciksIEpJVENvbXBpbGVy OjpBZGRyZXNzKHNjcmF0Y2hHUFIxLCAtKG9mZnNldCArIHNpemVvZihKU1ZhbHVlKSArIHNpemVv Zih2b2lkKikpKSk7CiAKICAgICBhZGRTbG93UGF0aEdlbmVyYXRvcigKICAgICAgICAgc2xvd1Bh dGhDYWxsKHNsb3dQYXRoLCB0aGlzLCBvcGVyYXRpb25BbGxvY2F0ZVNpbXBsZVByb3BlcnR5U3Rv cmFnZSwgc2NyYXRjaEdQUjEsIG5ld1NpemUgLyBzaXplb2YoSlNWYWx1ZSkpKTsKIAorICAgIGZv ciAocHRyZGlmZl90IG9mZnNldCA9IG9sZFNpemU7IG9mZnNldCA8IHN0YXRpY19jYXN0PHB0cmRp ZmZfdD4obmV3U2l6ZSk7IG9mZnNldCArPSBzaXplb2Yodm9pZCopKQorICAgICAgICBtX2ppdC5z dG9yZVB0cihUcnVzdGVkSW1tUHRyKG51bGxwdHIpLCBKSVRDb21waWxlcjo6QWRkcmVzcyhzY3Jh dGNoR1BSMSwgLShvZmZzZXQgKyBzaXplb2YoSlNWYWx1ZSkgKyBzaXplb2Yodm9pZCopKSkpOwor CiAgICAgLy8gV2UgaGF2ZSBzY3JhdGNoR1BSMSA9IG5ldyBzdG9yYWdlLCBzY3JhdGNoR1BSMiA9 IHNjcmF0Y2gKICAgICBmb3IgKHB0cmRpZmZfdCBvZmZzZXQgPSAwOyBvZmZzZXQgPCBzdGF0aWNf Y2FzdDxwdHJkaWZmX3Q+KG9sZFNpemUpOyBvZmZzZXQgKz0gc2l6ZW9mKHZvaWQqKSkgewogICAg ICAgICBtX2ppdC5sb2FkUHRyKEpJVENvbXBpbGVyOjpBZGRyZXNzKG9sZFN0b3JhZ2VHUFIsIC0o b2Zmc2V0ICsgc2l6ZW9mKEpTVmFsdWUpICsgc2l6ZW9mKHZvaWQqKSkpLCBzY3JhdGNoR1BSMik7 CiAgICAgICAgIG1faml0LnN0b3JlUHRyKHNjcmF0Y2hHUFIyLCBKSVRDb21waWxlcjo6QWRkcmVz cyhzY3JhdGNoR1BSMSwgLShvZmZzZXQgKyBzaXplb2YoSlNWYWx1ZSkgKyBzaXplb2Yodm9pZCop KSkpOwogICAgIH0KLSAgICAgICAgCisKICAgICBzdG9yYWdlUmVzdWx0KHNjcmF0Y2hHUFIxLCBu b2RlKTsKIH0KIAo=