187087 2018-06-27 00:39:13 -0700 [GStreamer] Coverity scan issues 2018-06-27 01:17:16 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tpopela tpopela bugs-noreply calvaris oldest_to_newest 1436878 0 tpopela 2018-06-27 00:39:13 -0700 Error: UNINIT_CTOR (CWE-456): /usr/include/gstreamer-1.0/gst/video/video-frame.h:73: member_decl: Class member declaration for "info". webkitgtk-2.20.3/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:203: uninit_member: Non-static class member field "m_videoFrame.info" is not initialized in this constructor nor in any functions that it calls. /usr/include/gstreamer-1.0/gst/video/video-frame.h:74: member_decl: Class member declaration for "flags". webkitgtk-2.20.3/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:203: uninit_member: Non-static class member field "m_videoFrame.flags" is not initialized in this constructor nor in any functions that it calls. /usr/include/gstreamer-1.0/gst/video/video-frame.h:76: member_decl: Class member declaration for "buffer". webkitgtk-2.20.3/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:203: uninit_member: Non-static class member field "m_videoFrame.buffer" is not initialized in this constructor nor in any functions that it calls. /usr/include/gstreamer-1.0/gst/video/video-frame.h:77: member_decl: Class member declaration for "meta". webkitgtk-2.20.3/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:203: uninit_member: Non-static class member field "m_videoFrame.meta" is not initialized in this constructor nor in any functions that it calls. /usr/include/gstreamer-1.0/gst/video/video-frame.h:78: member_decl: Class member declaration for "id". webkitgtk-2.20.3/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:203: uninit_member: Non-static class member field "m_videoFrame.id" is not initialized in this constructor nor in any functions that it calls. /usr/include/gstreamer-1.0/gst/video/video-frame.h:80: member_decl: Class member declaration for "data". webkitgtk-2.20.3/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:203: uninit_member: Non-static class member field "m_videoFrame.data" is not initialized in this constructor nor in any functions that it calls. /usr/include/gstreamer-1.0/gst/video/video-frame.h:81: member_decl: Class member declaration for "map". webkitgtk-2.20.3/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:203: uninit_member: Non-static class member field "m_videoFrame.map" is not initialized in this constructor nor in any functions that it calls. /usr/include/gstreamer-1.0/gst/video/video-frame.h:84: member_decl: Class member declaration for "_gst_reserved". webkitgtk-2.20.3/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:203: uninit_member: Non-static class member field "m_videoFrame._gst_reserved" is not initialized in this constructor nor in any functions that it calls. webkitgtk-2.20.3/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:232: member_decl: Class member declaration for "m_flags". webkitgtk-2.20.3/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:203: uninit_member: Non-static class member "m_flags" is not initialized in this constructor nor in any functions that it calls. # 201| GstVideoInfo videoInfo; # 202| if (UNLIKELY(!getSampleVideoInfo(sample, videoInfo))) # 203|-> return; # 204| # 205| m_size = IntSize(GST_VIDEO_INFO_WIDTH(&videoInfo), GST_VIDEO_INFO_HEIGHT(&videoInfo)); Error: UNINIT_CTOR (CWE-456): webkitgtk-2.20.3/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:88: member_decl: Class member declaration for "m_sourceBufferPrivateClient". webkitgtk-2.20.3/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:62: uninit_member: Non-static class member "m_sourceBufferPrivateClient" is not initialized in this constructor nor in any functions that it calls. # 60| , m_client(client.get()) # 61| { # 62|-> } # 63| # 64| void SourceBufferPrivateGStreamer::setClient(SourceBufferPrivateClient* client) Error: UNINIT_CTOR (CWE-456): webkitgtk-2.20.3/Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:138: member_decl: Class member declaration for "currentCaps". webkitgtk-2.20.3/Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:128: uninit_member: Non-static class member "currentCaps" is not initialized in this constructor nor in any functions that it calls. # 126| { # 127| gst_video_info_init(&info); # 128|-> } # 129| # 130| ~_WebKitVideoSinkPrivate() 1436879 1 343699 tpopela 2018-06-27 00:42:06 -0700 Created attachment 343699 Patch 1436887 2 343699 tpopela 2018-06-27 01:17:12 -0700 Comment on attachment 343699 Patch Clearing flags on attachment: 343699 Committed r233248: <https://trac.webkit.org/changeset/233248> 1436888 3 tpopela 2018-06-27 01:17:16 -0700 All reviewed patches have been landed. Closing bug. 343699 2018-06-27 00:42:06 -0700 2018-06-27 01:17:12 -0700 Patch bug-187087-20180627094205.patch text/plain 3049 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMjQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDE0NDc2ZjM3ZjU5NWNi OGVkYWZmOTFjNzMyM2U4YTZkNDhiZTMxYS4uNzM3OTk3YmI2MmRlY2IxMTBjOWQ3NzM0ZDBhZTU4 M2UwNmNiOWFjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA2LTI3ICBUb21h cyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+CisKKyAgICAgICAgW0dTdHJlYW1lcl0gQ292 ZXJpdHkgc2NhbiBpc3N1ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4NzA4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEZpeCB1bmluaXRpYWxpemVkIG1lbWJlcnMuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHA6 CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1ZpZGVvU2lua0dTdHJlYW1l ci5jcHA6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9Tb3VyY2VC dWZmZXJQcml2YXRlR1N0cmVhbWVyLmg6CisKIDIwMTgtMDYtMjYgIFl1c3VrZSBTdXp1a2kgIDx1 dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgW0pTQ10gUGFzcyBWTSYgdG8gZnVuY3Rp b25zIG1vcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dz dHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXJCYXNlLmNwcAppbmRleCBhNjIyZWIyOGE0ZWI2NWYwNWVhNGQwMjUzNGYzZjc4ZmQwZGM4NjVk Li5iNjE0NzFiY2IzZDFjOGEyNzJjMmVjYzY4NjlhYWI1Mzk3M2RiYWY0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2 YXRlR1N0cmVhbWVyQmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwCkBAIC0yNjcs MTAgKzI2NywxMCBAQCBwdWJsaWM6CiAKIHByaXZhdGU6CiAgICAgR3N0QnVmZmVyKiBtX2J1ZmZl cjsKLSAgICBHc3RWaWRlb0ZyYW1lIG1fdmlkZW9GcmFtZTsKKyAgICBHc3RWaWRlb0ZyYW1lIG1f dmlkZW9GcmFtZSB7IH07CiAgICAgSW50U2l6ZSBtX3NpemU7CiAgICAgYm9vbCBtX2hhc0FscGhh Q2hhbm5lbDsKLSAgICBUZXh0dXJlTWFwcGVyR0w6OkZsYWdzIG1fZmxhZ3M7CisgICAgVGV4dHVy ZU1hcHBlckdMOjpGbGFncyBtX2ZsYWdzIHsgfTsKICAgICBHTHVpbnQgbV90ZXh0dXJlSUQgeyAw IH07CiAgICAgYm9vbCBtX2lzTWFwcGVkIHsgZmFsc2UgfTsKIH07CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvVmlkZW9TaW5rR1N0cmVhbWVy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9WaWRlb1Np bmtHU3RyZWFtZXIuY3BwCmluZGV4IDE2NGU3YTQwNTQ4NTI4MzJhYWQzZjE4MmM5OGFlNDlmYjMy ZDEyYzkuLmM4OTNiNDczYjMzMTBlZTUwMjA3MTdiMTgyMDczYzU1MTBhZjUxZGMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9WaWRlb1NpbmtH U3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9WaWRlb1NpbmtHU3RyZWFtZXIuY3BwCkBAIC0xMzQsNyArMTM0LDcgQEAgc3RydWN0IF9X ZWJLaXRWaWRlb1NpbmtQcml2YXRlIHsKIAogICAgIFZpZGVvUmVuZGVyUmVxdWVzdFNjaGVkdWxl ciBzY2hlZHVsZXI7CiAgICAgR3N0VmlkZW9JbmZvIGluZm87Ci0gICAgR3N0Q2FwcyogY3VycmVu dENhcHM7CisgICAgR3N0Q2FwcyogY3VycmVudENhcHMgeyBudWxscHRyIH07CiB9OwogCiAjZGVm aW5lIHdlYmtpdF92aWRlb19zaW5rX3BhcmVudF9jbGFzcyBwYXJlbnRfY2xhc3MKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvU291cmNl QnVmZmVyUHJpdmF0ZUdTdHJlYW1lci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZ3N0cmVhbWVyL21zZS9Tb3VyY2VCdWZmZXJQcml2YXRlR1N0cmVhbWVyLmgKaW5kZXggZWI0 NjkwMjQ4NWYwYzQxMzVkNzZlMzMyNTk4OGJiNTY3NzUxMTA3My4uYjA3YzJiMDI3MThhYjg5NTdi MjZmMWI3N2UyYjBhNmI4NDFkNDk5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9Tb3VyY2VCdWZmZXJQcml2YXRlR1N0cmVhbWVyLmgK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9Tb3Vy Y2VCdWZmZXJQcml2YXRlR1N0cmVhbWVyLmgKQEAgLTg2LDcgKzg2LDcgQEAgcHJpdmF0ZToKICAg ICBNZWRpYVNvdXJjZUdTdHJlYW1lciogbV9tZWRpYVNvdXJjZTsKICAgICBDb250ZW50VHlwZSBt X3R5cGU7CiAgICAgUmVmPE1lZGlhU291cmNlQ2xpZW50R1N0cmVhbWVyTVNFPiBtX2NsaWVudDsK LSAgICBTb3VyY2VCdWZmZXJQcml2YXRlQ2xpZW50KiBtX3NvdXJjZUJ1ZmZlclByaXZhdGVDbGll bnQ7CisgICAgU291cmNlQnVmZmVyUHJpdmF0ZUNsaWVudCogbV9zb3VyY2VCdWZmZXJQcml2YXRl Q2xpZW50IHsgbnVsbHB0ciB9OwogICAgIGJvb2wgbV9pc1JlYWR5Rm9yTW9yZVNhbXBsZXMgPSB0 cnVlOwogICAgIGJvb2wgbV9ub3RpZnlXaGVuUmVhZHlGb3JNb3JlU2FtcGxlcyA9IGZhbHNlOwog ICAgIEF0b21pY1N0cmluZyBtX3RyYWNrSWQ7Cg==