187071 2018-06-26 16:47:04 -0700 [iOS] Rebaseline two webanimations tests after r233164 2018-06-27 00:12:05 -0700 1 1 1 Unclassified WebKit Animations Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad webkit-unassigned commit-queue dino graouts tsavell webkit-bug-importer oldest_to_newest 1436727 0 ryanhaddad 2018-06-26 16:47:04 -0700 The following two tests are failing on iOS Simulator after https://trac.webkit.org/changeset/233164/webkit Regressions: Unexpected text-only failures (2) imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property.html [ Failure ] webanimations/opacity-animation-yields-compositing-span.html [ Failure ] It looks like they just need iOS specific baselines, though. 1436728 1 ryanhaddad 2018-06-26 16:49:42 -0700 imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property.html looks like it just needs a line changed to pass: -FAIL filter: interpolate different length of filter-function-list with function which lacuna value is 0 assert_equals: The value should be opacity(0.5) grayscale(0.5) invert(0.5) sepia(0.5) blur(5px) at 500ms expected "opacity(0.5) grayscale(0.5) invert(0.5) sepia(0.5) blur(5px)" but got "opacity(0.25) grayscale(0.75) invert(0.75) sepia(0.75) blur(7.5px)" +PASS filter: interpolate different length of filter-function-list with function which lacuna value is 0 webanimations/opacity-animation-yields-compositing-span.html has a different bounds value: (children 1 (GraphicsLayer (position 8.00 8.00) - (bounds 25.00 18.00) + (bounds 25.00 19.00) (opacity 0.50) (drawsContent 1) ) 1436729 2 ryanhaddad 2018-06-26 16:50:19 -0700 Link to results on a bot: https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/r233201%20(5798)/results.html Let's just go ahead and rebaseline them. Antoine, please let us know if this warrants a bug and we can undo the change. 1436735 3 343661 tsavell 2018-06-26 16:58:47 -0700 Created attachment 343661 Patch 1436759 4 343661 commit-queue 2018-06-26 17:41:37 -0700 Comment on attachment 343661 Patch Clearing flags on attachment: 343661 Committed r233233: <https://trac.webkit.org/changeset/233233> 1436760 5 commit-queue 2018-06-26 17:41:38 -0700 All reviewed patches have been landed. Closing bug. 1436761 6 webkit-bug-importer 2018-06-26 17:43:17 -0700 <rdar://problem/41500291> 1436874 7 graouts 2018-06-27 00:12:05 -0700 This looks correct Ryan, thanks to you and Truitt for handling this. 343661 2018-06-26 16:58:47 -0700 2018-06-26 17:41:37 -0700 Patch bug-187071-20180626165846.patch text/plain 4840 tsavell U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMjE4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNmRlZmRkNmQ5YWMxZmUwNGZlZDRj N2E5YjdiMGVmYTdlYjkwMDFiNy4uNDA5OGQzZjY2NzRmYWZlNjVlNTI5Y2QwZmMyMWYyZjMwMDk4 ZDJkNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE4LTA2LTI2ICBUcnVpdHQgU2F2ZWxsICA8 dHNhdmVsbEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gUmViYXNlbGluZSB0d28gd2ViYW5p bWF0aW9ucyB0ZXN0cyBhZnRlciByMjMzMTY0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xODcwNzEKKworICAgICAgICBVbnJldmlld2VkIGdhcmRlbmlu ZworCisgICAgICAgICogcGxhdGZvcm0vaW9zL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVz dHMvd2ViLWFuaW1hdGlvbnMvYW5pbWF0aW9uLW1vZGVsL2FuaW1hdGlvbi10eXBlcy9pbnRlcnBv bGF0aW9uLXBlci1wcm9wZXJ0eS1leHBlY3RlZC50eHQ6CisgICAgICAgICogcGxhdGZvcm0vaW9z L3dlYmFuaW1hdGlvbnMvb3BhY2l0eS1hbmltYXRpb24teWllbGRzLWNvbXBvc2l0aW5nLXNwYW4t ZXhwZWN0ZWQudHh0OiBBZGRlZC4KKwogMjAxOC0wNi0yNiAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0 LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIz MzE4NC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy9pbXBvcnRlZC93M2Mv d2ViLXBsYXRmb3JtLXRlc3RzL3dlYi1hbmltYXRpb25zL2FuaW1hdGlvbi1tb2RlbC9hbmltYXRp b24tdHlwZXMvaW50ZXJwb2xhdGlvbi1wZXItcHJvcGVydHktZXhwZWN0ZWQudHh0IGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vaW9zL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd2ViLWFu aW1hdGlvbnMvYW5pbWF0aW9uLW1vZGVsL2FuaW1hdGlvbi10eXBlcy9pbnRlcnBvbGF0aW9uLXBl ci1wcm9wZXJ0eS1leHBlY3RlZC50eHQKaW5kZXggOTBhZjc1ZmFjNTkyNjYzNjViY2Q3MDgwNTI0 YTc5NGI0MzdhNTA5Zi4uZWJjOGE1ODE0MTgxNjdlNTQ2NTljN2RjMTZiMmM1ODkxZWJkOTY0ZCAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zL2ltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvd2ViLWFuaW1hdGlvbnMvYW5pbWF0aW9uLW1vZGVsL2FuaW1hdGlvbi10eXBl cy9pbnRlcnBvbGF0aW9uLXBlci1wcm9wZXJ0eS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vaW9zL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd2ViLWFuaW1h dGlvbnMvYW5pbWF0aW9uLW1vZGVsL2FuaW1hdGlvbi10eXBlcy9pbnRlcnBvbGF0aW9uLXBlci1w cm9wZXJ0eS1leHBlY3RlZC50eHQKQEAgLTE0MCw3ICsxNDAsNyBAQCBQQVNTIGZpbHRlcjogZHJv cC1zaGFkb3cgZnVuY3Rpb24KIEZBSUwgZmlsdGVyOiBwZXJjZW50YWdlIG9yIG51bWVyaWMtc3Bl Y2lmaWFibGUgZnVuY3Rpb25zIChudW1iZXIgdmFsdWUpIGFzc2VydF9lcXVhbHM6IFRoZSB2YWx1 ZSBzaG91bGQgYmUgYnJpZ2h0bmVzcygwLjMpIGNvbnRyYXN0KDAuMykgZ3JheXNjYWxlKDAuMykg aW52ZXJ0KDAuMykgb3BhY2l0eSgwLjMpIHNhdHVyYXRlKDAuMykgc2VwaWEoMC4zKSBhdCA1MDBt cyBleHBlY3RlZCAiYnJpZ2h0bmVzcygwLjMpIGNvbnRyYXN0KDAuMykgZ3JheXNjYWxlKDAuMykg aW52ZXJ0KDAuMykgb3BhY2l0eSgwLjMpIHNhdHVyYXRlKDAuMykgc2VwaWEoMC4zKSIgYnV0IGdv dCAiYnJpZ2h0bmVzcygwLjMwMDAwMDAwMDAwMDAwMDA0KSBjb250cmFzdCgwLjMwMDAwMDAwMDAw MDAwMDA0KSBncmF5c2NhbGUoMC4zMDAwMDAwMDAwMDAwMDAwNCkgaW52ZXJ0KDAuMzAwMDAwMDAw MDAwMDAwMDQpIG9wYWNpdHkoMC4zMDAwMDAwMDAwMDAwMDAwNCkgc2F0dXJhdGUoMC4zMDAwMDAw MDAwMDAwMDAwNCkgc2VwaWEoMC4zMDAwMDAwMDAwMDAwMDAwNCkiCiBGQUlMIGZpbHRlcjogcGVy Y2VudGFnZSBvciBudW1lcmljLXNwZWNpZmlhYmxlIGZ1bmN0aW9ucyAocGVyY2VudGFnZSB2YWx1 ZSkgYXNzZXJ0X2VxdWFsczogVGhlIHZhbHVlIHNob3VsZCBiZSBicmlnaHRuZXNzKDAuMykgY29u dHJhc3QoMC4zKSBncmF5c2NhbGUoMC4zKSBpbnZlcnQoMC4zKSBvcGFjaXR5KDAuMykgc2F0dXJh dGUoMC4zKSBzZXBpYSgwLjMpIGF0IDUwMG1zIGV4cGVjdGVkICJicmlnaHRuZXNzKDAuMykgY29u dHJhc3QoMC4zKSBncmF5c2NhbGUoMC4zKSBpbnZlcnQoMC4zKSBvcGFjaXR5KDAuMykgc2F0dXJh dGUoMC4zKSBzZXBpYSgwLjMpIiBidXQgZ290ICJicmlnaHRuZXNzKDAuMzAwMDAwMDAwMDAwMDAw MDQpIGNvbnRyYXN0KDAuMzAwMDAwMDAwMDAwMDAwMDQpIGdyYXlzY2FsZSgwLjMwMDAwMDAwMDAw MDAwMDA0KSBpbnZlcnQoMC4zMDAwMDAwMDAwMDAwMDAwNCkgb3BhY2l0eSgwLjMwMDAwMDAwMDAw MDAwMDA0KSBzYXR1cmF0ZSgwLjMwMDAwMDAwMDAwMDAwMDA0KSBzZXBpYSgwLjMwMDAwMDAwMDAw MDAwMDA0KSIKIEZBSUwgZmlsdGVyOiBpbnRlcnBvbGF0ZSBkaWZmZXJlbnQgbGVuZ3RoIG9mIGZp bHRlci1mdW5jdGlvbi1saXN0IHdpdGggZnVuY3Rpb24gd2hpY2ggbGFjdW5hIHZhbHVlIGlzIDEg YXNzZXJ0X2VxdWFsczogVGhlIHZhbHVlIHNob3VsZCBiZSBncmF5c2NhbGUoMC41KSBicmlnaHRu ZXNzKDAuNSkgY29udHJhc3QoMC41KSBvcGFjaXR5KDAuNSkgc2F0dXJhdGUoMC41KSBhdCA1MDBt cyBleHBlY3RlZCAiZ3JheXNjYWxlKDAuNSkgYnJpZ2h0bmVzcygwLjUpIGNvbnRyYXN0KDAuNSkg b3BhY2l0eSgwLjUpIHNhdHVyYXRlKDAuNSkiIGJ1dCBnb3QgImdyYXlzY2FsZSgxKSBicmlnaHRu ZXNzKDApIGNvbnRyYXN0KDApIG9wYWNpdHkoMCkgc2F0dXJhdGUoMCkiCi1GQUlMIGZpbHRlcjog aW50ZXJwb2xhdGUgZGlmZmVyZW50IGxlbmd0aCBvZiBmaWx0ZXItZnVuY3Rpb24tbGlzdCB3aXRo IGZ1bmN0aW9uIHdoaWNoIGxhY3VuYSB2YWx1ZSBpcyAwIGFzc2VydF9lcXVhbHM6IFRoZSB2YWx1 ZSBzaG91bGQgYmUgb3BhY2l0eSgwLjUpIGdyYXlzY2FsZSgwLjUpIGludmVydCgwLjUpIHNlcGlh KDAuNSkgYmx1cig1cHgpIGF0IDUwMG1zIGV4cGVjdGVkICJvcGFjaXR5KDAuNSkgZ3JheXNjYWxl KDAuNSkgaW52ZXJ0KDAuNSkgc2VwaWEoMC41KSBibHVyKDVweCkiIGJ1dCBnb3QgIm9wYWNpdHko MC4yNSkgZ3JheXNjYWxlKDAuNzUpIGludmVydCgwLjc1KSBzZXBpYSgwLjc1KSBibHVyKDcuNXB4 KSIKK1BBU1MgZmlsdGVyOiBpbnRlcnBvbGF0ZSBkaWZmZXJlbnQgbGVuZ3RoIG9mIGZpbHRlci1m dW5jdGlvbi1saXN0IHdpdGggZnVuY3Rpb24gd2hpY2ggbGFjdW5hIHZhbHVlIGlzIDAgCiBGQUlM IGZpbHRlcjogaW50ZXJwb2xhdGUgZGlmZmVyZW50IGxlbmd0aCBvZiBmaWx0ZXItZnVuY3Rpb24t bGlzdCB3aXRoIGRyb3Atc2hhZG93IGZ1bmN0aW9uIGFzc2VydF9lcXVhbHM6IFRoZSB2YWx1ZSBz aG91bGQgYmUgYmx1cig1cHgpIGRyb3Atc2hhZG93KHJnYmEoODUsIDAsIDE3MCwgMC42KSA1cHgg NXB4IDVweCBhdCA1MDBtcyBleHBlY3RlZCAiYmx1cig1cHgpIGRyb3Atc2hhZG93KHJnYmEoODUs IDAsIDE3MCwgMC42KSA1cHggNXB4IDVweCIgYnV0IGdvdCAiYmx1cigxMHB4KSBkcm9wLXNoYWRv dyhyZ2JhKDAsIDAsIDI1NSwgMC44KSAxMHB4IDEwcHggMTBweCkiCiBQQVNTIGZpbHRlcjogaW50 ZXJwb2xhdGUgZnJvbSBub25lIAogRkFJTCBmaWx0ZXI6IHVybCBmdW5jdGlvbiAoaW50ZXJwb2Fs dGUgYXMgZGlzY3JldGUpIGFzc2VydF9lcXVhbHM6IFRoZSB2YWx1ZSBzaG91bGQgYmUgYmx1cigw cHgpIHVybCgiI2YxIikgYXQgNDk5bXMgZXhwZWN0ZWQgImJsdXIoMHB4KSB1cmwoXCIjZjFcIiki IGJ1dCBnb3QgImJsdXIoNC45ODk5OTk3NzExMTgxNjRweCkgdXJsKFwiI2YxXCIpIgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zL3dlYmFuaW1hdGlvbnMvb3BhY2l0eS1hbmlt YXRpb24teWllbGRzLWNvbXBvc2l0aW5nLXNwYW4tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vaW9zL3dlYmFuaW1hdGlvbnMvb3BhY2l0eS1hbmltYXRpb24teWllbGRzLWNvbXBv c2l0aW5nLXNwYW4tZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjZmYTZlZWViN2Q4MGI5Y2UwNWJj ZWM1ZjRiYWJmMzJkZGYxYzAwMzcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9pb3Mvd2ViYW5pbWF0aW9ucy9vcGFjaXR5LWFuaW1hdGlvbi15aWVsZHMtY29tcG9zaXRp bmctc3Bhbi1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxOSBAQAorKEdyYXBoaWNzTGF5ZXIKKyAg KGFuY2hvciAwLjAwIDAuMDApCisgIChib3VuZHMgODAwLjAwIDYwMC4wMCkKKyAgKGNoaWxkcmVu IDEKKyAgICAoR3JhcGhpY3NMYXllcgorICAgICAgKGJvdW5kcyA4MDAuMDAgNjAwLjAwKQorICAg ICAgKGNvbnRlbnRzT3BhcXVlIDEpCisgICAgICAoY2hpbGRyZW4gMQorICAgICAgICAoR3JhcGhp Y3NMYXllcgorICAgICAgICAgIChwb3NpdGlvbiA4LjAwIDguMDApCisgICAgICAgICAgKGJvdW5k cyAyNS4wMCAxOS4wMCkKKyAgICAgICAgICAob3BhY2l0eSAwLjUwKQorICAgICAgICAgIChkcmF3 c0NvbnRlbnQgMSkKKyAgICAgICAgKQorICAgICAgKQorICAgICkKKyAgKQorKQorRm9vCg==